From 39f78c88218b038e99bc590ce1d64d265c3d5d39 Mon Sep 17 00:00:00 2001 From: Gabriel Luong Date: Mon, 1 Apr 2024 21:47:30 +0000 Subject: [PATCH] =?utf8?q?Bug=201885561=20-=20[Menu=20Redesign]=20Rename?= =?utf8?q?=20=E2=80=9CAdd-ons=E2=80=9D=20to=20=E2=80=9CExtensions=E2=80=9D?= =?utf8?q?=20in=20menus=20and=20Add-ons=20Manager=20r=3Dandroid-reviewers,?= =?utf8?q?Roger?= MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Differential Revision: https://phabricator.services.mozilla.com/D206094 --- .../browser/menu/WebExtensionBrowserMenuBuilder.kt | 10 ++-- .../browser/menu/src/main/res/values/strings.xml | 14 +++-- .../menu/WebExtensionBrowserMenuBuilderTest.kt | 4 +- .../feature/addons/ui/AddonsManagerAdapter.kt | 4 +- .../feature/addons/update/AddonUpdater.kt | 2 +- .../mozac_feature_addons_footer_section_item.xml | 4 +- .../mozac_feature_addons_header_section_item.xml | 8 +-- .../feature/addons/src/main/res/values/strings.xml | 64 ++++++++++++++++------ .../feature/addons/ui/AddonsManagerAdapterTest.kt | 2 +- .../samples/browser/addons/AddonsFragment.kt | 2 +- .../addons/InstalledAddonDetailsActivity.kt | 2 +- .../main/res/layout/overlay_add_on_progress.xml | 2 +- .../fenix/screenshots/MenuScreenShotTest.kt | 2 +- .../org/mozilla/fenix/ui/robots/SettingsRobot.kt | 41 ++++++++------ .../ui/robots/SettingsSubMenuAddonsManagerRobot.kt | 6 +- .../fenix/ui/robots/ThreeDotMenuMainRobot.kt | 2 +- .../fenix/addons/AddonsManagementFragment.kt | 4 +- ...xtensionsProcessDisabledForegroundController.kt | 4 +- .../fenix/addons/InstalledAddonDetailsFragment.kt | 2 +- .../fenix/extension/WebExtensionPromptFeature.kt | 8 +-- .../main/java/org/mozilla/fenix/home/HomeMenu.kt | 2 +- .../org/mozilla/fenix/settings/SettingsFragment.kt | 4 +- .../src/main/res/layout/crash_extension_dialog.xml | 6 +- .../main/res/layout/fragment_add_on_details.xml | 2 +- .../res/layout/fragment_add_ons_management.xml | 2 +- .../main/res/layout/overlay_add_on_progress.xml | 2 +- .../fenix/app/src/main/res/values/strings.xml | 54 +++++++++++++----- .../fenix/app/src/main/res/xml/preferences.xml | 6 +- .../extension/WebExtensionPromptFeatureTest.kt | 8 +-- 29 files changed, 170 insertions(+), 103 deletions(-) diff --git a/mobile/android/android-components/components/browser/menu/src/main/java/mozilla/components/browser/menu/WebExtensionBrowserMenuBuilder.kt b/mobile/android/android-components/components/browser/menu/src/main/java/mozilla/components/browser/menu/WebExtensionBrowserMenuBuilder.kt index 1ca54f676467..494014bf66b5 100644 --- a/mobile/android/android-components/components/browser/menu/src/main/java/mozilla/components/browser/menu/WebExtensionBrowserMenuBuilder.kt +++ b/mobile/android/android-components/components/browser/menu/src/main/java/mozilla/components/browser/menu/WebExtensionBrowserMenuBuilder.kt @@ -91,14 +91,14 @@ class WebExtensionBrowserMenuBuilder( ): List { val addonsMenuItem = if (filteredExtensionMenuItems.isNotEmpty()) { val backPressMenuItem = BackPressMenuItem( - contentDescription = context.getString(R.string.mozac_browser_menu_addons_description), - label = context.getString(R.string.mozac_browser_menu_addons), + contentDescription = context.getString(R.string.mozac_browser_menu_extensions_content_description), + label = context.getString(R.string.mozac_browser_menu_extensions), imageResource = style.backPressMenuItemDrawableRes, iconTintColorResource = style.webExtIconTintColorResource, ) val addonsManagerMenuItem = BrowserMenuImageText( - label = context.getString(R.string.mozac_browser_menu_addons_manager), + label = context.getString(R.string.mozac_browser_menu_extensions_manager), imageResource = style.addonsManagerMenuItemDrawableRes, iconTintColorResource = style.webExtIconTintColorResource, ) { @@ -119,7 +119,7 @@ class WebExtensionBrowserMenuBuilder( val webExtMenu = WebExtensionBrowserMenu(webExtBrowserMenuAdapter, store) ParentBrowserMenuItem( - label = context.getString(R.string.mozac_browser_menu_addons), + label = context.getString(R.string.mozac_browser_menu_extensions), imageResource = style.addonsManagerMenuItemDrawableRes, iconTintColorResource = style.webExtIconTintColorResource, subMenu = webExtMenu, @@ -127,7 +127,7 @@ class WebExtensionBrowserMenuBuilder( ) } else { BrowserMenuImageText( - label = context.getString(R.string.mozac_browser_menu_addons), + label = context.getString(R.string.mozac_browser_menu_extensions), imageResource = style.addonsManagerMenuItemDrawableRes, iconTintColorResource = style.webExtIconTintColorResource, ) { diff --git a/mobile/android/android-components/components/browser/menu/src/main/res/values/strings.xml b/mobile/android/android-components/components/browser/menu/src/main/res/values/strings.xml index bb0b725b17cc..dae4c81308b1 100644 --- a/mobile/android/android-components/components/browser/menu/src/main/res/values/strings.xml +++ b/mobile/android/android-components/components/browser/menu/src/main/res/values/strings.xml @@ -2,17 +2,23 @@ - + Menu Highlighted - Add-ons + Add-ons + + Extensions - Add-ons Manager + Add-ons Manager + + Extensions Manager Navigate up - Add-ons, navigate up + Add-ons, navigate up + + Extensions, navigate up diff --git a/mobile/android/android-components/components/browser/menu/src/test/java/mozilla/components/browser/menu/WebExtensionBrowserMenuBuilderTest.kt b/mobile/android/android-components/components/browser/menu/src/test/java/mozilla/components/browser/menu/WebExtensionBrowserMenuBuilderTest.kt index 58b1a8288951..0c5feb0d5b2f 100644 --- a/mobile/android/android-components/components/browser/menu/src/test/java/mozilla/components/browser/menu/WebExtensionBrowserMenuBuilderTest.kt +++ b/mobile/android/android-components/components/browser/menu/src/test/java/mozilla/components/browser/menu/WebExtensionBrowserMenuBuilderTest.kt @@ -391,7 +391,7 @@ class WebExtensionBrowserMenuBuilderTest { assertEquals("ParentBrowserMenuItem", parentMenuItem.javaClass.simpleName) // the replaced item should have the action title of the WebExtensionBrowserMenuItem - assertEquals("Add-ons", parentMenuItem.label) + assertEquals(testContext.getString(R.string.mozac_browser_menu_extensions), parentMenuItem.label) val subMenuItemSize = parentMenuItem.subMenu.adapter.visibleItems.size @@ -450,7 +450,7 @@ class WebExtensionBrowserMenuBuilderTest { assertEquals(3, recyclerAdapter.itemCount) val lastItem = recyclerAdapter.visibleItems[2] - assert(lastItem is ParentBrowserMenuItem && lastItem.label == "Add-ons") + assert(lastItem is ParentBrowserMenuItem && lastItem.label == testContext.getString(R.string.mozac_browser_menu_extensions)) } @Test diff --git a/mobile/android/android-components/components/feature/addons/src/main/java/mozilla/components/feature/addons/ui/AddonsManagerAdapter.kt b/mobile/android/android-components/components/feature/addons/src/main/java/mozilla/components/feature/addons/ui/AddonsManagerAdapter.kt index 33b35e8adda8..76ffb0990a45 100644 --- a/mobile/android/android-components/components/feature/addons/src/main/java/mozilla/components/feature/addons/ui/AddonsManagerAdapter.kt +++ b/mobile/android/android-components/components/feature/addons/src/main/java/mozilla/components/feature/addons/ui/AddonsManagerAdapter.kt @@ -247,10 +247,10 @@ class AddonsManagerAdapter( holder.titleView.setText(section.title) holder.descriptionView.text = if (unsupportedAddons.size == 1) { - context.getString(R.string.mozac_feature_addons_unsupported_caption) + context.getString(R.string.mozac_feature_addons_unsupported_caption_2) } else { context.getString( - R.string.mozac_feature_addons_unsupported_caption_plural, + R.string.mozac_feature_addons_unsupported_caption_plural_2, unsupportedAddons.size.toString(), ) } diff --git a/mobile/android/android-components/components/feature/addons/src/main/java/mozilla/components/feature/addons/update/AddonUpdater.kt b/mobile/android/android-components/components/feature/addons/src/main/java/mozilla/components/feature/addons/update/AddonUpdater.kt index 8b1e1c9f3249..717c1bdef65c 100644 --- a/mobile/android/android-components/components/feature/addons/src/main/java/mozilla/components/feature/addons/update/AddonUpdater.kt +++ b/mobile/android/android-components/components/feature/addons/src/main/java/mozilla/components/feature/addons/update/AddonUpdater.kt @@ -288,7 +288,7 @@ class DefaultAddonUpdater( ): Notification { val channel = ChannelData( NOTIFICATION_CHANNEL_ID, - R.string.mozac_feature_addons_updater_notification_channel, + R.string.mozac_feature_addons_updater_notification_channel_2, NotificationManagerCompat.IMPORTANCE_LOW, ) val channelId = ensureNotificationChannelExists(applicationContext, channel) diff --git a/mobile/android/android-components/components/feature/addons/src/main/res/layout/mozac_feature_addons_footer_section_item.xml b/mobile/android/android-components/components/feature/addons/src/main/res/layout/mozac_feature_addons_footer_section_item.xml index a749fa5c29c4..1f76ce69d5e2 100644 --- a/mobile/android/android-components/components/feature/addons/src/main/res/layout/mozac_feature_addons_footer_section_item.xml +++ b/mobile/android/android-components/components/feature/addons/src/main/res/layout/mozac_feature_addons_footer_section_item.xml @@ -9,7 +9,7 @@ android:layout_marginEnd="12dp" android:layout_marginTop="8dp" android:layout_marginBottom="12dp" - android:text="@string/mozac_feature_addons_find_more_addons_button_text" + android:text="@string/mozac_feature_addons_find_more_extensions_button_text" android:textAlignment="center" android:textAllCaps="false" - android:textSize="14sp" /> \ No newline at end of file + android:textSize="14sp" /> diff --git a/mobile/android/android-components/components/feature/addons/src/main/res/layout/mozac_feature_addons_header_section_item.xml b/mobile/android/android-components/components/feature/addons/src/main/res/layout/mozac_feature_addons_header_section_item.xml index 4649d018e78f..28156a186099 100644 --- a/mobile/android/android-components/components/feature/addons/src/main/res/layout/mozac_feature_addons_header_section_item.xml +++ b/mobile/android/android-components/components/feature/addons/src/main/res/layout/mozac_feature_addons_header_section_item.xml @@ -24,7 +24,7 @@ app:srcCompat="@drawable/mozac_ic_warning_fill_24" app:tint="?android:attr/textColorLink"/> - \ No newline at end of file + diff --git a/mobile/android/android-components/components/feature/addons/src/main/res/values/strings.xml b/mobile/android/android-components/components/feature/addons/src/main/res/values/strings.xml index d767e75d74ff..8429f6135abf 100644 --- a/mobile/android/android-components/components/feature/addons/src/main/res/values/strings.xml +++ b/mobile/android/android-components/components/feature/addons/src/main/res/values/strings.xml @@ -90,7 +90,9 @@ Rating - More about this add-on + More about this add-on + + More about this extension Settings @@ -158,13 +160,21 @@ Add-ons Manager - Add-ons are temporarily disabled + Add-ons are temporarily disabled + + Extensions are temporarily disabled - One or more add-ons stopped working, making your system unstable. + One or more add-ons stopped working, making your system unstable. + + One or more extensions stopped working, making your system unstable. - Restart add-ons + Restart add-ons + + Restart extensions - Find more add-ons + Find more add-ons + + Find more extensions Allow @@ -176,13 +186,15 @@ A new permission is required - Add-on updates + Add-on updates + + Extension updates - Supported add-ons checker + Supported add-ons checker - New add-on available + New add-on available - New add-ons available + New add-ons available Add %1$s to %2$s @@ -190,13 +202,17 @@ Add them to %1$s - Firefox add-on technology is modernizing. These add-ons use frameworks that are not compatible with Firefox 75 & beyond. + Firefox add-on technology is modernizing. These add-ons use frameworks that are not compatible with Firefox 75 & beyond. We‘re currently building support for an initial selection of Recommended Extensions. - Downloading and verifying add-on… + Downloading and verifying add-on… + + Downloading and verifying extension… - Failed to query Add-ons! + Failed to query Add-ons! + + Failed to query Extensions! Translation not found, for locale %1$s neither default language %2$s @@ -204,13 +220,21 @@ Failed to install %1$s - Failed to install this add-on. + Failed to install this add-on. + + Failed to install this extension. - This add-on could not be downloaded because of a connection failure. + This add-on could not be downloaded because of a connection failure. + + This extension could not be downloaded because of a connection failure. - This add-on could not be installed because it appears to be corrupt. + This add-on could not be installed because it appears to be corrupt. + + This extension could not be installed because it appears to be corrupt. - This add-on could not be installed because it has not been verified. + This add-on could not be installed because it has not been verified. + + This extension could not be installed because it has not been verified. %1$s could not be installed because it is not compatible with %2$s %3$s. @@ -234,9 +258,13 @@ This add-on was migrated from a previous version of %1$s - 1 add-on + 1 add-on + + 1 extension - %1$s add-ons + %1$s add-ons + + %1$s extensions Learn more diff --git a/mobile/android/android-components/components/feature/addons/src/test/java/mozilla/components/feature/addons/ui/AddonsManagerAdapterTest.kt b/mobile/android/android-components/components/feature/addons/src/test/java/mozilla/components/feature/addons/ui/AddonsManagerAdapterTest.kt index 70fb2da94821..9ff8a083e533 100644 --- a/mobile/android/android-components/components/feature/addons/src/test/java/mozilla/components/feature/addons/ui/AddonsManagerAdapterTest.kt +++ b/mobile/android/android-components/components/feature/addons/src/test/java/mozilla/components/feature/addons/ui/AddonsManagerAdapterTest.kt @@ -486,7 +486,7 @@ class AddonsManagerAdapterTest { adapter.bindNotYetSupportedSection(unsupportedSectionViewHolder, mock()) verify(unsupportedSectionViewHolder.descriptionView).setText( - testContext.getString(R.string.mozac_feature_addons_unsupported_caption_plural, unsupportedAddons.size), + testContext.getString(R.string.mozac_feature_addons_unsupported_caption_plural_2, unsupportedAddons.size), ) unsupportedSectionViewHolder.itemView.performClick() diff --git a/mobile/android/android-components/samples/browser/src/main/java/org/mozilla/samples/browser/addons/AddonsFragment.kt b/mobile/android/android-components/samples/browser/src/main/java/org/mozilla/samples/browser/addons/AddonsFragment.kt index ab37acca3a35..1e3115a8db62 100644 --- a/mobile/android/android-components/samples/browser/src/main/java/org/mozilla/samples/browser/addons/AddonsFragment.kt +++ b/mobile/android/android-components/samples/browser/src/main/java/org/mozilla/samples/browser/addons/AddonsFragment.kt @@ -104,7 +104,7 @@ class AddonsFragment : Fragment(), AddonsManagerAdapterDelegate { scope.launch(Dispatchers.Main) { Toast.makeText( activity, - addonsR.string.mozac_feature_addons_failed_to_query_add_ons, + addonsR.string.mozac_feature_addons_failed_to_query_extensions, Toast.LENGTH_SHORT, ).show() } diff --git a/mobile/android/android-components/samples/browser/src/main/java/org/mozilla/samples/browser/addons/InstalledAddonDetailsActivity.kt b/mobile/android/android-components/samples/browser/src/main/java/org/mozilla/samples/browser/addons/InstalledAddonDetailsActivity.kt index e029ace967eb..1d84830d2989 100644 --- a/mobile/android/android-components/samples/browser/src/main/java/org/mozilla/samples/browser/addons/InstalledAddonDetailsActivity.kt +++ b/mobile/android/android-components/samples/browser/src/main/java/org/mozilla/samples/browser/addons/InstalledAddonDetailsActivity.kt @@ -55,7 +55,7 @@ class InstalledAddonDetailsActivity : AppCompatActivity() { scope.launch(Dispatchers.Main) { Toast.makeText( baseContext, - addonsR.string.mozac_feature_addons_failed_to_query_add_ons, + addonsR.string.mozac_feature_addons_failed_to_query_extensions, Toast.LENGTH_SHORT, ).show() } diff --git a/mobile/android/android-components/samples/browser/src/main/res/layout/overlay_add_on_progress.xml b/mobile/android/android-components/samples/browser/src/main/res/layout/overlay_add_on_progress.xml index 4beaa3caac26..77cc30fa5ef2 100644 --- a/mobile/android/android-components/samples/browser/src/main/res/layout/overlay_add_on_progress.xml +++ b/mobile/android/android-components/samples/browser/src/main/res/layout/overlay_add_on_progress.xml @@ -23,7 +23,7 @@ android:drawablePadding="8dp" android:gravity="start|center_vertical" android:padding="16dp" - android:text="@string/mozac_add_on_install_progress_caption" + android:text="@string/mozac_extension_install_progress_caption" app:drawableStartCompat="@drawable/mozac_ic_extensions_black" />