From 3085eae60a3bd7034ed7bacef8939845ae777ad9 Mon Sep 17 00:00:00 2001 From: Alexandru2909 Date: Tue, 18 Oct 2022 12:57:50 +0300 Subject: [PATCH] [fenix] For https://github.com/mozilla-mobile/fenix/issues/27135 - Correctly report top sites for a11y services --- .../java/org/mozilla/fenix/home/topsites/TopSiteItemViewHolder.kt | 4 ++-- .../java/org/mozilla/fenix/home/topsites/TopSiteItemViewHolderTest.kt | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/home/topsites/TopSiteItemViewHolder.kt b/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/home/topsites/TopSiteItemViewHolder.kt index ab13c2abbaa5..5af87487f162 100644 --- a/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/home/topsites/TopSiteItemViewHolder.kt +++ b/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/home/topsites/TopSiteItemViewHolder.kt @@ -39,7 +39,7 @@ class TopSiteItemViewHolder( private val binding = TopSiteItemBinding.bind(view) init { - binding.topSiteItem.setOnLongClickListener { + itemView.setOnLongClickListener { interactor.onTopSiteMenuOpened() TopSites.longPress.record(TopSites.LongPressExtra(topSite.name())) @@ -72,7 +72,7 @@ class TopSiteItemViewHolder( } fun bind(topSite: TopSite, position: Int) { - binding.topSiteItem.setOnClickListener { + itemView.setOnClickListener { interactor.onSelectTopSite(topSite, position) } diff --git a/mobile/android/fenix/app/src/test/java/org/mozilla/fenix/home/topsites/TopSiteItemViewHolderTest.kt b/mobile/android/fenix/app/src/test/java/org/mozilla/fenix/home/topsites/TopSiteItemViewHolderTest.kt index 97aef255b71c..cd41e14d8d4b 100644 --- a/mobile/android/fenix/app/src/test/java/org/mozilla/fenix/home/topsites/TopSiteItemViewHolderTest.kt +++ b/mobile/android/fenix/app/src/test/java/org/mozilla/fenix/home/topsites/TopSiteItemViewHolderTest.kt @@ -58,7 +58,7 @@ class TopSiteItemViewHolderTest { fun `calls interactor on click`() { TopSiteItemViewHolder(binding.root, lifecycleOwner, interactor).bind(pocket, position = 0) - binding.topSiteItem.performClick() + binding.root.performClick() verify { interactor.onSelectTopSite(pocket, position = 0) } } @@ -67,7 +67,7 @@ class TopSiteItemViewHolderTest { every { testContext.components.analytics } returns mockk(relaxed = true) TopSiteItemViewHolder(binding.root, lifecycleOwner, interactor).bind(pocket, position = 0) - binding.topSiteItem.performLongClick() + binding.root.performLongClick() verify { interactor.onTopSiteMenuOpened() } } -- 2.11.4.GIT