From 0d10cb3c364849db30d17a3a60bf798a5ed4f7fd Mon Sep 17 00:00:00 2001 From: Blink WPT Bot Date: Thu, 13 Oct 2022 16:04:38 +0000 Subject: [PATCH] Bug 1794188 [wpt PR 36174] - [css-flex] Fix column-wrap container max < min error with % width item, a=testonly Automatic update from web-platform-tests [css-flex] Fix column-wrap container max < min error with % width item (#36174) When laying out items during column-wrap container max intrinsic sizing, items with % width were resolving against indefinite, so contributed 0 width. But during intrinsic sizing, children with % width are supposed to treat that width as auto, which ComputeMinMaxContributionSizes already handles. So instead of letting items resolve their widths _during layout during intrinsic sizing_, fix items' inline sizes to the their max contribution size in the various constraint spaces. Bug: 240765 Change-Id: I8aa16497e759cb6325f6febcab3446328abf9002 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3927803 Reviewed-by: Ian Kilpatrick Commit-Queue: David Grogan Cr-Commit-Position: refs/heads/main@{#1056008} Co-authored-by: David Grogan -- wpt-commits: 639970875c9b766106bd19a768f1821cb88de056 wpt-pr: 36174 --- .../css-flexbox/intrinsic-size/col-wrap-010.html | 33 ++++++++++++++++ .../css-flexbox/intrinsic-size/col-wrap-011.html | 36 +++++++++++++++++ .../css-flexbox/intrinsic-size/col-wrap-012.html | 39 +++++++++++++++++++ .../css-flexbox/intrinsic-size/col-wrap-013.html | 26 +++++++++++++ .../css-flexbox/intrinsic-size/col-wrap-014.html | 26 +++++++++++++ .../css-flexbox/intrinsic-size/col-wrap-015.html | 39 +++++++++++++++++++ .../css-flexbox/intrinsic-size/col-wrap-016.html | 38 ++++++++++++++++++ .../css-flexbox/intrinsic-size/col-wrap-017.html | 29 ++++++++++++++ .../css-flexbox/intrinsic-size/col-wrap-018.html | 45 ++++++++++++++++++++++ .../css-flexbox/intrinsic-size/col-wrap-019.html | 42 ++++++++++++++++++++ 10 files changed, 353 insertions(+) create mode 100644 testing/web-platform/tests/css/css-flexbox/intrinsic-size/col-wrap-010.html create mode 100644 testing/web-platform/tests/css/css-flexbox/intrinsic-size/col-wrap-011.html create mode 100644 testing/web-platform/tests/css/css-flexbox/intrinsic-size/col-wrap-012.html create mode 100644 testing/web-platform/tests/css/css-flexbox/intrinsic-size/col-wrap-013.html create mode 100644 testing/web-platform/tests/css/css-flexbox/intrinsic-size/col-wrap-014.html create mode 100644 testing/web-platform/tests/css/css-flexbox/intrinsic-size/col-wrap-015.html create mode 100644 testing/web-platform/tests/css/css-flexbox/intrinsic-size/col-wrap-016.html create mode 100644 testing/web-platform/tests/css/css-flexbox/intrinsic-size/col-wrap-017.html create mode 100644 testing/web-platform/tests/css/css-flexbox/intrinsic-size/col-wrap-018.html create mode 100644 testing/web-platform/tests/css/css-flexbox/intrinsic-size/col-wrap-019.html diff --git a/testing/web-platform/tests/css/css-flexbox/intrinsic-size/col-wrap-010.html b/testing/web-platform/tests/css/css-flexbox/intrinsic-size/col-wrap-010.html new file mode 100644 index 000000000000..2458443f0659 --- /dev/null +++ b/testing/web-platform/tests/css/css-flexbox/intrinsic-size/col-wrap-010.html @@ -0,0 +1,33 @@ + + + + + + + + + + + + +
+
+
+
+
+
+ + + diff --git a/testing/web-platform/tests/css/css-flexbox/intrinsic-size/col-wrap-011.html b/testing/web-platform/tests/css/css-flexbox/intrinsic-size/col-wrap-011.html new file mode 100644 index 000000000000..9970d43d0cdc --- /dev/null +++ b/testing/web-platform/tests/css/css-flexbox/intrinsic-size/col-wrap-011.html @@ -0,0 +1,36 @@ + + + + + + + + + +

Test passes if there is a filled green square and no red. +

+ +
+ +
+
+
+
diff --git a/testing/web-platform/tests/css/css-flexbox/intrinsic-size/col-wrap-012.html b/testing/web-platform/tests/css/css-flexbox/intrinsic-size/col-wrap-012.html new file mode 100644 index 000000000000..a46ceea2ec49 --- /dev/null +++ b/testing/web-platform/tests/css/css-flexbox/intrinsic-size/col-wrap-012.html @@ -0,0 +1,39 @@ + + + + + + + + + +

Test passes if there is a filled green square and no red. +

+
+ +
+
+
+
+
+ +
+
+
diff --git a/testing/web-platform/tests/css/css-flexbox/intrinsic-size/col-wrap-013.html b/testing/web-platform/tests/css/css-flexbox/intrinsic-size/col-wrap-013.html new file mode 100644 index 000000000000..d8eab3f1331d --- /dev/null +++ b/testing/web-platform/tests/css/css-flexbox/intrinsic-size/col-wrap-013.html @@ -0,0 +1,26 @@ + + + + + + + + +

Test passes if there is a filled green square and no red. + +

+
+
+
+
+
+
+
diff --git a/testing/web-platform/tests/css/css-flexbox/intrinsic-size/col-wrap-014.html b/testing/web-platform/tests/css/css-flexbox/intrinsic-size/col-wrap-014.html new file mode 100644 index 000000000000..5861d829b582 --- /dev/null +++ b/testing/web-platform/tests/css/css-flexbox/intrinsic-size/col-wrap-014.html @@ -0,0 +1,26 @@ + + + + + + + + +

Test passes if there is a filled green square and no red. + +

+
+
+
+
+
+
+
diff --git a/testing/web-platform/tests/css/css-flexbox/intrinsic-size/col-wrap-015.html b/testing/web-platform/tests/css/css-flexbox/intrinsic-size/col-wrap-015.html new file mode 100644 index 000000000000..23b762f36a9b --- /dev/null +++ b/testing/web-platform/tests/css/css-flexbox/intrinsic-size/col-wrap-015.html @@ -0,0 +1,39 @@ + + + + + + + + + +

Test passes if there is a filled green square and no red. +

+
+ +
+
+
+
+
+
+
+
diff --git a/testing/web-platform/tests/css/css-flexbox/intrinsic-size/col-wrap-016.html b/testing/web-platform/tests/css/css-flexbox/intrinsic-size/col-wrap-016.html new file mode 100644 index 000000000000..a013bbd3566b --- /dev/null +++ b/testing/web-platform/tests/css/css-flexbox/intrinsic-size/col-wrap-016.html @@ -0,0 +1,38 @@ + + + + + + + + + +

Test passes if there is a filled green square and no red. +

+
+ +
+
+
+
+
+
+
+
diff --git a/testing/web-platform/tests/css/css-flexbox/intrinsic-size/col-wrap-017.html b/testing/web-platform/tests/css/css-flexbox/intrinsic-size/col-wrap-017.html new file mode 100644 index 000000000000..c7a64643bf1d --- /dev/null +++ b/testing/web-platform/tests/css/css-flexbox/intrinsic-size/col-wrap-017.html @@ -0,0 +1,29 @@ + + + + + + + + + +

Test passes if there is a filled green square and no red. +

+ +
+ +
+
+
+
+
diff --git a/testing/web-platform/tests/css/css-flexbox/intrinsic-size/col-wrap-018.html b/testing/web-platform/tests/css/css-flexbox/intrinsic-size/col-wrap-018.html new file mode 100644 index 000000000000..755237fd0b70 --- /dev/null +++ b/testing/web-platform/tests/css/css-flexbox/intrinsic-size/col-wrap-018.html @@ -0,0 +1,45 @@ + + + + + + + + + + + + +

Main point of this test is that the container width is 100px, not 140px.

+ +
+
+
+ +
+
+
+
+
+
+
+ + diff --git a/testing/web-platform/tests/css/css-flexbox/intrinsic-size/col-wrap-019.html b/testing/web-platform/tests/css/css-flexbox/intrinsic-size/col-wrap-019.html new file mode 100644 index 000000000000..9da4d77cd129 --- /dev/null +++ b/testing/web-platform/tests/css/css-flexbox/intrinsic-size/col-wrap-019.html @@ -0,0 +1,42 @@ + + + + + + + + + + + + +

Main point of this test is that the container width is 100px, not 80px.

+ +
+ +
+
+
+
+
+
+
+ + -- 2.11.4.GIT