Bug 1599969 [wpt PR 20494] - Revert "[LayoutNG] Fix hyphens when rewinding occurs...
commitfb261ab5a94c709ba7786f32730ca0124dc099ef
authorKoji Ishii <kojii@chromium.org>
Mon, 2 Dec 2019 13:33:00 +0000 (2 13:33 +0000)
committermoz-wptsync-bot <wptsync@mozilla.com>
Wed, 4 Dec 2019 12:12:36 +0000 (4 12:12 +0000)
tree8ef89e5b32bdfaa3e3ccd536c0a6848e632b4762
parent9b4b9d17131c2a500638011670abf6b99b8fcc67
Bug 1599969 [wpt PR 20494] - Revert "[LayoutNG] Fix hyphens when rewinding occurs", a=testonly

Automatic update from web-platform-tests
Revert "[LayoutNG] Fix hyphens when rewinding occurs"

This reverts commit 957329b6eeba01be943a4991c8bd082a87ac1417.

Reason for revert: r708894 fixed the case where hyphens are
not rendered under certain conditions, but caused the
infinite rewind loop in |NGLineBreaker| when there are
negative margins on inline boxes.

This patch reverts the fix. I will work on the new fix for
the issue 1015297 after this revert.

Original change's description:
> [LayoutNG] Fix hyphens when rewinding occurs
>
> This patch removes |NGLineInfo::LineEndFragment|, which was
> introduced to support hyphens and ellipsis with the single
> code. However, ellipsis was changed to use different code,
> and |LineEndFragment| ended up with non-optimal way to handle
> hyphens.
>
> Although hyphens appear at most once in a line, storing this
> to |NGLineInfo| makes harder to keep it in sync with the
> hyphenated item. This patch changes it to a field in
> |NGInlineItemResult|.
>
> Bug: 1015297
> Change-Id: I0706cf54bebfa967661dc40123c6dfd5887ff59c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868534
> Commit-Queue: Koji Ishii <kojii@chromium.org>
> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#708894}

TBR=kojii@chromium.org,ikilpatrick@chromium.org

Bug: 10152971028817
Change-Id: I5f116288b935f3fd296f4c25c1bf0457779a8e84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940323
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719869}

--

wpt-commits: 38526f675727779ad81e8ad0c9e06da31e7b534c
wpt-pr: 20494
testing/web-platform/tests/css/css-text/hyphens/hyphens-overflow-001.html
testing/web-platform/tests/css/css-text/hyphens/reference/hyphens-overflow-001-ref.html