Bug 1736000 [wpt PR 31264] - Update DCHECK for <= 1px tall fragmentainers in legacy...
commitf356bf633c74a19d06ea7941b17d29ec3acf3b0d
authorMorten Stenshorne <mstensho@chromium.org>
Thu, 28 Oct 2021 10:15:02 +0000 (28 10:15 +0000)
committermoz-wptsync-bot <wptsync@mozilla.com>
Fri, 29 Oct 2021 10:23:38 +0000 (29 10:23 +0000)
treed61f0b3f179ce7c0ae031da78289ed6350b01486
parentb34e185432c15d0fe7a4a3d164bf5d43bb3f964b
Bug 1736000 [wpt PR 31264] - Update DCHECK for <= 1px tall fragmentainers in legacy write-back., a=testonly

Automatic update from web-platform-tests
Update DCHECK for <= 1px tall fragmentainers in legacy write-back.

If block_size was zero, we'd pass the DCHECK, but we should check for
any block_size <= 1px, since we don't only clamp for 0, but for any
values less than 1px. This code is in
NGBlockNode::PlaceChildrenInFlowThread(), and we'll clamp depending on
whether we have overflow or not. Some fragmentainers may have overflow,
while others may not.

This fixes external/wpt/css/css-paint-api/column-count-crash.https.html
when LayoutNGBlockFragmentation is enabled. Added two more crash tests
(the first one turned out to be an over-simplification, so I added
another one).

Bug: 829028
Change-Id: I19987f4b33df832d0298bfda81aadd1ea3ed557f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3226101
Reviewed-by: Alison Maher <almaher@microsoft.com>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/main@{#932101}

--

wpt-commits: 067d1be35ea8dd3ae5a69b72dd39f5e79e1afebc
wpt-pr: 31264
testing/web-platform/tests/css/css-break/fragmentainer-1px-clamping-000-crash.html [new file with mode: 0644]
testing/web-platform/tests/css/css-break/fragmentainer-1px-clamping-001-crash.html [new file with mode: 0644]