| commit | ed922c24b816e62e4cb3b99f54e746c2b3736d8f | |
| author | Dale Curtis <dalecurtis@chromium.org> | |
| Thu, 27 Jan 2022 11:14:02 +0000 (27 11:14 +0000) | ||
| committer | moz-wptsync-bot <wptsync@mozilla.com> | |
| Sat, 5 Feb 2022 11:49:05 +0000 (5 11:49 +0000) | ||
| tree | 2e2d1e6de529c7d893d5a2ff0f9a7678c38ea1f5 | treesnapshot (tar.gz zip) |
| parent | 24f80c25b824efeaf34d4b74396534ca44150242 | commitdiff |
Bug 1749870 [wpt PR 32357] - Fix issue with VideoFrameMetadata merging for bool=true fields., a=testonly
Automatic update from web-platform-tests
Fix issue with VideoFrameMetadata merging for bool=true fields.
The code was written assuming that if (metadata.value) was false,
it shouldn't be merged. This is fine for optional fields, but not
bool fields.
Specifically in this bug, `texture_origin_is_top_left` defaults to
true, but is set to false when a canvas backed VideoFrame is made.
The old path would fail to copy the false value over.
This fixes the merge process and adds a test for this case. It also
adds a missing 'dcomp_surface' to the merge process.
R=tguilbert
Fixed: 1277865
Change-Id: I96f7a8032327adaa150ffe7412883bcfb051f71e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3385357
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/main@{#958843}
--
wpt-commits: 506092d9a9f4d7480fa6351e136fd98b93ace350
wpt-pr: 32357
Automatic update from web-platform-tests
Fix issue with VideoFrameMetadata merging for bool=true fields.
The code was written assuming that if (metadata.value) was false,
it shouldn't be merged. This is fine for optional fields, but not
bool fields.
Specifically in this bug, `texture_origin_is_top_left` defaults to
true, but is set to false when a canvas backed VideoFrame is made.
The old path would fail to copy the false value over.
This fixes the merge process and adds a test for this case. It also
adds a missing 'dcomp_surface' to the merge process.
R=tguilbert
Fixed: 1277865
Change-Id: I96f7a8032327adaa150ffe7412883bcfb051f71e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3385357
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/main@{#958843}
--
wpt-commits: 506092d9a9f4d7480fa6351e136fd98b93ace350
wpt-pr: 32357
| testing/web-platform/tests/webcodecs/videoFrame-canvasImageSource.html | diffblobblamehistory |