| commit | ed8615062585103fb8b413681ff61e7def8dbd99 | |
| author | Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> | |
| Thu, 27 Jan 2022 11:57:48 +0000 (27 11:57 +0000) | ||
| committer | moz-wptsync-bot <wptsync@mozilla.com> | |
| Sat, 5 Feb 2022 11:50:29 +0000 (5 11:50 +0000) | ||
| tree | 914e437dd1b97d9feb1341a0cf9aeac87a413a1b | treesnapshot (tar.gz zip) |
| parent | be4541ac9d12606803b656f5e1874488a51daee9 | commitdiff |
Bug 1751736 [wpt PR 32514] - sensors: Do nothing in Sensor.start() when the document is not fully active., a=testonly
Automatic update from web-platform-tests
sensors: Do nothing in Sensor.start() when the document is not fully active.
When a sensor is created on e.g. an iframe that is later removed from
its parent via removeChild(), we end up in a situation where a sensor
instance did get created but which does not have a valid
ExecutionContext by the time start() is invoked.
Check for a valid ExecutionContext when start() is called and bail out
early if it is null. https://github.com/w3c/sensors/issues/415 tracks
handling non-fully active documents from a spec perspective; once that
one is fixed we should probably throw an error in this case rather than
silently doing nothing.
Bug: 1289924
Change-Id: I2b033252d93347ba7c91385bdb510b69b8298aa2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3412476
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Raphael Kubo Da Costa <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/main@{#962930}
--
wpt-commits: 57fbbb2179141a672ee861ba53d9afb705bdb7f8
wpt-pr: 32514
Automatic update from web-platform-tests
sensors: Do nothing in Sensor.start() when the document is not fully active.
When a sensor is created on e.g. an iframe that is later removed from
its parent via removeChild(), we end up in a situation where a sensor
instance did get created but which does not have a valid
ExecutionContext by the time start() is invoked.
Check for a valid ExecutionContext when start() is called and bail out
early if it is null. https://github.com/w3c/sensors/issues/415 tracks
handling non-fully active documents from a spec perspective; once that
one is fixed we should probably throw an error in this case rather than
silently doing nothing.
Bug: 1289924
Change-Id: I2b033252d93347ba7c91385bdb510b69b8298aa2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3412476
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Raphael Kubo Da Costa <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/main@{#962930}
--
wpt-commits: 57fbbb2179141a672ee861ba53d9afb705bdb7f8
wpt-pr: 32514
| testing/web-platform/tests/generic-sensor/generic-sensor-iframe-tests.sub.js | diffblobblamehistory |