| commit | e2f04fe67e8f432809a33a917e8ed846a83935a5 | |
| author | Michael Comella <michael.l.comella@gmail.com> | |
| Thu, 24 Sep 2020 23:35:36 +0000 (24 16:35 -0700) | ||
| committer | Michael Comella <mcomella@fastmail.com> | |
| Tue, 29 Sep 2020 01:01:19 +0000 (28 18:01 -0700) | ||
| tree | 342e8350e514b7d5f0d15d8374cf47bf68dda72c | treesnapshot (tar.gz zip) |
| parent | 885197c7490c9bf37fa0d74549e86c3b906f0aac | commitdiff |
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959: move resetAfter into StrictModeManager.
In a followup PR, we need to add state to strictModeManager (the
number of suppressions). This is much simpler to do when this is defined
as a class rather than an object. However, when this is defined as a
class, `resetAfter` needs access to the strictModeManager. Instead of
passing it in as an argument, it made sense to move this function onto
the strictModeManager instead.
Since folks are used to calling:
```
StrictMode.ThreadPolicy.allowThreadDiskReads().resetAfter
```
We're going to have to add a lint check to prevent them from doing that.
In a followup PR, we need to add state to strictModeManager (the
number of suppressions). This is much simpler to do when this is defined
as a class rather than an object. However, when this is defined as a
class, `resetAfter` needs access to the strictModeManager. Instead of
passing it in as an argument, it made sense to move this function onto
the strictModeManager instead.
Since folks are used to calling:
```
StrictMode.ThreadPolicy.allowThreadDiskReads().resetAfter
```
We're going to have to add a lint check to prevent them from doing that.
20 files changed: