[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959: improve custom...
commitdf0e186be37d70576813d2c49022aad12139b464
authorMichael Comella <michael.l.comella@gmail.com>
Wed, 30 Sep 2020 18:49:06 +0000 (30 11:49 -0700)
committerMichael Comella <mcomella@fastmail.com>
Tue, 6 Oct 2020 21:11:53 +0000 (6 14:11 -0700)
treea44a7d540ba7471d8bbe3f457d3c4b9f51845317
parent70bc84762c9930b52c6215b2f448c1f6839b0d7e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959: improve custom detekt violation output.

Before it used to output the violations all one one line. Now it looks
like:
```
MozillaStrictModeSuppression:
    'import mozilla.components.support.ktx.android.os.resetAfter' at
(17,1) in /StrictModeManager.kt
    Please use `components.strictMode.resetAfter` instead because it has
performance improvements and additional code to monitor for performance
regressions.

MozillaStrictModeSuppression:
    'setThreadPolicy(threadPolicy.build())' at (56,24) in
/StrictModeManager.kt
    Please use `components.strictMode.resetAfter` instead because it has
performance improvements and additional code to monitor for performance
regressions.

MozillaStrictModeSuppression:
    'setVmPolicy(builder.build())' at (71,24) in /StrictModeManager.kt
    NOT YET IMPLEMENTED: please consult the perf team about
implementing`StrictModeManager.resetAfter`: we want to understand the
performance implications of suppressing setVmPolicy before allowing it.
```
mobile/android/fenix/mozilla-detekt-rules/src/main/java/org/mozilla/fenix/detektrules/CustomRulesetConsoleReport.kt