| commit | d821b7456b2e22b1670e2dc3020b4a93aff944da | |
| author | Michael Comella <michael.l.comella@gmail.com> | |
| Wed, 14 Oct 2020 22:28:20 +0000 (14 15:28 -0700) | ||
| committer | Michael Comella <mcomella@fastmail.com> | |
| Thu, 15 Oct 2020 16:53:13 +0000 (15 09:53 -0700) | ||
| tree | 33d2105036b6573153b5571765d3593861e99dda | treesnapshot (tar.gz zip) |
| parent | 2d223f8651215782eac90044e29a4462add3f020 | commitdiff |
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15644: mock package inspection dependencies in GleanMetricsService.
The new robolectric version changed the behavior such that the app ID
that was returned for our app was `org.mozilla.fenix.debug` instead of
(I guess) `org.mozilla.fenix`. In general, relying on robolectric can be
fragile, such as this case, so it's better to mock. Also, this test
behavior should theoretically have varied between build flavors so
mocking prevents the tests from breaking across flavors.
The new robolectric version changed the behavior such that the app ID
that was returned for our app was `org.mozilla.fenix.debug` instead of
(I guess) `org.mozilla.fenix`. In general, relying on robolectric can be
fragile, such as this case, so it's better to mock. Also, this test
behavior should theoretically have varied between build flavors so
mocking prevents the tests from breaking across flavors.