| commit | ccc087a65a791f16548eb2f6face38f711f3ed33 | |
| author | Michael Comella <michael.l.comella@gmail.com> | |
| Wed, 4 Aug 2021 21:53:00 +0000 (4 14:53 -0700) | ||
| committer | mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> | |
| Fri, 6 Aug 2021 20:07:32 +0000 (6 20:07 +0000) | ||
| tree | 610b6c95c0070aec97bbee05df0cf4816cd6a117 | treesnapshot (tar.gz zip) |
| parent | 96e97090539860f8747155ff15a600a1c0257322 | commitdiff |
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20679: revert allowaccessmodification proguard disabling.
We disabled the allowaccessmodification proguard option because it broke
functionality or crashed the app (I can't rememeber). As far as we know,
the R8 bug was fixed in the R8 bundled with the Android Gradle Plugin
v4.1. We're now on AGP v7.0.0-rc1 so we should be able to revert this
now.
This commit reverts the following commits:
Revert "Proguard/r8: Do not allow access modification."
This reverts commit d2ec7c648856664c27b31831959fd2e83a580968.
Revert "Dump `proguard-android-optimize.txt` into local configuration for later modification"
This reverts commit c543ae338e0bce4a6e2395f3e72742d9c0d65042.
We disabled the allowaccessmodification proguard option because it broke
functionality or crashed the app (I can't rememeber). As far as we know,
the R8 bug was fixed in the R8 bundled with the Android Gradle Plugin
v4.1. We're now on AGP v7.0.0-rc1 so we should be able to revert this
now.
This commit reverts the following commits:
Revert "Proguard/r8: Do not allow access modification."
This reverts commit d2ec7c648856664c27b31831959fd2e83a580968.
Revert "Dump `proguard-android-optimize.txt` into local configuration for later modification"
This reverts commit c543ae338e0bce4a6e2395f3e72742d9c0d65042.
| mobile/android/fenix/app/build.gradle | diffblobblamehistory | |
| mobile/android/fenix/app/proguard-android-optimize-3.5.0-modified.txt | [deleted file] | blobblamehistory |