Bug 1832428 [wpt PR 39948] - [dPWA] Refactoring relative manifest id to absolute...
commitc5ebcc86a200cd3cda4742b727dad9ffe36c6279
authorDaniel Murphy <dmurph@google.com>
Wed, 17 May 2023 16:45:59 +0000 (17 16:45 +0000)
committermoz-wptsync-bot <wptsync@mozilla.com>
Sun, 21 May 2023 22:46:16 +0000 (21 22:46 +0000)
treedca63a8e011b5b88c10851e75e84fef96b37a005
parentba1fd7934b83d16ca13cde44cc4365f03d8b1071
Bug 1832428 [wpt PR 39948] - [dPWA] Refactoring relative manifest id to absolute id., a=testonly

Automatic update from web-platform-tests
[dPWA] Refactoring relative manifest id to absolute id.

This patch refactors the manifest parser & id handling to use the
computed manifest_id defined in the spec, which simplifies a lot of
code. This patch:
- Makes changes to the ManifestParser to output the id as a full url.
- Always populates the manifest_id web app representations.
- Fixes a variety of tests, including some small mistakes in the sub app
  tests that are hopefully minor.
- Adds a number of checks to ensure that things are created correctly.
- Updates the web_app_helper methods appropriately.

This change should have no functional impact.

Bug: 1231765,1442799,b/280606515
Change-Id: I6d69e2d94af9278d796df4efb3e275416e4ad59e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4515997
Reviewed-by: Dibyajyoti Pal <dibyapal@chromium.org>
Reviewed-by: Maksim Moskvitin <mmoskvitin@google.com>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1144248}

--

wpt-commits: cb1e54222a206b4cbb5211f7e24878a267b820f1
wpt-pr: 39948
testing/web-platform/tests/subapps/add-error.tentative.https.html
testing/web-platform/tests/subapps/add-success.tentative.https.html
testing/web-platform/tests/subapps/list-success.tentative.https.html
testing/web-platform/tests/subapps/remove-error.tentative.https.html
testing/web-platform/tests/subapps/remove-success.tentative.https.html