Bug 1863634 [wpt PR 43006] - view-transition: Fix rendering of inlines with box decor...
commitb74926a131871ed3d9da9ecc639738bbb3ea2335
authorKhushal Sagar <khushalsagar@chromium.org>
Mon, 20 Nov 2023 10:22:02 +0000 (20 10:22 +0000)
committermoz-wptsync-bot <wptsync@mozilla.com>
Wed, 22 Nov 2023 12:49:46 +0000 (22 12:49 +0000)
tree08bc4ac38ae6145ef7576bf55ce6014260c0bdb5
parent83ae632e575393be0a57af701f8be831ff9fc18f
Bug 1863634 [wpt PR 43006] - view-transition: Fix rendering of inlines with box decorations., a=testonly

Automatic update from web-platform-tests
view-transition: Fix rendering of inlines with box decorations.

The ink overflow rect computation for inlines misses overflow from box
decorations like box-shadow. Fix that by using
LinesVisualOverflowBoundingBox() which includes this overflow instead of
PhysicalLinesBorderBox() which is limited to border box bounds.

Since LinesVisualOverflowBoundingBox() also includes all overflow from
child text nodes (from text-shadow for example), we can skip iterating
those children as well. This iteration is still needed for text nodes
from non-inline LayoutObjects.

Bug: 1496876
Change-Id: I211028f1edc7cb4ba7f5e5e6e89e3d119d3d057c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5010350
Auto-Submit: Khushal Sagar <khushalsagar@chromium.org>
Reviewed-by: Vladimir Levin <vmpstr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Khushal Sagar <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1221792}

--

wpt-commits: 1a993c9e4eac9e6b144e6258315fcfce4c66adea
wpt-pr: 43006
testing/web-platform/tests/css/css-view-transitions/block-with-overflowing-text-ref.html [new file with mode: 0644]
testing/web-platform/tests/css/css-view-transitions/block-with-overflowing-text.html [copied from testing/web-platform/tests/css/css-view-transitions/span-with-overflowing-text.html with 74% similarity]
testing/web-platform/tests/css/css-view-transitions/span-with-overflowing-text-and-box-decorations-ref.html [copied from testing/web-platform/tests/css/css-view-transitions/span-with-overflowing-text-ref.html with 77% similarity]
testing/web-platform/tests/css/css-view-transitions/span-with-overflowing-text-and-box-decorations.html [copied from testing/web-platform/tests/css/css-view-transitions/span-with-overflowing-text.html with 80% similarity]
testing/web-platform/tests/css/css-view-transitions/span-with-overflowing-text-ref.html
testing/web-platform/tests/css/css-view-transitions/span-with-overflowing-text.html