| commit | af0abb6cb82c78ad0d7b5cd81470d1725253f76c | |
| author | James Graham <james@hoppipolla.co.uk> | |
| Tue, 20 Jun 2023 09:52:13 +0000 (20 10:52 +0100) | ||
| committer | moz-wptsync-bot <wptsync@mozilla.com> | |
| Wed, 21 Jun 2023 14:35:45 +0000 (21 14:35 +0000) | ||
| tree | 3d177f2fb8cb9337f0a5817c4287cf10ca277fdb | treesnapshot (tar.gz zip) |
| parent | 89c86010168f5a9eaef6f08445c615f3879eedb9 | commitdiff |
Bug 1839336 - Fix handling of testdriver failures in marionette, r=webdriver-reviewers
PR 40058 changed the behaviour here to reject the promise when an
action failed rather than throwing an exception. However there were
two problems:
* It implemented the new behaviour for Firefox, but failed to use the
implementation
* It changed the existing code to log an Error, which causes problems
in Gecko's CI
This reverts the logging behaviour, and fixes / wires up the
implementation of the new exception handling behaviour in gecko.
Differential Revision: https://phabricator.services.mozilla.com/D181455
PR 40058 changed the behaviour here to reject the promise when an
action failed rather than throwing an exception. However there were
two problems:
* It implemented the new behaviour for Firefox, but failed to use the
implementation
* It changed the existing code to log an Error, which causes problems
in Gecko's CI
This reverts the logging behaviour, and fixes / wires up the
implementation of the new exception handling behaviour in gecko.
Differential Revision: https://phabricator.services.mozilla.com/D181455
| testing/web-platform/tests/tools/wptrunner/wptrunner/executors/base.py | diffblobblamehistory | |
| testing/web-platform/tests/tools/wptrunner/wptrunner/executors/executormarionette.py | diffblobblamehistory |