Bug 1824795 [wpt PR 39222] - Convert `:open` to `:popover-open` for popovers, a=testonly
commit9f27b53b4c29c2b4a74ea47c2617602e8e4792bb
authorMason Freed <masonf@chromium.org>
Thu, 13 Apr 2023 04:24:48 +0000 (13 04:24 +0000)
committermoz-wptsync-bot <wptsync@mozilla.com>
Fri, 14 Apr 2023 11:15:09 +0000 (14 11:15 +0000)
treeba530ba9cae9d0823fc87514da890792f27aac67
parent9c42c8dd3ec755b39b1ab7bcc41f64391aad4404
Bug 1824795 [wpt PR 39222] - Convert `:open` to `:popover-open` for popovers, a=testonly

Automatic update from web-platform-tests
Convert `:open` to `:popover-open` for popovers

See [1]/[2] for more context, but there are cases where `:open` is
ambiguous for popovers. If multiple elements support `:open/:closed`,
and [popover] can be applied to any of them, there are situations
where an element is both open and closed. For example,
`<details popover>` can be closed as a details element and open as
a popover, which makes it match both `:open` and `:closed`. It seems
that really `:open` and `:closed` should match *elements* that can
open and close, and not things that can be made to open or close
via an attribute or other mechanism such as JS.

This CL adds `:popover-open` which only applies to popovers in the open
state, and it removes `:open` and `:closed` support for popovers. It also converts all of the popover WPTs to use `:popover-open` instead
of either `:open` or `:closed`.

[1] https://github.com/w3c/csswg-drafts/issues/8637
[2] https://github.com/whatwg/html/pull/9077

Bug: 1307772
Fixed: 1429670
Change-Id: I8d840512166ccdb5d5c8abbb7192bbce7177ee88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4373888
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Auto-Submit: Mason Freed <masonf@chromium.org>
Commit-Queue: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1124869}

--

wpt-commits: e68cb913b7cd3002609729bd2bde85b24ecaff39
wpt-pr: 39222
29 files changed:
testing/web-platform/tests/html/semantics/forms/the-selectmenu-element/selectmenu-parts-structure.tentative.html
testing/web-platform/tests/html/semantics/forms/the-selectmenu-element/selectmenu-popover-position-with-zoom.tentative.html [moved from testing/web-platform/tests/html/semantics/forms/the-selectmenu-element/selectmenu-popup-position-with-zoom.tentative.html with 100% similarity]
testing/web-platform/tests/html/semantics/forms/the-selectmenu-element/selectmenu-popover-position.tentative.html [moved from testing/web-platform/tests/html/semantics/forms/the-selectmenu-element/selectmenu-popup-position.tentative.html with 100% similarity]
testing/web-platform/tests/html/semantics/forms/the-selectmenu-element/selectmenu-popover.tentative.html [moved from testing/web-platform/tests/html/semantics/forms/the-selectmenu-element/selectmenu-popup.tentative.html with 100% similarity]
testing/web-platform/tests/html/semantics/popovers/hide-other-popover-side-effects.html
testing/web-platform/tests/html/semantics/popovers/light-dismiss-event-ordering.html
testing/web-platform/tests/html/semantics/popovers/popover-anchor-nesting.html
testing/web-platform/tests/html/semantics/popovers/popover-attribute-basic.html
testing/web-platform/tests/html/semantics/popovers/popover-document-open.html
testing/web-platform/tests/html/semantics/popovers/popover-events.html
testing/web-platform/tests/html/semantics/popovers/popover-focus-2.html
testing/web-platform/tests/html/semantics/popovers/popover-focus-child-dialog.html
testing/web-platform/tests/html/semantics/popovers/popover-focus.html
testing/web-platform/tests/html/semantics/popovers/popover-hidden-display.html
testing/web-platform/tests/html/semantics/popovers/popover-inside-display-none.html
testing/web-platform/tests/html/semantics/popovers/popover-invoking-attribute.html
testing/web-platform/tests/html/semantics/popovers/popover-light-dismiss-on-scroll.html
testing/web-platform/tests/html/semantics/popovers/popover-light-dismiss.html
testing/web-platform/tests/html/semantics/popovers/popover-not-keyboard-focusable.html
testing/web-platform/tests/html/semantics/popovers/popover-removal-2.html
testing/web-platform/tests/html/semantics/popovers/popover-removal.html
testing/web-platform/tests/html/semantics/popovers/popover-shadow-dom.html
testing/web-platform/tests/html/semantics/popovers/popover-stacking.html
testing/web-platform/tests/html/semantics/popovers/popover-target-element-disabled.html
testing/web-platform/tests/html/semantics/popovers/popover-top-layer-combinations.html
testing/web-platform/tests/html/semantics/popovers/popover-top-layer-interactions.html
testing/web-platform/tests/html/semantics/popovers/popover-types-with-hints.tentative.html
testing/web-platform/tests/html/semantics/popovers/popover-types.html
testing/web-platform/tests/html/semantics/popovers/resources/popover-utils.js