| commit | 93e4aa0fd18c92bc714a0bcc245e8e39becc7cf1 | |
| author | Xiaocheng Hu <xiaochengh@chromium.org> | |
| Fri, 13 Sep 2019 10:27:24 +0000 (13 10:27 +0000) | ||
| committer | moz-wptsync-bot <wptsync@mozilla.com> | |
| Sat, 14 Sep 2019 08:51:37 +0000 (14 08:51 +0000) | ||
| tree | faf26fa4ccca1fb86d557261fc8e7000263a2c53 | treesnapshot (tar.gz zip) |
| parent | 4eed4e23e7656a6028d03bfb3f2e2757fa3316d9 | commitdiff |
Bug 1578966 [wpt PR 18865] - Switch InterpolableLength implementation from length array to expression, a=testonly
Automatic update from web-platform-tests
Switch InterpolableLength implementation from length array to expression
This patch changes the internal implementation of InterpolableLength
from CSSLengthArray to the following:
- A CSSNumericLiteralValue to keep it simple when it's a simple value
- A CSSMathExpressionNode to make it general when the underlying length
involves calculation and math functions
In this way, we can interpolate when the length cannot be represented
as a CSSLengthArray (i.e., when comparison functions min/max are
involved).
Bug: 991672
Change-Id: Ib83fc0a07d0eb1d03a2465ac9df5282f963b935b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777025
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694443}
--
wpt-commits: 23209b4b1aecd29a86d33e1ac5145219983099fa
wpt-pr: 18865
Automatic update from web-platform-tests
Switch InterpolableLength implementation from length array to expression
This patch changes the internal implementation of InterpolableLength
from CSSLengthArray to the following:
- A CSSNumericLiteralValue to keep it simple when it's a simple value
- A CSSMathExpressionNode to make it general when the underlying length
involves calculation and math functions
In this way, we can interpolate when the length cannot be represented
as a CSSLengthArray (i.e., when comparison functions min/max are
involved).
Bug: 991672
Change-Id: Ib83fc0a07d0eb1d03a2465ac9df5282f963b935b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777025
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694443}
--
wpt-commits: 23209b4b1aecd29a86d33e1ac5145219983099fa
wpt-pr: 18865
| testing/web-platform/tests/css/css-values/minmax-length-percentage-interpolate.html | [new file with mode: 0644] | blob |