Bug 1881821 - Clean up tokens files ahead of JSON source of truth setup r=desktop...
commit93d186f3b113212be872037844faa72991b79dd6
authorJules Simplicio <jsimplicio@mozilla.com>
Tue, 26 Mar 2024 00:04:25 +0000 (26 00:04 +0000)
committerJules Simplicio <jsimplicio@mozilla.com>
Tue, 26 Mar 2024 00:04:25 +0000 (26 00:04 +0000)
tree4c7997628a7f1e682188d24ab86d7ba4c9db3cf2
parent5f3cb6000101a050fdaf38cc62fe67283c69b1ac
Bug 1881821 - Clean up tokens files ahead of JSON source of truth setup r=desktop-theme-reviewers,reusable-components-reviewers,hjones,dao,mstriemer

Changed
* `--color-background-*` are now part of the group of `--background-color` tokens
* `--box-background-color` is now part of the group of `--background-color` tokens as `--background-color-box`
* `--color-canvas` is now part of the group of `--background-color` tokens as `--background-color-canvas`
* `--border-interactive-*` are now part of the group of `--border-color` tokens and consequently now start with `--border-color`
* `--color-error-outline` is now an outline-specific token as `--outline-color-error`
* Comment headings were cleaned up as to follow the existing standard
* Better documentation behind the difference of "Base", "Application", and "Component" tiers in the design tokens documentation
* Tokens files are alphabetized

Removed
* `--outline-color-error` had duplicates in both high contrast mode media queries, so its value under `forced-colors` was removed
* "Base" and "Application" headings in tokens files were removed in order to lean in on the alphabetical order organization of token groups and promote a cleaner file and less confusion
* Documentation was edited down to not incude any guidance that we don't adhere to
* Remove duplicate interactive border color high contrast mode tokens in `tokens-brand.css` in favor of `tokens-shared.css`
* Remove `--button-border-color-primary` duplicate in `tokens-brand.css`
* Remove duplicate `--button-text-color` in `tokens-shared.css`

Differential Revision: https://phabricator.services.mozilla.com/D202767
13 files changed:
browser/components/reportbrokensite/test/browser/browser_prefers_contrast.js
browser/components/storybook/.storybook/preview.mjs
browser/themes/shared/customizableui/panelUI-shared.css
toolkit/content/widgets/moz-card/moz-card.css
toolkit/content/widgets/moz-message-bar/moz-message-bar.css
toolkit/content/widgets/moz-toggle/moz-toggle.css
toolkit/themes/shared/design-system/README.design-tokens.stories.md
toolkit/themes/shared/design-system/tokens-brand.css
toolkit/themes/shared/design-system/tokens-platform.css
toolkit/themes/shared/design-system/tokens-shared.css
toolkit/themes/shared/global-shared.css
toolkit/themes/shared/in-content/common-shared.css
toolkit/themes/shared/popup.css