Bug 1449132 [wpt PR 10194] - [css-grid] Fix resolution of percentage paddings and...
commit7e289b632b2f899dfe3986042dee524210a1db5c
authorManuel Rego Casasnovas <rego@igalia.com>
Mon, 9 Apr 2018 21:29:17 +0000 (9 21:29 +0000)
committerJames Graham <james@hoppipolla.co.uk>
Sun, 15 Apr 2018 08:24:36 +0000 (15 09:24 +0100)
treeec68e957547061b2823462ed3aa3b78882fee604
parente154a07b55ca1b81b2a36743ec0df41dfe8ea379
Bug 1449132 [wpt PR 10194] - [css-grid] Fix resolution of percentage paddings and margins of grid items, a=testonly

Automatic update from web-platform-tests[css-grid] Fix resolution of percentage paddings and margins of grid items

We were not resolving properly percentage paddings and margins
for tracks that have something like minmax(auto, 100px).
The reason was that while computing the minimum size of a grid item,
the percentages were resolved against the inline size of the grid container.
But for grid items we shouldn't never use the grid container size,
but the grid area size, as that's their containing block.

The patch modifies ContainingBlockLogicalWidthForContent() and
ContainingBlockLogicalHeightForContent() in LayoutBox,
so for grid items we return 0 if the area size hasn't been set yet.
We never want to use the grid container's sizes in these cases.

BUG=808758
TEST=external/wpt/css/css-grid/grid-items/grid-items-percentage-margins-*
TEST=external/wpt/css/css-grid/grid-items/grid-items-percentage-paddings-*

Change-Id: Ib142e51aee1fe623d38688469b179f01f82eb07b
Reviewed-on: https://chromium-review.googlesource.com/980756
Reviewed-by: Javier Fernandez <jfernandez@igalia.com>
Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#547417}

wpt-commits: e4efc10a82630de47f920a737aa8ea94845191af
wpt-pr: 10194
wpt-commits: e4efc10a82630de47f920a737aa8ea94845191af
wpt-pr: 10194
13 files changed:
testing/web-platform/meta/MANIFEST.json
testing/web-platform/tests/css/css-grid/grid-items/grid-items-percentage-margins-001.html [new file with mode: 0644]
testing/web-platform/tests/css/css-grid/grid-items/grid-items-percentage-margins-002.html [new file with mode: 0644]
testing/web-platform/tests/css/css-grid/grid-items/grid-items-percentage-margins-vertical-lr-001.html [new file with mode: 0644]
testing/web-platform/tests/css/css-grid/grid-items/grid-items-percentage-margins-vertical-lr-002.html [new file with mode: 0644]
testing/web-platform/tests/css/css-grid/grid-items/grid-items-percentage-margins-vertical-rl-001.html [new file with mode: 0644]
testing/web-platform/tests/css/css-grid/grid-items/grid-items-percentage-margins-vertical-rl-002.html [new file with mode: 0644]
testing/web-platform/tests/css/css-grid/grid-items/grid-items-percentage-paddings-001.html [new file with mode: 0644]
testing/web-platform/tests/css/css-grid/grid-items/grid-items-percentage-paddings-002.html [new file with mode: 0644]
testing/web-platform/tests/css/css-grid/grid-items/grid-items-percentage-paddings-vertical-lr-001.html [new file with mode: 0644]
testing/web-platform/tests/css/css-grid/grid-items/grid-items-percentage-paddings-vertical-lr-002.html [new file with mode: 0644]
testing/web-platform/tests/css/css-grid/grid-items/grid-items-percentage-paddings-vertical-rl-001.html [new file with mode: 0644]
testing/web-platform/tests/css/css-grid/grid-items/grid-items-percentage-paddings-vertical-rl-002.html [new file with mode: 0644]