| commit | 720a6fa226a7bbd252e813e712b7bbb3deaec98a | |
| author | Jon Coppeard <jcoppeard@mozilla.com> | |
| Sat, 20 May 2023 08:29:48 +0000 (20 08:29 +0000) | ||
| committer | Jon Coppeard <jcoppeard@mozilla.com> | |
| Sat, 20 May 2023 08:29:48 +0000 (20 08:29 +0000) | ||
| tree | 90f4d351444aaa4c2f19f1c9665ae93bac226868 | treesnapshot (tar.gz zip) |
| parent | a700cbb88c16cffab1a34e57eafee2ecd78246ac | commitdiff |
Bug 1833854 - Part 5: Remove range check for JSGC_NURSERY_FREE_THRESHOLD_FOR_IDLE_COLLECTION GC parameter r=sfink
This check is problematic because gcMaxNurseryBytes can be changed afterwards
to make the current value of nurseryFreeThresholdForIdleCollection_ invalid by
this measure. Also, as with nursery size parameters, the caller doesn't
necessarily know what the max nursery size is when setting this parameter.
Invalid values do not change behaviour since belowBytesThreshold will always
come out as true in Nursery::isNearlyFull. Therefore we should just remove
this check.
(And this is all moot anyway because this parameter is never changed anywhere).
Depends on D178528
Differential Revision: https://phabricator.services.mozilla.com/D178529
This check is problematic because gcMaxNurseryBytes can be changed afterwards
to make the current value of nurseryFreeThresholdForIdleCollection_ invalid by
this measure. Also, as with nursery size parameters, the caller doesn't
necessarily know what the max nursery size is when setting this parameter.
Invalid values do not change behaviour since belowBytesThreshold will always
come out as true in Nursery::isNearlyFull. Therefore we should just remove
this check.
(And this is all moot anyway because this parameter is never changed anywhere).
Depends on D178528
Differential Revision: https://phabricator.services.mozilla.com/D178529
| js/src/gc/Scheduling.cpp | diffblobblamehistory |