| commit | 6df2779799224b6cf821bd390a16ce19b66c3662 | |
| author | William Durand <will+git@drnd.me> | |
| Wed, 8 Feb 2023 09:52:44 +0000 (8 09:52 +0000) | ||
| committer | William Durand <will+git@drnd.me> | |
| Wed, 8 Feb 2023 09:52:44 +0000 (8 09:52 +0000) | ||
| tree | e8a3b4689ecd6ba62f5aee876b3686b398ae7212 | treesnapshot (tar.gz zip) |
| parent | 815895b3bd452cdaac3c215c3f6d138471d98a85 | commitdiff |
Bug 1798683 - Fix intermittent browser/components/extensions/test/browser/browser_unified_extensions_overflowable_toolbar.js. r=rpl
This patch attempts to fix intermittent failures by:
1. using `ensureMaximizedWindow()` where appropriate. While nothing
seemed wrong per se with the previous approach, resizing to the
original height was done to restore the previous window dimensions.
Since the window is maximized before, it makes sense to reuse this
helper function, especially given that it is a bit more robust than
just awaiting an event.
2. not awaiting the `resize` event, which does not seem to be fired all
the time when `resizeBy()` is used. It was mostly fine, except when
it wasn't... Since we have a `.waitForCondition()` call right after,
we can probably skip the await of this event.
Differential Revision: https://phabricator.services.mozilla.com/D169088
This patch attempts to fix intermittent failures by:
1. using `ensureMaximizedWindow()` where appropriate. While nothing
seemed wrong per se with the previous approach, resizing to the
original height was done to restore the previous window dimensions.
Since the window is maximized before, it makes sense to reuse this
helper function, especially given that it is a bit more robust than
just awaiting an event.
2. not awaiting the `resize` event, which does not seem to be fired all
the time when `resizeBy()` is used. It was mostly fine, except when
it wasn't... Since we have a `.waitForCondition()` call right after,
we can probably skip the await of this event.
Differential Revision: https://phabricator.services.mozilla.com/D169088