| commit | 6d120d162bf430acb41eee5317eecfe33e19a058 | |
| author | Kelsey Gilbert <kelsey.gilbert@mozilla.com> | |
| Wed, 14 Dec 2022 23:08:41 +0000 (14 23:08 +0000) | ||
| committer | Kelsey Gilbert <kelsey.gilbert@mozilla.com> | |
| Wed, 14 Dec 2022 23:08:41 +0000 (14 23:08 +0000) | ||
| tree | db91b341092455c6ca2437667811ee1d9ef7e8c5 | treesnapshot (tar.gz zip) |
| parent | ffeed88c2a4eae496f13cfa83d56a9ec8e67392b | commitdiff |
Bug 1805626 - Query vert attrib buffer binding directly. r=gfx-reviewers,lsalzman
Previously we were querying the current ARRAY_BUFFER_BINDING, which
would fail if you did:
```
BindBuffer(ARRAY_BUFFER, a)
VertexAttribPointer(...)
BindBuffer(ARRAY_BUFFER, b)
```
We would assume we should call VeretxAttribPointer again with `b` bound,
when we need to bind `a` instead.
Unfortunately, this is hard to test, and we only hit this on drivers
where we don't use VAOs, which are rare now.
Differential Revision: https://phabricator.services.mozilla.com/D164744
Previously we were querying the current ARRAY_BUFFER_BINDING, which
would fail if you did:
```
BindBuffer(ARRAY_BUFFER, a)
VertexAttribPointer(...)
BindBuffer(ARRAY_BUFFER, b)
```
We would assume we should call VeretxAttribPointer again with `b` bound,
when we need to bind `a` instead.
Unfortunately, this is hard to test, and we only hit this on drivers
where we don't use VAOs, which are rare now.
Differential Revision: https://phabricator.services.mozilla.com/D164744
| gfx/gl/GLBlitHelper.cpp | diffblobblamehistory |