| commit | 667c6dc276bed3dbd0619b107536282854c9e677 | |
| author | Marijn Kruisselbrink <mek@chromium.org> | |
| Fri, 2 Apr 2021 22:02:54 +0000 (2 22:02 +0000) | ||
| committer | moz-wptsync-bot <wptsync@mozilla.com> | |
| Wed, 7 Apr 2021 08:58:17 +0000 (7 08:58 +0000) | ||
| tree | c55562e4a7684b57c4c902c05fde468bee55c759 | treesnapshot (tar.gz zip) |
| parent | c12d42a85c8a93c60e11c5f479c8158abeba1c76 | commitdiff |
Bug 1702585 [wpt PR 28338] - WebLocks: Remove invalid DCHECK and add some comments., a=testonly
Automatic update from web-platform-tests
WebLocks: Remove invalid DCHECK and add some comments.
It is possible for a ExecutionContext to be destroyed, and all its locks
to be released while the lock is still being set up. Remove a DCHECK
that tried to verify that this didn't happen. All the relevant code
should work correctly even if Lock::handle_ does become unbound.
If the handle_ gets unbound because the ExecutionContext is destroyed
Lock might not signal LockManager that it is no longer held and thus can
be destroyed, but that is okay, as LockManager itself will clear out all
references to Lock objects when the ExecutionContext is destroyed
anyway.
Bug: 1190515
Change-Id: Idbb6014cbd7f18257fdf3f7a2dffa7f7aeae75c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2783622
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#868622}
--
wpt-commits: 1e1b2dea81629faa338336934336d616df1b8c0b
wpt-pr: 28338
Automatic update from web-platform-tests
WebLocks: Remove invalid DCHECK and add some comments.
It is possible for a ExecutionContext to be destroyed, and all its locks
to be released while the lock is still being set up. Remove a DCHECK
that tried to verify that this didn't happen. All the relevant code
should work correctly even if Lock::handle_ does become unbound.
If the handle_ gets unbound because the ExecutionContext is destroyed
Lock might not signal LockManager that it is no longer held and thus can
be destroyed, but that is okay, as LockManager itself will clear out all
references to Lock objects when the ExecutionContext is destroyed
anyway.
Bug: 1190515
Change-Id: Idbb6014cbd7f18257fdf3f7a2dffa7f7aeae75c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2783622
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#868622}
--
wpt-commits: 1e1b2dea81629faa338336934336d616df1b8c0b
wpt-pr: 28338
| testing/web-platform/tests/web-locks/frames.tentative.https.html | diffblobblamehistory |