| commit | 6448d222da2c9f7cf58881bfeb9caa584bce51e9 | |
| author | Seokho Song <0xdevssh@gmail.com> | |
| Thu, 1 Apr 2021 16:47:56 +0000 (1 16:47 +0000) | ||
| committer | moz-wptsync-bot <wptsync@mozilla.com> | |
| Fri, 2 Apr 2021 09:15:55 +0000 (2 09:15 +0000) | ||
| tree | 9254412a721b097cc4a99a18352aaf5f8a36210d | treesnapshot (tar.gz zip) |
| parent | f5518b7ffec568842fba19911406c0b3b293dfd9 | commitdiff |
Bug 1701554 [wpt PR 28273] - Implement invert and negate exp.node creation and type check in CSSScale, a=testonly
Automatic update from web-platform-tests
Implement invert and negate exp.node creation and type check in CSSScale
For the current implementation, the CSS Typed OM could occur null
pointer access when building CSSMathExpressionNode.
Because in the middle of ToCalcExpressionNode() recursion, nullptr is
accessed instead of propagation.
Also, The CSSScale's constructor didn't check the type properly for
the expression. This possibly might be needed another typed om.
Therefore, implement TODOs for building CSSMathExpressionNode tree
and add condition in IsValidScaleCoord() to check resolved type is
the number for CSSMathExpressionNode tree.
Bug: 1188610
Change-Id: If6bf70b791b72c7ed67465f898130e098f68e853
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2788308
Commit-Queue: Seokho Song <0xdevssh@gmail.com>
Reviewed-by: Mason Freed <masonf@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#868415}
--
wpt-commits: 90166f709d096e77e7cf1279cc3b13a5ddf0cd87
wpt-pr: 28273
Automatic update from web-platform-tests
Implement invert and negate exp.node creation and type check in CSSScale
For the current implementation, the CSS Typed OM could occur null
pointer access when building CSSMathExpressionNode.
Because in the middle of ToCalcExpressionNode() recursion, nullptr is
accessed instead of propagation.
Also, The CSSScale's constructor didn't check the type properly for
the expression. This possibly might be needed another typed om.
Therefore, implement TODOs for building CSSMathExpressionNode tree
and add condition in IsValidScaleCoord() to check resolved type is
the number for CSSMathExpressionNode tree.
Bug: 1188610
Change-Id: If6bf70b791b72c7ed67465f898130e098f68e853
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2788308
Commit-Queue: Seokho Song <0xdevssh@gmail.com>
Reviewed-by: Mason Freed <masonf@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#868415}
--
wpt-commits: 90166f709d096e77e7cf1279cc3b13a5ddf0cd87
wpt-pr: 28273
| testing/web-platform/tests/css/css-typed-om/stylevalue-subclasses/cssScale.tentative.html | diffblobblamehistory |