| commit | 64119a7af7bb9082fefeb8a04242a6377f372012 | |
| author | Cathie Chen <cathiechen@igalia.com> | |
| Mon, 25 Nov 2019 16:23:36 +0000 (25 16:23 +0000) | ||
| committer | moz-wptsync-bot <wptsync@mozilla.com> | |
| Fri, 29 Nov 2019 10:55:27 +0000 (29 10:55 +0000) | ||
| tree | c0f5c908dfc1e99d66c1c1345248f592dcd92500 | treesnapshot (tar.gz zip) |
| parent | 718860fe9559122d6bfea035444f00fb13338d1f | commitdiff |
Bug 1594499 [wpt PR 20132] - Fixed crash issue when list inside a contain element, a=testonly
Automatic update from web-platform-tests
Fixed crash issue when list inside a contain element
ListItem will check the layout tree position of marker if the subtree
of li is changed which sets lifecycle state to kInLayoutSubtreeChange.
Marker might be reattached which will cause relayout. If it's inside
a contain element, it will trigger ScheduleRelayoutOfSubtree which
requires lifecycle state <= kStyleClean. So there's a DCHECK failure.
To fix this, make sure don't change marker layout tree position unless
li is NormalChildNeedsLayout which can stop marker triggering
ScheduleRelayoutOfSubtree. And adding restriction to reattach marker.
Bug: 1004764
Change-Id: Id7c8aedafb2deed21d48f726d54a51f4f346e7b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901011
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713066}
--
wpt-commits: c6b843402f1c2a68aeebe1f153107cb238f355cc
wpt-pr: 20132
Automatic update from web-platform-tests
Fixed crash issue when list inside a contain element
ListItem will check the layout tree position of marker if the subtree
of li is changed which sets lifecycle state to kInLayoutSubtreeChange.
Marker might be reattached which will cause relayout. If it's inside
a contain element, it will trigger ScheduleRelayoutOfSubtree which
requires lifecycle state <= kStyleClean. So there's a DCHECK failure.
To fix this, make sure don't change marker layout tree position unless
li is NormalChildNeedsLayout which can stop marker triggering
ScheduleRelayoutOfSubtree. And adding restriction to reattach marker.
Bug: 1004764
Change-Id: Id7c8aedafb2deed21d48f726d54a51f4f346e7b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901011
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713066}
--
wpt-commits: c6b843402f1c2a68aeebe1f153107cb238f355cc
wpt-pr: 20132
| testing/web-platform/tests/css/css-lists/list-inside-contain.html | [new file with mode: 0644] | blob |