Bug 1771022 [wpt PR 34189] - Properly handle non-current entries with no NavigationAp...
commit5c7d9d6fbdf732e9b792f818b2fea49567655a5f
authorNate Chapin <japhet@chromium.org>
Fri, 27 May 2022 09:34:26 +0000 (27 09:34 +0000)
committermoz-wptsync-bot <wptsync@mozilla.com>
Mon, 30 May 2022 14:45:46 +0000 (30 14:45 +0000)
tree2643a718fb349f45cb054546a123ef68d8f97b0e
parentb328a7939dfadf41e1c1bc473449af8d5936677e
Bug 1771022 [wpt PR 34189] - Properly handle non-current entries with no NavigationApi state, a=testonly

Automatic update from web-platform-tests
Properly handle non-current entries with no NavigationApi state

1. The NavigationApiHistoryEntry mojom struct doesn't allow a
   null string representation of the the state object, which confuses
   deserialization when no state object is set.
2. When the state object is updated, it does not immediately get
   synced to the browser process. This is because it is either set
   shortly after commit for ordering reasons (and so misses the sync
   that happens during commit), or is updated by
   navigation.updateCurrentEntry() (which is not treated as a
   navigation, so there is no commit). This is problematic because
   the navigation api state object can be exposed on other same-origin
   documents, and that state is gathered in the browser process commit
   logic, which is too early for the renderer's "last chance" sync
   during unload. When that happens, the next document's entry for
   for the previous document has an out-of-date state object.
   Introduce a mechanism to force an immediate history sync outside
   of the commit/freeze/unload ones, and use it when navigation api
   state is updated.

Bug: 1326246
Change-Id: Ie62bf0791c0e366258a32a5e62f193d5597de5a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3662189
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1008064}

--

wpt-commits: b28e5b14195e0d1614a4a39eb44407747f8b54d9
wpt-pr: 34189
testing/web-platform/tests/navigation-api/state/cross-document-getState-undefined.html [new file with mode: 0644]
testing/web-platform/tests/navigation-api/state/cross-document-getState.html [new file with mode: 0644]