Bug 1701013 [wpt PR 28244] - Fixing bug with segfaulting TransferFromImageBitmap...
commit5bf54db34c274f5cb3a2d06d1ca9d5e03097c81a
authorJuanmi <juanmihd@chromium.org>
Fri, 2 Apr 2021 21:56:16 +0000 (2 21:56 +0000)
committermoz-wptsync-bot <wptsync@mozilla.com>
Thu, 8 Apr 2021 10:47:20 +0000 (8 10:47 +0000)
tree88203f0533d008262a55ab9732fb861750874d49
parent5d44005f28ce40a2829c90438ef64bd4fb12e17d
Bug 1701013 [wpt PR 28244] - Fixing bug with segfaulting TransferFromImageBitmap(null), a=testonly

Automatic update from web-platform-tests
Fixing bug with segfaulting TransferFromImageBitmap(null)

There was an issue with OffscreenCanvas created from transferring
control from a onscreen canvas, and using a BitmapRenderer context
with the TransferFromImageBitmap(null).

According to the standard TransferFromImageBitmap(null) has to reset the
internal bitmap and create a black transparent one.
https://html.spec.whatwg.org/multipage/canvas.html#the-imagebitmaprenderingcontext-interface

This CL also adds new tests, and fixes some issues with naming in the
tests.

This CL also moves a method that should have been protected and not
public in the first place.

Bug: 1188892
Change-Id: I79f5487c99618fa0bbaf8c436b710766f82ce657
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2785425
Reviewed-by: Juanmi Huertas <juanmihd@chromium.org>
Reviewed-by: Yi Xu <yiyix@chromium.org>
Commit-Queue: Juanmi Huertas <juanmihd@chromium.org>
Auto-Submit: Juanmi Huertas <juanmihd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#867359}

--

wpt-commits: 5dacd60bbfdee3de26860d40ac14c4db74ebb48b
wpt-pr: 28244
testing/web-platform/tests/imagebitmap-renderingcontext/transferFromImageBitmap-ToBlob-offscreen.html [copied from testing/web-platform/tests/imagebitmap-renderingcontext/tranferFromImageBitmap-ToBlob-offscreen.html with 100% similarity]
testing/web-platform/tests/imagebitmap-renderingcontext/transferFromImageBitmap-ToBlob-transferControlToOffscreen.html [moved from testing/web-platform/tests/imagebitmap-renderingcontext/tranferFromImageBitmap-ToBlob-offscreen.html with 85% similarity]
testing/web-platform/tests/imagebitmap-renderingcontext/transferFromImageBitmap-TransferToImageBitmap-offscreen.html [copied from testing/web-platform/tests/imagebitmap-renderingcontext/tranferFromImageBitmap-TransferToImageBitmap-offscreen.html with 100% similarity]
testing/web-platform/tests/imagebitmap-renderingcontext/transferFromImageBitmap-TransferToImageBitmap-transferControlToOffscreen.html [moved from testing/web-platform/tests/imagebitmap-renderingcontext/tranferFromImageBitmap-TransferToImageBitmap-offscreen.html with 81% similarity]
testing/web-platform/tests/imagebitmap-renderingcontext/transferFromImageBitmap-null-offscreen.html [moved from testing/web-platform/tests/imagebitmap-renderingcontext/tranferFromImageBitmap-null-offscreen.html with 100% similarity]
testing/web-platform/tests/imagebitmap-renderingcontext/transferFromImageBitmap-null.html [moved from testing/web-platform/tests/imagebitmap-renderingcontext/tranferFromImageBitmap-null.html with 100% similarity]