| commit | 5b0374554ee393fb08a38efe9c0f15abd42cd843 | |
| author | Karl Tomlinson <karlt+@karlt.net> | |
| Fri, 17 Dec 2021 05:54:27 +0000 (17 05:54 +0000) | ||
| committer | Karl Tomlinson <karlt+@karlt.net> | |
| Fri, 17 Dec 2021 05:54:27 +0000 (17 05:54 +0000) | ||
| tree | a545e0697895519b1987e41f9c9262b486dcc213 | treesnapshot (tar.gz zip) |
| parent | f445b7454a59bc42b2f4f9ebddab4fe97c8d825a | commitdiff |
Bug 1744346 consolidate boolean device enumeration parameters into a flags parameter r=jib
The key motivator here was the misleading aForceNoPermRequest parameter.
This came from an unreviewed change in response to a review request.
https://phabricator.services.mozilla.com/D14575?vs=44463&id=47352#inline-82282
The newer variable name described the opposite of its use, but its usage was
not negated.
The logical change to the AllowPermissionRequest flag no longer passed from
MediaDevices::GetSinkDevice() has little effect because any permission
required would be obtained from getUserMedia() or selectAudioOutput() prior to
setSinkId(). A permission request is not expected during setSinkId().
The EnumerateAudioOutputs flag removes some use of the confusing
MediaSinkEnum::Other and makes the long list of parameters slightly easier to
read.
Differential Revision: https://phabricator.services.mozilla.com/D132875
The key motivator here was the misleading aForceNoPermRequest parameter.
This came from an unreviewed change in response to a review request.
https://phabricator.services.mozilla.com/D14575?vs=44463&id=47352#inline-82282
The newer variable name described the opposite of its use, but its usage was
not negated.
The logical change to the AllowPermissionRequest flag no longer passed from
MediaDevices::GetSinkDevice() has little effect because any permission
required would be obtained from getUserMedia() or selectAudioOutput() prior to
setSinkId(). A permission request is not expected during setSinkId().
The EnumerateAudioOutputs flag removes some use of the confusing
MediaSinkEnum::Other and makes the long list of parameters slightly easier to
read.
Differential Revision: https://phabricator.services.mozilla.com/D132875