| commit | 58db0b45d1b69baac72356dff54ff28c18816419 | |
| author | Rushan Suleymanov <rushans@google.com> | |
| Fri, 18 Mar 2022 10:23:28 +0000 (18 10:23 +0000) | ||
| committer | moz-wptsync-bot <wptsync@mozilla.com> | |
| Mon, 21 Mar 2022 06:50:02 +0000 (21 06:50 +0000) | ||
| tree | 93678bf04761494eb6a00b27802b6d96fdde6a9a | treesnapshot (tar.gz zip) |
| parent | a7a8e3fdb9928fce5916e74c0fa5ac3ba8f326fb | commitdiff |
Bug 1755876 [wpt PR 32869] - Revert "[WPT][Prerender2] Fix restrictions.html timeout", a=testonly
Automatic update from web-platform-tests
Revert "[WPT][Prerender2] Fix restrictions.html timeout"
This reverts commit a5453f64084c40b8cf88cfcc98e7c8ab07b4984f.
Reason for revert: due to failing test virtual/prerender/external/wpt/speculation-rules/prerender/restrictions.https.html on try bots.
Original change's description:
> [WPT][Prerender2] Fix restrictions.html timeout
>
> Before this CL, the test could hang if getCurrentPosition returned error.
> This CL modifies the test to resolve the promise with the stringified
> error to avoid it from hanging.
>
> In addition, this CL also changes Geolocation::PageVisibilityChanged so
> that it would care about invisible->visible cases. Before this CL, the
> code path assumed visible->invisible case, where it only needed to
> shutdown the notifier updates, which didn't require
> UpdateGeolocationConnection calls with actual notifier pointers. This CL
> updates it to loop for all notifiers registered, so that it can setup
> the timers in invisible->visible case.
>
> Bug: 626703
> Change-Id: Ibd8ff599c8e2c51555ae3dbd8a55f4252813c405
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3449477
> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
> Auto-Submit: Kouhei Ueno <kouhei@chromium.org>
> Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#972180}
Bug: 626703, 1298335
Change-Id: I56d006e8524d0a5e1afd25314adb16a9f543bda2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3468382
Owners-Override: Rushan Suleymanov <rushans@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rushan Suleymanov <rushans@google.com>
Cr-Commit-Position: refs/heads/main@{#972381}
--
wpt-commits: eb4b2486a896a0be2a7a2ab494c13902b050d35b
wpt-pr: 32869
Automatic update from web-platform-tests
Revert "[WPT][Prerender2] Fix restrictions.html timeout"
This reverts commit a5453f64084c40b8cf88cfcc98e7c8ab07b4984f.
Reason for revert: due to failing test virtual/prerender/external/wpt/speculation-rules/prerender/restrictions.https.html on try bots.
Original change's description:
> [WPT][Prerender2] Fix restrictions.html timeout
>
> Before this CL, the test could hang if getCurrentPosition returned error.
> This CL modifies the test to resolve the promise with the stringified
> error to avoid it from hanging.
>
> In addition, this CL also changes Geolocation::PageVisibilityChanged so
> that it would care about invisible->visible cases. Before this CL, the
> code path assumed visible->invisible case, where it only needed to
> shutdown the notifier updates, which didn't require
> UpdateGeolocationConnection calls with actual notifier pointers. This CL
> updates it to loop for all notifiers registered, so that it can setup
> the timers in invisible->visible case.
>
> Bug: 626703
> Change-Id: Ibd8ff599c8e2c51555ae3dbd8a55f4252813c405
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3449477
> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
> Auto-Submit: Kouhei Ueno <kouhei@chromium.org>
> Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#972180}
Bug: 626703, 1298335
Change-Id: I56d006e8524d0a5e1afd25314adb16a9f543bda2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3468382
Owners-Override: Rushan Suleymanov <rushans@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rushan Suleymanov <rushans@google.com>
Cr-Commit-Position: refs/heads/main@{#972381}
--
wpt-commits: eb4b2486a896a0be2a7a2ab494c13902b050d35b
wpt-pr: 32869