Bug 1686483 [wpt PR 27153] - [GridNG] Small fix to gap resolution, and abspos contain...
commit3d687466158495595b34ebfc13994994e4068b33
authorIan Kilpatrick <ikilpatrick@chromium.org>
Fri, 15 Jan 2021 22:15:06 +0000 (15 22:15 +0000)
committermoz-wptsync-bot <wptsync@mozilla.com>
Tue, 19 Jan 2021 13:23:03 +0000 (19 13:23 +0000)
treea45780a5ee183cdd388ba040e785d442d59e1fb3
parent9801abf1eeb59874e090a8a536b4bb9ad95837b7
Bug 1686483 [wpt PR 27153] - [GridNG] Small fix to gap resolution, and abspos container., a=testonly

Automatic update from web-platform-tests
[GridNG] Small fix to gap resolution, and abspos container.

Previously we'd just use the intrinsic block-size to resolve gaps, and
abs-pos containing rects when we didn't know the block-size upfront.

This was slightly incorrect as there might be a min/max size constraint
growing or shrinking this final size.

This patch moves the call to ComputeBlockSizeForFragment into
PlaceItems. As a result of this there are a few small fixes:
1) When we have an indefinite available-size, we resolve the grid-gap
   against zero. (This was surprising to me grid-gutters-{010,011} was
   testing this).
2) Abspos "default" size is correctly calculated based on the final
   block-size (not intrinsic block-size).
3) Resolving gaps against the "resolved" available block-size (not the
   intrinsic block-size). This correctly respects border/padding as
   well.

Bug: 1045599
Change-Id: I6be819b8eb254fe9e8eaee4d5a9caaa500a75601
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624032
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#842748}

--

wpt-commits: 7021d50a11fa620c3beac449ef044590d9e0fd1d
wpt-pr: 27153
testing/web-platform/tests/css/css-grid/abspos/positioned-grid-items-018.html [new file with mode: 0644]
testing/web-platform/tests/css/css-grid/alignment/grid-gutters-015-ref.html [new file with mode: 0644]
testing/web-platform/tests/css/css-grid/alignment/grid-gutters-015.html [new file with mode: 0644]
testing/web-platform/tests/css/css-grid/alignment/grid-gutters-016-ref.html [new file with mode: 0644]
testing/web-platform/tests/css/css-grid/alignment/grid-gutters-016.html [new file with mode: 0644]