Bug 1842711 [wpt PR 40960] - Move popover invoker CHECK, a=testonly
commit3d06dce3c9283de168899966597e90a1cbfe11b6
authorJoey Arhar <jarhar@chromium.org>
Thu, 13 Jul 2023 08:09:42 +0000 (13 08:09 +0000)
committermoz-wptsync-bot <wptsync@mozilla.com>
Thu, 20 Jul 2023 10:31:09 +0000 (20 10:31 +0000)
treeb4ba7e7e4b9f01bfa173e03cd045fb3d8ee2a7e9
parent7ca435b2cf610e5d5974f3b0c8312710c6c8d78e
Bug 1842711 [wpt PR 40960] - Move popover invoker CHECK, a=testonly

Automatic update from web-platform-tests
Move popover invoker CHECK

I added this CHECK in http://crrev.com/1166594 but it will get hit when
showPopover is called while the popover is open with an invoker. This
patch moves the CHECK down past the IsPopoverReady check to avoid
getting hit. If the popover is already open, then the IsPopoverReady
check will return before the CHECK is run.

The motivation behind the CHECK is still fine - it ensures that while
the popover is closed, it can't have an invoker set.

Fixed: 1463384
Change-Id: Ie75a1026acefd9ce8018caf96b2bb314a18ac730
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4676654
Commit-Queue: Mason Freed <masonf@chromium.org>
Auto-Submit: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Mason Freed <masonf@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1168432}

--

wpt-commits: 798fe28294ff7b847e62a38c42ea0e4508af44ea
wpt-pr: 40960
testing/web-platform/tests/html/semantics/popovers/invoker-show-crash.html [new file with mode: 0644]