Bug 1882146 [wpt PR 44791] - Revert "[FedCM] Allow button flow to replace widget...
commit0659def0cbcb3330e609990f52ec40541acf8da0
authorStephen McGruer <smcgruer@chromium.org>
Wed, 28 Feb 2024 08:39:59 +0000 (28 08:39 +0000)
committermoz-wptsync-bot <wptsync@mozilla.com>
Fri, 1 Mar 2024 20:10:24 +0000 (1 20:10 +0000)
tree6ee8d3e4a14f674f41bbe40d46cc8d9051915c05
parent2ce0a3e7c36403e6428b1caf78e7cc6e7ec3d90b
Bug 1882146 [wpt PR 44791] - Revert "[FedCM] Allow button flow to replace widget flow", a=testonly

Automatic update from web-platform-tests
Revert "[FedCM] Allow button flow to replace widget flow"

This reverts commit a2783105732c27a57dd0c3e1100730cc4aec32e0.

Reason for revert: Suspected of causing failures on WebKit Linux Leak: https://ci.chromium.org/ui/p/chromium/builders/ci/WebKit%20Linux%20Leak/60801/overview (and other runs since)

Original change's description:
> [FedCM] Allow button flow to replace widget flow
>
> Since button flow implies stronger user login intention of, it should
> take precedence over the widget flow. In particular:
> 1. If there's an in-flight button request, reject any coming widget request
> 2. If there's an in-flight widget request, replace it with the button request
>
> This patch also fixes an issue where we persisted the rp_mode_ after a
> button flow.
>
> Bug: 41483050
> Change-Id: Ic75ba4ab359a9247f4c41b75ad84f7a3cabeb0c9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5321982
> Commit-Queue: Yi Gu <yigu@chromium.org>
> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1265238}

Bug: 41483050
Change-Id: I82728a8ea02194f46eed086015473975a4017dc4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5317868
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1265306}

--

wpt-commits: 4e124bd215d00032c69d87b499d4e04fa97595b3
wpt-pr: 44791
testing/web-platform/tests/credential-management/fedcm-button-mode-basics.https.html