Fix canceling keybinding overriding by discarding the dialog
commitd7750a44796b0ddc1c7a8968fd53aad91382d686
authorColomban Wendling <ban@herbesfolles.org>
Tue, 17 May 2016 00:45:03 +0000 (17 02:45 +0200)
committerColomban Wendling <ban@herbesfolles.org>
Tue, 17 May 2016 00:45:03 +0000 (17 02:45 +0200)
tree0193a00b28609d33fd651d27076550ebba27d57d
parent96818888069f8c5d7a1b5d3e1d3f9a4d73c7ffb7
Fix canceling keybinding overriding by discarding the dialog

Properly handle discarding the dialog asking whether to override a
keybinding as canceling it rather than as allowing multiple identical
keybindings.

In the way, simplify and fix dialogs_show_prompt() not to perform odd
and useless response mapping that effectively go round back, and that
don't handle what the comment above it suggests.  Simply document it
can return GTK_RESPONSE_DELETE_EVENT and handle it in the caller side,
as it's a possibly valuable information.  Only one current caller is
affected, and it doesn't change anything as it doesn't change behavior
but only documents it.

Closes #714.
src/dialogs.c
src/prefs.c