| commit | 293157c7a99880523900e29a1e3191800c2018fe | |
| author | Colomban Wendling <ban@herbesfolles.org> | |
| Sat, 1 Jun 2024 20:25:21 +0000 (1 22:25 +0200) | ||
| committer | Colomban Wendling <ban@herbesfolles.org> | |
| Thu, 13 Jun 2024 10:02:22 +0000 (13 12:02 +0200) | ||
| tree | 45f2a81281037a8c241e34196abcde41c127f13d | treesnapshot (tar.gz zip) |
| parent | de4f029fb23c4058a71db6f05a4c892643a0ec62 | commitdiff |
Fix emission of document-activate signal and associated UI glitches
PR https://github.com/geany/geany/pull/3267 broke handling of several
special tab switch cases:
* By showing the tab's child too early, it prevented the switch-page
handler to properly work in situations where there was only one page,
as the tab switch would happen at page creation yet the document
would not be valid yet.
* It removed explicit emission of the switch-page signal when the
source and target pages are the same after session opening, which
happens if the active session page is the first one.
Fix this by mostly reverting 23367de0c5237558ea63cb8c711d46390d978267
and implementing the delay directly in the switch-page handler.
Fixes #3684.
PR https://github.com/geany/geany/pull/3267 broke handling of several
special tab switch cases:
* By showing the tab's child too early, it prevented the switch-page
handler to properly work in situations where there was only one page,
as the tab switch would happen at page creation yet the document
would not be valid yet.
* It removed explicit emission of the switch-page signal when the
source and target pages are the same after session opening, which
happens if the active session page is the first one.
Fix this by mostly reverting 23367de0c5237558ea63cb8c711d46390d978267
and implementing the delay directly in the switch-page handler.
Fixes #3684.