Split the action "Incite City".
commit7e5db57e84e28d1276fb4ecb7414f95e0b4a31e5
authorsveinung <sveinung@a0f10bec-cc02-0410-94fc-a9cfff90b4cd>
Wed, 17 May 2017 10:45:32 +0000 (17 10:45 +0000)
committersveinung <sveinung@a0f10bec-cc02-0410-94fc-a9cfff90b4cd>
Wed, 17 May 2017 10:45:32 +0000 (17 10:45 +0000)
tree255e6486fb9edb27a8782ff3484388f69d6e7396
parent6ad44b2ca05abbd195300d520d8251013f804c94
Split the action "Incite City".

Stop relying on the Spy unit type flag to decide if the "Incite City" action
consumes the actor unit. Split the new action "Incite City Escape" from
"Incite City". The former will have its actor try to escape. The latter will
always consume the actor unit.

This makes it possible to create a ruleset where all actor units, including
those with the Spy utype flag, are consumed when inciting a foreign city to
revolt and join the actor's side. It makes a ruleset where no actor units,
including those without the Spy utype flag, will try to escape after
inciting a revolt. It also makes more complex rules, like "inciting a revolt
consumes the unit unless the city belongs to a democracy, possible.

See hrm Feature #660927

git-svn-id: svn://svn.gna.org/svn/freeciv/trunk@35621 a0f10bec-cc02-0410-94fc-a9cfff90b4cd
29 files changed:
ai/default/aicity.c
ai/default/aidata.c
ai/default/aidiplomat.c
client/gui-gtk-3.0/action_dialog.c
client/gui-gtk-3.22/action_dialog.c
client/gui-gtk-4.0/action_dialog.c
client/gui-qt/dialogs.cpp
client/gui-qt/menu.cpp
client/gui-sdl2/action_dialog.c
client/helpdata.c
client/packhand.c
common/actions.c
common/actions.h
common/aicore/pf_tools.c
common/unittype.c
data/civ2/game.ruleset
data/civ2civ3/game.ruleset
data/classic/game.ruleset
data/experimental/game.ruleset
data/multiplayer/game.ruleset
data/sandbox/game.ruleset
data/webperimental/game.ruleset
doc/README.actions
fc_version
server/advisors/advdata.c
server/ruleset.c
server/savegame3.c
server/unithand.c
tools/ruleutil/rulesave.c