Ken Smith [Sat, 17 Jul 2010 04:36:40 +0000 (17 04:36 +0000)]
Ready for 8.1-RELEASE builds.
Approved by: re (implicit)
Ken Smith [Sat, 17 Jul 2010 04:35:51 +0000 (17 04:35 +0000)]
Predict the date we'll be ready to announce 8.1-RELEASE. While here
add the entry for 8.0-RELEASE which was added to releng/8.0/UPDATING
during the 8.0-RELEASE cycle but not to stable/8/UPDATING at that time.
Approved by: re (implicit)
Hiroki Sato [Sat, 17 Jul 2010 00:12:41 +0000 (17 00:12 +0000)]
Clean-up old contents and bump version numbers for 8.1R.
Approved by: re (implicitly)
Colin Percival [Tue, 13 Jul 2010 02:45:17 +0000 (13 02:45 +0000)]
Correctly copy the M_RDONLY flag when duplicating a reference
to an mbuf external buffer.
Approved by: so (cperciva)
Approved by: re (kensmith)
Security: FreeBSD-SA-10:07.mbuf
Marius Strobl [Wed, 7 Jul 2010 21:00:17 +0000 (7 21:00 +0000)]
MFC: r209695
- Pin the IPI cache and TLB demap functions in order to prevent migration
between determining the other CPUs and calling cpu_ipi_selected(), which
apart from generally doing the wrong thing can lead to a panic when a
CPU is told to IPI itself (which sun4u doesn't support).
Reported and tested by: Nathaniel W Filardo
- Add __unused where appropriate.
Approved by: re (kib)
Bjoern A. Zeeb [Wed, 7 Jul 2010 17:52:13 +0000 (7 17:52 +0000)]
MFC r207303 (originally by kmacy):
need to initialize the lock before it is used
Reported on: stable@ (MFC missing)
Approved by: re (kensmith)
Ken Smith [Wed, 7 Jul 2010 17:20:16 +0000 (7 17:20 +0000)]
Merge r209770 from stable/8:
> Package set for 8.1-RELEASE. We still have a 2Gb maximum file size
> limit caused by cvsup still being used for some of our mirror system.
> That is being worked on.
Reviewed by: re@, portmgr@
Approved by: re (implicit)
Michael Tuexen [Mon, 5 Jul 2010 18:45:59 +0000 (5 18:45 +0000)]
MFC r209624
* Do not dereference a NULL pointer when calling an SCTP send syscall
not providing a destination address and using ktrace.
* Do not copy out kernel memory when providing sinfo for sctp_recvmsg().
Both bugs where reported by Valentin Nechayev.
The first bug results in a kernel panic.
Approved by: re@
Rui Paulo [Mon, 28 Jun 2010 14:15:54 +0000 (28 14:15 +0000)]
MFC r209541, r209548:
Fix the AR_SREV_MERLIN_20_OR_LATER() check.
Approved by: re (kensmith)
Ken Smith [Sat, 26 Jun 2010 14:55:53 +0000 (26 14:55 +0000)]
Ready to proceed with 8.1-RC2.
Approved by: re (implicit)
Qing Li [Fri, 25 Jun 2010 21:26:34 +0000 (25 21:26 +0000)]
MFC r208553
This patch fixes the problem where proxy ARP entries cannot be added
over the if_ng interface.
Approved by: re (bz)
Pawel Jakub Dawidek [Wed, 23 Jun 2010 23:07:57 +0000 (23 23:07 +0000)]
MFC r209263:
r209175:
Eliminate dead code.
Found by: Coverity Prevent
CID: 5158
r209177:
Remove macros that are not really needed. The idea was to have them in case
we grow more descriptors, but I'll reconsider readding them once we get there.
Passing (a = b) expression to FD_ISSET() is bad idea, as FD_ISSET() evaluates
its argument twice.
Found by: Coverity Prevent
CID: 5243
r209179:
Plug memory leaks.
Found by: Coverity Prevent
CID: 7052, 7053, 7054, 7055
r209180:
Plug memory leak.
Found by: Coverity Prevent
CID: 7051
r209181:
Plug memory leak.
Found by: Coverity Prevent
CID: 7056
r209182:
Plug memory leak.
Found by: Coverity Prevent
CID: 7057
r209183:
Initialize gctl_seq for synchronization requests.
Reported by: hiroshi@soupacific.com
Analysed by: Mikolaj Golub <to.my.trociny@gmail.com>
Tested by: hiroshi@soupacific.com, Mikolaj Golub <to.my.trociny@gmail.com>
r209184:
Fix typos.
r209185:
Correct various log messages.
Submitted by: Mikolaj Golub <to.my.trociny@gmail.com>
Note that without some of these changes hastd won't work on 8.x properly.
Approved by: re (kensmith)
Pawel Jakub Dawidek [Wed, 23 Jun 2010 23:03:25 +0000 (23 23:03 +0000)]
MFC r209262:
r209186:
BIO_DELETE contains range we want to delete and doesn't provide any
useful data, so there is no need to copy it to userland.
r209187:
'unit' can be negative, so use signed type for it.
Found by: Coverity Prevent
CID: 3731
Approved by: re (kensmith)
John Baldwin [Wed, 23 Jun 2010 17:51:11 +0000 (23 17:51 +0000)]
MFC 209213:
When updating individual CPU's lowest Cx state to use, never set it to a
state lower than the lowest one supported by the current CPU. This closes
some races with changes to the hw.acpi.cpu_cx_lowest sysctl while Cx
states for individual CPUs were changing (e.g. unplugging the AC adapter
of a laptop) that could result in panics.
Approved by: re (kib)
Nathan Whitehorn [Wed, 23 Jun 2010 13:47:27 +0000 (23 13:47 +0000)]
MFC r209369:
Temporarily disable instruction relocation while setting up the kernel's
IBAT entry in early boot in order to prevent possible faults from races
between the instruction cache and the MMU.
PR: powerpc/148003
Approved by: re (kib)
Alexander Motin [Wed, 23 Jun 2010 10:06:31 +0000 (23 10:06 +0000)]
MFC r209341:
Report transport type in XPT_PATH_INQ.
Approved by: re (kib)
Alexander Motin [Wed, 23 Jun 2010 10:04:48 +0000 (23 10:04 +0000)]
MFC r209340:
Report transport type in XPT_PATH_INQ.
PR: i386/147929
Approved by: re (kib)
Doug Barton [Wed, 23 Jun 2010 03:56:53 +0000 (23 03:56 +0000)]
MFC 209286:
Add the AAAA address for i.root-servers.net
Approved by: re (kensmith)
Dag-Erling Smørgrav [Tue, 22 Jun 2010 19:56:07 +0000 (22 19:56 +0000)]
merge r196650 from head (via stable/8): tty might be NULL
Approved by: re (kib@)
Michael Tuexen [Tue, 22 Jun 2010 17:45:21 +0000 (22 17:45 +0000)]
MFC 209264
* Fix a bug where the length of the ASCONF-ACK was calculated wrong due
to using an uninitialized variable.
* Fix a bug where a NULL pointer was dereferenced when interfaces
come and go at a high rate.
* Fix a bug where inps where not deregistered from iterators.
* Fix a race condition in freeing an association.
* Fix a refcount problem related to the iterator.
Each of the above bug results in a panic. It shows up when
interfaces come and go at a high rate.
Approved by: re
Marcel Moolenaar [Sat, 19 Jun 2010 05:35:47 +0000 (19 05:35 +0000)]
MFC revs 209026 and 209085:
o Bump MAX_BPAGES from 256 to 1024.
o Synchronize the kernel entry on all CPUs with the use of the ptc.g
instruction on a single CPU by implementing a bare-bones readers-
writer lock.
Approved by: re (kensmith)
Pawel Jakub Dawidek [Fri, 18 Jun 2010 22:06:49 +0000 (18 22:06 +0000)]
MFC r209265:
r209260:
Backout r207970 for now, it can lead to deadlocks.
Reported by: kan
r209261:
Turn off UMA allocations on all archs by default. It isn't stable even
on amd64.
Reported by: many
Approved by: re (kib)
Randi Harper [Fri, 18 Jun 2010 21:10:56 +0000 (18 21:10 +0000)]
MFC r209273:
Fix uninitialized variables that cause a crash when the network is
initialized and sysinstall is not running as init.
Submitted by: Nick Mills
Approved by: cperciva (mentor)
Approved by: re (kensmith)
Marius Strobl [Thu, 17 Jun 2010 20:53:56 +0000 (17 20:53 +0000)]
MFC: r209138
Update a branch missed in r207537 (committed to stable/8 in r207890).
Approved by: re (kib)
Ken Smith [Mon, 14 Jun 2010 02:31:53 +0000 (14 02:31 +0000)]
Ready for 8.1-RC1.
Approved by: re (implicit)
Ken Smith [Mon, 14 Jun 2010 02:30:59 +0000 (14 02:30 +0000)]
Adjust __FreeBSD_version to reflect this is the 8.1 release branch.
Approved by: re (implicit)
Ken Smith [Mon, 14 Jun 2010 02:29:25 +0000 (14 02:29 +0000)]
Adjust cvs branch tag.
Approved by: re (implicit)
Ken Smith [Mon, 14 Jun 2010 02:26:33 +0000 (14 02:26 +0000)]
Adjust the cvs branch for 'make update'.
Approved by: re (implicit)
Xin LI [Sat, 12 Jun 2010 05:22:55 +0000 (12 05:22 +0000)]
MFC r208888,208889,209017:
- make sure that initialize isb with fstat() on
input file before using it. (bin/147275)
- Fix grammar for st_nlink.
- Style changes.
PR: bin/147275
Approved by: re (kensmith)
Xin LI [Sat, 12 Jun 2010 05:21:29 +0000 (12 05:21 +0000)]
MFC r209078:
Detect bit endianness through machine/endian.h.
This fixes xz on big-endian systems.
Tested on: sparc64 (kindly provided by linimon), amd64
Approved by: re (kensmith)
Brian Somers [Sat, 12 Jun 2010 02:00:15 +0000 (12 02:00 +0000)]
MFC r208795; additional date -v detail
PR: 147354
Approved by: re (kib)
Marius Strobl [Sat, 12 Jun 2010 00:28:41 +0000 (12 00:28 +0000)]
MFC: r208778
- Mention that VTOC8 labels are found in Fujitsu SPARC64 machines as well.
- Add information regarding VTOC8 bootrstrap code and how it's handled with
r208777 in place.
- Document the mapping of partition types to VTOC8 tags.
- Add examples for VTOC8 to the respective section.
- Eliminated hard sentence breaks.
Reviewed by: marcel (slightly buggy version)
Approved by: re (bz)
Marius Strobl [Fri, 11 Jun 2010 22:59:47 +0000 (11 22:59 +0000)]
Revert part of r209077 which shouldn't have been MFC'ed, yet.
This is a direct commit to stable/8.
Approved by: re (kib)
Marius Strobl [Fri, 11 Jun 2010 22:25:50 +0000 (11 22:25 +0000)]
MFC: r208777
- In gpart_bootfile_read() fix an off-by-one error preventing the bootstrap
file to be of maximum size.
- Add special handling required for SMI/VTOC8 disklabel partcode, i.e. avoid
overwriting the label when writing the bootstrap code to the partition
starting at 0 and install it to all partitions when the -i option is omitted
just like geom_sunlabel(4) and sunlabel(8) do by default.
- Add missing prototypes.
- Add const where applicable.
Reviewed by: marcel
Approved by: re (kib)
Marius Strobl [Fri, 11 Jun 2010 22:01:58 +0000 (11 22:01 +0000)]
MFC: r208776
Avoid possible NULL-dereferences.
Found with: Coverity Prevent(tm)
CID: 3428
Approved by: re (kib)
Marius Strobl [Fri, 11 Jun 2010 21:54:04 +0000 (11 21:54 +0000)]
MFC: r208746
Don't leak memory on destruction.
Reviewed by: marcel
Approved by: re (kib)
Michael Tuexen [Fri, 11 Jun 2010 20:38:20 +0000 (11 20:38 +0000)]
MFC 209029
3 Fixes -
a) There was a case where a ICMP message could cause
us to return leaving a stuck lock on an stcb.
b) The iterator needed some tweaks to fix its lock
ordering.
c) The ITERATOR_LOCK is no longer needed in the freeing
of a stcb. Now that the timer based one is gone we don't
have a multiple resume situation. Add to that that there
was somewhere a path out of the freeing of an assoc that
did NOT release the iterator_lock.. it was time to clean
this old code up and in the process fix the lock bug.
Approved by: re (bz)
Kenneth D. Merry [Fri, 11 Jun 2010 19:17:36 +0000 (11 19:17 +0000)]
MFC 199549, 199997, 204158, 207673, and 208901.
Bring in a number of netfront changes:
r199549 | jhb
Remove commented out reference to if_watchdog and an assignment of zero to
if_timer.
Reviewed by: scottl
r199997 | gibbs
Add media ioctl support and link notifications so that devd will attempt
to run dhclient on a netfront (xn) device that is setup for DHCP in
/etc/rc.conf.
PR: kern/136251 (fixed differently than the submitted patch)
r204158 | kmacy
- make printf conditional
- fix witness warnings by making configuration lock a mutex
r207673 | joel
Switch to our preferred 2-clause BSD license.
Approved by: kmacy
r208901 | ken
A number of netfront fixes and stability improvements:
- Re-enable TSO. This was broken previously due to CSUM_TSO clearing the
CSUM_TCP flag, so our checksum flags were incorrectly set going to the
netback driver. That was fixed in r206844 in tcp_output.c, so we can
turn TSO back on here.
- Fix the way transmit slots are calculated, so that we can't overfill
the ring.
- Avoid sending packets with more fragments/segments than netback can
handle. The Linux netback code can only handle packets of
MAX_SKB_FRAGS, which turns out to be 18 on machines with 4K pages. We
can easily generate packets with 32 or so fragments with TSO turned on.
Right now the solution is just to drop the packets (since netback
doesn't seem to handle it gracefully), but we should come up with a way
to allow a driver to tell the TCP stack the maximum number of fragments
it can handle in a single packet.
- Fix the way the consumer is tracked in the receive path. It could get
out of sync fairly easily.
- Use standard Xen ring macros to make it clearer how netfront is using
the rings.
- Get rid of Linux-ish negative errno return values.
- Added more documentation to the driver.
- Refactored code to make it easier to read.
- Some other minor fixes.
Reviewed by: gibbs
Sponsored by: Spectra Logic
Approved by: re (bz)
Xin LI [Fri, 11 Jun 2010 17:38:24 +0000 (11 17:38 +0000)]
MFC r205940:
Remove unused files.
PR: bin/38256
Approved by: re (kib)
Ulrich Spörlein [Fri, 11 Jun 2010 15:55:18 +0000 (11 15:55 +0000)]
iMFC r208484: Fix back references in substitute command for pax(1)
pax(1) was trying to copy the back-referenced data from
the match pattern, not the matched data.
Approved by: re (kib)
Edward Tomasz Napierala [Fri, 11 Jun 2010 15:26:15 +0000 (11 15:26 +0000)]
MFC r208811:
Don't use pointer to 64 bit value (id_t) to point to 32 bit value (uid_t).
Found with: Coverity Prevent
CID: 7466, 7467
Approved by: re (kib)
Edward Tomasz Napierala [Fri, 11 Jun 2010 15:21:12 +0000 (11 15:21 +0000)]
Fix usage of uninitialized variable.
Found with: Coverity Prevent
CID: 7517
Approved by: re (kib)
Nathan Whitehorn [Fri, 11 Jun 2010 14:10:20 +0000 (11 14:10 +0000)]
MFC r208162, 208836, 208837:
Program the K2 SATA controller's interrupt to be level-triggered low, and
respect the edge/level settings in the device tree.
OpenPIC on powerpc sets interrupts to be level high by default. On Apple
interrupt controllers, all level interrupts are low regardless of
programming except interrupt 0, used by K2 SATA on some Apple systems, with
the result that the K2 SATA IRQ is misconfigured. Pending review of changes
to this default, work around this by changing the programming of the K2
SATA interrupt to level low.
Approved by: re (kib)
Nathan Whitehorn [Fri, 11 Jun 2010 14:06:35 +0000 (11 14:06 +0000)]
MFC r208870:
Some revisions of the Serverworks K2 SATA controller have a data
corruption bug where if an ATA command is issued before DMA is started,
data will become available to the controller before it knows what to do
with it. This results in either data corruption or a controller crash.
This patch remedies the problem by adopting the workaround employed
by Linux and Darwin: starting the DMA engine prior to sending the ATA
command.
Reviewed by: mav
Approved by: re (kib)
Ulrich Spörlein [Fri, 11 Jun 2010 11:24:23 +0000 (11 11:24 +0000)]
MFC r208592: mail(1) misses addresses when replying to all
There's a parsing error for fields where addresses are not separated by
space. This is often produced by MS Outlook.
PR: bin/131861
Submitted by: Pete French <petefrench at ticketswitch.com>
Tested by: Pete French
Reviewed by: mikeh
Approved by: re (kib)
Randall Stewart [Fri, 11 Jun 2010 03:13:19 +0000 (11 03:13 +0000)]
MFC:
Fix a number of bugs and race conditions.
r208160: Bring back of the iterator thread. It now properly handles VNETS
having only one thread. The old timer based code was full of
LOR's and other issues.
r208852: Cleanup bug. Basically when an un-accepted socket was hanging on a
closed listener, we would leak the inp never cleaning it up
r208853: Enhance the use under invarients of the audit for locks function
and fix a bug where a close collision with a cookie being processed
would cause a crash.
r208854: Use the proper increment macros when working with the
sent_queue_retran_cnt
r208855: Align comments properly, Fix a bug where we were NOT looking at the
resend markings for control chunks and also not decrementing the
retran count which caused extra calls to retransmission. Alos add
a valid no locks call to the output routine.
r208856: Spacing issues in auth/bsd addr.
r208857: Get rid of a windows ifdef that somehow leaked in
r208863: Missing error leg returns in some failure cases
r208864: LOR fix between the iterator and sctp_inpcb_close
r208874: Don't call the sctp_inpcb_free from abort an association since you
don't know what locks you hold and a timer will take care of the
situation when the gone flag is set
r208875: sctp_inpcb_free bug - a socket under the right situation could get
stuck (from the accept queue) and never start the proper cleanup
timer)
r208876: Further enhance invariant lock validation, Fix a bug where a closed
socket and a INIT-ACK could collide and cause a crash
r208878: Clear up another bug in sctp_inpcb_free where we would end up due
to a race in freeing hit a destroy of a contended lock.
r208879: Optimize the cleanup and make some additional fixes in the sysctl
code so that it won't reference a GONE INP and crash us
r208883 & r208891: Fix so we don't open a hole between a sock lock and a call
to socantrcvmore.. we could before hit a race that would kill the
socket underneath us leading to a crash
r208897: CUM-ACK calculation was messed up. So basically large message got
broken from the original NR_sack integration.
r208902: Make sure that we don't move a bit to the NR array that is behind
the cum-ack
r208952: Use both bit maps to calculte the cum-ack.
r208953: Fix bug having to do with freeing an sctp_inpcb_free().
1) make sure not to remove the flag until you get the lock again.
2) make sure all log_closing calls hold the lock.
3) Release all the locks when everthing is done and call callout_drain
not callout_stop..
r208970: Fix some places on user allocation of a new sctp_inpcb where we run
out of resource that we make sure to NULL the so_pcb pointer.
Approved by: re - (bz@freebsd.org)
Rui Paulo [Thu, 10 Jun 2010 20:54:53 +0000 (10 20:54 +0000)]
MFC r208642:
Don't shadow the global variable 'version'.
Submitted by: Arnaud Lacombe <alc@NetBSD.org>
Approved by: re (kensmith)
Rui Paulo [Thu, 10 Jun 2010 20:51:13 +0000 (10 20:51 +0000)]
MFC r204644:
Replace Id keyword with FreeBSD keyword and set the svn props correctly.
No functional change.
Approved by: re (bz)
Rui Paulo [Thu, 10 Jun 2010 20:36:30 +0000 (10 20:36 +0000)]
MFC r208643:
Due to the way HALDEBUG() is defined, we need to add curly brackets
when using it as a sole if clause instruction.
Submitted by: Arnaud Lacombe <alc@NetBSD.org>
Approved by: re (kensmith)
Rui Paulo [Thu, 10 Jun 2010 20:34:22 +0000 (10 20:34 +0000)]
MFC r208644:
Due to the way HALDEBUG() is defined, we need to add curly brackets
when using it as a sole if clause instruction.
While there, fix 'const static' typo.
Submitted by: Arnaud Lacombe <alc@FreeBSD.org>
Approved by: re (kensmith)
Rui Paulo [Thu, 10 Jun 2010 20:28:42 +0000 (10 20:28 +0000)]
MFC r208712:
Rewrite ar9285SetBoardValues() to match what ath9k does and fix out of
bounds reads.
Approved by: re (kensmith)
Rui Paulo [Thu, 10 Jun 2010 20:26:34 +0000 (10 20:26 +0000)]
MFC r208711:
Bring in a couple of fixes from the Linux ath9k related to chip hangs.
While there, try to make the register write pattern look like what's
done by ath9k.
Approved by: re (kensmith)
Rui Paulo [Thu, 10 Jun 2010 20:23:20 +0000 (10 20:23 +0000)]
MFC r208703:
Fix an off by one in ar9285SetPowerCalTable().
Found with: Coverity Prevent(tm)
CID: 3979
Approved by: re (kensmit)
Rui Paulo [Thu, 10 Jun 2010 20:20:46 +0000 (10 20:20 +0000)]
MFC r208699:
Fix resource leaks in ieee80211_ioctl_setchanlist() in case of error.
Found with: Coverity Prevent(tm)
CID: 4115
Approved by: re (kensmith)
John Baldwin [Thu, 10 Jun 2010 20:13:03 +0000 (10 20:13 +0000)]
MFC 208603,208605:
More gracefully handle stale file handles and attributes when opening a
file via NFS. Specifically, to satisfy close-to-open-consistency, the NFS
client always performs at least one RPC on a file during an open(2) to see
if the file has changed. Normally this RPC is an ACCESS or GETATTR RPC
that is forced by flushing a file's attribute cache during nfs_open() and
then requesting new attributes. However, if the file is noticed to be
stale during nfs_open(), the only recourse is to fail the open(2) call
with ESTALE. On the other hand, if the ACCESS or GETATTR RPC is sent
during nfs_lookup(), then the NFS client can fall back to a LOOKUP RPC to
obtain the new file handle in the case that a file has been replaced.
This change causes the NFS client to flush the attribute cache during
nfs_lookup() when validating a name cache hit if the attributes fetched
during nfs_lookup() can be reused in nfs_open(). This allows the client
to open a replaced file via the new file handle the first time that it
notices a replaced file rather than failing with ESTALE in some cases.
Approved by: re (kib)
John Baldwin [Thu, 10 Jun 2010 20:04:44 +0000 (10 20:04 +0000)]
MFC 208912:
Fix a sign bug that caused adaptive spinning in sx_xlock() to not work
properly.
Approved by: re (bz)
John Baldwin [Thu, 10 Jun 2010 20:01:33 +0000 (10 20:01 +0000)]
MFC 208925:
The lock associated with the /dev/apm knote is already held, so use
KNOTE_LOCKED() instead of KNOTE_UNLOCKED().
Approved by: re (kib)
Marcel Moolenaar [Thu, 10 Jun 2010 19:58:54 +0000 (10 19:58 +0000)]
MFC rev 208622:
The EFI system partition used to make the CD image bootable is running
out of space. Bump it up...
Approved by: re (kensmith)
Nathan Whitehorn [Thu, 10 Jun 2010 19:11:00 +0000 (10 19:11 +0000)]
MFC r208835:
Make sure that interrupt sense settings set after interrupts are enabled
are respected. This fixes loading the Apple onboard audio driver
(snd_ai2s) as a module after boot, which would previously cause a panic.
PR: powerpc/146888
Approved by: re (kensmith)
Pyun YongHyeon [Thu, 10 Jun 2010 17:53:35 +0000 (10 17:53 +0000)]
MFC r208862:
Fix a bug introduced in r199011. When bge(4) reuses loaded RX
buffers it should also reinitialize RX descriptors otherwise some
stale data could be passed to controller. This could end up with
mbuf double free or unexpected NULL pointer dereference in upper
stack. To fix the issue, save loaded buffer's length and
reinitialize RX descriptors with the saved value whenever bge(4)
reuses the loaded RX buffers.
While I'm here, increase the number of RX buffers to 512 from 256.
This simplifies RX buffer handling as well as giving more RX
buffers. Controller supports just fixed number of RX buffers
(i.e. 512) and bge(4) used to rely on hope that our CPU is fast
enough to keep up with the controller. With this change, bge(4)
will use 1MB for RX buffers but I don't think it would cause
problems in these days.
Reported by: marcel
Tested by: marcel
Approved by: re (bz)
Attilio Rao [Wed, 9 Jun 2010 14:54:05 +0000 (9 14:54 +0000)]
MFC r208771:
Improve wording and fix style.
Sponsored by: Sandvine Incorporated
Approved by: re (bz)
Ulrich Spörlein [Wed, 9 Jun 2010 14:31:11 +0000 (9 14:31 +0000)]
MFC r208753:
Add required header for isalnum(3) to quench compiler warnings
Forgotten in: r174678
Submitted by: Alexander Best alexbestms at wwu.de
Approved by: das
Approved by: re (kib)
Ulrich Spörlein [Wed, 9 Jun 2010 14:30:21 +0000 (9 14:30 +0000)]
MFC r208074:
fsirand(8): make WARNS=3 clean
- Drop bogus quad_t cast for di_gen, it is a 32bit type
- Print di_gen with leading zeros, to get consistent output
Approved by: re (kib)
Andriy Gapon [Wed, 9 Jun 2010 10:13:59 +0000 (9 10:13 +0000)]
MFC r208671: udf_readlink: fix malloc call with uninitialized size
parameter
Found by: clang static analyzer
Approved by: re(kib)
Andriy Gapon [Wed, 9 Jun 2010 09:44:05 +0000 (9 09:44 +0000)]
MFC r208800: scsi_cd: pass correct pointer to free()
Found with: Coverity Prevent(tm)
CID: 2986
Approved by: re(kib)
Brian Somers [Wed, 9 Jun 2010 07:31:41 +0000 (9 07:31 +0000)]
MFC r197477 - clean up keys deleted via pthread_key_delete()
PR: 135462
Approved by: re (kib)
Nod timeout: davidxu
Pyun YongHyeon [Tue, 8 Jun 2010 19:26:22 +0000 (8 19:26 +0000)]
MFC r208806:
Don't blindly set IFF_DRV_OACTIVE when sge_encap() fails. If there
is no queued frame, IFF_DRV_OACTIVE would never be cleared.
Submitted by: Nikolay Denev < ndenev <> gmail at com >
Approved by: re (bz)
Nathan Whitehorn [Tue, 8 Jun 2010 17:26:18 +0000 (8 17:26 +0000)]
MFC r208168:
It is not necessary (and in some cases harmful) to hardcode ata_kauai's
IRQ to 39 on K2 devices, as well as Shasta ones.
Reported by: Andreas Tobler
Approved by: re (kib)
Alexander Motin [Tue, 8 Jun 2010 10:52:37 +0000 (8 10:52 +0000)]
MFC r208796:
Fix PCH chipset IDs. They are 0x3bxx, not 0x3axx.
Approved by: re (kib)
Alan Cox [Tue, 8 Jun 2010 04:41:31 +0000 (8 04:41 +0000)]
MFC r208765
In the unlikely event that pmap_ts_referenced() demoted five superpage
mappings to the same underlying physical page, the calling thread would
be left forever pinned to the same processor.
Approved by: re (kib)
Andrey V. Elsukov [Mon, 7 Jun 2010 20:31:55 +0000 (7 20:31 +0000)]
MFC r197608:
The first 96 bytes may not be zeroes. It can contain trivial boot
code that merely emits an error and waits for a key press before
rebooting. The error being that extended partitions are not
bootable. The origin is presumed to be Windows 2000; Windows XP
does not do this...
For now, ignore the first 96 bytes when checking that the EBR is
(for the most part) all zeroes.
Tested by: Mario Lobo <mlobo at digiart.art.br>
Dieter <dieterbsd at engineer.com>
PR: kern/141235
Reviewed by: marcel
Approved by: kib (mentor)
Approved by: re (bz)
Matt Jacob [Mon, 7 Jun 2010 16:32:12 +0000 (7 16:32 +0000)]
MFC of 198262
Use callout_init_mtx on FreeBSD versions recent enough. This closes
the race where interrupt thread can complete the request for which
timeout has fired and while mpt_timeout has blocked on mpt_lock.
Approved by: re (kib)
Andriy Gapon [Mon, 7 Jun 2010 13:37:13 +0000 (7 13:37 +0000)]
MFC r208610: boot/zfs: fix gang block reading code
- use correct size (512) while reading a gang block
- skip holes while reading child blocks
- advance buffer pointer while reading child blocks
PR: 144214
Approved by: re(kib)
Andrey V. Elsukov [Mon, 7 Jun 2010 10:22:22 +0000 (7 10:22 +0000)]
MFC r207181:
Re-calculate a geometry when reprobing as well.
PR: kern/145452
Reviewed by: marcel
Approved by: kib (mentor)
Approved by: re (bz)
Martin Matuska [Sun, 6 Jun 2010 13:08:36 +0000 (6 13:08 +0000)]
MFC r208775:
Fix freeing space after deleting large files with holes.
OpenSolaris onnv revision: 9950:
78fc41aa9bc5
Reviewed by: pjd, delphij (mentor)
Obtained from: OpenSolaris (Bug ID
6792701)
Approved by: re (kib)
Rui Paulo [Sat, 5 Jun 2010 20:51:56 +0000 (5 20:51 +0000)]
MFC r208696:
Don't reference null pointer in hwmp_recv_preq().
Found with: Coverity Prevent(tm)
CID: 3912
Approved by: re (bz)
Gavin Atkinson [Sat, 5 Jun 2010 18:30:42 +0000 (5 18:30 +0000)]
Fix typo (COMPAT_FREEBDS32 -> COMPAT_FREEBSD32)
Direct commit to stable/8 as this text isn't in head.
PR: docs/147497
Submitted by: Jack Low <xxjack12xx gmail.com>
Approved by: re (kib)
Konstantin Belousov [Sat, 5 Jun 2010 14:53:34 +0000 (5 14:53 +0000)]
MFC r208731:
Add a facility to dynamically adjust or unconfigure p1003_1b mib.
Use it to allow to tune sem_nsem_max at runtime, only when sem.ko
module is present in kernel.
Approved by: re (bz)
Konstantin Belousov [Fri, 4 Jun 2010 14:06:59 +0000 (4 14:06 +0000)]
MFC r208374:
Remove POLLHUP from the flags used to test for to set exceptfsd
fd_set bits in select(2). It seems that historical behaviour is to not
reporting exception on EOF, and several applications are broken.
Approved by: re (kensmith)
Martin Matuska [Fri, 4 Jun 2010 08:46:26 +0000 (4 08:46 +0000)]
MFC r208689:
Fix ZIL close when doing zfs rollback or zfs receive on a mounted dataset.
The fix is a partial import and merge of OpenSolaris onnv revisions
8227:
f7d7be9b1f56. and 9292:
e112194b5b73
Reviewed by: pjd, delphij (mentor)
Obtained from: OpenSolaris (Bug ID
6798298)
Approved by: re (kib)
Robert Watson [Thu, 3 Jun 2010 09:15:52 +0000 (3 09:15 +0000)]
Merge r205010 from head to stable/8:
Update nfsrv_getsocksndseq() for changes in TCP internals since FreeBSD 6.x:
- so_pcb is now guaranteed to be non-NULL and valid if a valid socket
reference is held.
- Need to check INP_TIMEWAIT and INP_DROPPED before assuming inp_ppcb is a
tcpcb, as it might be a tcptw or NULL otherwise.
- tp can never be NULL by the end of the function, so only check
TCPS_ESTABLISHED before extracting tcpcb fields.
The NFS server arguably incorporates too many assumptions about TCP
internals, but fixing that is left for another day.
Reviewed by: bz
Reviewed and tested by: rmacklem
Sponsored by: Juniper Networks
Approved by: re (kib)
Robert Watson [Thu, 3 Jun 2010 09:06:50 +0000 (3 09:06 +0000)]
Merge r204830 from head to stable/8
Locking the tcbinfo structure should not be necessary in tcp_timer_delack(),
so don't.
Reviewed by: bz
Sponsored by: Juniper Networks
Approved by: re (kib)
Robert Watson [Thu, 3 Jun 2010 09:02:53 +0000 (3 09:02 +0000)]
Merge r204826 from head to stable/8:
Make udp_set_kernel_tunneling() less forgiving when its invariants are
violated: so_pcb can never be NULL for a valid UDP socket, and it is
always SOCK_DGRAM. Use sotoinpcb() as the rest of the UDP code does.
Reviewed by: bz
Sponsored by: Juniper Networks
Approved by: re (kib)
Robert Watson [Thu, 3 Jun 2010 08:55:45 +0000 (3 08:55 +0000)]
Merge r204810 from head to stable/8:
Remove unnecessary locking of divcbinfo lock from div_output(): this has
not been required since FreeBSD 7.0 when the so_pcb pointer leading to inp
was guaranteed to be stable when a valid socket reference is held (as it
is in the output path).
Reviewed by: bz
Sponsored by: Juniper Networks
Approved by: re (kib)
Jung-uk Kim [Wed, 2 Jun 2010 21:00:18 +0000 (2 21:00 +0000)]
MFC: r208650
Fix a regression from r203544 (MFC of r200554), which broke fdc(4)
attachment to acpi(4).
Approved by: re (kib)
Edward Tomasz Napierala [Wed, 2 Jun 2010 20:35:56 +0000 (2 20:35 +0000)]
MFC r208437:
Make acl_get_perm_np(3) work with NFSv4 ACLs.
Reviewed by: kientzle@
Approved by: re (kib)
Gleb Smirnoff [Wed, 2 Jun 2010 18:46:12 +0000 (2 18:46 +0000)]
Merge 208554 from head:
Add uep(4), driver for USB onscreen touch panel from eGalax.
The driver is stub. It just creates device entry and feeds
reassembled packets from hardware into it.
If in future we would port wsmouse(4) from NetBSD, or make
sysmouse(4) to support absolute motion events, then the driver
can be extended to act as system mouse. Meanwhile, it just
presents a /dev/uep0, that can be utilized by X driver, that
I am going to commit to ports tree soon.
The name for the driver is chosen to be the same as in NetBSD,
however, due to different USB stacks this driver isn't a port.
The driver is supported by ports/x11-drivers/xf86-input-egalax.
Approved by: re (kib)
Dag-Erling Smørgrav [Wed, 2 Jun 2010 10:28:26 +0000 (2 10:28 +0000)]
Missing commas in Dd
Approved by: re (kib@)
Dag-Erling Smørgrav [Wed, 2 Jun 2010 10:26:31 +0000 (2 10:26 +0000)]
Fix expansion of AuthorizedKeysFile (upstream patch)
PR: 146334, 145940
Approved by: re (kib@)
Attilio Rao [Tue, 1 Jun 2010 21:19:58 +0000 (1 21:19 +0000)]
MFC r207329, r208716:
- Extract the IODEV_PIO interface from ia64 and make it MI.
- On i386 and amd64 the old behaviour is kept but multithreaded
processes must use the new interface in order to work well.
- Support for the other architectures is greatly improved.
Sponsored by: Sandvine Incorporated
Approved by: re (kib, bz)
John Baldwin [Tue, 1 Jun 2010 19:38:46 +0000 (1 19:38 +0000)]
MFC 208555:
Ignore the 'addr' argument passed to PT_STEP (it is required to be '1'
for PT_STEP which means "ignore") and PT_DETACH.
Approved by: re (kib)
Robert Watson [Tue, 1 Jun 2010 14:29:26 +0000 (1 14:29 +0000)]
Merge r206210 from head to stable/7:
Synchronize Coda kernel module definitions in our coda.h to Coda 6's
coda.h:
- CodaFid typdef -> struct CodaFid throughout.
- Use unsigned int instead of unsigned long for venus_dirent and other
cosmetic fixes.
- Introduce cuid_t and cgid_t and use instead of uid_t and gid_t in RPCs.
- Synchronize comments and macros.
- Use u_int32_t instead of unsigned long for coda_out_hdr.
With these changes, a 64-bit Coda kernel module now works with
coda6_client, whereas previous userspace and kernel versions of RPCs
differed sufficiently to prevent using the file system. This has been
verified only with casual testing, but /coda is now usable for at least
basic operations on amd64.
Approved by: re (kensmith)
Robert Watson [Tue, 1 Jun 2010 14:26:27 +0000 (1 14:26 +0000)]
Merge r206972 from head to stable/8:
Merge @176820, @176822, @177156 to tcpp from P4 to HEAD:
Improve accuracy of connection data transfer math.
Disable Nagle's algorithm to avoid delaying transfers of data --
will want to refine this to combine payload with header transfer,
however.
Now that we're running w/o Nagle, try to send the initial data
burst with the header in a single TCP segment.
Prefer %zu to %ju for size_t.
Sponsored by: Juniper, Inc.
Approved by: re (bz)
Robert Watson [Tue, 1 Jun 2010 14:21:24 +0000 (1 14:21 +0000)]
Merge r204809 from head to stable/8:
Add a comment to tcp_usr_accept() to indicate why it is we acquire the
tcbinfo lock there: r175612, which re-added it, masked a race between
sonewconn(2) and accept(2) that could allow an incompletely initialized
address on a newly-created socket on a listen queue to be exposed. Full
details can be found in that commit message.
Sponsored by: Juniper Networks
Approved by: re (bz)
Robert Watson [Tue, 1 Jun 2010 14:18:44 +0000 (1 14:18 +0000)]
Merge r204806 from head to stable/8:
Wrap use of rw_try_upgrade() on pcbinfo with macro INP_INFO_TRY_UPGRADE()
to match other pcbinfo locking macros.
Approved by: re (bz)
Robert Watson [Tue, 1 Jun 2010 14:09:35 +0000 (1 14:09 +0000)]
Merge r204435 from head to stable/8:
Fix typo in comment.
Approved by: re (bz)
Robert Watson [Tue, 1 Jun 2010 14:04:33 +0000 (1 14:04 +0000)]
Merge r204430 from head to stable/8:
Remove stale comment about socket buffer accounting from access(2) code.
It is the case, however, that the uidinfo of the temporary credential
set up for access(2) is not properly updated when its effective uid is
changed.
Approved by: re (bz)
Robert Watson [Tue, 1 Jun 2010 13:59:48 +0000 (1 13:59 +0000)]
Merge r208601 from head to stable/8:
When close() is called on a connected socket pair, SO_ISCONNECTED might be
set but be cleared before the call to sodisconnect(). In this case,
ENOTCONN is returned: suppress this error rather than returning it to
userspace so that close() doesn't report an error improperly.
PR: kern/144061
Reported by: Matt Reimer <mreimer at vpop.net>,
Nikolay Denev <ndenev at gmail.com>,
Mikolaj Golub <to.my.trociny at gmail.com>
Approved by: re (kib)
Robert Watson [Tue, 1 Jun 2010 13:57:58 +0000 (1 13:57 +0000)]
Merge r206206 from head to stable/8:
Correct definition of CIOC_KERNEL_VERSION Coda ioctl() for systems
where sizeof(int) != sizeof(sizeof(int)), or the ioctl will return
EINVAL.
Approved by: re (kib)
Attilio Rao [Tue, 1 Jun 2010 09:32:22 +0000 (1 09:32 +0000)]
MFC r208300:
Fix a race between ngs_rcvmsg() and soclose() which closes the control
socket while it is still in use as ngs_rcvmsg() runs without any lock
held.
Sponsored by: Sandvine Incorporated
Approved by: re (bz)