| commit | 95fafca26dc317b7ea0667c57576b0b5389f5bef | |
| author | Luis R. Rodriguez <lrodriguez@atheros.com> | |
| Mon, 3 Aug 2009 19:24:54 +0000 (3 12:24 -0700) | ||
| committer | John W. Linville <linville@tuxdriver.com> | |
| Tue, 4 Aug 2009 20:44:33 +0000 (4 16:44 -0400) | ||
| tree | aedd7cec1275411a39a90370a2a10ab98f5446ef | treesnapshot (tar.gz zip) |
| parent | 3ce1b1a949ae849fb73556867e60977a65ca3141 | commitdiff |
ath9k: call ath9k_hw_detach() once upon hw init failure
If hw initialization fails (ath9k_hw_init()) on ath_init_softc()
we bail out and call ath9k_hw_detach(). The call ath9k_hw_detach()
is conditional though as ath9k_hw_init() could itself have called
ath9k_hw_detach(). Just describing this is itself a brain twister.
Avoid this nonsense by removing ath9k_hw_detach() from ath9k_hw_init().
Upon hw initialization failure we expect the callers to take care of
the cleanup.
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
If hw initialization fails (ath9k_hw_init()) on ath_init_softc()
we bail out and call ath9k_hw_detach(). The call ath9k_hw_detach()
is conditional though as ath9k_hw_init() could itself have called
ath9k_hw_detach(). Just describing this is itself a brain twister.
Avoid this nonsense by removing ath9k_hw_detach() from ath9k_hw_init().
Upon hw initialization failure we expect the callers to take care of
the cleanup.
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
| drivers/net/wireless/ath/ath9k/hw.c | diffblobblamehistory | |
| drivers/net/wireless/ath/ath9k/main.c | diffblobblamehistory |