net-2.6 : V2 - fix dev_get_valid_name
commit8ce6cebc2f126f3ecf2d80746ea54245adf18057
authorDaniel Lezcano <daniel.lezcano@free.fr>
Wed, 19 May 2010 10:12:19 +0000 (19 10:12 +0000)
committerDavid S. Miller <davem@davemloft.net>
Mon, 24 May 2010 06:24:36 +0000 (23 23:24 -0700)
tree6efcd84b0a8d00aede2c52944bc8eaecc02e67de
parenta4ed89cb92f93d406ac45fe5507228a2475e32ba
net-2.6 : V2 - fix dev_get_valid_name

the commit:

commit d90310243fd750240755e217c5faa13e24f41536
Author: Octavian Purdila <opurdila@ixiacom.com>
Date:   Wed Nov 18 02:36:59 2009 +0000

    net: device name allocation cleanups

introduced a bug when there is a hash collision making impossible
to rename a device with eth%d. This bug is very hard to reproduce
and appears rarely.

The problem is coming from we don't pass a temporary buffer to
__dev_alloc_name but 'dev->name' which is modified by the function.

A detailed explanation is here:

http://marc.info/?l=linux-netdev&m=127417784011987&w=2

Changelog:
 V2 : replaced strings comparison by pointers comparison

Signed-off-by: Daniel Lezcano <daniel.lezcano@free.fr>
Reviewed-by: Octavian Purdila <opurdila@ixiacom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/dev.c