| commit | 52c5171214ff3327961d0ce0db7e8d2ce55004fd | |
| author | Andrew Morton <akpm@linux-foundation.org> | |
| Tue, 26 Oct 2010 21:21:19 +0000 (26 14:21 -0700) | ||
| committer | Linus Torvalds <torvalds@linux-foundation.org> | |
| Tue, 26 Oct 2010 23:52:04 +0000 (26 16:52 -0700) | ||
| tree | 705e7f51b39f4e8af767cc2a8df19e9e78f15000 | treesnapshot (tar.gz zip) |
| parent | 1b627d5771312c92404b66f0a0b16f66036dd2e1 | commitdiff |
kfifo: disable __kfifo_must_check_helper()
This helper is wrong: it coerces signed values into unsigned ones, so code
such as
if (kfifo_alloc(...) < 0) {
error
}
will fail to detect the error.
So let's disable __kfifo_must_check_helper() for 2.6.36.
Cc: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Stefani Seibold <stefani@seibold.net>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This helper is wrong: it coerces signed values into unsigned ones, so code
such as
if (kfifo_alloc(...) < 0) {
error
}
will fail to detect the error.
So let's disable __kfifo_must_check_helper() for 2.6.36.
Cc: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Stefani Seibold <stefani@seibold.net>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
| include/linux/kfifo.h | diffblobblamehistory |