[IPSEC]: Remove bogus ref count in xfrm_secpath_reject
commit1ecafede835321ebdc396531245adc37d22366f7
authorHerbert Xu <herbert@gondor.apana.org.au>
Tue, 9 Oct 2007 20:24:07 +0000 (9 13:24 -0700)
committerDavid S. Miller <davem@sunset.davemloft.net>
Wed, 10 Oct 2007 23:54:59 +0000 (10 16:54 -0700)
tree230419433b8a08b86abf8998da84652c66c3b20e
parent32f0c4cbe495d121c09ed14d9c84f9e1b9574415
[IPSEC]: Remove bogus ref count in xfrm_secpath_reject

Constructs of the form

xfrm_state_hold(x);
foo(x);
xfrm_state_put(x);

tend to be broken because foo is either synchronous where this is totally
unnecessary or if foo is asynchronous then the reference count is in the
wrong spot.

In the case of xfrm_secpath_reject, the function is synchronous and therefore
we should just kill the reference count.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/xfrm/xfrm_policy.c