From e1a33299cdf281a928b39ed4605f0bd8c0b51491 Mon Sep 17 00:00:00 2001
From: Bas Leijdekkers <basleijdekkers@gmail.com>
Date: Sun, 1 Jun 2008 13:47:47 +0400
Subject: [PATCH] IDEADEV-26972

---
 .../src/com/siyeh/InspectionGadgetsBundle.properties         |  5 ++++-
 .../src/com/siyeh/ig/InspectionGadgetsPlugin.java            |  2 ++
 .../logging/LoggerInitializedWithForeignClassInspection.java | 12 ++++++++----
 .../LoggerInitializedWithForeignClass.html                   |  8 ++++++++
 4 files changed, 22 insertions(+), 5 deletions(-)
 create mode 100644 plugins/InspectionGadgets/src/inspectionDescriptions/LoggerInitializedWithForeignClass.html

diff --git a/plugins/InspectionGadgets/src/com/siyeh/InspectionGadgetsBundle.properties b/plugins/InspectionGadgets/src/com/siyeh/InspectionGadgetsBundle.properties
index 19d94de4c1..605a559465 100644
--- a/plugins/InspectionGadgets/src/com/siyeh/InspectionGadgetsBundle.properties
+++ b/plugins/InspectionGadgets/src/com/siyeh/InspectionGadgetsBundle.properties
@@ -1659,4 +1659,7 @@ change.modifier.quickfix=Make ''{0}''
 the.whole.project=the whole project
 this.class=this class
 assertequals.may.be.assertsame.display.name='assertEquals()' may be 'assertSame()'
-assertequals.may.be.assertsame.problem.descriptor=<code>#ref()</code> may be 'assertSame()'
\ No newline at end of file
+assertequals.may.be.assertsame.problem.descriptor=<code>#ref()</code> may be 'assertSame()'
+logger.initialized.with.foreign.class.quickfix=Replace with '{0}.class'
+logger.initialized.with.foreign.class.problem.descriptor=Logger initializer with foreign class <code>#ref</code>
+logger.initialized.with.foreign.class.display.name=Logger initialized with foreign class
\ No newline at end of file
diff --git a/plugins/InspectionGadgets/src/com/siyeh/ig/InspectionGadgetsPlugin.java b/plugins/InspectionGadgets/src/com/siyeh/ig/InspectionGadgetsPlugin.java
index c04d55679f..ceaab5e943 100644
--- a/plugins/InspectionGadgets/src/com/siyeh/ig/InspectionGadgetsPlugin.java
+++ b/plugins/InspectionGadgets/src/com/siyeh/ig/InspectionGadgetsPlugin.java
@@ -57,6 +57,7 @@ import com.siyeh.ig.junit.*;
 import com.siyeh.ig.logging.ClassWithMultipleLoggersInspection;
 import com.siyeh.ig.logging.ClassWithoutLoggerInspection;
 import com.siyeh.ig.logging.NonStaticFinalLoggerInspection;
+import com.siyeh.ig.logging.LoggerInitializedWithForeignClassInspection;
 import com.siyeh.ig.maturity.*;
 import com.siyeh.ig.memory.StaticCollectionInspection;
 import com.siyeh.ig.memory.StringBufferFieldInspection;
@@ -358,6 +359,7 @@ public class InspectionGadgetsPlugin implements ApplicationComponent,
     private void registerLoggingInspections() {
         m_inspectionClasses.add(ClassWithMultipleLoggersInspection.class);
         m_inspectionClasses.add(ClassWithoutLoggerInspection.class);
+        m_inspectionClasses.add(LoggerInitializedWithForeignClassInspection.class);
         m_inspectionClasses.add(NonStaticFinalLoggerInspection.class);
         //m_inspectionClasses.add(PublicMethodWithoutLoggingInspection.class);
     }
diff --git a/plugins/InspectionGadgets/src/com/siyeh/ig/logging/LoggerInitializedWithForeignClassInspection.java b/plugins/InspectionGadgets/src/com/siyeh/ig/logging/LoggerInitializedWithForeignClassInspection.java
index 64c422c090..22f228ea7a 100644
--- a/plugins/InspectionGadgets/src/com/siyeh/ig/logging/LoggerInitializedWithForeignClassInspection.java
+++ b/plugins/InspectionGadgets/src/com/siyeh/ig/logging/LoggerInitializedWithForeignClassInspection.java
@@ -23,6 +23,7 @@ import com.intellij.util.IncorrectOperationException;
 import com.siyeh.ig.BaseInspection;
 import com.siyeh.ig.BaseInspectionVisitor;
 import com.siyeh.ig.InspectionGadgetsFix;
+import com.siyeh.InspectionGadgetsBundle;
 import org.apache.log4j.Logger;
 import org.jetbrains.annotations.NotNull;
 import org.jetbrains.annotations.Nullable;
@@ -35,13 +36,14 @@ public class LoggerInitializedWithForeignClassInspection
 
     @NotNull
     public String getDisplayName() {
-        return "Logger initialized with foreign class";
-        //return InspectionGadgetsBundle.message("multiple.loggers.display.name");
+        return InspectionGadgetsBundle.message(
+                "logger.initialized.with.foreign.class.display.name");
     }
 
     @NotNull
     protected String buildErrorString(Object... infos) {
-        return "Logger initializer with foreign class <code>#ref</code>";
+        return InspectionGadgetsBundle.message(
+                "logger.initialized.with.foreign.class.problem.descriptor");
     }
 
     @Nullable
@@ -60,7 +62,9 @@ public class LoggerInitializedWithForeignClassInspection
 
         @NotNull
         public String getName() {
-            return "replace with'" + newClassName + ".class'";
+            return InspectionGadgetsBundle.message(
+                    "logger.initialized.with.foreign.class.quickfix",
+                    newClassName);
         }
 
         protected void doFix(Project project, ProblemDescriptor descriptor)
diff --git a/plugins/InspectionGadgets/src/inspectionDescriptions/LoggerInitializedWithForeignClass.html b/plugins/InspectionGadgets/src/inspectionDescriptions/LoggerInitializedWithForeignClass.html
new file mode 100644
index 0000000000..50733640f2
--- /dev/null
+++ b/plugins/InspectionGadgets/src/inspectionDescriptions/LoggerInitializedWithForeignClass.html
@@ -0,0 +1,8 @@
+<html>
+<body><table> <tr> <td valign="top" height="150">
+<font face="verdana" size="-1">
+This inspection reports any Log4j <b><font color="#000080">Logger</font></b>s which are
+initialized with a class literal from a different class than the <b><font color="#000080">Logger</font></b>
+is contained in.
+</font></td> </tr> <tr> <td height="20"> <font face="verdana" size="-2">New in 8, Powered by InspectionGadgets</font> </td> </tr> </table> </body>
+</html>
\ No newline at end of file
-- 
2.11.4.GIT