From 3937fe3564a7a7c77eb07e5770ea4f7e835d98d5 Mon Sep 17 00:00:00 2001 From: Kirill Kalishev Date: Mon, 2 Nov 2009 15:22:28 +0300 Subject: [PATCH] NPE in ToolWindow combo when text may be null --- .../intellij/openapi/wm/impl/content/ContentComboLabel.java | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/platform/platform-impl/src/com/intellij/openapi/wm/impl/content/ContentComboLabel.java b/platform/platform-impl/src/com/intellij/openapi/wm/impl/content/ContentComboLabel.java index 901c6b3b71..ec4366d193 100644 --- a/platform/platform-impl/src/com/intellij/openapi/wm/impl/content/ContentComboLabel.java +++ b/platform/platform-impl/src/com/intellij/openapi/wm/impl/content/ContentComboLabel.java @@ -15,22 +15,14 @@ */ package com.intellij.openapi.wm.impl.content; -import com.intellij.openapi.ui.popup.JBPopupFactory; -import com.intellij.openapi.ui.popup.ListPopup; -import com.intellij.openapi.ui.popup.PopupStep; -import com.intellij.openapi.ui.popup.util.BaseListPopupStep; import com.intellij.ui.content.Content; -import com.intellij.ui.content.ContentManager; import com.intellij.util.ui.UIUtil; -import org.jetbrains.annotations.NotNull; -import javax.swing.*; import javax.swing.border.Border; import javax.swing.border.EmptyBorder; import java.awt.*; import java.awt.event.MouseAdapter; import java.awt.event.MouseEvent; -import java.util.Arrays; public class ContentComboLabel extends BaseLabel { @@ -92,7 +84,8 @@ public class ContentComboLabel extends BaseLabel { int width = 0; for (int i = 0; i < myUi.myManager.getContentCount(); i++) { String text = myUi.myManager.getContent(i).getDisplayName(); - int eachTextWidth = getFontMetrics(getFont()).stringWidth(text); + FontMetrics metrics = getFontMetrics(getFont()); + int eachTextWidth = metrics.stringWidth(text != null ? text : ""); width = Math.max(eachTextWidth, width); } -- 2.11.4.GIT