From c5e9de8b48c0483b53b12cbc16718efd5726afe9 Mon Sep 17 00:00:00 2001 From: Theodore Ts'o Date: Thu, 29 Oct 2015 14:08:12 -0400 Subject: [PATCH] add patch remove-unnecessary-new_valid_dev-check --- remove-unnecessary-new_valid_dev-check | 27 +++++++++++++++++++++++++++ series | 1 + timestamps | 9 +++++---- 3 files changed, 33 insertions(+), 4 deletions(-) create mode 100644 remove-unnecessary-new_valid_dev-check diff --git a/remove-unnecessary-new_valid_dev-check b/remove-unnecessary-new_valid_dev-check new file mode 100644 index 00000000..e83bcb95 --- /dev/null +++ b/remove-unnecessary-new_valid_dev-check @@ -0,0 +1,27 @@ +fs/ext4: remove unnecessary new_valid_dev check + +From: Yaowei Bai + +As new_valid_dev always returns 1, so !new_valid_dev check is not +needed, remove it. + +Signed-off-by: Yaowei Bai +Signed-off-by: Theodore Ts'o +--- + fs/ext4/namei.c | 3 --- + 1 file changed, 3 deletions(-) + +diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c +index 52a79d4..19ce345 100644 +--- a/fs/ext4/namei.c ++++ b/fs/ext4/namei.c +@@ -2468,9 +2468,6 @@ static int ext4_mknod(struct inode *dir, struct dentry *dentry, + struct inode *inode; + int err, credits, retries = 0; + +- if (!new_valid_dev(rdev)) +- return -EINVAL; +- + err = dquot_initialize(dir); + if (err) + return err; diff --git a/series b/series index 064df4b1..6cb9a9de 100644 --- a/series +++ b/series @@ -28,6 +28,7 @@ ensure-entering-into-panic-after-recording-an-error-in-superblock explicit-mount-options-parsing-cleanup do-not-allow-journal_opts-for-fs-wo-journal fix-abs-usage-in-ext4_mb_check_group_pa +remove-unnecessary-new_valid_dev-check ########################################## # unstable patches diff --git a/timestamps b/timestamps index 7e5648a5..c93645c8 100755 --- a/timestamps +++ b/timestamps @@ -58,7 +58,8 @@ touch -d @1445649441 get-rid-of-EXT4_GET_BLOCKS_NO_LOCK-flag touch -d @1445650730 provide-ext4_issue_zeroout touch -d @1445650790 implement-allocation-of-pre-zeroed-blocks touch -d @1445651125 use-pre-zeroed-blocks-for-DAX-page-faults -touch -d @1445651185 stable-boundary -touch -d @1445772103 status -touch -d @1445772143 series -touch -d @1445772153 timestamps +touch -d @1446141485 stable-boundary +touch -d @1446142042 series +touch -d @1446142693 remove-unnecessary-new_valid_dev-check +touch -d @1446142693 status +touch -d @1446142704 timestamps -- 2.11.4.GIT