From 805cf8eee7a18b88c4b23fe61bb19c3155fe3b13 Mon Sep 17 00:00:00 2001 From: Theodore Ts'o Date: Sat, 15 Aug 2015 11:40:10 -0400 Subject: [PATCH] add patch silence-a-format-string-false-positive --- series | 1 + silence-a-format-string-false-positive | 24 ++++++++++++++++++++++++ timestamps | 7 ++++--- 3 files changed, 29 insertions(+), 3 deletions(-) create mode 100644 silence-a-format-string-false-positive diff --git a/series b/series index a204bb10..2575970c 100644 --- a/series +++ b/series @@ -16,6 +16,7 @@ limit-number-of-reserved-credits dont-manipulate-recovery-flag-when-freezing-no-journal-fs ensure-entering-into-panic-after-recording-an-error-in-superblock simplify-some-code-in-read-mmp_block +silence-a-format-string-false-positive ########################################## # unstable patches diff --git a/silence-a-format-string-false-positive b/silence-a-format-string-false-positive new file mode 100644 index 00000000..12b1e7a3 --- /dev/null +++ b/silence-a-format-string-false-positive @@ -0,0 +1,24 @@ +ext4: silence a format string false positive + +From: Dan Carpenter + +Static checkers complain that the format string should be "%s". It does +not make a difference for the current code. + +Signed-off-by: Dan Carpenter +Signed-off-by: Theodore Ts'o + +diff --git a/fs/ext4/mmp.c b/fs/ext4/mmp.c +index 0880ec9..8b72634 100644 +--- a/fs/ext4/mmp.c ++++ b/fs/ext4/mmp.c +@@ -115,7 +115,7 @@ warn_exit: + void __dump_mmp_msg(struct super_block *sb, struct mmp_struct *mmp, + const char *function, unsigned int line, const char *msg) + { +- __ext4_warning(sb, function, line, msg); ++ __ext4_warning(sb, function, line, "%s", msg); + __ext4_warning(sb, function, line, + "MMP failure info: last update time: %llu, last update " + "node: %s, last update device: %s\n", + diff --git a/timestamps b/timestamps index 96e6d2d9..5f436a7f 100755 --- a/timestamps +++ b/timestamps @@ -39,7 +39,8 @@ touch -d @1438701712 limit-number-of-reserved-credits touch -d @1439649906 dont-manipulate-recovery-flag-when-freezing-no-journal-fs touch -d @1439651916 ensure-entering-into-panic-after-recording-an-error-in-superblock touch -d @1439651935 stable-boundary -touch -d @1439652455 series touch -d @1439652631 simplify-some-code-in-read-mmp_block -touch -d @1439652631 status -touch -d @1439652846 timestamps +touch -d @1439653093 silence-a-format-string-false-positive +touch -d @1439653197 series +touch -d @1439653201 status +touch -d @1439653202 timestamps -- 2.11.4.GIT