| commit | c903384a2c470d0a2e137191f124aee61ebe861b | |
| author | Milan Crha <mcrha@redhat.com> | |
| Mon, 9 Apr 2018 14:11:49 +0000 (9 16:11 +0200) | ||
| committer | Milan Crha <mcrha@redhat.com> | |
| Mon, 9 Apr 2018 14:11:49 +0000 (9 16:11 +0200) | ||
| tree | bea05e180734635f5bfd0dbed3228a6aac633931 | treesnapshot (tar.gz zip) |
| parent | 0f8e08ac518351d56be73a47f08af2a40134b3f9 | commitdiff |
[EMailDisplay] Do not call reload when nothing is loaded
It can happen that the EMailDisplay's reload, due to property changes,
is scheduled for idle during the EMailBrowser construction and that
idle callback is called when WebKitGTK+ doesn't have loaded expected
URI in it, only "about:blank". Calling reload in such state can prevent
the real (and possibly ongoing) request to be cancelled, which results
in an empty message preview. Avoiding schedule of such false reload
helps to prevent this situation.
This had been reported downstream at:
https://bugzilla.redhat.com/show_bug.cgi?id=1560312
It can happen that the EMailDisplay's reload, due to property changes,
is scheduled for idle during the EMailBrowser construction and that
idle callback is called when WebKitGTK+ doesn't have loaded expected
URI in it, only "about:blank". Calling reload in such state can prevent
the real (and possibly ongoing) request to be cancelled, which results
in an empty message preview. Avoiding schedule of such false reload
helps to prevent this situation.
This had been reported downstream at:
https://bugzilla.redhat.com/show_bug.cgi?id=1560312
| src/mail/e-mail-display.c | diffblobblamehistory |