1 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
3 * xml.c (parse_region): Make the parsing work for
4 non-comment-starting XML files again (bug#9144).
6 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
8 * image.c (gif_load): Fix calculation of bottom and right corner.
11 2011-09-10 Eli Zaretskii <eliz@gnu.org>
13 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
14 redisplay in small windows.
16 2011-09-09 Eli Zaretskii <eliz@gnu.org>
18 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
20 2011-09-08 Martin Rudalics <rudalics@gmx.at>
22 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
23 Operate on live windows only.
25 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
27 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
29 2011-09-07 Eli Zaretskii <eliz@gnu.org>
31 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
32 only under bidi iteration.
34 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
36 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
38 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
40 isnan: Fix porting problem to Solaris 10 with bundled gcc.
41 Without this fix, the command to link temacs failed due to an
42 undefined symbol __builtin_isnan. This is because
43 /usr/include/iso/math_c99.h #defines isnan(x) to
44 __builtin_isnan(x), but the bundled gcc, which identifies itself
45 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
47 * floatfns.c (isnan): #undef, and then #define to a clone of
49 (Fisnan): Always define, since it's always available now.
50 (syms_of_floatfns): Always define isnan at the Lisp level.
52 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
54 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
56 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
58 * fileio.c: Fix bugs with large file offsets (Bug#9428).
59 The previous code assumed that file offsets (off_t values) fit in
60 EMACS_INT variables, which is not true on typical 32-bit hosts.
61 The code messed up by falsely reporting buffer overflow in cases
62 such as (insert-file-contents "big" nil 1 2) into an empty buffer
63 when "big" contains more than 2**29 bytes, even though this
64 inserts just one byte and does not overflow the buffer.
65 (Finsert_file_contents): Store file offsets as off_t
66 values, not as EMACS_INT values. Check for overflow when
67 converting between EMACS_INT and off_t. When checking for
68 buffer overflow or for overlap, take the offsets into account.
69 Don't use EMACS_INT for small values where int suffices.
70 When checking for overlap, fix a typo: ZV was used where
72 (Fwrite_region): Don't assume off_t fits into 'long'.
73 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
75 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
77 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
79 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
81 sprintf-related integer and memory overflow issues (Bug#9412).
83 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
84 (esprintf, exprintf, evxprintf): New functions.
85 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
86 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
87 (modify_event_symbol): Do not assume that the length of
88 name_alist_or_stem is safe to alloca and fits in int.
89 (Fexecute_extended_command): Likewise for function name and binding.
90 (Frecursion_depth): Wrap around reliably on integer overflow.
91 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
92 since some callers pass EMACS_INT values.
93 (Fsingle_key_description): Don't crash if symbol name contains more
94 than MAX_ALLOCA bytes.
95 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
96 (get_minibuffer): Arg is now EMACS_INT, not int.
97 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
98 (esprintf, exprintf, evxprintf): New decls.
99 * window.h (command_loop_level, minibuf_level): Reflect API changes.
101 * dbusbind.c (signature_cat): New function.
102 (xd_signature, Fdbus_register_signal):
103 Do not overrun buffer; instead, report string overflow.
105 * dispnew.c (add_window_display_history): Don't overrun buffer.
106 Truncate instead; this is OK since it's just a log.
108 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
109 even if the time zone offset is outlandishly large.
110 Don't mishandle offset == INT_MIN.
112 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
113 when creating daemon; the previous buffer-overflow check was incorrect.
115 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
116 which has the guts of the old verror function.
118 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
119 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
121 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
122 (font_unparse_xlfd): Don't blindly alloca long strings.
123 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
124 fits in int, when using sprintf. Use single snprintf to count
125 length of string rather than counting it via multiple sprintfs;
126 that's simpler and more reliable.
127 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
128 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
129 sprintf, in case result does not fit in int.
131 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
132 (fontset_from_font): Print it.
134 * frame.c (tty_frame_count): Now printmax_t, not int.
135 (make_terminal_frame, set_term_frame_name): Print it.
136 (x_report_frame_params): In X, window IDs are unsigned long,
137 not signed long, so print them as unsigned.
138 (validate_x_resource_name): Check for implausibly long names,
139 and don't assume name length fits in 'int'.
140 (x_get_resource_string): Don't blindly alloca invocation name;
141 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
144 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
145 (xg_check_special_colors, xg_set_geometry):
146 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
148 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
149 Use esprintf, not sprintf, in case result does not fit in int.
151 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
152 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
153 it as a large positive number.
154 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
155 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
157 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
158 in case result does not fit in int.
160 * print.c (float_to_string): Detect width overflow more reliably.
161 (print_object): Make sprintf buffer a bit bigger, to avoid potential
162 buffer overrun. Don't assume list length fits in 'int'. Treat
163 print length of 0 as 0, not as infinity; to be consistent with other
164 uses of print length in this function. Don't overflow print length
165 index. Don't assume hash table size fits in 'long', or that
166 vectorlike size fits in 'unsigned long'.
168 * process.c (make_process): Use printmax_t, not int, to format
169 process-name gensyms.
171 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
173 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
174 to avoid potential buffer overrun.
176 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
177 if X resource line is longer than 512 bytes.
179 * xfns.c (x_window): Make sprintf buffer a bit bigger
180 to avoid potential buffer overrun.
182 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
184 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
186 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
188 Integer overflow fixes for scrolling, etc.
189 Without these, Emacs silently mishandles large integers sometimes.
190 For example, "C-u 4294967297 M-x recenter" was treated as if
191 it were "C-u 1 M-x recenter" on a typical 64-bit host.
193 * xdisp.c (try_window_id): Check Emacs fixnum range before
196 * window.c (window_scroll_line_based, Frecenter):
197 Check that an Emacs fixnum is in range before assigning it to 'int'.
198 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
199 values converted from Emacs fixnums.
200 (Frecenter): Don't wrap around a line count if it is out of 'int'
201 range; instead, treat it as an extreme value.
202 (Fset_window_configuration, compare_window_configurations):
203 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
205 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
206 that can exceed INT_MAX. Check that EMACS_INT value is in range
207 before assigning it to the (possibly-narrower) index.
208 (match_limit): Don't assume that a fixnum can fit in 'int'.
210 * print.c (print_object): Use ptrdiff_t, not int, for index that can
213 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
214 (Fvertical_motion): Don't wrap around LINES values that don't fit
215 in 'int'. Instead, treat them as extreme values. This is good
216 enough for windows, which can't have more than INT_MAX lines anyway.
218 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
220 * Require libxml/parser.h to avoid compilation warning.
222 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
224 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
225 since this reportedly can destroy thread storage.
227 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
229 * syntax.c (find_defun_start): Update all cache variables if
230 exiting early (Bug#9401).
232 2011-08-30 Eli Zaretskii <eliz@gnu.org>
234 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
236 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
237 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
238 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
240 * term.c (tty_append_glyph): New function.
241 (produce_stretch_glyph): Static function and its prototype deleted.
243 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
246 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
248 * image.c (parse_image_spec): Check for nonnegative, not for positive,
249 when checking :margin (Bug#9390).
250 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
251 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
252 so that the name doesn't mislead. All uses changed.
254 2011-08-28 Johan Bockgård <bojohan@gnu.org>
256 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
259 2011-08-27 Eli Zaretskii <eliz@gnu.org>
261 * xdisp.c (move_it_to): Don't bail out early when reaching
262 position beyond to_charpos, if we are scanning backwards.
263 (move_it_vertically_backward): When DY == 0, make sure we get to
264 the first character in the line after the newline.
266 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
268 * ccl.c: Improve and simplify overflow checking (Bug#9196).
269 (ccl_driver): Do not generate an out-of-range pointer.
270 (Fccl_execute_on_string): Remove unnecessary check for
271 integer overflow, noted by Stefan Monnier in
272 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
273 Remove a FIXME that didn't need fixing.
274 Simplify the newly-introduced buffer reallocation code.
276 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
278 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
280 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
282 Integer and memory overflow issues (Bug#9196).
284 * doc.c (get_doc_string): Rework so that
285 get_doc_string_buffer_size is the actual buffer size, rather than
286 being 1 less than the actual buffer size; this makes xpalloc more
289 * image.c (x_allocate_bitmap_record, cache_image):
290 * xselect.c (Fx_register_dnd_atom):
291 Simplify previous changes by using xpalloc.
293 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
294 since either will do and ptrdiff_t is convenient with xpalloc.
296 * charset.c (charset_table_size)
297 (struct charset_sort_data.priority): Now ptrdiff_t.
298 (charset_compare): Don't overflow if priorities differ greatly.
299 (Fsort_charsets): Don't assume list length fits in int.
300 Check for size-calculation overflow when allocating sort data.
301 (syms_of_charset): Allocate an initial charset table that is
302 just under 64 KiB, to avoid problems with glibc malloc and mmap.
304 * cmds.c (internal_self_insert): Check for size-calculation overflow.
306 * composite.h (struct composition.glyph_len): Now int, not unsigned.
307 The actual value is always <= INT_MAX, and leaving it unsigned made
308 overflow checking harder.
310 * dispextern.h (struct glyph_matrix.rows_allocated)
311 (struct face_cache.size): Now ptrdiff_t, for convenience in use
312 with xpalloc. The values are still always <= INT_MAX.
314 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
316 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
317 (SAFE_NALLOCA): New macro.
319 * region-cache.c (struct boundary.pos, find_cache_boundary)
320 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
321 (set_cache_region, invalidate_region_cache)
322 (revalidate_region_cache, know_region_cache, region_cache_forward)
323 (region_cache_backward, pp_cache):
324 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
325 so that ptrdiff_t * can be passed to xpalloc.
326 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
327 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
328 (pp_cache): Don't assume cache_len fits in int.
329 * region-cache.h: Adjust extern decls to match.
331 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
332 EMACS_INT, since either will do, for xpalloc.
334 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
335 (xnmalloc, xnrealloc, xpalloc): New functions.
337 * bidi.c (bidi_shelve_header_size): New constant.
338 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
339 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
341 * bidi.c (bidi_cache_shrink):
342 * buffer.c (overlays_at, overlays_in, record_overlay_string)
344 Don't update size of array until after memory allocation succeeds,
345 because xmalloc/xrealloc may not return.
346 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
347 now that we have proper integer overflow checking.
348 (record_overlay_string, overlay_strings): Catch overflows when
349 calculating size of overlay_str_buf.
351 * callproc.c (Fcall_process): Check for size overflow when
352 calculating size of args2.
353 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
354 Normally we prefer signed values, but sticking with ptrdiff_t would
355 require adding more-complicated checks.
357 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
358 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
359 Redo buffer-overflow calculations to avoid integer overflow.
360 Add a FIXME comment where memory seems to be over-allocated.
362 * character.c (Fstring): Check for size-calculation overflow.
364 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
365 unnecessary integer overflow. Check for size overflow.
366 (encode_coding_object): Don't update size until xmalloc succeeds.
368 * composite.c (get_composition_id): Check for overflow in glyph
371 Integer and memory overflow fixes for display code.
372 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
373 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
374 (scrolling_window): Check for overflow in size calculations.
375 (line_draw_cost, realloc_glyph_pool, add_row_entry):
376 Don't assume glyph table len fits in int.
377 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
378 (row_table_size): Now ptrdiff_t, not int.
379 (scrolling_window): Avoid overflow in size calculations.
380 Don't update size until allocation succeeds.
381 * fns.c (concat): Check for overflow in size calculations.
382 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
383 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
384 (NEXT_ALMOST_PRIME_LIMIT): New constant.
386 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
387 (get_doc_string): Check for size calculation overflow.
388 Don't update size until allocation succeeds.
389 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
390 EMACS_INT, where ptrdiff_t will do.
391 (Fsubstitute_command_keys): Check for string overflow.
393 * editfns.c (set_time_zone_rule): Don't assume environment length
395 (message_length): Now ptrdiff_t, not int.
396 (Fmessage_box): Don't update size until allocation succeeds.
397 Don't assume message length fits in int.
398 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
400 * emacs.c (main): Do not reallocate argv, since there is a null at
401 the end that can be overwritten, and this way there's no need to
402 worry about size-calculation overflow.
403 (sort_args): Check for size-calculation overflow.
405 * eval.c (init_eval_once, grow_specpdl): Don't update size until
407 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
409 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
410 (x_set_scroll_bar_width, x_figure_window_size):
411 Check for integer overflow.
412 (x_set_alpha): Do not assume XINT fits in int.
414 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
415 This is for the members text_lines, text_cols, total_lines, total_cols,
416 where the system imposes an 'int' limit.
418 * fringe.c (Fdefine_fringe_bitmap):
419 Don't update size until alloc works.
421 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
422 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
424 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
425 Check for size-calculation overflow.
426 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
427 do, as we prefer signed integers.
428 (id_to_widget.max_size, id_to_widget.used)
429 (xg_store_widget_in_map, xg_remove_widget_from_map)
430 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
431 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
432 Use and return ptrdiff_t, not int.
433 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
434 * gtkutil.h: Change prototypes to match the above.
436 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
437 are duplicate now that they've been promoted to lisp.h.
438 (x_allocate_bitmap_record, x_alloc_image_color)
439 (make_image_cache, cache_image, xpm_load):
440 Don't update size until alloc is done.
441 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
443 Check for size calculation overflow.
444 (ct_colors_allocated_max): New constant.
445 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
448 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
449 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
450 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
451 Use ptrdiff_t, not int, to count maps.
452 (read_char_minibuf_menu_prompt): Check for overflow in size
453 calculations. Don't update size until allocation succeeds. Redo
454 calculations to avoid overflow.
455 * keyboard.h: Change prototypes to match the above.
457 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
459 (current_minor_maps): Check for size calculation overflow.
460 * keymap.h: Change prototypes to match the above.
462 * lread.c (read1, init_obarray): Don't update size until alloc done.
464 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
465 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
467 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
468 Now ptrdiff_t, not int.
469 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
470 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
472 * process.c (Fnetwork_interface_list): Check for overflow
475 * region-cache.c (move_cache_gap): Check for size calculation overflow.
477 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
478 overflow. Don't bother calling xmalloc when xrealloc will do.
480 * search.c (Freplace_match): Check for size calculation overflow.
481 (Fset_match_data): Don't assume list lengths fit in 'int'.
483 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
484 for command line length. Do not attempt to address one before the
485 beginning of an array, as that's not portable.
487 * term.c (max_frame_lines): Remove; unused.
488 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
490 (encode_terminal_code, calculate_costs): Check for size
491 calculation overflow.
492 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
493 table lengths and related sizes. Don't update size until alloc
494 done. Redo calculations to avoid overflow.
495 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
497 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
498 subtracting pointers.
499 (gobble_line): Check for overflow more carefully. Don't update size
502 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
503 Don't update size until alloc done.
504 Redo size calculations to avoid overflow.
505 Check for size calculation overflow.
506 (main) [DEBUG]: Fix typo in invoking tparam1.
508 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
509 Use ptrdiff_t, not int, for sizes.
510 (store_mode_line_noprop_char): Don't update size until alloc done.
512 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
513 Use ptrdiff_t, not int, for sizes.
514 (Finternal_make_lisp_face, cache_face):
515 Check for size calculation overflow.
516 (cache_face): Treat size calculation overflows as if they were
517 memory exhaustion (the usual treatment), rather than aborting.
519 * xfns.c (x_encode_text, x_set_name_internal)
520 (Fx_change_window_property): Use ptrdiff_t, not int, to count
521 sizes, since they can exceed INT_MAX in size. Check for size
522 calculation overflow.
524 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
525 (xg_select): Check for size calculation overflow.
526 Don't update size until alloc done.
528 * xrdb.c (get_environ_db): Don't assume path length fits in int,
529 as sprintf is limited to int lengths.
531 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
532 (X_LONG_MIN): New macros.
533 Use them to make the following changes clearer.
534 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
535 This change doesn't affect the value now, but it may help remind
536 future maintainers not to raise the value too much later.
537 (SELECTION_QUANTUM): Remove, replacing with ...
538 (selection_quantum): ... new function, which avoids overflow.
540 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
541 assumption that selection length fits in 'int'.
542 (x_reply_selection_request, x_handle_selection_request)
543 (x_get_window_property, receive_incremental_selection)
544 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
545 (lisp_data_to_selection_data, clean_local_selection_data):
546 Use ptrdiff_t, not int, to record length of selection.
547 (x_reply_selection_request, x_get_window_property)
548 (receive_incremental_selection, x_property_data_to_lisp):
549 Redo calculations to avoid overflow.
550 (x_reply_selection_request): When sending hint, ceiling it at
551 X_LONG_MAX rather than relying on wraparound overflow to send
553 (x_get_window_property, receive_incremental_selection)
554 (lisp_data_to_selection_data, x_property_data_to_lisp):
555 Check for size-calculation overflow.
556 (x_get_window_property, receive_incremental_selection)
557 (lisp_data_to_selection_data, Fx_register_dnd_atom):
558 Don't store size until memory allocation succeeds.
559 (x_get_window_property): Plug memory leak on memory exhaustion.
560 Don't double-block input; malloc is safe here. Don't assume 2**34
561 - 4 fits in unsigned long. Add an xassert to check
562 XGetWindowProperty overflow. Be more careful about overflow
563 calculations, and distinguish size from memory overflow better.
564 (receive_incremental_selection): When tracing, don't assume
565 unsigned int is less than INT_MAX.
566 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
567 harmful) conversions of unsigned short to int.
568 (lisp_data_to_selection_data): Don't assume that integers
569 in the range -65535 through -1 fit in an X unsigned short.
570 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
571 result parameters unless successful. Rely on cons_to_unsigned
572 to report problems with elements; the old code wasn't right anyway.
573 (x_check_property_data): Check for int overflow; we cannot use
574 a wider type due to X limits.
575 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
577 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
579 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
580 (x_term_init): Check for size calculation overflow.
581 (x_color_cells): Don't store size until memory allocation succeeds.
582 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
583 Don't assume alloca size is less than MAX_ALLOCA.
584 (x_term_init): Don't assume length fits in int (sprintf is limited
587 Use ptrdiff_t for composition IDs.
588 * character.c (lisp_string_width):
589 * composite.c (composition_table_size, n_compositions)
590 (get_composition_id, composition_gstring_from_id):
591 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
592 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
593 * window.c (Frecenter):
594 Use ptrdiff_t, not int, for composition IDs.
595 * composite.c (get_composition_id): Check for integer overflow.
596 * composite.h: Adjust prototypes to match the above changes.
598 Use ptrdiff_t for hash table indexes.
599 * category.c (hash_get_category_set):
600 * ccl.c (ccl_driver):
601 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
602 * coding.c (coding_system_charset_list, detect_coding_system):
603 * coding.h (struct coding_system.id):
604 * composite.c (get_composition_id, gstring_lookup_cache):
605 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
606 * image.c (xpm_get_color_table_h):
607 * lisp.h (hash_lookup, hash_put):
608 * minibuf.c (Ftest_completion):
609 Use ptrdiff_t for hash table indexes, not int (which is too
610 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
611 32-bit --with-wide-int hosts).
613 * charset.c (Fdefine_charset_internal): Check for integer overflow.
614 Add a FIXME comment about memory leaks.
615 (syms_of_charset): Don't assume xmalloc returns.
617 Don't assume that stated character widths fit in int.
618 * character.c (Fchar_width, c_string_width, lisp_string_width):
619 * character.h (CHAR_WIDTH):
620 * indent.c (MULTIBYTE_BYTES_WIDTH):
621 Use sanitize_char_width to avoid undefined and/or bad behavior
622 with outlandish widths.
623 * character.h (sanitize_tab_width): Renamed from sanitize_width,
624 now that we have two such functions. All uses changed.
625 (sanitize_char_width): New inline function.
627 Don't assume that tab-width fits in int.
628 * character.h (sanitize_width): New inline function.
629 (SANE_TAB_WIDTH): New macro.
630 (ASCII_CHAR_WIDTH): Use it.
631 * indent.c (sane_tab_width): Remove. All uses replaced by
632 SANE_TAB_WIDTH (current_buffer).
633 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
635 * fileio.c: Integer overflow issues with file modes.
636 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
638 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
639 Remove unreachable code.
640 (read_hex, load_charset_map_from_file): Check for integer overflow.
642 * xterm.c: don't go over XClientMessageEvent limit
643 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
644 (x_send_scroll_bar_event): Likewise. Check that the size does not
645 exceed limits imposed by XClientMessageEvent, as well as the usual
646 ptrdiff_t and size_t limits.
648 * keyboard.c: Overflow, signedness and related fixes.
649 (make_lispy_movement): Use same integer type in forward decl
650 that is used in the definition.
651 (read_key_sequence, keyremap_step):
652 Change bufsize argument back to int, undoing my 2011-03-30 change.
653 We prefer signed types, and int is wide enough here.
654 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
655 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
656 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
657 length, not size_t. Use ptrdiff_t for index, not int.
658 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
659 possibility of integer overflow.
661 Overflow, signedness and related fixes for images.
663 * dispextern.h (struct it.stack[0].u.image.image_id)
664 (struct_it.image_id, struct image.id, struct image_cache.size)
665 (struct image_cache.used, struct image_cache.ref_count):
666 * gtkutil.c (update_frame_tool_bar):
667 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
668 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
669 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
670 * nsmenu.m (update_frame_tool_bar):
671 * xdisp.c (calc_pixel_width_or_height):
672 * xfns.c (image_cache_refcount):
673 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
674 on typical 64-bit hosts.
676 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
677 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
678 Omit unnecessary casts to int.
679 (parse_image_spec): Check that integers fall into 'int' range
680 when the callers expect that.
681 (image_ascent): Redo ascent calculation to avoid int overflow.
682 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
683 (lookup_image): Remove unnecessary tests.
684 (xbm_image_p): Locals are now of int, not EMACS_INT,
685 since parse_image_check makes sure they fit into int.
686 (png_load, gif_load, svg_load_image):
687 Prefer int to unsigned where either will do.
688 (tiff_handler): New function, combining the cores of the
689 old tiff_error_handler and tiff_warning_handler. This
690 function is rewritten to use vsnprintf and thereby avoid
691 stack buffer overflows. It uses only the features of vsnprintf
692 that are common to both POSIX and native Microsoft.
693 (tiff_error_handler, tiff_warning_handler): Use it.
694 (tiff_load, gif_load, imagemagick_load_image):
695 Don't assume :index value fits in 'int'.
696 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
697 (imagemagick_load_image): Check that crop parameters fit into
698 the integer types that MagickCropImage accepts. Don't assume
699 Vimagemagick_render_type has a nonnegative value. Don't assume
700 size_t fits in 'long'.
701 (gs_load): Use printmax_t to print the widest integers possible.
702 Check for integer overflow when computing image height and width.
704 2011-08-26 Eli Zaretskii <eliz@gnu.org>
706 * xdisp.c (redisplay_window): Don't force window start if point
707 will be invisible in the resulting window. (Bug#9324)
709 2011-08-25 Eli Zaretskii <eliz@gnu.org>
711 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
712 the display spec is of the form `(space ...)'.
713 (handle_display_spec): Return the value returned by
714 handle_single_display_spec, not just 1 or zero.
715 (handle_single_display_spec): If the display spec is of the form
716 `(space ...)', and specifies display in the text area, return 2
718 (try_cursor_movement): Check for the need to scroll more
719 accurately, and prefer exact match for point under bidi. Don't
720 advance `row' beyond the last row of the window.
722 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
723 into disp_prop; all users changed.
725 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
726 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
727 for the text covered by the display property.
729 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
731 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
732 Change return value to nil.
733 (Frecord_buffer): Delete unused function.
735 2011-08-24 Eli Zaretskii <eliz@gnu.org>
737 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
738 buffers, return left-to-right.
739 (set_cursor_from_row): Consider candidate row a win if its glyph
740 represents a newline and point is on that newline. Fixes cursor
741 positioning on the newline at EOL of R2L text within L2R
742 paragraph, and vice versa.
743 (try_cursor_movement): Check continued rows, in addition to
744 continuation rows. Fixes unwarranted scroll when point enters a
745 continued line of R2L text within an L2R paragraph, or vice versa.
746 (cursor_row_p): Consider the case of point being equal to
747 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
748 from the end of a short line to the beginning of a continued line
749 of R2L text within L2R paragraph.
750 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
753 * bidi.c (bidi_check_type): Use xassert.
754 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
757 2011-08-23 Eli Zaretskii <eliz@gnu.org>
759 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
762 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
764 * nsfont.m (ns_otf_to_script): Fix typo.
766 2011-08-22 Kenichi Handa <handa@m17n.org>
768 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
769 extra slot even if the purpose is char-code-property-table.
771 2011-08-23 Eli Zaretskii <eliz@gnu.org>
773 * xdisp.c (redisplay_window): When computing centering_position,
774 account for the height of the header line. (Bug#8874)
776 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
777 instead of CHAR_TO_BYTE. Fixes a crash when a completion
778 candidate is selected by the mouse, and that candidate has a
779 composed character under the mouse.
781 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
782 coordinates reported by pos-visible-in-window-p for a composed
783 character in column zero.
785 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
787 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
789 2011-08-22 Eli Zaretskii <eliz@gnu.org>
791 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
792 consider it a hit if to_charpos is anywhere in the range of the
793 composed buffer positions.
795 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
797 * image.c (gif_load): Don't assume that each subimage has the same
798 dimensions as the base image. Handle disposal method that is
799 "undefined" by the gif spec (Bug#9335).
801 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
803 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
804 (Fcondition_case): Document `debug' symbol in error handler.
806 2011-08-19 Eli Zaretskii <eliz@gnu.org>
808 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
809 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
810 from an Org mode buffer to a Speedbar frame.
812 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
813 a composition, take its buffer position from IT->cmp_it.charpos.
814 Fixes cursor positioning at the beginning of a line that begins
815 with a composed character.
817 2011-08-18 Eli Zaretskii <eliz@gnu.org>
819 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
820 character bidirectional type, use STRONG_L instead. Fixes crashes
821 in a buffer produced by `describe-categories'.
823 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
824 members before the level stack, so they would be saved and
825 restored when copying iterator state. Fixes incorrect reordering
826 around TABs covered by display properties.
828 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
830 * process.c (Fnetwork_interface_list): Correctly determine buffer
833 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
835 * eval.c (internal_condition_case, internal_condition_case_1)
836 (internal_condition_case_2, internal_condition_case_n):
837 Remove unnecessary aborts (Bug#9081).
839 2011-08-17 Eli Zaretskii <eliz@gnu.org>
841 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
842 has no `load' handler, try opening the file locally. (Bug#9311)
844 2011-08-16 Ken Brown <kbrown@cornell.edu>
846 * gmalloc.c: Expand comment.
848 2011-08-16 Eli Zaretskii <eliz@gnu.org>
850 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
851 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
853 2011-08-16 Ken Brown <kbrown@cornell.edu>
855 Fix memory allocation problems in Cygwin build (Bug#9273).
857 * unexcw.c ( __malloc_initialized): Declare external variable.
858 (fixup_executable): Force the dumped emacs to reinitialize malloc.
860 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
862 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
864 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
866 [CYGWIN] (special_realloc): New function.
867 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
868 requests to realloc storage in the static heap.
870 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
872 * bidi.c (bidi_initialize): Remove unused local.
874 2011-08-15 Eli Zaretskii <eliz@gnu.org>
876 * biditype.h: File removed.
878 * bidimirror.h: File removed.
880 * deps.mk (bidi.o): Remove biditype.h and
883 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
886 * dispextern.h: Fix a typo in the comment to bidi_type_t.
888 * chartab.c: Improve commentary for the uniprop_table API.
890 * bidi.c (bidi_paragraph_init): Support zero value of
891 bidi_ignore_explicit_marks_for_paragraph_level.
892 (bidi_initialize): Use uniprop_table instead of including
893 biditype.h and bidimirror.h.
895 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
896 coordinates of the iterator when restoring from ppos_it.
899 2011-08-14 Kenichi Handa <handa@m17n.org>
901 * process.c (create_process): Call setup_process_coding_systems
902 after the pid of the process is set to -1 (Bug#8162).
904 2011-08-14 Eli Zaretskii <eliz@gnu.org>
906 * xdisp.c (move_it_in_display_line_to): Don't invoke
907 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
908 ppos_it. Fixes vertical cursor motion when line beginning is
909 covered by an image. (Bug#9296)
911 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
913 * nsterm.h (ns_run_ascript): Declare.
914 (NSAPP_DATA2_RUNASSCRIPT): Define.
916 * nsfns.m (as_script, as_result, as_status): New static variables.
917 (ns_run_ascript): New function.
918 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
919 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
920 the event loop. Get status from as_status (Bug#7276).
922 * nsterm.m (sendEvent): If event is NSApplicationDefined and
923 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
924 the event loop (Bug#7276).
926 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
928 * gnutls.c (QCgnutls_bootprop_priority)
929 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
930 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
931 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
932 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
933 (QCgnutls_bootprop_verify_hostname_error)
934 (QCgnutls_bootprop_callbacks_verify): Rename from
935 Qgnutls_bootprop_..., all uses changed.
937 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
940 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
942 * xfaces.c (Qframe_set_background_mode): Now static.
943 * dispextern.h (Qframe_set_background_mode): Remove decl.
945 * process.c (Fnetwork_interface_info): Declare local only if needed.
947 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
949 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
950 (Fnetwork_interface_list): Allocate in increments of bytes instead
951 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
952 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
954 (struct ifflag_def): notrailers is smart on OSX.
955 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
956 Get hardware address with getifaddrs if available.
958 2011-08-12 Eli Zaretskii <eliz@gnu.org>
960 * xdisp.c (iterate_out_of_display_property): xassert that
961 IT->position is set to within IT->object's boundaries. Break from
962 the loop as soon as EOB is reached; avoids infloops in redisplay
963 when IT->position is set up wrongly due to some bug.
964 Set IT->current to match the bidi iterator unconditionally.
965 (push_display_prop): Allow GET_FROM_STRING as IT->method on
966 entry. Force push_it to save on the stack the current
967 buffer/string position, to be restored by pop_it. Fix flags in
968 the iterator structure wrt the object coming from a display
969 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
970 properties. (Bug#9284)
972 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
974 * fontset.c (fontset_get_font_group): Add proper type checks.
977 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
979 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
980 and LC_VERSION_MIN_MACOSX.
981 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
982 (dump_it) [LC_FUNCTION_STARTS]: Use it.
984 2011-08-08 Eli Zaretskii <eliz@gnu.org>
986 * xdisp.c (forward_to_next_line_start): Allow to use the
987 no-display-properties-and-no-overlays under bidi display.
988 Set disp_pos in the bidi iterator to avoid searches for display
989 properties and overlays.
991 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
993 * editfns.c (Fset_time_zone_rule): Document relationship with the
996 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
997 the font entity extracted from the cache (Bug#8109).
999 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
1001 * composite.c (autocmp_chars): Don't reset point. That is done by
1002 restore_point_unwind (Bug#5984).
1004 2011-08-07 Juri Linkov <juri@jurta.org>
1006 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1007 to show the arg `TIME' instead of `TIMEVAL'.
1009 2011-08-06 Eli Zaretskii <eliz@gnu.org>
1011 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1012 display property strides EOL and includes a newline, as in
1013 longlines-mode. (Bug#9254)
1014 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1015 word-wrap under bidirectional display. (Bug#9224)
1017 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1018 is non-zero, even if the data buffer is NULL. Fixes a crash in
1019 vertical-motion with longlines-mode. (Bug#9254)
1021 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1023 * bidi.c <bidi_cache_total_alloc>: Now static.
1024 (bidi_initialize): Initialize bidi_cache_total_alloc.
1026 * xdisp.c (display_line): Release buffer allocated for shelved bidi
1029 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1030 amount allocated this far in `bidi_cache_total_alloc'.
1031 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1032 non-zero, only free the data buffer without restoring the cache
1033 contents. All callers changed.
1035 * dispextern.h (bidi_unshelve_cache): Update prototype.
1037 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1038 (move_it_in_display_line, move_it_to)
1039 (move_it_vertically_backward, move_it_by_lines): Replace the call
1040 to xfree to an equivalent call to bidi_unshelve_cache.
1041 (move_it_in_display_line_to): Fix logic of returning
1042 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
1044 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1046 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1047 came from a string character with a `cursor' property. (Bug#9229)
1049 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1051 * Makefile.in (LIB_PTHREAD): New variable.
1052 (LIBES): Add LIB_PTHREAD (Bug#9216).
1054 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1055 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1057 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1059 * regex.c (re_iswctype): Remove some redundant boolean
1062 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1064 * xterm.c (x_find_topmost_parent): New function.
1065 (x_set_frame_alpha): Find topmost parent window with
1066 x_find_topmost_parent and set the property there also (bug#9181).
1067 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1069 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1071 * callproc.c (Fcall_process): Avoid vfork clobbering
1072 the local vars buffer, coding_systems, current_dir.
1074 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1076 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1078 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1080 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1081 so that it is not optimized away.
1083 * xdisp.c (compute_display_string_pos): Remove unused local.
1085 2011-08-02 Eli Zaretskii <eliz@gnu.org>
1087 Fix slow cursor motion and scrolling in large buffers with
1088 selective display, like Org Mode buffers. (Bug#9218)
1090 * dispextern.h (struct bidi_it): New member disp_prop_p.
1092 * xdisp.c: Remove one-slot cache of display string positions.
1093 (compute_display_string_pos): Accept an additional argument
1094 DISP_PROP_P; callers changed. Scan at most 5K characters forward
1095 for a display string or property. If found, set DISP_PROP_P
1098 * bidi.c (bidi_fetch_char): Accept an additional argument
1099 DISP_PROP_P, and pass it to compute_display_string_pos.
1100 Only handle text covered by a display string if DISP_PROP_P is returned
1101 non-zero. All callers of bidi_fetch_char changed.
1103 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1105 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1107 2010-12-03 Don March <don@ohspite.net>
1109 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1110 last character M-[char] is translated to ESC [char] (bug#7541).
1112 2011-08-02 Kenichi Handa <handa@m17n.org>
1114 * lisp.h (uniprop_table): Extern it.
1116 * chartab.c (uniprop_table): Make it non-static.
1118 2011-08-01 Eli Zaretskii <eliz@gnu.org>
1120 * xdisp.c (forward_to_next_line_start): Accept additional argument
1121 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1123 (reseat_at_next_visible_line_start): Use the bidi iterator state
1124 returned by forward_to_next_line_start to restore the state of
1125 it->bidi_it after backing up to previous newline. (Bug#9212)
1127 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1129 * regex.c (re_comp): Protoize.
1130 (re_exec): Fix return type.
1131 (regexec): Fix type of `ret'. (Bug#9203)
1133 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1135 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1136 This is needed if max-image-size is a floating-point number.
1138 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1140 * print.c (print_object): Print empty symbol as ##.
1142 * lread.c (read1): Read ## as empty symbol.
1144 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1146 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1147 setting frame foreground color (Bug#9175).
1148 (x_set_background_color): Likewise.
1150 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1151 contents (Bug#9176).
1152 (EmacsTooltip -init): Remove bezels and add shadows to
1155 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1156 or scroll bar (Bug#8470).
1158 * nsfont.m (nsfont_open): Remove assignment to voffset and
1159 unnecessary vars hshink, expand, hd, full_height, min_height.
1160 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1162 * nsterm.h (nsfont_info): Remove voffset field.
1164 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1166 Implement strike-through and overline on NextStep (Bug#8863).
1168 * nsfont.m (nsfont_open): Use underline position provided by font,
1169 instead of hard-coded value of 2.
1170 (nsfont_draw): Call ns_draw_text_decoration instead.
1172 * nsterm.h: Add declaration for ns_draw_text_decoration.
1174 * nsterm.m (ns_draw_text_decoration): New function for drawing
1175 underline, overline, and strike-through.
1176 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1177 ns_draw_text_decoration. Change treatment of cursor drawing to
1178 accomodate underlining, etc.
1180 2011-07-28 Eli Zaretskii <eliz@gnu.org>
1182 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1185 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1187 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1188 Without this fix, if a signal arrives just after memory fills up,
1189 'malloc' might be invoked reentrantly.
1191 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1192 In other words, assume that every image size is allowed, on non-X
1193 hosts. This assumption is probably wrong, but it lets Emacs compile.
1195 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1197 * regex.c (re_iswctype): Convert return values to boolean.
1199 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1201 * xdisp.c (compute_display_string_pos): Don't use cached display
1202 string position if the buffer had its restriction changed.
1205 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1207 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1209 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1211 Integer signedness and overflow and related fixes. (Bug#9079)
1213 * bidi.c: Integer size and overflow fixes.
1214 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1215 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1216 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1217 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1218 (bidi_find_other_level_edge):
1219 Use ptrdiff_t instead of EMACS_INT where either will do.
1220 This works better on 32-bit hosts configured --with-wide-int.
1221 (bidi_cache_ensure_space): Check for size-calculation overflow.
1222 Use % rather than repeated addition, for better worst-case speed.
1223 Don't set bidi_cache_size until after xrealloc returns, because it
1225 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
1226 (bidi_cache_ensure_space): Also check that the bidi cache size
1227 does not exceed that of the largest Lisp string or buffer. See Eli
1228 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
1230 * alloc.c (__malloc_size_t): Remove.
1231 All uses replaced by size_t. See Andreas Schwab's note
1232 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1234 * image.c: Improve checking for integer overflow.
1235 (check_image_size): Assume that f is nonnull, since
1236 it is always nonnull in practice. This is one less thing to
1237 worry about when checking for integer overflow later.
1238 (x_check_image_size): New function, which checks for integer
1239 overflow issues inside X.
1240 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1241 This removes the need for a memory_full check.
1242 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1243 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1244 (xbm_read_bitmap_data): Change locals back to 'int', since
1245 their values must fit in 'int'.
1246 (xpm_load_image, png_load, tiff_load):
1247 Invoke x_create_x_image_and_pixmap earlier,
1248 to avoid much needless work if the image is too large.
1249 (tiff_load): Treat overly large images as if
1250 x_create_x_image_and_pixmap failed, not as malloc failures.
1251 (gs_load): Use x_check_image_size.
1253 * gtkutil.c: Omit integer casts.
1254 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1255 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1257 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1259 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1260 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1261 would wrongly return t on a 64-bit host.
1263 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1264 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1265 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1266 and therefore cause GCC to emit a bogus diagnostic in some cases.
1268 * image.c: Integer signedness and overflow and related fixes.
1269 This is not an exhaustive set of fixes, but it's time to
1270 record what I've got.
1271 (lookup_pixel_color, check_image_size): Remove redundant decls.
1272 (check_image_size): Don't assume that arbitrary EMACS_INT values
1273 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1274 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1275 (tiff_load, imagemagick_load_image):
1276 Check for overflow in size calculations.
1277 (x_create_x_image_and_pixmap): Remove unnecessary test for
1278 xmalloc returning NULL; that can't happen.
1279 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1280 (xpm_color_bucket): Use better integer hashing function.
1281 (xpm_cache_color): Don't possibly over-allocate memory.
1282 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1283 (gif_memory_source):
1284 Use ptrdiff_t, not int or size_t, to record sizes.
1285 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1286 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1287 either works, as we prefer signed integers.
1288 (tiff_read_from_memory, tiff_write_from_memory):
1289 Return tsize_t, not size_t, since that's what the TIFF API wants.
1290 (tiff_read_from_memory): Don't fail simply because the read would
1291 go past EOF; instead, return a short read.
1292 (tiff_load): Omit no-longer-needed casts.
1293 (Fimagemagick_types): Don't assume size fits into 'int'.
1295 Improve hashing quality when configured --with-wide-int.
1296 * fns.c (hash_string): New function, taken from sxhash_string.
1297 Do not discard information about ASCII character case; this
1298 discarding is no longer needed.
1299 (sxhash-string): Use it. Change sig to match it. Caller changed.
1300 * lisp.h: Declare it.
1301 * lread.c (hash_string): Remove, since we now use fns.c's version.
1302 The fns.c version returns a wider integer if --with-wide-int is
1303 specified, so this should help the quality of the hashing a bit.
1305 * emacs.c: Integer overflow minor fix.
1306 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1307 Define only if GNU_LINUX.
1308 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1310 * dispnew.c: Integer signedness and overflow fixes.
1311 Remove unnecessary forward decls, that were a maintenance hassle.
1312 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1314 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1315 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1316 (prepare_desired_row, line_draw_cost):
1317 Use int, not unsigned, where either works.
1318 (save_current_matrix, restore_current_matrix):
1319 Use ptrdiff_t, not size_t, where either works.
1320 (init_display): Check for overflow more accurately, and without
1321 relying on undefined behavior.
1323 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1324 Remove, replacing with the new symbols in lisp.h. All uses changed.
1325 * fileio.c (make_temp_name):
1326 * filelock.c (lock_file_1, lock_file):
1327 * xdisp.c (message_dolog):
1328 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1329 Use pMd etc. instead.
1330 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1331 replacing the pWIDE etc. symbols removed from editfns.c.
1333 * keyboard.h (num_input_events): Now uintmax_t.
1334 This is (very slightly) less likely to mess up due to wraparound.
1337 * buffer.c: Integer signedness fixes.
1338 (alloc_buffer_text, enlarge_buffer_text):
1339 Use ptrdiff_t rather than size_t when either will do, as we prefer
1342 * alloc.c: Integer signedness and overflow fixes.
1343 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1344 (__malloc_size_t): Default to size_t, not to int.
1345 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1346 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1347 Prefer ptrdiff_t to size_t when either would do, as we prefer
1349 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1350 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1351 Now const. Initialize with values that are in range even if char
1353 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1354 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1355 These functions do the right thing with sizes > 2**32.
1356 (check_depth): Now ptrdiff_t, not int.
1357 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1358 Adjust to new way of storing sizes. Check for size overflow bugs
1360 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1361 slightly wrong anyway, as it missed one instance of
1362 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1363 (refill_memory_reserve): Omit needless cast to size_t.
1364 (mark_object_loop_halt): Mark as externally visible.
1366 * xselect.c: Integer signedness and overflow fixes.
1367 (Fx_register_dnd_atom, x_handle_dnd_message):
1368 Use ptrdiff_t, not size_t, since we prefer signed.
1369 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1370 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1371 x_dnd_atoms_size and x_dnd_atoms_length.
1373 * doprnt.c: Prefer signed to unsigned when either works.
1375 * doprnt.c (doprnt):
1377 * xdisp.c (vmessage):
1378 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1379 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1380 prefer signed arithmetic to avoid comparison confusion.
1381 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1382 but is a bit tricky.
1384 Assume freestanding C89 headers, string.h, stdlib.h.
1385 * data.c, doprnt.c, floatfns.c, print.c:
1386 Include float.h unconditionally.
1387 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1388 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1389 * regex.c: Likewise for stddef.h, string.h.
1390 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1391 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1392 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1393 (STDC_HEADERS): Remove obsolete defines.
1394 * sysdep.c: Include limits.h unconditionally.
1396 Assume support for memcmp, memcpy, memmove, memset.
1397 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1398 * regex.c (memcmp, memcpy):
1399 Remove; we assume C89 now.
1401 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1402 (__malloc_safe_bcopy): Remove; no longer needed.
1404 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
1405 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1406 well either way, and we prefer signed to unsigned.
1408 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1410 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1411 closes the connection while we're reading (bug#9182).
1413 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1415 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1416 are specified (Bug#9168).
1418 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1420 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1421 Found by GCC static checking and --with-wide-int on a 32-bit host.
1423 2011-07-25 Eli Zaretskii <eliz@gnu.org>
1425 * xdisp.c (compute_display_string_pos): Fix logic of caching
1426 previous display string position. Initialize cached_prev_pos to
1427 -1. Fixes slow-down at the beginning of a buffer.
1429 2011-07-24 Eli Zaretskii <eliz@gnu.org>
1431 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1432 for attrs[LFACE_FONTSET_INDEX].
1434 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1436 * xml.c (parse_region): Remove unused local
1437 that was recently introduced.
1439 2011-07-23 Eli Zaretskii <eliz@gnu.org>
1441 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1442 revision 84777 on 2008-02-22.
1444 * xdisp.c (move_it_in_display_line_to): Record the best matching
1445 position for TO_CHARPOS while scanning the line, and restore it on
1446 exit if none of the characters scanned was an exact match.
1447 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
1448 when exact match is impossible due to invisible text, and the
1449 lines are truncated.
1451 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1453 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1456 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1458 Fix a significant slow-down of cursor motion with C-n, C-p,
1459 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1460 auto-repeat under bidi redisplay in fontified buffers.
1461 * xdisp.c (compute_stop_pos_backwards): New function.
1462 (next_element_from_buffer): Call compute_stop_pos_backwards to
1463 find a suitable prev_stop when we find ourselves before
1465 (reseat): Don't look for prev_stop, as that could mean a very long
1467 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1468 <cached_disp_overlay_modiff>: Cache for last found display string
1470 (compute_display_string_pos): Return the cached position if asked
1471 about the same buffer in the same area of character positions, and
1472 the buffer wasn't changed since the time the display string
1473 position was cached.
1475 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1477 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1478 is an integer, which is important for empty lines. (Bug#9149)
1480 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
1482 * frame.c (Fmodify_frame_parameters): In tty case, update the
1483 default face if necessary (Bug#4238).
1485 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
1487 * editfns.c (Fstring_to_char): No need to explain what a character
1488 is in the docstring (Bug#6576).
1490 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1492 * xml.c (parse_region): Make sure we always return a tree.
1494 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1496 * xml.c (parse_region): If a document contains only comments,
1499 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1501 * xml.c (make_dom): Return comments, too.
1503 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1506 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1507 and the surrounding thread.
1508 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1509 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1510 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1512 * s/openbsd.h (BROKEN_SIGIO): Define.
1513 * unexelf.c (unexec) [__OpenBSD__]:
1514 Don't update the .mdebug section of the Alpha COFF symbol table.
1516 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1518 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1521 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1523 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1524 This fixes some race conditions on the permissions of any newly
1527 * alloc.c (valid_pointer_p): Use pipe, not open.
1528 This fixes some permissions issues when debugging.
1530 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1531 If fchown fails to set both uid and gid, try to set just gid,
1532 as that is sometimes allowed. Adjust the file's mode to eliminate
1533 setuid or setgid bits that are inappropriate if fchown fails.
1535 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1537 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1538 to compare Lisp_Objects.
1539 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1540 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1541 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1543 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1545 * lread.c (read_integer): Unread even EOF character.
1546 (read1): Likewise. Properly record start position of symbol.
1548 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1549 symbol character follows.
1551 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1553 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1554 This works around a problem with the previous change to Fcopy_file.
1555 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1556 and without this change, GCC might complain about discarding
1557 fchown's return value.
1559 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
1561 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1563 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1565 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1567 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1569 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1570 it's used from the C level.
1572 * process.c: Use the same condition for POLL_FOR_INPUT in both
1573 keyboard.c and process.c (bug#1858).
1575 2011-07-09 Lawrence Mitchell <wence@gmx.li>
1577 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1578 (Fgnutls_boot): Use it.
1580 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1582 * doc.c (Fsubstitute_command_keys): Revert last change.
1584 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1586 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1587 quotes the next character, and doesn't affect other longer
1588 sequences (bug#8935).
1590 * lread.c (syms_of_lread): Clarify that is isn't only
1591 `eval-buffer' and `eval-defun' that's affected by
1592 `lexical-binding' (bug#8460).
1594 2011-07-15 Eli Zaretskii <eliz@gnu.org>
1596 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1597 bidi redisplay when a line includes both an image and is
1600 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1602 Fix minor problems found by static checking.
1603 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1604 (elsz): Now a signed constant, not a size_t var. We prefer signed
1605 types to unsigned, to avoid integer comparison confusion. Without
1606 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1607 "cannot optimize loop, the loop counter may overflow", a symptom
1609 * indent.c (Fvertical_motion): Mark locals as initialized.
1610 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1612 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1614 * search.c (Fre_search_backward): Mention `case-fold-search' in
1615 all the re_search_* functions (bug#8138).
1617 * keyboard.c (Fopen_dribble_file): Document when the file is
1620 2011-07-14 Eli Zaretskii <eliz@gnu.org>
1622 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1625 Support bidi reordering of display and overlay strings.
1626 * xdisp.c (compute_display_string_pos)
1627 (compute_display_string_end): Accept additional argument STRING.
1628 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1629 (reseat_to_string): Initialize bidi_it->string.s and
1630 bidi_it->string.schars.
1631 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
1632 NULL (avoids a crash in bidi_paragraph_init).
1633 Initialize itb.string.lstring.
1634 (init_iterator): Call bidi_init_it only of a valid
1635 buffer position was specified. Initialize paragraph_embedding to
1637 (reseat_to_string): Initialize the bidi iterator.
1638 (display_string): If we need to ignore text properties of
1639 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1640 original value of -1 will not work with bidi.)
1641 (compute_display_string_pos): First arg is now struct
1642 `text_pos *'; all callers changed. Support display properties on
1644 (compute_display_string_end): Support display properties on Lisp
1646 (init_iterator, reseat_1, reseat_to_string): Initialize the
1647 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1648 when iterating on a string not from display properties).
1649 (compute_display_string_pos, compute_display_string_end):
1650 Fix calculation of the object to scan. Fixes an error when using
1652 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
1653 base_level_stop; instead, set base_level_stop to BEGV.
1654 Fixes crashes in vertical-motion.
1655 (next_element_from_buffer): Improve commentary for when
1656 the iterator is before prev_stop.
1657 (init_iterator): Initialize bidi_p from the default value of
1658 bidi-display-reordering, not from buffer-local value. Use the
1659 buffer-local value only if initializing for buffer iteration.
1660 (handle_invisible_prop): Support invisible properties on strings
1661 that are being bidi-reordered.
1662 (set_iterator_to_next): Support bidi reordering of C strings and
1664 (next_element_from_string): Support bidi reordering of Lisp
1666 (handle_stop_backwards): Support Lisp strings as well.
1667 (display_string): Support display of R2L glyph rows.
1668 Use IT_STRING_CHARPOS when displaying from a Lisp string.
1669 (init_iterator): Don't initialize it->bidi_p for strings
1671 (reseat_to_string): Initialize it->bidi_p for strings here.
1672 (next_element_from_string, next_element_from_c_string)
1673 (next_element_from_buffer): Add xassert's for correspondence
1674 between IT's object being iterated and it->bidi_it.string
1676 (face_before_or_after_it_pos): Support bidi iteration.
1677 (next_element_from_c_string): Handle the case of the first string
1678 character that is not the first one in the visual order.
1679 (get_visually_first_element): New function, refactored from common
1680 parts of next_element_from_buffer, next_element_from_string, and
1681 next_element_from_c_string.
1682 (tool_bar_lines_needed, redisplay_tool_bar)
1683 (display_menu_bar): Force left-to-right direction. Add a FIXME
1684 comment for making that be controlled by a user option.
1685 (push_it, pop_it): Save and restore the state of the
1686 bidi iterator. Save and restore the bidi_p flag.
1687 (pop_it): Iterate out of display property for string iteration as
1689 (iterate_out_of_display_property): Support iteration over strings.
1690 (handle_single_display_spec): Set up it->bidi_it for iteration
1691 over a display string, and call bidi_init_it.
1692 (handle_single_display_spec, next_overlay_string)
1693 (get_overlay_strings_1, push_display_prop): Set up the bidi
1694 iterator for displaying display or overlay strings.
1695 (forward_to_next_line_start): Don't use the shortcut if
1697 (back_to_previous_visible_line_start): If handle_display_prop
1698 pushed the iterator stack, restore the internal state of the bidi
1699 iterator by calling bidi_pop_it same number of times.
1700 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1701 and we are bidi-iterating, don't decrement the iterator position;
1702 instead, set the first_elt flag in the bidi iterator, to produce
1704 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1705 (push_display_prop): xassert that we are iterating a buffer.
1706 (push_it, pop_it): Save and restore paragraph_embedding member.
1707 (handle_single_display_spec, next_overlay_string)
1708 (get_overlay_strings_1, reseat_1, reseat_to_string)
1709 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1710 correctly. Don't assume unibyte strings are not bidi-reordered.
1711 (compute_display_string_pos)
1712 (compute_display_string_end): Fix handling the case of C string.
1713 (push_it, pop_it): Save and restore from_disp_prop_p.
1714 (handle_single_display_spec, push_display_prop): Set the
1715 from_disp_prop_p flag.
1716 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1717 (pop_it): Call iterate_out_of_display_property only if we are
1718 popping after iteration over a string that came from a display
1719 property. Fix a typo in popping stretch info. Add an assertion
1720 for verifying that the iterator position is in sync with the bidi
1722 (handle_single_display_spec, get_overlay_strings_1)
1723 (push_display_prop): Fix initialization of paragraph direction for
1724 string when that of the parent object is not yet determined.
1725 (reseat_1): Call bidi_init_it to resync the bidi
1726 iterator with IT's position. (Bug#7616)
1727 (find_row_edges): If ROW->start.pos gives position
1728 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1729 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1730 Reset the from_disp_prop_p flag.
1731 (SAVE_IT, RESTORE_IT): New macros.
1732 (pos_visible_p, face_before_or_after_it_pos)
1733 (back_to_previous_visible_line_start)
1734 (move_it_in_display_line_to, move_it_in_display_line)
1735 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1736 (try_scrolling, redisplay_window, display_line): Use them when
1737 saving a temporary copy of the iterator and restoring it back.
1738 (back_to_previous_visible_line_start, reseat_1)
1739 (init_iterator): Empty the bidi cache "stack".
1740 (move_it_in_display_line_to): If iterator ended up at
1741 EOL, but we never saw any buffer positions smaller than
1742 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1743 motion in bidi-reordered lines.
1744 (move_it_in_display_line_to): Record prev_method and prev_pos
1745 immediately before the call to set_iterator_to_next. Fixes cursor
1746 motion in bidi-reordered lines with stretch glyphs and strings
1747 displayed in margins. (Bug#8133) (Bug#8867)
1748 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1750 (pos_visible_p): Support positions in bidi-reordered lines.
1751 Save and restore bidi cache.
1753 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1754 (bidi_paragraph_info): Delete unused struct.
1755 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1756 (bidi_cache_start): New variable.
1757 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1759 (bidi_cache_fetch_state, bidi_cache_search)
1760 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1761 (bidi_cache_find, bidi_peek_at_next_level)
1762 (bidi_level_of_next_char, bidi_find_other_level_edge)
1763 (bidi_move_to_visually_next): Compare cache index with
1764 bidi_cache_start rather than with zero.
1765 (bidi_fetch_char): Accept new argument STRING; all callers
1766 changed. Support iteration over a string. Support strings with
1767 display properties. Support unibyte strings. Fix the type of
1768 `len' according to what STRING_CHAR_AND_LENGTH expects.
1769 (bidi_paragraph_init, bidi_resolve_explicit_1)
1770 (bidi_resolve_explicit, bidi_resolve_weak)
1771 (bidi_level_of_next_char, bidi_move_to_visually_next):
1772 Support iteration over a string.
1773 (bidi_set_sor_type, bidi_resolve_explicit_1)
1774 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1775 can now be zero (for strings); special values 0 and -1 were
1776 changed to -1 and -2, respectively.
1777 (bidi_char_at_pos): New function.
1778 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1779 Call it instead of FETCH_MULTIBYTE_CHAR.
1780 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1781 initialized to valid values.
1782 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1784 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1785 the test for valid cached positions. Fix the logic for looking up
1786 the sentinel state in the cache. GCPRO the Lisp string we are
1788 (bidi_push_it, bidi_pop_it): New functions.
1789 (bidi_initialize): Initialize the bidi cache start stack pointer.
1790 (bidi_cache_ensure_space): New function, refactored from part of
1791 bidi_cache_iterator_state. Don't assume the required size is just
1792 one BIDI_CACHE_CHUNK away.
1793 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1794 (bidi_count_bytes, bidi_char_at_pos): New functions.
1795 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1796 always valid if bidi_cache_idx is valid.
1797 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1798 is valid if it's going to be used.
1799 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1800 (bidi_cache_fetch_state, bidi_cache_search)
1801 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1802 (bidi_cache_iterator_state, bidi_cache_find)
1803 (bidi_find_other_level_edge, bidi_cache_start_stack):
1804 All variables related to cache indices are now EMACS_INT.
1806 * dispextern.h (struct bidi_string_data): New structure.
1807 (struct bidi_it): New member `string'. Make flag members be 1-bit
1808 fields, and put them last in the struct.
1809 (compute_display_string_pos, compute_display_string_end):
1811 (bidi_push_it, bidi_pop_it): Add prototypes.
1812 (struct iterator_stack_entry): New members bidi_p,
1813 paragraph_embedding, and from_disp_prop_p.
1814 (struct it): Member bidi_p is now a bit field 1 bit wide.
1815 (bidi_shelve_cache, bidi_unshelve_cache):
1818 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1819 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1820 and vector-like objects.
1822 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1823 cache around display iteration.
1825 * window.c (Fwindow_end, window_scroll_pixel_based)
1826 (displayed_window_lines, Frecenter): Save and restore the bidi
1827 cache around display iteration.
1829 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1831 * editfns.c (Fdelete_region): Clarify the use of the named
1832 parameters (bug#6788).
1834 2011-07-14 Martin Rudalics <rudalics@gmx.at>
1836 * indent.c (Fvertical_motion): Set and restore w->pointm when
1837 saving and restoring the window's buffer (Bug#9006).
1839 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1841 * editfns.c (Fstring_to_char): Clarify just what is returned
1842 (bug#6576). Text by Eli Zaretskii.
1844 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
1846 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1848 2011-07-13 Eli Zaretskii <eliz@gnu.org>
1850 * buffer.c (mmap_find): Fix a typo.
1852 2011-07-13 Johan Bockgård <bojohan@gnu.org>
1854 Fix execution of x selection hooks.
1855 * xselect.c (Qx_lost_selection_functions)
1856 (Qx_sent_selection_functions): New vars.
1857 (syms_of_xselect): DEFSYM them.
1858 (x_handle_selection_request): Pass Qx_sent_selection_functions
1859 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1860 (x_handle_selection_clear,x_clear_frame_selections):
1861 Pass Qx_lost_selection_functions rather than
1862 Vx_lost_selection_functions to Frun_hook_with_args.
1864 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1866 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
1867 The old code sometimes used this field without initializing it.
1869 * alloc.c (gc_sweep): Don't read past end of array.
1870 In theory, the old code could also have corrupted Emacs internals,
1871 though it'd be very unlikely.
1873 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1875 * character.c (Fcharacterp): Don't advertise optional ignored
1876 argument. (Bug#4026)
1878 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1880 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1883 * window.c (Fset_window_start): Doc fix (bug#4199).
1884 (Fset_window_hscroll): Ditto.
1886 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1888 Fix minor new problems caught by GCC 4.6.1.
1889 * term.c (init_tty): Remove unused local.
1890 * xsettings.c (store_monospaced_changed): Define this function only
1891 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
1894 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
1896 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1898 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1900 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1901 are the mini-buffer and the echo area (bug#3320).
1903 * term.c (init_tty): Remove support for supdup, c10 and perq
1904 terminals, which are no longer supported (bug#1482).
1906 2011-07-10 Johan Bockgård <bojohan@gnu.org>
1908 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1910 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1912 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1913 for non-popups (Bug#3642).
1915 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1917 * alloc.c (reset_malloc_hooks): Protoize.
1918 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
1919 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1920 * cm.c (losecursor): Likewise.
1921 * data.c (fmod): Likewise.
1922 * dispnew.c (swap_glyphs_in_rows): Likewise.
1923 * emacs.c (memory_warning_signal): Likewise.
1924 * floatfns.c (float_error): Likewise.
1925 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1926 (otf_open, font_otf_capability, generate_otf_features)
1927 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1929 * image.c (pbm_read_file): Likewise.
1930 * indent.c (string_display_width): Likewise.
1931 * intervals.c (check_for_interval, search_for_interval)
1932 (inc_interval_count, count_intervals, root_interval)
1933 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1934 * lread.c (defalias): Likewise.
1935 * ralloc.c (r_alloc_check): Likewise.
1936 * regex.c (set_image_of_range_1, set_image_of_range)
1937 (regex_grow_registers): Likewise.
1938 * sysdep.c (strerror): Likewise.
1939 * termcap.c (valid_filename_p, tprint, main): Likewise.
1940 * tparam.c (main): Likewise.
1941 * unexhp9k800.c (run_time_remap, save_data_space)
1942 (update_file_ptrs, read_header, write_header, calculate_checksum)
1943 (copy_file, copy_rest, display_header): Likewise.
1944 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1946 * xdisp.c (check_it): Likewise.
1947 * xfaces.c (register_color, unregister_color, unregister_colors):
1949 * xfns.c (print_fontset_result): Likewise.
1950 * xrdb.c (member, fatal, main): Likewise.
1952 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1954 Fix minor problems found by static checking (Bug#9031).
1955 * chartab.c (char_table_set_range, map_sub_char_table):
1956 Remove unused locals.
1957 (uniprop_table): Now static.
1958 * composite.c (_work_char): Remove unused static var.
1960 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
1962 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1964 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1966 * gtkutil.c (qttip_cb): Remove code without function.
1968 2011-07-09 Eli Zaretskii <eliz@gnu.org>
1970 * w32.c (pthread_sigmask): New stub.
1972 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
1974 Use pthread_sigmask, not sigprocmask (Bug#9010).
1975 sigprocmask is portable only for single-threaded applications, and
1976 Emacs can be multi-threaded when it uses GTK.
1977 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1979 * callproc.c (Fcall_process):
1980 * process.c (create_process):
1981 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1982 Use pthread_sigmask, not sigprocmask.
1984 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1986 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1987 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1990 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1992 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1993 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1994 (xg_hide_tooltip): Fix comment.
1996 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1997 in registerServicesMenuSendTypes.
1998 (validRequestorForSendType): Don't check ns_return_types.
2000 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2003 2011-07-08 Jason Rumney <jasonr@gnu.org>
2005 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2006 frame struct members of non-existent frames (Bug#6284).
2008 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2010 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2011 variable firstTime not needed on OSX >= 10.6.
2012 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2013 >= 10.5. Use setKnobProportion, setDoubleValue.
2015 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2016 (MAC_OS_X_VERSION_10_5): Define if not defined.
2017 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2018 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2019 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2021 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2022 cString and lossyCString on OSX >= 10.4
2024 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2025 sizeToFit on OSX >= 10.2.
2027 * nsimage.m (allocInitFromFile): Don't use deprecated method
2028 bestRepresentationForDevice on OSX >= 10.6.
2030 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2033 * emacs.c: Declare unexec_init_emacs_zone.
2035 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2037 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2039 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2040 on svcsMenu (Bug#8842).
2042 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2044 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2046 * nsterm.m (QUTF8_STRING): Declare.
2047 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2048 (validRequestorForSendType): Return type is (id).
2049 Change indexOfObjectIdenticalTo to indexOfObject.
2050 Check if we have local selection before returning self (Bug#8842).
2051 (writeSelectionToPasteboard): Put local selection into paste board
2052 if we have a local selection (Bug#8842).
2053 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2055 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2056 (ns_get_local_selection): Declare.
2058 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2060 * keymap.c (describe_map_tree): Don't insert a double newline at
2061 the end of the buffer (bug#1169) and return whether we inserted
2064 * callint.c (Fcall_interactively): Change "reading args" to
2065 "providing args" to try to clarify what it does (bug#1010).
2067 2011-07-07 Kenichi Handa <handa@m17n.org>
2069 * composite.c (composition_compute_stop_pos): Ignore a static
2070 composition starting before CHARPOS (Bug#8915).
2072 * xdisp.c (handle_composition_prop): Likewise.
2074 2011-07-07 Eli Zaretskii <eliz@gnu.org>
2076 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2079 2011-07-07 Kenichi Handa <handa@m17n.org>
2081 * character.h (unicode_category_t): New enum type.
2083 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2084 (Qchar_code_property_table): New variable.
2085 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2086 (UNIPROP_COMPRESSED_FORM_P): New macros.
2087 (char_table_ascii): Uncompress the compressed values.
2088 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2089 Uncompress the compressed values.
2090 (sub_char_table_ref_and_range): Likewise.
2091 (char_table_ref_and_range): Uncompress the compressed values.
2092 (sub_char_table_set): New arg is_uniprop. Callers changed.
2093 Uncompress the compressed values.
2094 (sub_char_table_set_range): Args changed. Callers changed.
2095 (char_table_set_range): Adjuted for the above change.
2096 (map_sub_char_table): Delete args default_val and parent. Add arg
2097 top. Give decoded values to a Lisp function.
2098 (map_char_table): Adjust for the above change. Give decoded
2099 values to a Lisp function. Gcpro more variables.
2100 (uniprop_table_uncompress)
2101 (uniprop_decode_value_run_length): New functions.
2102 (uniprop_decoder, uniprop_decoder_count): New variables.
2103 (uniprop_get_decoder, uniprop_encode_value_character)
2104 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2106 (uniprop_encoder, uniprop_encoder_count): New variables.
2107 (uniprop_get_encoder, uniprop_table)
2108 (Funicode_property_table_internal, Fget_unicode_property_internal)
2109 (Fput_unicode_property_internal): New functions.
2110 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2111 Sunicode_property_table_internal, Sget_unicode_property_internal,
2112 and Sput_unicode_property_internal. Defvar_lisp
2113 char-code-property-alist.
2115 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
2116 Vunicode_category_table.
2118 * font.c (font_range): Adjust for the change of
2119 Vunicode_category_table.
2121 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2123 * m/iris4d.h: Remove file, move contents ...
2124 * s/irix6-5.h: ... here.
2126 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2128 Remove unportable assumption about struct layout (Bug#8884).
2129 * alloc.c (mark_buffer):
2130 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2131 (clone_per_buffer_values): Don't assume that
2132 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2133 This isn't true in general, and it's particularly not true
2134 if Emacs is configured with --with-wide-int.
2135 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2136 New macros, used in the buffer.c change.
2138 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2140 * xsettings.c: Use both GConf and GSettings if both are available.
2141 (store_config_changed_event): Add comment.
2142 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2143 (store_tool_bar_style_changed): New functions.
2144 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
2145 (struct xsettings): Move font inside HAVE_XFT.
2146 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
2147 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
2148 Move inside HAVE_XFT.
2149 (something_changed_gsettingsCB): Rename from something_changedCB.
2150 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2152 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
2153 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
2154 (something_changed_gconfCB): Rename from something_changedCB.
2155 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2156 (parse_settings): Move check for font inside HAVE_XFT.
2157 (read_settings, apply_xft_settings): Add comment.
2158 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2159 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2160 call store_font_name_changed.
2161 (xft_settings_event): Add comment.
2162 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2163 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2164 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2165 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2166 (xsettings_initialize): Call init_gsettings last.
2167 (xsettings_get_system_font, xsettings_get_system_normal_font):
2170 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2172 Random fixes. E.g., (random) never returned negative values.
2173 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2174 subseconds part to the entropy, as that's a bit more random.
2175 Prefer signed to unsigned, since the signedness doesn't matter and
2176 in general we prefer signed. When given a limit, use a
2177 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2178 latter isn't right if USE_2_TAGS_FOR_INTS.
2179 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2180 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2182 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2184 * textprop.c (text_property_stickiness):
2185 Obey Vtext_property_default_nonsticky.
2186 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2187 * w32fns.c (syms_of_w32fns):
2188 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2190 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2192 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2193 This is more efficient than Ffile_directory_p and avoids a minor race.
2195 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2197 * buffer.c (Foverlay_put): Say what the return value is
2200 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2201 is a directory before asking whether to use the file name
2203 (barf_or_query_if_file_exists): Make the "File is a directory"
2204 error be more correct.
2206 * fns.c (Frequire): Remove the mention of the .gz files, since
2207 that's installation-specific, but keep the mention of
2208 `get-load-suffixes'.
2210 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2212 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2213 Report string overflow if the output is too long.
2215 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
2217 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2218 (syms_of_gnutls): Remove duplicate DEFSYM for
2219 Qgnutls_bootprop_verify_hostname_error, an error for
2220 Qgnutls_bootprop_verify_error (which is no longer used).
2222 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2223 unused since revno:102982 (2011-01-26). All callers changed.
2224 Also (re)move comments that are misplaced or no longer relevant.
2226 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2228 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2230 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2232 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2233 and background color parameters if they have been changed.
2235 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2237 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2239 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2241 * xsettings.c (SYSTEM_FONT): Define only when used.
2242 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2244 * keymap.c (access_keymap_1): Now static.
2246 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2248 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2249 leave any prefix arg for the up event (Bug#1586).
2251 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2253 * lread.c (syms_of_lread): Mention single symbols defined by
2254 `defvar' or `defconst' (bug#7154).
2256 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2257 (Frequire): Mention get-load-suffixes.
2259 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2261 * window.h (window): Remove clone_number slot.
2262 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2264 (make_parent_window, make_window, saved_window)
2265 (Fset_window_configuration, save_window_save): Don't deal with
2267 * buffer.c (Qclone_number): Remove declaration.
2268 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2270 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2272 Add multiple inheritance to keymaps.
2273 * keymap.c (Fmake_composed_keymap): New function.
2274 (Fset_keymap_parent): Simplify.
2275 (fix_submap_inheritance): Remove.
2276 (access_keymap_1): New function extracted from access_keymap to handle
2277 embedded parents and handle lists of maps.
2278 (access_keymap): Use it.
2279 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2280 (Fcopy_keymap): Handle embedded parents.
2281 (Fcommand_remapping, define_as_prefix): Simplify.
2282 (Fkey_binding): Simplify.
2283 (syms_of_keymap): Move minibuffer-local-completion-map,
2284 minibuffer-local-filename-completion-map,
2285 minibuffer-local-must-match-map, and
2286 minibuffer-local-filename-must-match-map to Elisp.
2287 (syms_of_keymap): Defsubr make-composed-keymap.
2288 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2289 (parse_menu_item): Trivial simplification.
2291 2011-07-01 Glenn Morris <rgm@gnu.org>
2293 * Makefile.in (SETTINGS_LIBS): Fix typo.
2295 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2297 * coding.c (Fencode_coding_string): Record the last coding system
2298 used, as the function doc string says (bug#8738).
2300 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2302 * xsettings.c (store_monospaced_changed): Take new font as arg and
2303 check for change against current_mono_font.
2304 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2305 (emacs_settings_constructor, emacs_settings_get_property)
2306 (emacs_settings_set_property, emacs_settings_class_init)
2307 (emacs_settings_init, gsettings_obj): Remove.
2308 (something_changedCB): New function for HAVE_GSETTINGS.
2309 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2310 with value as argument.
2311 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2312 g_settings_new (Bug#8967). Do not create gsettings_obj.
2313 Remove calls to g_settings_bind. Connect something_changedCB to
2316 * xgselect.c: Add defined (HAVE_GSETTINGS).
2317 (xgselect_initialize): Ditto.
2319 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2320 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2323 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2325 * eval.c (struct backtrace): Simplify and port the data structure.
2326 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2327 signed bit field, as this assumption is not portable and it makes
2328 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2329 "char debug_on_exit : 1" as this is not portable either; instead,
2330 use the portable "unsigned int debug_on_exit : 1". Remove unused
2331 member evalargs. Remove obsolete comments about cc bombing out.
2333 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2335 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
2336 Let HAVE_GSETTINGS override HAVE_GCONF.
2337 (store_monospaced_changed): New function.
2338 (EMACS_SETTINGS): A new type derived from GObject to handle
2339 GSettings notifications.
2340 (emacs_settings_constructor, emacs_settings_get_property)
2341 (emacs_settings_set_property, emacs_settings_class_init):
2343 (gsettings_client, gsettings_obj): New variables.
2344 (GSETTINGS_SCHEMA): New define.
2345 (something_changedCB): Call store_monospaced_changed.
2346 (init_gsettings): New function.
2347 (xsettings_initialize): Call init_gsettings.
2348 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2351 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
2354 2011-06-29 Martin Rudalics <rudalics@gmx.at>
2356 * window.c (resize_root_window, grow_mini_window)
2357 (shrink_mini_window): Rename Qresize_root_window to
2358 Qwindow_resize_root_window and Qresize_root_window_vertically to
2359 Qwindow_resize_root_window_vertically.
2361 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2363 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2365 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
2367 * makefile.w32-in: Redesign dependencies so they reflect more
2368 clearly which files are directly included by each source file,
2369 and not through other includes.
2371 2011-06-27 Martin Rudalics <rudalics@gmx.at>
2373 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2374 (sort_overlays, overlay_strings): When an overlay's clone number
2375 matches the window's clone number process the overlay even if
2376 the overlay's window property doesn't match the current window.
2378 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2379 (Fwindow_hchild): Rename to Fwindow_left_child.
2380 (Fwindow_next): Rename to Fwindow_next_sibling.
2381 (Fwindow_prev): Rename to Fwindow_prev_sibling.
2382 (resize_window_check): Rename to window_resize_check.
2383 (resize_window_apply): Rename to window_resize_apply.
2384 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2385 (Fdelete_other_windows_internal, resize_frame_windows)
2386 (Fsplit_window_internal, Fdelete_window_internal)
2387 (grow_mini_window, shrink_mini_window)
2388 (Fresize_mini_window_internal): Fix callers accordingly.
2390 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2392 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2393 (emacs_fixed_set_min_size): Remove.
2394 (emacs_fixed_new): Take frame as argument.
2396 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2397 (_EmacsFixedPrivate): Remove minwidth/height.
2398 Add struct frame *f.
2399 (emacs_fixed_init): Initialize priv->f.
2400 (get_parent_class, emacs_fixed_set_min_size): Remove.
2401 (emacs_fixed_new): Set priv->f to argument.
2402 (emacs_fixed_get_preferred_width)
2403 (emacs_fixed_get_preferred_height): Use min_width/height from
2404 frames size_hint to set minimum and natural (Bug#8919).
2405 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2406 and use min_width/height from frames size_hint to set
2407 min_width/height (Bug#8919).
2409 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
2410 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2413 2011-06-26 Eli Zaretskii <eliz@gnu.org>
2415 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2416 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2419 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
2421 * process.c (wait_reading_process_output): Bypass select if
2422 waiting for a cell while ignoring keyboard input, and input is
2423 pending. Suggested by Jan Djärv (Bug#8869).
2425 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2427 Use gnulib's dup2 module instead of rolling our own.
2428 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2430 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2432 * dispnew.c (scrolling_window): Before scrolling, turn off a
2433 mouse-highlight in the window being scrolled.
2435 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
2437 Move DEFSYM to lisp.h and use everywhere.
2439 * character.h (DEFSYM): Move declaration...
2440 * lisp.h (DEFSYM): ...here.
2446 * w32select.c: Don't include character.h.
2448 * alloc.c (syms_of_alloc):
2449 * buffer.c (syms_of_buffer):
2450 * bytecode.c (syms_of_bytecode):
2451 * callint.c (syms_of_callint):
2452 * casefiddle.c (syms_of_casefiddle):
2453 * casetab.c (init_casetab_once):
2454 * category.c (init_category_once, syms_of_category):
2455 * ccl.c (syms_of_ccl):
2456 * cmds.c (syms_of_cmds):
2457 * composite.c (syms_of_composite):
2458 * dbusbind.c (syms_of_dbusbind):
2459 * dired.c (syms_of_dired):
2460 * dispnew.c (syms_of_display):
2461 * doc.c (syms_of_doc):
2462 * editfns.c (syms_of_editfns):
2463 * emacs.c (syms_of_emacs):
2464 * eval.c (syms_of_eval):
2465 * fileio.c (syms_of_fileio):
2466 * fns.c (syms_of_fns):
2467 * frame.c (syms_of_frame):
2468 * fringe.c (syms_of_fringe):
2469 * insdel.c (syms_of_insdel):
2470 * keymap.c (syms_of_keymap):
2471 * lread.c (init_obarray, syms_of_lread):
2472 * macros.c (syms_of_macros):
2473 * msdos.c (syms_of_msdos):
2474 * print.c (syms_of_print):
2475 * process.c (syms_of_process):
2476 * search.c (syms_of_search):
2477 * sound.c (syms_of_sound):
2478 * syntax.c (init_syntax_once, syms_of_syntax):
2479 * terminal.c (syms_of_terminal):
2480 * textprop.c (syms_of_textprop):
2481 * undo.c (syms_of_undo):
2482 * w32.c (globals_of_w32):
2483 * window.c (syms_of_window):
2484 * xdisp.c (syms_of_xdisp):
2485 * xfaces.c (syms_of_xfaces):
2486 * xfns.c (syms_of_xfns):
2487 * xmenu.c (syms_of_xmenu):
2488 * xsettings.c (syms_of_xsettings):
2489 * xterm.c (syms_of_xterm): Use DEFSYM.
2491 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2493 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
2495 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2497 Integer and buffer overflow fixes (Bug#8873).
2499 * print.c (printchar, strout): Check for string overflow.
2500 (PRINTPREPARE, printchar, strout):
2501 Don't set size unless allocation succeeds.
2503 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2504 for sizes. Check for string overflow more accurately.
2505 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2507 * macros.c: Integer and buffer overflow fixes.
2508 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2509 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2510 Use ptrdiff_t, not int, for sizes.
2511 Don't increment bufsize until after realloc succeeds.
2512 Check for size-calculation overflow.
2513 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2515 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2517 * lread.c: Integer overflow fixes.
2518 (read_integer): Radix is now EMACS_INT, not int,
2519 to improve quality of diagnostics for out-of-range radices.
2520 Calculate buffer size correctly for out-of-range radices.
2521 (read1): Check for integer overflow in radices, and in
2522 read-circle numbers.
2523 (read_escape): Avoid int overflow.
2524 (Fload, openp, read_buffer_size, read1)
2525 (substitute_object_recurse, read_vector, read_list, map_obarray):
2526 Use ptrdiff_t, not int, for sizes.
2527 (read1): Use EMACS_INT, not int, for sizes.
2528 Check for size overflow.
2530 * image.c (cache_image): Check for size arithmetic overflow.
2532 * lread.c: Integer overflow issues.
2533 (saved_doc_string_size, saved_doc_string_length)
2534 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2535 Now ptrdiff_t, not int.
2536 (read1): Don't assume doc string length fits in int. Check for
2537 out-of-range doc string lengths.
2538 (read_list): Don't assume file position fits in int.
2539 (read_escape): Check for hex character overflow.
2541 2011-06-22 Leo Liu <sdl.web@gmail.com>
2543 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2544 Move to minibuffer.el.
2546 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2548 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
2549 The following patches are for when GLYPH_DEBUG && !XASSERT.
2550 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2551 * dispnew.c (flush_stdout):
2552 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2553 Mark as externally visible.
2554 * dispnew.c (check_window_matrix_pointers): Now static.
2555 * dispnew.c (window_to_frame_vpos):
2556 * xfns.c (unwind_create_frame):
2557 * xterm.c (x_check_font): Remove unused local.
2558 * scroll.c (CHECK_BOUNDS):
2559 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2560 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2561 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2562 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2563 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2565 (debug_method_add): Use va_list and vsprintf rather than relying
2566 on undefined behavior with wrong number of arguments.
2567 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2568 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2569 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2570 since we're not interested in debugging glyphs with old libraries.
2571 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2572 GCC 4.6.0's static checking.
2574 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2576 Integer overflow and signedness fixes (Bug#8873).
2577 A few related buffer overrun fixes, too.
2579 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2581 * dispextern.h (struct face.stipple):
2582 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2583 (x_bitmap_mask, x_allocate_bitmap_record)
2584 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2585 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2586 (x_create_bitmap_from_xpm_data):
2587 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2588 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2590 * xfaces.c (load_pixmap):
2591 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2592 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2593 (.bitmaps_last, struct x_output.icon_bitmap):
2594 Use ptrdiff_t, not int, for bitmap indexes.
2595 (x_allocate_bitmap_record): Check for size overflow.
2596 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2598 Use ptrdiff_t, not int, for overlay counts.
2599 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2600 * editfns.c (overlays_around, get_pos_property):
2601 * textprop.c (get_char_property_and_overlay):
2602 * xdisp.c (next_overlay_change, note_mouse_highlight):
2603 * xfaces.c (face_at_buffer_position):
2604 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2605 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2606 (Fnext_overlay_change, Fprevious_overlay_change)
2607 (mouse_face_overlay_overlaps, Foverlays_in):
2608 Use ptrdiff_t, not int, for sizes.
2609 (overlays_at, overlays_in): Check for size-calculation overflow.
2611 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2613 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2614 (x_session_initialize): Do not assume string length fits in int.
2616 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2617 This is unlikely, but can occur if DPI is outlandish.
2619 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
2620 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2622 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2623 * xrdb.c (magic_file_p, search_magic_path):
2624 Omit last arg SUFFIX; it was always 0. All callers changed.
2625 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2627 * xfont.c (xfont_match): Avoid need for strlen.
2629 * xfns.c: Don't assume strlen fits in int.
2630 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2632 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2633 not unsigned long, as we prefer signed integers. All callers changed.
2634 Detect integer overflow in repeat count.
2635 (message_dolog): Don't assume print length fits in 39 bytes.
2636 (display_mode_element): Don't assume strlen fits in int.
2638 * termcap.c: Don't assume sizes fit in int and never overflow.
2639 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2640 (gobble_line): Check for size-calculation overflow.
2642 * minibuf.c (Fread_buffer):
2643 * lread.c (intern, intern_c_string):
2644 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2645 Don't assume string length fits in int.
2647 * keyboard.c (parse_tool_bar_item):
2648 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2650 * font.c: Don't assume string length fits in int.
2651 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2652 Use ptrdiff_t, not int.
2653 (font_intern_prop): Don't assume string length fits in int.
2654 Don't assume integer property fits in fixnum.
2655 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
2657 * filelock.c: Fix some buffer overrun and integer overflow issues.
2658 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
2659 Reformulate so as not to need the command string.
2660 Invoke gzip -cd rather than gunzip, as it's more portable.
2661 (lock_info_type, lock_file_1, lock_file):
2662 Don't assume pid_t and time_t fit in unsigned long.
2663 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2664 (current_lock_owner): Prefer signed type for sizes.
2665 Use memcpy, not strncpy, where memcpy is what is really wanted.
2666 Don't assume (via atoi) that time_t and pid_t fit in int.
2667 Check for time_t and/or pid_t out of range, e.g., via a network share.
2668 Don't alloca where an auto var works fine.
2670 * fileio.c: Fix some integer overflow issues.
2671 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2672 Don't assume string length fits in int.
2673 (directory_file_name): Don't assume string length fits in long.
2674 (make_temp_name): Don't assume pid fits in int, or that its print
2675 length is less than 20.
2677 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2679 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2681 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2683 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2684 We prefer signed integers, even for size calculations.
2686 * emacs.c: Don't assume string length fits in 'int'.
2687 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2688 (main): Don't invoke strlen when not needed.
2690 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2691 (XD_DEBUG_MESSAGE): Don't waste a byte.
2693 * callproc.c (getenv_internal_1, getenv_internal)
2695 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2697 * lread.c (invalid_syntax): Omit length argument.
2698 All uses changed. This doesn't fix a bug, but it simplifies the
2699 code away from its former Hollerith-constant appearance, and it's
2700 one less 'int' to worry about when looking at integer-overflow issues.
2701 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
2703 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2704 This didn't break anything, but it didn't help either.
2705 It's confusing to put a bogus integer in a place where the actual
2706 value does not matter.
2707 (LIST_END_P): Remove unused macro and its bogus comment.
2708 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
2710 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2711 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2713 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2714 We prefer signed types, and the value cannot exceed the EMACS_INT
2715 range anyway (because otherwise the length would not be representable).
2716 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2717 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2718 This avoids a GCC warning when WIDE_EMACS_INT.
2720 * indent.c (sane_tab_width): New function.
2721 (current_column, scan_for_column, Findent_to, position_indentation)
2722 (compute_motion): Use it. This is just for clarity.
2723 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
2725 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
2727 * lisp.h (lint_assume): New macro.
2728 * composite.c (composition_gstring_put_cache):
2729 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2731 * editfns.c, insdel.c:
2732 Omit unnecessary forward decls, to simplify future changes.
2734 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2736 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2738 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
2739 Use much-faster test for byte-length change.
2740 Don't assume string byte-length fits in 'int'.
2741 Check that character arg fits in 'int'.
2742 (mapcar1): Declare byte as byte, for clarity.
2744 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2746 * fns.c (concat): Catch string overflow earlier.
2747 Do not rely on integer wraparound.
2749 * dispextern.h (struct it.overlay_strings_charpos)
2750 (struct it.selective): Now EMACS_INT, not int.
2751 * xdisp.c (forward_to_next_line_start)
2752 (back_to_previous_visible_line_start)
2753 (reseat_at_next_visible_line_start, next_element_from_buffer):
2754 Don't arbitrarily truncate the value of 'selective' to int.
2756 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2758 * composite.c: Don't truncate sizes to 'int'.
2759 (composition_gstring_p, composition_reseat_it)
2760 (composition_adjust_point): Use EMACS_INT, not int.
2761 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2762 not EMACS_UINT, for indexes.
2764 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2766 * buffer.c: Include <verify.h>.
2767 (struct sortvec.priority, struct sortstr.priority):
2768 Now EMACS_INT, not int.
2769 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
2770 (struct sortstr.size, record_overlay_string)
2771 (struct sortstrlist.size, struct sortlist.used):
2772 Don't truncate size to int.
2773 (record_overlay_string): Check for size-calculation overflow.
2774 (init_buffer_once): Check at compile-time, not run-time.
2776 2011-06-22 Jim Meyering <meyering@redhat.com>
2778 Don't leak an XBM-image-sized buffer
2779 * image.c (xbm_load): Free the image buffer after using it.
2781 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2784 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2785 that Sun C diagnosed.
2786 * fns.c (secure_hash): Fix pointer signedness issue.
2787 * intervals.c (static_offset_intervals): New function.
2788 (offset_intervals): Use it.
2790 2011-06-21 Leo Liu <sdl.web@gmail.com>
2793 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2796 * fns.c (secure_hash): Rename from crypto_hash_function and change
2797 the first arg to accept symbols.
2798 (Fsecure_hash): New primitive.
2799 (syms_of_fns): New symbols.
2801 2011-06-20 Deniz Dogan <deniz@dogan.se>
2803 * process.c (Fset_process_buffer): Clarify return value in
2806 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
2808 * dispnew.c (add_window_display_history): Use BVAR.
2810 * xdisp.c (debug_method_add): Use BVAR.
2811 (check_window_end, dump_glyph_matrix, dump_glyph)
2812 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2814 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2817 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2818 check till after the cache is created in init_frame_faces.
2820 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2822 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2824 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2826 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2827 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2828 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2830 Improve buffer-overflow checking (Bug#8873).
2831 * fileio.c (Finsert_file_contents):
2832 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2833 Remove the old (too-loose) buffer overflow checks.
2834 They weren't needed, since make_gap checks for buffer overflow.
2835 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2836 The old code merely checked for Emacs fixnum overflow, and relied
2837 on undefined (wraparound) behavior. The new code avoids undefined
2838 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2840 * editfns.c (Finsert_char): Don't dump core with very negative counts.
2841 Tune. Don't use wider integers than needed. Don't use alloca.
2842 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2844 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2846 * insdel.c, lisp.h (buffer_overflow): New function.
2847 (insert_from_buffer_1, replace_range, replace_range_2):
2848 * insdel.c (make_gap_larger):
2849 * editfns.c (Finsert_char):
2850 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2852 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2854 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2856 Integer overflow and signedness fixes (Bug#8873).
2858 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2859 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2861 * fileio.c: Don't assume EMACS_INT fits in off_t.
2862 (emacs_lseek): New static function.
2863 (Finsert_file_contents, Fwrite_region): Use it.
2864 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2866 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2868 * fns.c: Don't overflow int when computing a list length.
2869 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2870 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2871 truncation on 64-bit hosts. Check for QUIT every
2872 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2873 faster and is responsive enough.
2874 (Flength): Report an error instead of overflowing an integer.
2875 (Fsafe_length): Return a float if the value is not representable
2876 as a fixnum. This shouldn't happen except in contrived situations.
2877 (Fnthcdr, Fsort): Don't assume list length fits in int.
2878 (Fcopy_sequence): Don't assume vector length fits in int.
2880 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2881 (header_size, word_size): New constants.
2882 (allocate_vectorlike): Don't check size overflow here.
2883 (allocate_vector): Check it here instead, since this is the only
2884 caller of allocate_vectorlike that could cause overflow.
2885 Check that the new vector's length is representable as a fixnum.
2887 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2888 The previous code was bogus. For example, next_almost_prime (32)
2889 returned 39, which is undesirable as it is a multiple of 3; and
2890 next_almost_prime (24) returned 25, which is a multiple of 5 so
2891 why was the code bothering to check for multiples of 7?
2893 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2895 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2897 Variadic C functions now count arguments with ptrdiff_t.
2898 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2899 Back then I didn't know that the Emacs coding style prefers signed int.
2900 Also, in the meantime I found a few more instances where arguments
2901 were being counted with int, which may truncate counts on 64-bit
2902 machines, or EMACS_INT, which may be unnecessarily wide.
2903 * lisp.h (struct Lisp_Subr.function.aMANY)
2904 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2905 Arg counts are now ptrdiff_t, not size_t.
2906 All variadic functions and their callers changed accordingly.
2907 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2908 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2909 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2910 * callint.c (Fcall_interactively): Check arg count for overflow,
2911 to avoid potential buffer overrun. Use signed char, not 'int',
2912 for 'varies' array, so that we needn't bother to check its size
2913 calculation for overflow.
2914 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2915 * eval.c (apply_lambda):
2916 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2917 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2918 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2920 * callint.c (Fcall_interactively): Don't use index var as event count.
2922 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2923 * mem-limits.h (SIZE): Remove; no longer used.
2925 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
2927 Remove unnecessary casts.
2928 * xterm.c (x_term_init):
2929 * xfns.c (x_set_border_pixel):
2930 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2931 These aren't needed now that we assume ANSI C.
2933 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2934 It's more likely to cause problems (due to unsigned overflow)
2937 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2939 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2941 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2943 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2945 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2947 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2949 GLYPH_CODE_FACE returns EMACS_INT, not int.
2950 * dispextern.h (merge_faces):
2951 * xfaces.c (merge_faces):
2952 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2953 Don't assume EMACS_INT fits in int.
2955 * character.h (CHAR_VALID_P): Remove unused parameter.
2956 * fontset.c, lisp.h, xdisp.c: All uses changed.
2958 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2960 * fns.c (concat): Minor tuning based on overflow analysis.
2961 This doesn't fix any bugs. Use int to hold character, instead
2962 of constantly refetching from Emacs object. Use XFASTINT, not
2963 XINT, for value known to be a character. Don't bother comparing
2964 a single byte to 0400, as it's always less.
2966 * floatfns.c (Fexpt):
2967 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2969 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2972 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2974 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2975 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2976 incorrectly succeed when S was a string, because 4294967386 was
2977 truncated before it was used.
2979 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2980 Otherwise, an out-of-range integer could cause undefined behavior
2983 * composite.c: Use int, not EMACS_INT, for characters.
2984 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2985 EMACS_INT, for values that are known to be in character range.
2986 This doesn't fix any bugs but is the usual style inside Emacs and
2987 may generate better code on 32-bit machines.
2989 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2990 This is for reasons similar to the recent CHAR_STRING fix.
2991 * charset.c (Fencode_char): Check that character arg is actually
2992 a character. Pass an int to ENCODE_CHAR.
2993 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2994 wider than 'int', as a compile-time check to prevent future regressions
2997 * character.c (char_string): Remove unnecessary casts.
2999 Make sure a 64-bit char is never passed to CHAR_STRING.
3000 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3001 by silently ignoring the top 32 bits, allowing some values
3002 that were far too large to be valid characters.
3003 * character.h: Include <verify.h>.
3004 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3005 arguments are no wider than unsigned, as a compile-time check
3006 to prevent future regressions in this area.
3008 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
3009 (Fsubst_char_in_region):
3011 * xdisp.c (decode_mode_spec_coding):
3012 Adjust to CHAR_STRING's new requirement.
3013 * editfns.c (Finsert_char, Fsubst_char_in_region):
3014 * fns.c (concat): Check that character args are actually
3015 characters. Without this test, these functions did the wrong
3016 thing with wildly out-of-range values on 64-bit hosts.
3018 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3019 These casts should not be needed on 32-bit hosts, either.
3020 * keyboard.c (read_char):
3021 * lread.c (Fload): Remove casts to unsigned.
3023 * lisp.h (UNSIGNED_CMP): New macro.
3024 This fixes comparison bugs on 64-bit hosts.
3025 (ASCII_CHAR_P): Use it.
3026 * casefiddle.c (casify_object):
3027 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
3028 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3029 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3030 * dispextern.h (FACE_FROM_ID):
3031 * keyboard.c (read_char): Use UNSIGNED_CMP.
3033 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3034 not to EMACS_INT, to avoid GCC warning.
3036 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3038 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3039 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3040 isn't needed on 32-bit machines.
3042 * buffer.c (Fgenerate_new_buffer_name):
3043 Use EMACS_INT for count, not int.
3044 (advance_to_char_boundary): Return EMACS_INT, not int.
3046 * data.c (Qcompiled_function): Now static.
3048 * window.c (window_body_lines): Now static.
3050 * image.c (gif_load): Rename local to avoid shadowing.
3052 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3053 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3054 * alloc.c (make_save_value): Integer argument is now of type
3056 (mark_object): Use ptrdiff_t, not int.
3057 * lisp.h (pD): New macro.
3058 * print.c (print_object): Use it.
3060 * alloc.c: Use EMACS_INT, not int, to count objects.
3061 (total_conses, total_markers, total_symbols, total_vector_size)
3062 (total_free_conses, total_free_markers, total_free_symbols)
3063 (total_free_floats, total_floats, total_free_intervals)
3064 (total_intervals, total_strings, total_free_strings):
3065 Now EMACS_INT, not int. All uses changed.
3066 (Fgarbage_collect): Compute overall total using a double, so that
3067 integer overflow is less likely to be a problem. Check for overflow
3068 when converting back to an integer.
3069 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3070 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3071 These were 'int' variables that could overflow on 64-bit hosts;
3072 they were never used, so remove them instead of repairing them.
3073 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
3074 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3075 Previously, this ceilinged at INT_MAX, but that doesn't work on
3077 (allocate_pseudovector): Don't use EMACS_INT when int would do.
3079 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
3080 (allocate_vectorlike): Check for ptrdiff_t overflow.
3081 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3082 when a (possibly-narrower) signed value would do just as well.
3083 We prefer using signed arithmetic, to avoid comparison confusion.
3085 * alloc.c: Catch some string size overflows that we were missing.
3086 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3087 for convenience in STRING_BYTES_MAX.
3088 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3089 The definition here is exact; the one in lisp.h was approximate.
3090 (allocate_string_data): Check for string overflow. This catches
3091 some instances we weren't catching before. Also, it catches
3092 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3093 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3094 and ptrdiff_t and EMACS_INT are both 64 bits.
3096 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3097 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
3098 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
3100 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3102 * alloc.c (Fmake_string): Check for out-of-range init.
3104 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3106 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3108 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3110 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3111 xg_get_default_scrollbar_width.
3113 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3114 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3115 (style_changed_cb): Call update_theme_scrollbar_width and call
3116 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3117 all frames (Bug#8505).
3118 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3119 Call gtk_window_set_resizable if HAVE_GTK3.
3120 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3121 and height if HAVE_GTK3 (Bug#8505).
3122 (scroll_bar_width_for_theme): New variable.
3123 (update_theme_scrollbar_width): New function.
3124 (xg_get_default_scrollbar_width): Move code to
3125 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3126 (xg_initialize): Call update_theme_scrollbar_width.
3128 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3130 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3132 2011-06-12 Martin Rudalics <rudalics@gmx.at>
3134 * frame.c (make_frame): Call other_buffer_safely instead of
3137 * window.c (temp_output_buffer_show): Call display_buffer with
3138 second argument Vtemp_buffer_show_specifiers and reset latter
3139 immediately after the call.
3140 (Vtemp_buffer_show_specifiers): New variable.
3141 (auto_window_vscroll_p, next_screen_context_lines)
3142 (Vscroll_preserve_screen_position): Remove leading asterisks from
3145 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
3147 Fix minor problems found by GCC 4.6.0 static checking.
3148 * buffer.c (Qclone_number): Remove for now, as it's unused.
3149 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3150 (record_buffer): Remove unused local.
3151 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3152 (set_frame_buffer_list): Remove; unused.
3153 * frame.h (other_visible_frames): Remove decl.
3154 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3155 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3156 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3158 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3159 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3160 Define only if HAVE_GPM.
3161 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3162 (update_hints_inhibit): Remove; never set. All uses removed.
3163 * widgetprv.h (emacsFrameClassRec): Remove decl.
3164 * window.c (delete_deletable_window): Now returns void, since it
3165 wasn't returning anything.
3166 (compare_window_configurations): Remove unused locals.
3167 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3168 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
3169 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3170 the same widths as pointers. This follows up on the 2011-05-06 patch.
3171 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3172 * xterm.h: Likewise.
3173 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3175 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
3177 * makefile.w32-in: Update dependencies.
3178 (LISP_H): Add lib/intprops.h.
3180 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3182 * image.c (gif_load): Add animation frame delay to the metadata.
3183 (syms_of_image): Use DEFSYM. New symbol `delay'.
3185 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3187 * window.c (delete_deletable_window): Re-add.
3188 (Fset_window_configuration): Rewrite to handle dead buffers and
3189 consequently deletable windows.
3190 (window_tree, Fwindow_tree): Remove. Supply functionality in
3192 (compare_window_configurations): Simplify code.
3194 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3196 * image.c (imagemagick_load_image): Fix type mismatch.
3197 (Fimagemagick_types): Likewise.
3199 * window.h (replace_buffer_in_windows): Declare.
3201 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3203 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3204 Qclone_number. Remove external declaration of Qdelete_window.
3205 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3207 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3208 Run Qbuffer_list_update_hook if allowed.
3209 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3210 buffer list implementation.
3211 (other_buffer_safely): New function.
3212 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3213 calls to replace_buffer_in_windows and
3214 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3216 (record_buffer): Inhibit quitting and rewrite using quittable
3217 functions. Run Qbuffer_list_update_hook if allowed.
3218 (Frecord_buffer, Funrecord_buffer): New functions.
3219 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3220 Move switch-to-buffer to window.el.
3221 (bury-buffer): Move to window.el.
3222 (Vbuffer_list_update_hook): New variable.
3224 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3227 * window.h (resize_frame_windows): Move up in code.
3228 (Fwindow_frame): Remove EXFUN.
3229 (replace_buffer_in_all_windows): Remove prototype.
3230 (replace_buffer_in_windows_safely): Add prototype.
3232 * window.c: Declare Qdelete_window static again. Move down
3233 declaration of select_count.
3234 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3235 (Fother_window): Move to window.el.
3236 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3237 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3238 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3240 (replace_buffer_in_windows): Implement by calling
3241 Qreplace_buffer_in_windows.
3242 (replace_buffer_in_all_windows): Remove with some functionality
3243 moved into replace_buffer_in_windows_safely.
3244 (replace_buffer_in_windows_safely): New function.
3245 (select_window_norecord, select_frame_norecord): Move in front
3246 of run_window_configuration_change_hook. Remove now obsolete
3248 (Fset_window_buffer): Rewrite doc-string.
3249 Call Qrecord_window_buffer.
3250 (keys_of_window): Move binding for other-window to window.el.
3252 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3254 * dispextern.h (struct image): Replace data member, whose int_val
3255 and ptr_val fields were not used by anything, with a single
3258 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3259 (gif_clear_image, gif_load, imagemagick_load_image)
3260 (gs_clear_image, gs_load): Callers changed.
3262 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3264 * buffer.h: Include <time.h>, for time_t.
3265 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3267 Fix minor problems found by static checking.
3269 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3271 Make identifiers static if they are not used in other modules.
3272 * data.c (Qcompiled_function, Qframe, Qvector):
3273 * image.c (QimageMagick, Qsvg):
3274 * minibuf.c (Qmetadata):
3275 * window.c (resize_window_check, resize_root_window): Now static.
3276 * window.h (resize_window_check, resize_root_window): Remove decls.
3278 * window.c (window_deletion_count, delete_deletable_window):
3280 (window_body_lines): Now static.
3281 (Fdelete_other_windows_internal): Mark vars as initialized.
3282 Make sure 'resize_failed' is initialized.
3283 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3284 (resize_window_apply): Remove unused local.
3285 * window.h (delete_deletable_window): Remove decl.
3287 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
3288 (imagemagick_load_image): Fix pointer signedness problem by changing
3289 last arg from unsigned char * to char *. All uses changed.
3290 Also, fix a local for similar reasons.
3291 Remove unused locals. Remove locals to avoid shadowing.
3292 (fn_rsvg_handle_free): Remove; unused.
3293 (svg_load, svg_load_image): Fix pointer signedness problem.
3294 (imagemagick_load_image): Don't use garbage pointer image_wand.
3296 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3298 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
3300 * image.c (gif_load): Fix omitted cast error introduced by
3303 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3305 * window.h (resize_proportionally, orig_total_lines)
3306 (orig_top_line): Remove from window structure.
3307 (set_window_height, set_window_width, change_window_heights)
3308 (Fdelete_window): Remove prototypes.
3309 (resize_frame_windows): Remove duplicate declaration.
3311 2011-06-10 Eli Zaretskii <eliz@gnu.org>
3313 * window.h (resize_frame_windows, resize_window_check)
3314 (delete_deletable_window, resize_root_window)
3315 (resize_frame_windows): Declare prototypes.
3317 * window.c (resize_window_apply): Make definition be "static" to
3318 match the prototype.
3320 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3322 * window.c: Remove declarations of Qwindow_size_fixed,
3323 window_min_size_1, window_min_size_2, window_min_size,
3324 size_window, window_fixed_size_p, enlarge_window, delete_window.
3325 Remove static from declaration of Qdelete_window, it's
3326 temporarily needed by Fbury_buffer.
3327 (replace_window): Don't assign orig_top_line and
3329 (Fdelete_window, delete_window): Remove. Window deletion is
3330 handled by window.el.
3331 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3332 Replace Fdelete_window calls with calls to Qdelete_window.
3333 (Fdelete_other_windows): Remove. Deleting other windows is
3334 handled by window.el.
3335 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3336 handled in window.el.
3337 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3338 Window minimum sizes are handled in window.el.
3339 (shrink_windows, size_window, set_window_height)
3340 (set_window_width, change_window_heights, window_height)
3341 (window_width, CURBEG, CURSIZE, enlarge_window)
3342 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3343 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3344 handled in window.el.
3345 (make_dummy_parent): Rename to make_parent_window and give it a
3346 second argument horflag.
3347 (make_window): Don't set resize_proportionally any more.
3348 (Fsplit_window): Remove. Windows are split in window.el.
3349 (save_restore_action, save_restore_orig_size)
3350 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3351 Resize mini windows in window.el.
3352 (grow_mini_window, shrink_mini_window): Implement by calling
3353 Qresize_root_window_vertically, resize_window_check and
3354 resize_window_apply.
3355 (saved_window, Fset_window_configuration, save_window_save):
3356 Do not handle orig_top_line, orig_total_lines, and
3357 resize_proportionally.
3358 (window_min_height, window_min_width): Move to window.el.
3359 (keys_of_window): Move bindings for delete-other-windows,
3360 split-window, delete-window and enlarge-window to window.el.
3362 * buffer.c: Temporarily extern Qdelete_window.
3363 (Fbury_buffer): Temporarily call Qdelete_window instead of
3364 Fdelete_window (Fbury_buffer will move to window.el soon).
3366 * frame.c (set_menu_bar_lines_1): Remove code handling
3367 orig_top_line and orig_total_lines.
3369 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3370 set_window_height but set heights directly.
3371 (change_frame_size_1): Use resize_frame_windows.
3373 * xdisp.c (init_xdisp): Don't use set_window_height but set
3376 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3377 Use resize_frame_windows instead of change_window_heights and run
3378 run_window_configuration_change_hook.
3380 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3381 instead of change_window_heights and run
3382 run_window_configuration_change_hook.
3384 2011-06-09 Martin Rudalics <rudalics@gmx.at>
3386 * window.c (replace_window): Rename second argument REPLACEMENT to
3387 NEW. New third argument SETFLAG. Rewrite.
3388 (delete_window, make_dummy_parent): Call replace_window with
3390 (window_list_1): Move down in code.
3391 (run_window_configuration_change_hook): Move set_buffer part
3392 before select_frame_norecord part in order to unwind correctly.
3393 Rename count1 to count.
3394 (recombine_windows, delete_deletable_window, resize_root_window)
3395 (Fdelete_other_windows_internal)
3396 (Frun_window_configuration_change_hook, make_parent_window)
3397 (resize_window_check, resize_window_apply, Fresize_window_apply)
3398 (resize_frame_windows, Fsplit_window_internal)
3399 (Fdelete_window_internal, Fresize_mini_window_internal):
3401 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3403 2011-06-08 Martin Rudalics <rudalics@gmx.at>
3405 * window.h (window): Add some new members to window structure -
3406 normal_lines, normal_cols, new_total, new_normal, clone_number,
3407 splits, nest, prev_buffers, next_buffers.
3408 (WINDOW_TOTAL_SIZE): Move here from window.c.
3409 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
3411 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3413 (make_dummy_parent): Set new members of windows structure.
3414 (make_window): Move down in code. Handle new members of window
3416 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3417 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3418 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3419 (Fset_window_prev_buffers, Fwindow_next_buffers)
3420 (Fset_window_next_buffers, Fset_window_clone_number):
3422 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3423 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3425 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3426 Argument WINDOW can be now internal window too.
3427 (Fwindow_use_time): Move up in code.
3428 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3430 (Fset_window_configuration, saved_window)
3431 (Fcurrent_window_configuration, save_window_save): Handle new
3432 members of window structure.
3433 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3434 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3435 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3436 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3437 Qget_mru_window, Qresize_root_window,
3438 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3439 Qauto_buffer_name; staticpro them.
3441 2011-06-07 Martin Rudalics <rudalics@gmx.at>
3443 * window.c (Fwindow_total_size, Fwindow_left_column)
3444 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3445 (Fwindow_list_1): New functions.
3446 (window_box_text_cols): Replace with window_body_cols.
3447 (Fwindow_width, Fscroll_left, Fscroll_right):
3448 Use window_body_cols instead of window_box_text_cols.
3449 (delete_window, Fset_window_configuration):
3450 Call delete_all_subwindows with window as argument.
3451 (delete_all_subwindows): Take a window as argument and not a
3453 (window_loop): Remove handling of GET_LRU_WINDOW and
3455 (Fget_lru_window, Fget_largest_window): Move to window.el.
3457 * window.h: Extern window_body_cols instead of
3458 window_box_text_cols. delete_all_subwindows now takes a
3459 Lisp_Object as argument.
3461 * indent.c (compute_motion, Fcompute_motion):
3462 Use window_body_cols instead of window_box_text_cols.
3464 * frame.c (delete_frame): Call delete_all_subwindows with root
3467 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3469 * fns.c (Fputhash): Document return value.
3471 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3473 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3475 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3477 Cons<->int and similar integer overflow fixes (Bug#8794).
3479 Check for overflow when converting integer to cons and back.
3480 * charset.c (Fdefine_charset_internal, Fdecode_char):
3481 Use cons_to_unsigned to catch overflow.
3482 (Fencode_char): Use INTEGER_TO_CONS.
3483 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3484 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3485 * data.c (long_to_cons, cons_to_long): Remove.
3486 (cons_to_unsigned, cons_to_signed): New functions.
3487 These signal an error for invalid or out-of-range values.
3488 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3489 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3490 * font.c (Ffont_variation_glyphs):
3491 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3492 * lisp.h: Include <intprops.h>.
3493 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3494 (cons_to_signed, cons_to_unsigned): New decls.
3495 (long_to_cons, cons_to_long): Remove decls.
3496 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3497 (Fprimitive_undo): Use CONS_TO_INTEGER.
3498 * xfns.c (Fx_window_property): Likewise.
3499 * xselect.c: Include <limits.h>.
3500 (x_own_selection, selection_data_to_lisp_data):
3501 Use INTEGER_TO_CONS.
3502 (x_handle_selection_request, x_handle_selection_clear)
3503 (x_get_foreign_selection, Fx_disown_selection_internal)
3504 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3505 (lisp_data_to_selection_data): Use cons_to_unsigned.
3506 (x_fill_property_data): Use cons_to_signed.
3507 Report values out of range.
3509 Check for buffer and string overflow more precisely.
3510 * buffer.h (BUF_BYTES_MAX): New macro.
3511 * lisp.h (STRING_BYTES_MAX): New macro.
3512 * alloc.c (Fmake_string):
3513 * character.c (string_escape_byte8):
3514 * coding.c (coding_alloc_by_realloc):
3515 * doprnt.c (doprnt):
3516 * editfns.c (Fformat):
3518 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3519 since they may not be the same number.
3520 * editfns.c (Finsert_char):
3521 * fileio.c (Finsert_file_contents):
3522 Likewise for BUF_BYTES_MAX.
3524 * image.c: Use ptrdiff_t, not int, for sizes.
3525 (slurp_file): Switch from int to ptrdiff_t.
3527 (slurp_file): Check that file size fits in both size_t (for
3528 malloc) and ptrdiff_t (for sanity and safety).
3530 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3531 if b->modtime has its maximal value.
3533 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3535 Don't assume time_t can fit into int.
3536 * buffer.h (struct buffer.modtime): Now time_t, not int.
3537 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3538 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3540 Minor fixes for signed vs unsigned integers.
3541 * character.h (MAYBE_UNIFY_CHAR):
3542 * charset.c (maybe_unify_char):
3543 * keyboard.c (read_char, reorder_modifiers):
3544 XINT -> XFASTINT, since the integer must be nonnegative.
3545 * ftfont.c (ftfont_spec_pattern):
3546 * keymap.c (access_keymap, silly_event_symbol_error):
3547 XUINT -> XFASTINT, since the integer must be nonnegative.
3548 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3549 since it makes no difference and we prefer signed.
3550 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3551 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3554 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3556 * window.h (Fwindow_frame): Declare.
3558 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3560 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3561 (SPARE_MEMORY): Always define.
3562 (LARGE_REQUEST): Remove.
3563 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3565 2011-06-06 Martin Rudalics <rudalics@gmx.at>
3567 * lisp.h: Move EXFUNS for Fframe_root_window,
3568 Fframe_first_window and Fset_frame_selected_window to window.h.
3570 * window.h: Move EXFUNS for Fframe_root_window,
3571 Fframe_first_window and Fset_frame_selected_window here from
3574 * frame.c (Fwindow_frame, Fframe_first_window)
3575 (Fframe_root_window, Fframe_selected_window)
3576 (Fset_frame_selected_window): Move to window.c.
3577 (Factive_minibuffer_window): Move to minibuf.c.
3578 (Fother_visible_frames_p): New function.
3580 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3582 * window.c (decode_window, decode_any_window): Move up in code.
3583 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3584 (inhibit_frame_unsplittable): Remove unused variable.
3585 (Fwindow_buffer): Move up and rewrite doc-string.
3586 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3587 (Fwindow_prev): New functions.
3588 (Fwindow_frame): Move here from frame.c. Accept any window as
3590 (Fframe_root_window, Fframe_first_window)
3591 (Fframe_selected_window): Move here from frame.c. Accept frame
3592 or arbitrary window as argument. Update doc-strings.
3593 (Fminibuffer_window): Move up in code.
3594 (Fwindow_minibuffer_p): Move up in code and simplify.
3595 (Fset_frame_selected_window): Move here from frame.c.
3597 (Fselected_window, select_window, Fselect_window): Move up in
3598 code. Minor doc-string fixes.
3600 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3602 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3603 Do not assume that spare memory exists; that assumption is valid
3604 only if SYSTEM_MALLOC.
3605 (LARGE_REQUEST): New macro, so that the issue of large requests
3606 is separated from the issue of spare memory.
3608 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3610 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3613 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3615 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3618 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3620 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3622 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3624 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3625 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3627 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
3629 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3631 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
3633 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3634 (x_clipboard_manager_save): Add return value.
3635 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3637 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3638 Obey Vx_select_enable_clipboard_manager. Catch errors in
3639 x_clipboard_manager_save (Bug#8779).
3640 (Vx_select_enable_clipboard_manager): New variable.
3641 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
3643 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
3645 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3647 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3649 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3650 in the current matrix if keep_current_p is non-zero.
3652 2011-06-04 Eli Zaretskii <eliz@gnu.org>
3654 * bidi.c (bidi_level_of_next_char): Fix last change.
3656 2011-06-03 Eli Zaretskii <eliz@gnu.org>
3658 Support bidi reordering of text covered by display properties.
3660 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3661 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3662 (bidi_cache_search, bidi_cache_iterator_state)
3663 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3664 (bidi_level_of_next_char, bidi_move_to_visually_next):
3665 Support character positions inside a run of characters covered by a
3667 (bidi_paragraph_init, bidi_resolve_explicit_1)
3668 (bidi_level_of_next_char): Call bidi_fetch_char and
3669 bidi_fetch_char_advance instead of FETCH_CHAR and
3671 (bidi_init_it): Initialize new members.
3672 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3674 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3675 instead of using explicit *_CHAR codes.
3676 (bidi_resolve_explicit, bidi_resolve_weak):
3677 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
3678 bidirectional text is supported only in multibyte buffers.
3679 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3680 it to initialize the frame_window_p member of struct bidi_it.
3681 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3682 (bidi_resolve_explicit, bidi_resolve_weak)
3683 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3684 bidi_it->nchars is non-positive.
3685 (bidi_level_of_next_char): Don't try to lookup the cache for the
3686 next/previous character if nothing is cached there yet, or if we
3687 were just reseat()'ed to a new position.
3689 * xdisp.c (set_cursor_from_row): Set start and stop points
3690 according to the row's direction when priming the loop that looks
3691 for the glyph on which to display cursor.
3692 (single_display_spec_intangible_p): Function deleted.
3693 (display_prop_intangible_p): Reimplement to call
3694 handle_display_spec instead of single_display_spec_intangible_p.
3695 Accept 3 additional arguments needed by handle_display_spec.
3696 This fixes incorrect cursor motion across display property with complex
3697 values: lists, `(when COND...)' forms, etc.
3698 (single_display_spec_string_p): Support property values that are
3699 lists with the argument STRING its top-level element.
3700 (display_prop_string_p): Fix the condition for processing a
3701 property that is a list to be consistent with handle_display_spec.
3702 (handle_display_spec): New function, refactored from the
3703 last portion of handle_display_prop.
3704 (compute_display_string_pos): Accept additional argument
3705 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3706 value of a `display' property is a "replacing spec".
3707 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3708 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3709 the display property, but just return a value indicating whether
3710 the display property will replace the characters it covers.
3711 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3712 frame_window_p members of struct bidi_it.
3713 (compute_display_string_pos, compute_display_string_end):
3715 (push_it): Accept second argument POSITION, where pop_it should
3716 jump to continue iteration.
3717 (reseat_1): Initialize bidi_it.disp_pos.
3719 * keyboard.c (adjust_point_for_property): Adjust the call to
3720 display_prop_intangible_p to its new signature.
3722 * dispextern.h (struct bidi_it): New member frame_window_p.
3723 (bidi_init_it): Update prototypes.
3724 (display_prop_intangible_p): Update prototype.
3725 (compute_display_string_pos, compute_display_string_end):
3727 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3730 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
3732 Malloc failure behavior now depends on size of allocation.
3733 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3734 * lisp.h: Change signatures accordingly.
3735 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3736 All callers changed. (Bug#8762)
3738 * gnutls.c: Use Emacs's memory allocators.
3739 Without this change, the gnutls library would invoke malloc etc.
3740 directly, which causes problems on non-SYNC_INPUT hosts, and which
3741 runs afoul of improving memory_full behavior. (Bug#8761)
3742 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3743 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3744 xfree instead of the default malloc, realloc, free.
3745 (Fgnutls_boot): No need to check for memory allocation failure,
3746 since xmalloc does that for us.
3748 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3749 * category.c (hash_get_category_set):
3750 * ccl.c (ccl_driver):
3751 * charset.c (Fdefine_charset_internal):
3752 * charset.h (struct charset.hash_index):
3753 * composite.c (get_composition_id, gstring_lookup_cache)
3754 (composition_gstring_put_cache):
3755 * composite.h (struct composition.hash_index):
3756 * dispextern.h (struct image.hash):
3757 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3758 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3759 (hashfn_equal, hashfn_user_defined, make_hash_table)
3760 (maybe_resize_hash_table, hash_lookup, hash_put)
3761 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3762 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3763 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3764 * image.c (make_image, search_image_cache, lookup_image)
3765 (xpm_put_color_table_h):
3766 * lisp.h (struct Lisp_Hash_Table):
3767 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3768 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3769 for hashes and hash indexes, instead of 'unsigned' and 'int'.
3770 * alloc.c (allocate_vectorlike):
3771 Check for overflow in vector size calculations.
3772 * ccl.c (ccl_driver):
3773 Check for overflow when converting EMACS_INT to int.
3774 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3775 need to be updated by these changes.
3776 * fns.c (make_hash_table, maybe_resize_hash_table):
3777 Check for integer overflow with large hash tables.
3778 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3779 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3780 (SXHASH_REDUCE): New macro.
3781 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3782 Use it instead of discarding useful hash info with large hash values.
3783 (sxhash_float): New function.
3784 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3785 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
3786 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3787 Rewrite to use FIXNUM_BITS, as this simplifies things.
3788 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3789 Adjust signatures to match updated version of code.
3790 (consing_since_gc): Now EMACS_INT, since a single hash table can
3791 use more than INT_MAX bytes.
3793 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3795 Make it possible to build with GCC-4.6+ -O2 -flto.
3797 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3799 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3801 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3802 Call minibuffer-inactive-mode.
3804 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
3806 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3807 Update dependencies.
3809 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3811 * data.c (init_data): Remove code for UTS, this system is not
3814 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3816 Don't force ./temacs to start in terminal mode.
3818 * frame.c (make_initial_frame): Initialize faces in all cases, not
3819 only when CANNOT_DUMP is defined.
3820 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3822 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3824 * dispnew.c (add_window_display_history): Use const for the string
3825 pointer. Remove declaration, not needed.
3827 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3829 Use 'inline', not 'INLINE'.
3830 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
3831 * alloc.c, fontset.c (INLINE): Remove.
3832 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3833 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3834 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3835 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3836 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3838 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3840 Make it possible to run ./temacs.
3842 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3843 syms_of_callproc does the same thing. Remove test for
3844 "initialized", do it in the caller.
3845 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3847 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3849 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3850 (read_minibuf): Use get_minibuffer.
3851 (syms_of_minibuf): Use DEFSYM.
3852 (Qmetadata): New var.
3853 * data.c (Qbuffer): Don't make it static.
3854 (syms_of_data): Use DEFSYM.
3856 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3858 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3859 (CCL_CODE_MIN): New macro.
3861 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3863 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3865 * eval.c (Qdebug): Now static.
3866 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3867 2011-04-26 change (bzr 104015) that inadvertently undid part of
3868 the 2011-04-14 change (bzr 103913).
3870 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3872 * image.c: Various fixes to ImageMagick code comments.
3873 (Fimagemagick_types): Doc fix.
3875 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3877 Minor fixes prompted by GCC 4.6.0 warnings.
3879 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3881 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3882 (x_clipboard_manager_save_all): Move extern decl to ...
3883 * xterm.h: ... here, so that it can be checked for consistency.
3885 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3887 * xselect.c (x_clipboard_manager_save_frame)
3888 (x_clipboard_manager_save_all): New functions.
3889 (Fx_clipboard_manager_save): Lisp function deleted.
3891 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3892 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3894 * xterm.h: Update prototype.
3896 2011-05-28 William Xu <william.xwl@gmail.com>
3898 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3901 2011-05-28 Jim Meyering <meyering@redhat.com>
3903 Avoid a sign-extension bug in crypto_hash_function.
3904 * fns.c (to_uchar): Define.
3905 (crypto_hash_function): Use it to convert some newly-signed
3906 variables to unsigned, to avoid sign-extension bugs. For example,
3907 without this change, (md5 "truc") would evaluate to
3908 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3909 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
3910 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3912 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3914 Integer overflow fixes.
3916 * dbusbind.c: Serial number integer overflow fixes.
3917 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
3918 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3919 to hold a serial number that is too large for a fixnum.
3920 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3921 Check for serial numbers out of range. Decode any serial number
3922 that was so large that it became a float. (Bug#8722)
3924 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3925 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3926 Use XFASTINT rather than XUINT when numbers are nonnegative.
3927 (xd_append_arg, Fdbus_method_return_internal):
3928 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3929 arguments, check that Lisp number is nonnegative, rather than
3930 silently wrapping negative numbers around. (Bug#8722)
3931 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
3934 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3936 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3938 ccl: add integer overflow checks
3939 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3940 (IN_INT_RANGE): New macros.
3941 (ccl_driver): Use them to check for integer overflow when
3942 decoding a CCL program. Many of the new checks are whether XINT (x)
3943 fits in int; it doesn't always, on 64-bit hosts. The new version
3944 doesn't catch all possible integer overflows, but it's an
3945 improvement. (Bug#8719)
3947 * alloc.c (make_event_array): Use XINT, not XUINT.
3948 There's no need for unsigned here.
3950 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3951 This follows up to the 2011-05-06 change that substituted uintptr_t
3952 for EMACS_INT. This case wasn't caught back then.
3954 Rework Fformat to avoid integer overflow issues.
3955 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3956 now (part of C89). Include <verify.h>.
3957 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3958 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3959 (Fformat): Avoid the prepass trying to compute sizes; it was only
3960 approximate and thus did not catch overflow reliably. Instead, walk
3961 through the format just once, formatting and computing sizes as we go,
3962 checking for integer overflow at every step, and allocating a larger
3963 buffer as needed. Keep track separately whether the format is
3964 multibyte. Keep only the most-recently calculated precision, rather
3965 than them all. Record whether each argument has been converted to
3966 string. Use EMACS_INT, not int, for byte and char and arg counts.
3967 Support field widths and precisions larger than INT_MAX. Avoid
3968 sprintf's undefined behavior with conversion specifications such as %#d
3969 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3970 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3971 formatting out-of-range floating point numbers with int
3974 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3976 * data.c: Avoid integer truncation in expressions involving floats.
3977 * data.c: Include <intprops.h>.
3978 (arith_driver): When there's an integer overflow in an expression
3979 involving floating point, convert the integers to floating point
3980 so that the resulting value does not suffer from catastrophic
3981 integer truncation. For example, on a 64-bit host (* 4
3982 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3983 Do not rely on undefined behavior after integer overflow.
3985 merge count_size_as_multibyte, parse_str_to_multibyte
3986 * character.c, character.h (count_size_as_multibyte):
3987 Rename from parse_str_to_multibyte; all uses changed.
3988 Check for integer overflow.
3989 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3990 since it's now a duplicate of the other. This is more of
3991 a character than a buffer op, so better that it's in character.c.
3992 * fns.c, print.c: Adjust to above changes.
3994 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3996 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3998 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4000 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4001 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4002 (x_clipboard_manager_save): Now static.
4003 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4005 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4006 (crypto_hash_function): Now static.
4007 Fix pointer signedness problems. Avoid unnecessary initializations.
4009 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
4011 * termhooks.h (Vselection_alist): Make it terminal-local.
4013 * terminal.c (create_terminal): Initialize it.
4015 * xselect.c: Support for clipboard managers.
4016 (Vselection_alist): Move to termhooks.h as terminal-local var.
4017 (LOCAL_SELECTION): New macro.
4018 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4019 (symbol_to_x_atom): Remove gratuitous arg.
4020 (x_handle_selection_request, lisp_data_to_selection_data)
4021 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
4022 (x_own_selection, x_get_local_selection, x_convert_selection):
4023 New arg, specifying work frame. Use terminal-local Vselection_alist.
4024 (some_frame_on_display): Delete unused function.
4025 (Fx_own_selection_internal, Fx_get_selection_internal)
4026 (Fx_disown_selection_internal, Fx_selection_owner_p)
4027 (Fx_selection_exists_p): New optional frame arg.
4028 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4029 (x_handle_selection_clear): Don't treat other terminals with the
4030 same keyboard specially. Use the terminal-local Vselection_alist.
4031 (x_clear_frame_selections): Use Frun_hook_with_args.
4033 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4035 * xterm.h: Add support for those atoms.
4037 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
4039 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4040 (converted_selections, conversion_fail_tag): New global variables.
4041 (x_selection_request_lisp_error): Free the above.
4042 (x_get_local_selection): Remove unnecessary code.
4043 (x_reply_selection_request): Args changed; handle arbitrary array
4044 of converted selections stored in converted_selections.
4045 Separate the XChangeProperty and SelectionNotify steps.
4046 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4047 (x_convert_selection): New function.
4048 (x_handle_selection_event): Simplify.
4049 (x_get_foreign_selection): Don't ignore incoming requests while
4050 waiting for an answer; this will fail when we implement
4051 SAVE_TARGETS, and seems unnecessary anyway.
4052 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4053 (Vx_sent_selection_functions): Doc fix.
4055 2011-05-26 Leo Liu <sdl.web@gmail.com>
4057 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4059 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4061 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4063 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4064 for fringe update if it has periodic bitmap.
4065 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
4066 and fringe_bitmap_periodic_p.
4068 * fringe.c (get_fringe_bitmap_data): New function.
4069 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4070 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4071 row. Mark glyph row for fringe update if periodicity changed.
4073 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4074 for fringe update unless it has periodic bitmap.
4076 2011-05-25 Kenichi Handa <handa@m17n.org>
4078 * xdisp.c (get_next_display_element): Set correct it->face_id for
4079 a static composition.
4081 2011-05-24 Leo Liu <sdl.web@gmail.com>
4084 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4086 * fns.c (crypto_hash_function, Fsha1): New function.
4087 (Fmd5): Use crypto_hash_function.
4088 (syms_of_fns): Add Ssha1.
4090 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4092 * gnutls.c: Remove unused macros.
4093 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4094 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4095 Remove macros that are defined and never used.
4096 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4098 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4100 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4101 (Fx_get_selection_internal): Minor cleanup.
4102 (Fx_own_selection_internal): Rename arguments for consistency with
4105 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4107 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4109 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4111 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4113 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4115 * dispnew.c (scrolling_window): Don't exclude the case that the
4116 last enabled row in the desired matrix touches the bottom boundary.
4118 2011-05-21 Glenn Morris <rgm@gnu.org>
4120 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
4121 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4122 and add some more files.
4124 2011-05-20 Eli Zaretskii <eliz@gnu.org>
4126 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4127 report_file_error introduced by the change from 2011-05-07.
4129 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4131 * systime.h (Time): Define only if emacs is defined.
4132 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4133 where the include path doesn't have X11/X.h by default. See
4134 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4136 2011-05-20 Kenichi Handa <handa@m17n.org>
4138 * composite.c (find_automatic_composition): Fix previous change.
4140 2011-05-20 Glenn Morris <rgm@gnu.org>
4142 * lisp.mk: New file, split from Makefile.in.
4143 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4144 (shortlisp): Remove.
4145 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4147 2011-05-19 Glenn Morris <rgm@gnu.org>
4149 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4150 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4151 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4152 (lisp): Set the order to that of loadup.el.
4153 (shortlisp): Make it a copy of $lisp.
4154 (SOME_MACHINE_LISP): Remove.
4155 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4156 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4158 2011-05-18 Kenichi Handa <handa@m17n.org>
4160 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4161 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4162 (find_automatic_composition): Mostly rewrite for efficiency.
4164 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
4166 * makefile.w32-in: Update dependencies.
4168 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4170 * menu.c: Include limits.h (fixes the MS-Windows build broken by
4173 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
4175 Fix some integer overflow issues, such as string length overflow.
4177 * insdel.c (count_size_as_multibyte): Check for string overflow.
4179 * character.c (lisp_string_width): Check for string overflow.
4180 Use EMACS_INT, not int, for string indexes and lengths; in
4181 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4182 the resulting string length overflows an EMACS_INT; instead,
4183 report a string overflow if no precision given. When checking for
4184 precision exhaustion, use a check that cannot possibly have
4185 integer overflow. (Bug#8675)
4186 * character.h (lisp_string_width): Adjust to new signature.
4188 * alloc.c (string_overflow): New function.
4189 (Fmake_string): Use it. This doesn't change behavior, but saves
4190 a few bytes and will simplify future changes.
4191 * character.c (string_escape_byte8): Likewise.
4192 * lisp.h (string_overflow): New decl.
4194 Fixups, following up to the user-interface timestamp change.
4195 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4196 for UI timestamps, instead of unsigned long.
4197 * msdos.c (mouse_get_pos): Likewise.
4198 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
4199 * w32gui.h (Time): Define by including "systime.h" rather than by
4200 declaring it ourselves. (Bug#8664)
4202 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4203 * image.c (clear_image_cache): Likewise.
4205 * term.c (term_mouse_position): Don't assume time_t wraparound.
4207 Be more systematic about user-interface timestamps.
4208 Before, the code sometimes used 'Time', sometimes 'unsigned long',
4209 and sometimes 'EMACS_UINT', to represent these timestamps.
4210 This change causes it to use 'Time' uniformly, as that's what X uses.
4211 This makes the code easier to follow, and makes it easier to catch
4212 integer overflow bugs such as Bug#8664.
4213 * frame.c (Fmouse_position, Fmouse_pixel_position):
4214 Use Time, not unsigned long, for user-interface timestamps.
4215 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4216 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4217 * keyboard.h (last_event_timestamp): Likewise.
4218 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4219 * menu.h (xmenu_show): Likewise.
4220 * term.c (term_mouse_position): Likewise.
4221 * termhooks.h (struct input_event.timestamp): Likewise.
4222 (struct terminal.mouse_position_hook): Likewise.
4223 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4224 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4225 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4226 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4228 * menu.h, termhooks.h: Include "systime.h", for Time.
4230 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4231 Don't assume that the difference between two unsigned long values
4232 can fit into an integer. At this point, we know button_down_time
4233 <= event->timestamp, so the difference must be nonnegative, so
4234 there's no need to cast the result if double-click-time is
4235 nonnegative, as it should be; check that it's nonnegative, just in
4236 case. This bug is triggered when events are more than 2**31 ms
4237 apart (about 25 days). (Bug#8664)
4239 * xselect.c (last_event_timestamp): Remove duplicate decl.
4240 (x_own_selection): Remove needless cast to unsigned long.
4242 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4243 that always fit in int. Use a sentinel instead of a counter, to
4244 avoid a temp and to allay GCC's concerns about possible int overflow.
4245 * frame.h (struct frame): Use int for menu_bar_items_used
4246 instead of EMACS_INT, since it always fits in int.
4248 * menu.c (grow_menu_items): Check for int overflow.
4250 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4252 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4253 Before, the code was not consistent. These values cannot exceed
4254 2**31 - 1 so there's no need to make them unsigned.
4255 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4256 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4257 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4259 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4261 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4262 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4263 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4264 presumably because the widths might not match.
4266 * window.c (size_window): Avoid needless test at loop start.
4268 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4270 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4272 2011-05-12 Drew Adams <drew.adams@oracle.com>
4274 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4276 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4278 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4279 `width' to `bar_area_x' and `bar_area_width', respectively.
4280 (x_scroll_run): Take account of fringe background extension.
4282 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4283 Rename local vars `left' and `width' to `bar_area_x' and
4284 `bar_area_width', respectively.
4285 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4286 background extension.
4288 2011-05-10 Jim Meyering <meyering@redhat.com>
4290 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4292 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
4294 * image.c (Finit_image_library): Return t for built-in image types,
4295 like pbm and xbm. (Bug#8640)
4297 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4299 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4301 2011-05-07 Eli Zaretskii <eliz@gnu.org>
4303 * w32console.c (Fset_screen_color): Doc fix.
4304 (Fget_screen_color): New function.
4305 (syms_of_ntterm): Defsubr it.
4307 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4308 unlink the temporary file if Fcall_process didn't create it in the
4310 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4311 child process will be redirected to a file specified with `:file'.
4312 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4313 cue to call_process_cleanup not to close that handle.
4315 2011-05-07 Ben Key <bkey76@gmail.com>
4317 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4318 one of two shell specific rules, either bootstrap-temacs-CMD or
4319 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4320 to the previous implementation of the bootstrap-temacs rule.
4321 The bootstrap-temacs-CMD rule is similar to the previous
4322 implementation of the bootstrap-temacs rule except that it
4323 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4326 These changes, along with some changes to nt/configure.bat,
4327 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4328 earlier fix to add support for --cflags and --ldflags options
4329 that include quotes so that it works whether make uses cmd or
4332 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
4334 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4335 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4337 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4338 a string. Handle both cases.
4339 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4340 (Fdbus_register_method): Use Qinvalid_function.
4342 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4344 * makefile.w32-in: Update dependencies.
4345 (LISP_H): Add inttypes.h and stdin.h.
4346 (PROCESS_H): Add unistd.h.
4348 2011-05-06 Eli Zaretskii <eliz@gnu.org>
4350 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4353 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
4355 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4357 * term.c (vfatal): Remove stray call to va_end.
4358 It's not needed and the C Standard doesn't allow it here anyway.
4360 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4361 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4363 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4366 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4368 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4370 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4372 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4374 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4376 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4377 * charset.c (Fdefine_charset_internal): Don't initialize
4378 charset.code_space[15]. The value was garbage, on hosts with
4379 32-bit int (Bug#8600).
4381 * lread.c (read_integer): Be more consistent with string-to-number.
4382 Use string_to_number to do the actual conversion; this avoids
4383 rounding errors and fixes some other screwups. Without this fix,
4384 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4385 (digit_to_number): Move earlier, for benefit of read_integer.
4386 Return -1 if the digit is out of range for the base, -2 if it is
4387 not a digit in any supported base. (Bug#8602)
4389 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4391 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4392 to match comment at start of function. This also removes a
4393 GCC warning about overflow in a 32+64-bit port.
4395 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4397 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4398 Reported by Stefan Monnier in
4399 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
4400 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4401 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
4403 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4404 (EMACS_UINTPTR): Likewise, with uintptr_t.
4406 * lisp.h: Prefer 64-bit EMACS_INT if available.
4407 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4408 on 32-bit hosts that have 64-bit int, so that they can access
4410 However, temporarily disable this change unless the temporary
4411 symbol WIDE_EMACS_INT is defined.
4413 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4415 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4416 This removes an assumption that EMACS_INT and long are the same
4417 width as pointers. The assumption is true for Emacs porting targets
4418 now, but we want to make other targets possible.
4419 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4420 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4421 In the rest of the code, change types of integers that hold casted
4422 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4423 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4424 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4425 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4426 No need to cast type when ORing.
4427 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4428 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4429 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4430 assume EMACS_INT is the same width as char *.
4431 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4432 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4433 Remove no-longer-needed casts.
4434 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4435 (xg_tool_bar_help_callback, xg_make_tool_item):
4436 Use EMACS_INTPTR to hold an integer
4437 that will be cast to void *; this can avoid a GCC warning
4438 if EMACS_INT is not the same width as void *.
4439 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4440 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4441 (current_message_1, set_message_1):
4442 Use a local to convert to proper width without a cast.
4443 * xmenu.c (dialog_selection_callback): Likewise.
4445 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4446 Also, don't assume VALBITS / RAND_BITS is less than 5,
4447 and don't rely on undefined behavior when shifting a 1 left into
4449 * lisp.h (get_random): Change signature to match.
4451 * lread.c (hash_string): Use size_t, not int, for hash computation.
4452 Normally we prefer signed values; but hashing is special, because
4453 it's better to use unsigned division on hash table sizes so that
4454 the remainder is nonnegative. Also, size_t is the natural width
4455 for hashing into memory. The previous code used 'int', which doesn't
4456 retain enough info to hash well into very large tables.
4457 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4459 * dbusbind.c: Don't possibly lose pointer info when converting.
4460 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4461 Use XPNTR rather than XHASH, so that the high-order bits of
4462 the pointer aren't lost when converting through void *.
4464 * eval.c (Fautoload): Don't double-shift a pointer.
4466 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4468 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4470 * gnutls.c (DEF_GNUTLS_FN):
4471 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4473 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4475 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4478 2011-05-05 Eli Zaretskii <eliz@gnu.org>
4480 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4481 New version that can reserve upto 2GB of heap space.
4483 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
4485 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4487 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4489 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4490 `gnutls_certificate_set_x509_key_file'.
4492 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
4494 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4495 Update dependencies.
4497 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4499 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4500 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4501 Remove unused parameter `fildes'.
4502 * process.c (read_process_output, send_process): Don't pass it.
4504 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4506 Fix previous change: the library cache is defined in w32.c.
4507 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4508 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4510 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4512 Implement dynamic loading of GnuTLS on Windows.
4514 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4515 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4516 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4519 * gnutls.c (Qgnutls_dll): Define.
4520 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4521 (gnutls_*): Declare function pointers.
4522 (init_gnutls_functions): New function to initialize function pointers.
4523 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4524 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4525 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4526 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4527 (emacs_gnutls_write, emacs_gnutls_read)
4528 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4529 (Fgnutls_available_p): New function.
4530 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4531 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4532 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4534 * image.c: Include w32.h.
4535 (Vimage_type_cache): Delete.
4536 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4537 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4538 (w32_delayed_load): Move to w32.c.
4540 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4542 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4543 (w32_delayed_load): Move from image.c. When loading a library, record
4544 its filename in the :loaded-from property of the library id.
4545 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4546 Initialize and staticpro them.
4547 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4549 * process.c: Include lisp.h before w32.h, not after.
4550 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4551 instead of gnutls_record_check_pending.
4553 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4555 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4557 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4558 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4561 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4563 * xterm.c (x_set_frame_alpha): Do not set property on anything
4564 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4566 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4568 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4570 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4572 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4573 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4574 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4575 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4576 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4577 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4578 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4579 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4580 (Qgnutls_bootprop_callbacks_verify): Make static.
4582 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4584 * callproc.c: Indentation fixup.
4586 * sysdep.c (wait_for_termination_1): Make static.
4587 (wait_for_termination, interruptible_wait_for_termination):
4588 Move after wait_for_termination_1.
4590 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4592 * sysdep.c (interruptible_wait_for_termination): New function
4593 which is like wait_for_termination, but allows keyboard
4596 * callproc.c (Fcall_process): Add (:file "file") as an option for
4598 (Fcall_process_region): Ditto.
4600 2011-04-30 Eli Zaretskii <eliz@gnu.org>
4602 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4603 rather than `XVECTOR (FOO)->size'.
4605 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4606 inttypes.h, as a gnulib replacement is used if it not available in
4609 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4611 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4612 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4613 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4615 * coding.c (coding_alloc_by_realloc): Error out if destination
4616 will grow beyond MOST_POSITIVE_FIXNUM.
4617 (decode_coding_emacs_mule): Abort if there isn't enough place in
4618 charbuf for the composition carryover bytes. Reserve an extra
4619 space for up to 2 characters produced in a loop.
4620 (decode_coding_iso_2022): Abort if there isn't enough place in
4621 charbuf for the composition carryover bytes.
4623 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4625 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4626 aborting when %lld or %lll format is passed.
4627 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4628 %llo or %llx format is passed. (Bug#8545)
4630 * window.c (window_scroll_line_based): Use a marker instead of
4631 simple variables to record original value of point. (Bug#7952)
4633 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4634 produced by %s or %c overflows available buffer space. (Bug#8545)
4636 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4638 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
4639 (SIZE_MAX): Move defn after all includes, as they might #define it.
4641 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4643 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4645 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4647 * keyboard.c (Qdelayed_warnings_hook): Define.
4648 (command_loop_1): Run `delayed-warnings-hook'
4649 if Vdelayed_warnings_list is non-nil.
4650 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4651 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4653 2011-04-28 Eli Zaretskii <eliz@gnu.org>
4655 * doprnt.c (doprnt): Don't return value smaller than the buffer
4656 size if the message was truncated. (Bug#8545).
4658 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4660 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4661 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4663 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4665 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4667 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
4669 * makefile.w32-in: Update dependencies.
4671 2011-04-27 Eli Zaretskii <eliz@gnu.org>
4673 Improve `doprnt' and its usage. (Bug#8545)
4674 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4675 `format_end'. Remove support for %l as a conversion specifier.
4676 Don't use xrealloc. Improve diagnostics when the %l size modifier
4677 is used. Update the commentary.
4679 * eval.c (verror): Simplify calculation of size_t.
4681 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4684 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4686 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4689 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4691 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4692 This makes this file independent of the recent pseudovector change.
4694 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
4696 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4698 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
4699 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
4700 Remove unused local.
4701 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
4703 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
4704 GCC 4.6.0 optimizes based on type-based alias analysis.
4705 For example, if b is of type struct buffer * and v of type struct
4706 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4707 != &v->size, and therefore "v->size = 1; b->size = 2; return
4708 v->size;" must therefore return 1. This assumption is incorrect
4709 for Emacs, since it type-puns struct Lisp_Vector * with many other
4710 types. To fix this problem, this patch adds a new type struct
4711 vectorlike_header that documents the constraints on layout of vectors
4712 and pseudovectors, and helps optimizing compilers not get fooled
4713 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4714 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
4715 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4717 (XSETPVECTYPE): Rewrite in terms of new macro.
4718 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4719 This is a bit clearer, and further avoids the possibility of
4720 undesirable aliasing.
4721 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
4722 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
4723 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4724 since Lisp_Subr is a special case (no "next" field).
4725 (ASIZE): Now uses header.size rather than size.
4726 All previous uses of XVECTOR (foo)->size replaced to use this macro,
4727 to avoid the hassle of writing XVECTOR (foo)->header.size.
4728 (struct vectorlike_header): New type.
4729 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4730 object, to help avoid aliasing.
4731 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4732 (SUBRP): Likewise, since Lisp_Subr is a special case.
4733 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4734 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4735 (struct Lisp_Hash_Table): Combine first two members into a single
4736 struct vectorlike_header member. All uses of "size" and "next" members
4737 changed to be "header.size" and "header.next".
4738 * buffer.h (struct buffer): Likewise.
4739 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4740 * frame.h (struct frame): Likewise.
4741 * process.h (struct Lisp_Process): Likewise.
4742 * termhooks.h (struct terminal): Likewise.
4743 * window.c (struct save_window_data, struct saved_window): Likewise.
4744 * window.h (struct window): Likewise.
4745 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4746 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4747 * buffer.c (init_buffer_once): Likewise.
4748 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4750 * process.c (Fformat_network_address): Use local var for size,
4753 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4755 Make the Lisp reader and string-to-float more consistent (Bug#8525)
4756 * data.c (atof): Remove decl; no longer used or needed.
4757 (digit_to_number): Move to lread.c.
4758 (Fstring_to_number): Use new string_to_number function, to be
4759 consistent with how the Lisp reader treats infinities and NaNs.
4760 Do not assume that floating-point numbers represent EMACS_INT
4761 without losing information; this is not true on most 64-bit hosts.
4762 Avoid double-rounding errors, by insisting on integers when
4763 parsing non-base-10 numbers, as the documentation specifies.
4764 * lisp.h (string_to_number): New decl, replacing ...
4765 (isfloat_string): Remove.
4766 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
4767 (read1): Do not accept +. and -. as integers; this
4768 appears to have been a coding error. Similarly, do not accept
4769 strings like +-1e0 as floating point numbers. Do not report
4770 overflow for integer overflows unless the base is not 10 which
4771 means we have no simple and reliable way to continue.
4772 Break out the floating-point parsing into a new
4773 function string_to_number, so that Fstring_to_number parses
4774 floating point numbers consistently with the Lisp reader.
4775 (digit_to_number): Move here from data.c. Make it static inline.
4776 (E_CHAR, EXP_INT): Remove, replacing with ...
4777 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4778 (string_to_number): New function, replacing isfloat_string.
4779 This function checks for valid syntax and produces the resulting
4780 Lisp float number too. Rework it so that string-to-number
4781 no longer mishandles examples like "1.0e+". Use strtoumax,
4782 so that overflow for non-base-10 numbers is reported only when
4783 there's no portable and simple way to convert to floating point.
4785 * textprop.c (set_text_properties_1): Rewrite for clarity,
4786 and to avoid GCC warning about integer overflow.
4788 * intervals.h (struct interval): Use EMACS_INT for members
4789 where EMACS_UINT might cause problems. See
4790 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4791 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4792 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4794 (offset_intervals): Tell GCC not to worry about length overflow
4795 when negating a negative length.
4797 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4798 (overrun_check_free): Likewise.
4800 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4801 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4804 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4805 (gnutls_make_error): Rename local to avoid shadowing.
4806 (gnutls_emacs_global_deinit): ifdef out; not used.
4807 (Fgnutls_boot): Use const for pointer to readonly storage.
4808 Comment out unused local. Fix pointer signedness problems.
4810 * lread.c (openp): Don't stuff size_t into an 'int'.
4811 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4812 about possible signed overflow.
4814 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4815 (GDK_KEY_g): Don't define if already defined.
4816 (xg_prepare_tooltip): Avoid pointer signedness problem.
4817 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4819 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4820 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4822 * xfns.c (Fx_window_property): Simplify a bit,
4823 to make a bit faster and to avoid GCC 4.6.0 warning.
4824 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4826 * fns.c (internal_equal): Don't assume size_t fits in int.
4828 * alloc.c (compact_small_strings): Tighten assertion a little.
4830 Replace pEd with more-general pI, and fix some printf arg casts.
4831 * lisp.h (pI): New macro, generalizing old pEd macro to other
4832 conversion specifiers. For example, use "...%"pI"d..." rather
4833 than "...%"pEd"...".
4834 (pEd): Remove. All uses replaced with similar uses of pI.
4835 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4836 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4837 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4838 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4839 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4840 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4841 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4843 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4844 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4845 * print.c (safe_debug_print, print_object): Likewise.
4846 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4848 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4849 avoiding the 0 flag, which is not portable.
4850 * process.c (Fmake_network_process): Use pI to avoid cast.
4851 * region-cache.c (pp_cache): Likewise.
4852 * xdisp.c (decode_mode_spec): Likewise.
4853 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4854 behavior on 64-bit hosts with printf arg.
4855 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
4856 (x_stop_queuing_selection_requests): Likewise.
4857 (x_get_window_property): Don't truncate byte count to an 'int'
4860 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4861 here, since it parses constructs like leading '-' and spaces,
4862 which are not wanted; and it overflows with large numbers.
4863 Instead, simply match F[0-9]+, which is what is wanted anyway.
4865 * alloc.c: Remove unportable assumptions about struct layout.
4866 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4867 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4868 (allocate_vectorlike, make_pure_vector): Use the new macros,
4869 plus offsetof, to remove unportable assumptions about struct layout.
4870 These assumptions hold on all porting targets that I know of, but
4871 they are not guaranteed, they're easy to remove, and removing them
4872 makes further changes easier.
4874 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4875 This doesn't fix a bug but makes the code clearer.
4876 (string_overrun_cookie): Now const. Use initializers that
4877 don't formally overflow signed char, to avoid warnings.
4878 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4879 can cause Emacs to crash when string overrun checking is enabled.
4880 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4881 multiple of sizeof (EMACS_INT); it need not be, if
4882 alignof(EMACS_INT) < sizeof (EMACS_INT).
4883 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
4885 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
4887 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4889 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4891 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
4892 supposed to be handshaking. (Bug#8556)
4893 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4895 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
4897 * lisp.h (Qdebug): List symbol.
4898 * eval.c (Qdebug): Restore global linkage.
4899 * keyboard.c (debug-on-event): New variable.
4900 (handle_user_signal): Break into debugger when debug-on-event
4901 matches the current signal symbol.
4903 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4905 * alloc.c (check_sblock, check_string_bytes)
4906 (check_string_free_list): Convert to standard C.
4908 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4910 * w32.c (emacs_gnutls_push): Fix typo.
4912 2011-04-25 Eli Zaretskii <eliz@gnu.org>
4914 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4915 "cast to pointer from integer of different size".
4917 Improve doprnt and its use in verror. (Bug#8545)
4918 * doprnt.c (doprnt): Document the set of format control sequences
4919 supported by the function. Use SAFE_ALLOCA instead of always
4922 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4923 is one byte too soon. Don't use xrealloc; instead xfree and
4926 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4928 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4931 * gnutls.c: Renamed global_initialized to
4932 gnutls_global_initialized. Added internals for the
4933 :verify-hostname-error, :verify-error, and :verify-flags
4934 parameters of `gnutls-boot' and documented those parameters in the
4935 docstring. Start callback support.
4936 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4937 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4938 on error. Return error code.
4939 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4940 (emacs_gnutls_read): Likewise.
4941 (Fgnutls_boot): Return handshake error code.
4942 (emacs_gnutls_handle_error): New function.
4943 (wsaerror_to_errno): Likewise.
4945 * w32.h (emacs_gnutls_pull): Add prototype.
4946 (emacs_gnutls_push): Likewise.
4948 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4949 (emacs_gnutls_push): Likewise.
4951 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4953 * process.c (wait_reading_process_output): Check if GnuTLS
4954 buffered some data internally if no FDs are set for TLS
4957 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4958 (LIBS): Link to USER_LIBS.
4959 ($(BLD)/gnutls.$(0)): New target.
4961 2011-04-24 Eli Zaretskii <eliz@gnu.org>
4963 * xdisp.c (handle_single_display_spec): Rename the
4964 display_replaced_before_p argument into display_replaced_p, to
4965 make it consistent with the commentary. Fix typos in the
4968 * textprop.c (syms_of_textprop): Remove dead code.
4969 (copy_text_properties): Delete obsolete commentary about an
4970 interface that was deleted long ago. Fix typos in the description
4973 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4974 to changes in oldXMenu/XMenu.h from 2011-04-16.
4975 <menu_help_message, prev_menu_help_message>: Constify.
4976 (IT_menu_make_room): menu->help_text is now `const char **';
4979 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4980 to changes in oldXMenu/XMenu.h from 2011-04-16.
4981 (struct XMenu): Declare `help_text' `const char **'.
4983 * xfaces.c <Qunspecified>: Make extern again.
4985 * syntax.c: Include sys/types.h before including regex.h, as
4988 * doc.c (get_doc_string): Improve the format passed to `error'.
4990 * doprnt.c (doprnt): Improve commentary.
4992 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4994 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4997 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4998 changes in globals.h immediately force recompilation.
4999 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5000 $(CURDIR)/s/ms-w32.h.
5001 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
5003 * character.c (Fchar_direction): Function deleted.
5004 (syms_of_character): Don't defsubr it.
5005 <char-direction-table>: Deleted.
5007 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5009 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5010 * doprnt.c: Include limits.h.
5011 (SIZE_MAX): New macro.
5012 (doprnt): Return a size_t value. 2nd arg is now size_t.
5013 Many local variables are now size_t instead of int or unsigned.
5014 Improve overflow protection. Support `l' modifier for integer
5015 conversions. Support %l conversion. Don't assume an EMACS_INT
5016 argument for integer conversions and for %c.
5018 * lisp.h (doprnt): Restore prototype.
5020 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5023 * Makefile.in (base_obj): Add back doprnt.o.
5025 * deps.mk (doprnt.o): Add back prerequisites.
5026 (callint.o): Depend on character.h.
5028 * eval.c (internal_lisp_condition_case): Include the handler
5029 representation in the error message.
5030 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5031 when breaking from the loop.
5033 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5035 * callint.c (Fcall_interactively): When displaying error message
5036 about invalid control letter, pass the character's codepoint, not
5037 a pointer to its multibyte form. Improve display of the character
5038 in octal and display also its hex code.
5040 * character.c (char_string): Use %x to display the (unsigned)
5041 codepoint of an invalid character, to avoid displaying a bogus
5044 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5045 `error', not SYMBOL_NAME itself.
5047 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5048 character arguments to `error'.
5050 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5051 to `error' in error message about FINAL_CHAR argument. Make sure
5052 FINAL_CHAR is a character, and use %c when it is passed as
5053 argument to `error'.
5055 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5057 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5059 * w32.c: Include <time.h>.
5060 (sys_localtime): New function.
5062 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
5064 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5066 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
5068 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
5070 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5073 2011-04-19 Eli Zaretskii <eliz@gnu.org>
5075 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5076 gl_state.e_property when gl_state.object is Qt.
5078 * insdel.c (make_gap_larger): Remove limitation of buffer size
5081 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
5083 * xdisp.c (lookup_glyphless_char_display)
5084 (produce_glyphless_glyph): Handle cons cell entry in
5085 glyphless-char-display.
5086 (Vglyphless_char_display): Document it.
5088 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5089 glyphless-char-display.
5091 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
5093 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5095 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5097 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5098 definition for no-X builds.
5100 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
5102 Static checks with GCC 4.6.0 and non-default toolkits.
5104 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5106 * process.c (keyboard_bit_set): Define only if SIGIO.
5107 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5108 (send_process): Repair possible setjmp clobbering.
5110 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5112 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5114 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5116 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5117 Define only if needed.
5119 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5120 by pacifying GCC about it. Maybe it's time to retire it?
5121 * xfaces.c (USG, __TIMEVAL__): Likewise.
5123 * dispextern.h (struct redisplay_interface): Rename param
5125 * termhooks.h (struct terminal): Likewise.
5126 * xterm.c (xembed_send_message): Likewise.
5128 * insdel.c (make_gap_smaller): Define only if
5129 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5131 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5134 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5135 so that we aren't warned about unused symbols.
5137 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5139 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
5141 * xfns.c (x_real_positions): Mark locals as initialized.
5143 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5145 * xterm.c: Fix problems found by static analysis with other toolkits.
5146 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
5147 (x_dispatch_event): Declare static if USE_GTK, and
5148 define if USE_GTK || USE_X_TOOLKIT.
5149 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
5150 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
5151 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5152 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
5154 * xmenu.c (menu_help_callback): Pointer type fixes.
5155 Use const pointers when pointing at readonly data. Avoid pointer
5157 (FALSE): Remove unused macro.
5158 (update_frame_menubar): Remove unused decl.
5160 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5162 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5163 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5164 (single_menu_item): Rename local to avoid shadowing.
5166 * keyboard.c (make_lispy_event): Remove unused local var.
5168 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5169 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5171 * bitmaps: Change bitmaps from unsigned char back to the X11
5172 compatible char. Avoid the old compiler warnings about
5173 out-of-range initializers by using, for example, '\xab' rather
5176 * xgselect.c (xgselect_initialize): Check vs interface
5177 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5179 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5181 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5182 to read-only memory.
5184 * fns.c (vector): Remove; this old hack is no longer needed.
5186 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
5188 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
5190 * xrdb.c (x_load_resources): Omit unused local.
5192 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
5193 (x_window): Rename locals to avoid shadowing.
5194 (USG): Use the kludged USG macro, to pacify gcc.
5196 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
5197 (x_term_init): Remove local to avoid shadowing.
5199 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
5201 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5202 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5204 2011-04-16 Eli Zaretskii <eliz@gnu.org>
5206 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5208 Fix regex.c, syntax.c and friends for buffers > 2GB.
5209 * syntax.h (struct gl_state_s): Declare character position members
5212 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5214 * textprop.c (verify_interval_modification, interval_of):
5215 Declare arguments EMACS_INT.
5217 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5220 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5222 * indent.c (Fvertical_motion): Local variable it_start is now
5225 * regex.c (re_match, re_match_2, re_match_2_internal)
5226 (bcmp_translate, regcomp, regexec, print_double_string)
5227 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5228 (re_compile_pattern, re_exec): Declare arguments and local
5229 variables `size_t' and `ssize_t' and return values `regoff_t', as
5231 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5232 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5233 <compile_stack_type>: `size' and `avail' are now `size_t'.
5235 * regex.h <regoff_t>: Use ssize_t, not int.
5236 (re_search, re_search_2, re_match, re_match_2): Arguments that
5237 specify buffer/string position and length are now ssize_t and
5238 size_t. Return type is regoff_t.
5240 2011-04-16 Ben Key <bkey76@gmail.com>
5242 * nsfont.m: Fixed bugs in ns_get_family and
5243 ns_descriptor_to_entity that were caused by using free to
5244 deallocate memory blocks that were allocated by xmalloc (via
5245 xstrdup). This caused Emacs to crash when compiled with
5246 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5247 --enable-checking=xmallocoverrun). xfree is now used to
5248 deallocate these memory blocks.
5250 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5252 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5254 emacs_write: Accept and return EMACS_INT for sizes.
5255 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5257 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5258 Accept and return EMACS_INT.
5259 (emacs_gnutls_write): Return the number of bytes written on
5261 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5262 (emacs_read, emacs_write): Remove check for negative size, as the
5263 Emacs source code has been audited now.
5264 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5265 (emacs_read, emacs_write): Use it.
5266 * process.c (send_process): Adjust to the new signatures of
5267 emacs_write and emacs_gnutls_write. Do not attempt to store
5268 a byte offset into an 'int'; it might overflow.
5269 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5271 * sound.c: Don't assume sizes fit in 'int'.
5272 (struct sound_device.period_size, alsa_period_size):
5273 Return EMACS_INT, not int.
5274 (struct sound_device.write, vox_write, alsa_write):
5275 Accept EMACS_INT, not int.
5276 (wav_play, au_play): Use EMACS_INT to store sizes and to
5277 record read return values.
5279 2011-04-15 Ben Key <bkey76@gmail.com>
5281 * keyboard.c (Qundefined): Don't declare static since it is used
5283 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5284 static since they are used in nsfont.m.
5286 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5288 * process.c (Qprocessp): Don't declare static.
5289 * lisp.h (Qprocessp): Declare again.
5291 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
5293 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5295 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5297 Improve C-level modularity by making more things 'static'.
5299 Don't publish debugger-only interfaces to other modules.
5300 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5301 (verify_bytepos, count_markers): Move decls to the only modules
5303 * region-cache.h (pp_cache): Likewise.
5304 * window.h (check_all_windows): Likewise.
5305 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5307 * sysdep.c (croak): Now static, if
5308 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5309 * syssignal.h (croak): Declare only if not static.
5311 * alloc.c (refill_memory_reserve): Now static if
5312 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5313 * lisp.h (refill_memory_reserve): Declare only if not static.
5315 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5316 Define only if USE_LUCID.
5318 * xrdb.c (x_customization_string, x_rm_string): Now static.
5320 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5321 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5323 * xdisp.c (draw_row_with_mouse_face): Now static.
5324 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5326 * window.h (check_all_windows): Mark externally visible.
5328 * window.c (window_deletion_count): Now static.
5330 * undo.c: Make symbols static if they're not exported.
5331 (last_undo_buffer, last_boundary_position, pending_boundary):
5334 * textprop.c (interval_insert_behind_hooks): Now static.
5335 (interval_insert_in_front_hooks): Likewise.
5337 * term.c: Make symbols static if they're not exported.
5338 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5339 (max_frame_lines, tty_set_terminal_modes):
5340 (tty_reset_terminal_modes, tty_turn_off_highlight):
5341 (get_tty_terminal): Now static.
5342 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5343 * termhooks.h (term_mouse_moveto): Do not declare if
5345 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5346 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5348 * sysdep.c: Make symbols static if they're not exported.
5349 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5351 (sigprocmask_set, full_mask): Remove; unused.
5352 (wait_debugging): Mark as visible.
5353 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5354 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5356 * syntax.c (syntax_temp): Define only if !__GNUC__.
5358 * sound.c (current_sound_device, current_sound): Now static.
5360 * search.c (searchbufs, searchbuf_head): Now static.
5362 * scroll.c (scroll_cost): Remove; unused.
5363 * dispextern.h (scroll_cost): Remove decl.
5365 * region-cache.h (pp_cache): Mark as externally visible.
5367 * process.c: Make symbols static if they're not exported.
5368 (process_tick, update_tick, create_process, chan_process):
5369 (Vprocess_alist, proc_buffered_char, datagram_access):
5370 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5371 (deactivate_process): Mark defn as static, as well as decl.
5372 * lisp.h (create_process): Remove decl.
5373 * process.h (chan_process, Vprocess_alist): Remove decls.
5375 * print.c: Make symbols static if they're not exported.
5376 (print_depth, new_backquote_output, being_printed, print_buffer):
5377 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5378 (print_interval, print_number_index, initial_stderr_stream):
5380 * lisp.h (Fprinc): Remove decl.
5381 (debug_output_compilation_hack): Mark as externally visible.
5383 * sysdep.c (croak): Move decl from here to syssignal.h.
5384 * syssignal.h (croak): Put it here, so the API can be checked when
5385 'croak' is called from dissociate_if_controlling_tty.
5387 * minibuf.c: Make symbols static if they're not exported.
5388 (minibuf_save_list, choose_minibuf_frame): Now static.
5389 * lisp.h (choose_minibuf_frame): Remove decl.
5391 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5393 * lread.c: Make symbols static if they're not exported.
5394 (read_objects, initial_obarray, oblookup_last_bucket_number):
5396 (make_symbol): Remove; unused.
5397 * lisp.h (initial_obarray, make_symbol): Remove decls.
5399 * keyboard.c: Make symbols static if they're not exported.
5400 (single_kboard, recent_keys_index, total_keys, recent_keys):
5401 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5402 (this_single_command_key_start, echoing, last_auto_save):
5403 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5404 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5405 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5406 (Vlispy_mouse_stem, double_click_count):
5408 (force_auto_save_soon): Define only if SIGDANGER.
5409 (ignore_mouse_drag_p): Now static if
5410 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5411 (print_help): Remove; unused.
5412 (stop_character, last_timer_event): Mark as externally visible.
5413 * keyboard.h (ignore_mouse_drag_p): Declare only if
5414 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5415 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5416 * lisp.h (echoing): Remove decl.
5417 (force_auto_save_soon): Declare only if SIGDANGER.
5418 * xdisp.c (redisplay_window): Simplify code, to make it more
5419 obvious that ignore_mouse_drag_p is not accessed if !defined
5420 USE_GTK && !defined HAVE_NS.
5422 * intervals.c: Make symbols static if they're not exported.
5423 (merge_properties_sticky, merge_interval_right, delete_interval):
5425 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5427 * insdel.c: Make symbols static if they're not exported.
5428 However, leave prepare_to_modify_buffer alone. It's never
5429 called from outside this function, but that appears to be a bug.
5430 (combine_after_change_list, combine_after_change_buffer):
5431 (adjust_after_replace, signal_before_change): Now static.
5432 (adjust_after_replace_noundo): Remove; unused.
5433 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
5434 (signal_before_change): Remove decls.
5436 * indent.c (val_compute_motion, val_vmotion): Now static.
5438 * image.c: Make symbols static if they're not exported.
5439 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5441 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5442 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5444 * fringe.c (standard_bitmaps): Now static.
5445 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5447 * frame.c: Make symbols static if they're not exported.
5448 (x_report_frame_params, make_terminal_frame): Now static.
5449 (get_frame_param): Now static, unless HAVE_NS.
5450 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5451 (x_get_resource_string): Remove; not used.
5452 * frame.h (make_terminal_frame, x_report_frame_params):
5453 (x_get_resource_string); Remove decls.
5454 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5455 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5457 * font.c, fontset.c: Make symbols static if they're not exported.
5458 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5459 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5460 * font.c (font_close_object): Now static.
5461 * font.h (font_close_object): Remove.
5462 * fontset.c (FONTSET_OBJLIST): Remove.
5463 (free_realized_fontset) #if-0 the body, which does nothing.
5464 (face_suitable_for_char_p): #if-0, as it's never called.
5465 * fontset.h (face_suitable_for_char_p): Remove decl.
5466 * xfaces.c (face_at_string_position):
5467 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5468 since 0 is always ASCII.
5470 * fns.c (weak_hash_tables): Now static.
5472 * fileio.c: Make symbols static if they're not exported.
5473 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5474 (Vwrite_region_annotation_buffers): Now static.
5476 * eval.c: Make symbols static if they're not exported.
5477 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5478 * lisp.h (backtrace_list): Remove decl.
5480 * emacs.c: Make symbols static if they're not exported.
5481 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5482 (fatal_error_code, fatal_error_signal_hook, standard_args):
5484 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5485 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5486 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5487 * lisp.h (fatal_error_signal_hook): Remove decl.
5488 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5490 * editfns.c: Move a (normally-unused) function to its only use.
5491 * editfns.c, lisp.h (get_operating_system_release): Remove.
5492 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5493 worth the hassle of breaking this out.
5495 * xterm.c: Make symbols static if they're not exported.
5496 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5497 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5498 (x_destroy_window, x_delete_display):
5500 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5501 (x_mouse_leave): Remove; unused.
5502 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5503 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5504 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5506 (x_mouse_leave): Declare only if WINDOWSNT.
5507 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5508 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5511 * ftxfont.c: Make symbols static if they're not exported.
5512 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5514 * font.h (ftxfont_driver): Likewise.
5516 * xfns.c: Make symbols static if they're not exported.
5517 (x_last_font_name, x_display_info_for_name):
5518 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5519 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5520 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5521 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5522 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5523 (last_show_tip_args): Now static.
5524 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5525 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5526 (x_screen_planes): Remove; unused.
5527 * dispextern.h (x_screen_planes): Remove decl.
5529 * dispnew.c: Make symbols static if they're not exported.
5530 * dispextern.h (redraw_garbaged_frames, scrolling):
5531 (increment_row_positions): Remove.
5532 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5533 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5535 (redraw_garbaged_frames): Remove; unused.
5537 * xfaces.c: Make symbols static if they're not exported.
5538 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5540 * xterm.h (defined_color): Remove decls.
5541 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5542 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5543 (menu_face_changed_default, defined_color, free_realized_face):
5544 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5545 (ascii_face_of_lisp_face): Remove; unused.
5547 * xdisp.c: Make symbols static if they're not exported.
5548 * dispextern.h (scratch_glyph_row, window_box_edges):
5549 (glyph_to_pixel_coords, set_cursor_from_row):
5550 (get_next_display_element, set_iterator_to_next):
5551 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5552 (show_mouse_face): Remove decls
5553 * frame.h (message_buf_print): Likewise.
5554 * lisp.h (pop_message, set_message, check_point_in_composition):
5556 * xterm.h (set_vertical_scroll_bar): Likewise.
5557 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5558 (message_buf_print, scratch_glyph_row, displayed_buffer):
5559 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5560 (get_next_display_element, show_mouse_face, window_box_edges):
5561 (frame_to_window_pixel_xy, check_point_in_composition):
5562 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5563 (glyph_to_pixel_coords): Remove; unused.
5565 * dired.c (file_name_completion): Now static.
5567 * dbusbind.c (xd_in_read_queued_messages): Now static.
5569 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5570 * data.c (circular_list_error): Remove.
5572 * commands.h (last_point_position, last_point_position_buffer):
5573 (last_point_position_window): Remove decls.
5574 * keyboard.c: Make these variables static.
5576 * coding.h (coding, code_convert_region, encode_coding_gap):
5578 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5579 (iso_code_class, detect_coding, code_convert_region): Now static.
5580 (encode_coding_gap): Remove; unused.
5582 * chartab.c (chartab_chars, chartab_bits): Now static.
5584 * charset.h (charset_iso_8859_1): Remove decl.
5585 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5588 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5589 * ccl.c (Vccl_program_table): Now static.
5590 (check_ccl_update): Remove; unused.
5592 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5593 * category.h: ... from here.
5594 * category.c (check_category_table, set_category_set): Now static.
5596 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5597 * lisp.h: Remove these decls.
5599 * buffer.c (buffer_count): Remove unused var.
5601 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5602 so that it's not optimized away.
5603 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5604 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5605 exported only to the debugger.
5607 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
5608 * atimer.h (run_all_atimers): Remove; not exported.
5610 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5611 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5612 was inaccessible from Lisp.
5613 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5614 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5616 alloc.c: Import and export fewer symbols, and remove unused items.
5617 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5619 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5620 it's not optimized away by whole-program optimization.
5621 (message_enable_multibyte, free_misc): Remove.
5622 (catchlist, handlerlist, mark_backtrace):
5623 Declare only if BYTE_MARK_STACK.
5624 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5625 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5626 (message_enable_multibyte): Remove decl.
5627 (free_misc, interval_free_list, float_block, float_block_index):
5628 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5629 (cons_free_list, last_marked_index):
5631 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5632 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5633 (mark_backtrace): Define only if BYTE_MARK_STACK.
5634 * xdisp.c (message_enable_multibyte): Now static.
5636 Declare Lisp_Object Q* variables to be 'static' if not exported.
5637 This makes it easier for human readers (and static analyzers)
5638 to see whether these variables are used from other modules.
5639 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5640 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5641 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5642 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5643 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5644 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5645 * xmenu.c, xselect.c:
5646 Declare Q* vars static if they are not used in other modules.
5647 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5648 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5649 Remove decls of unexported vars.
5650 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5652 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5654 Make Emacs functions such as Fatom 'static' by default.
5655 This makes it easier for human readers (and static analyzers)
5656 to see whether these functions can be called from other modules.
5657 DEFUN now defines a static function. To make the function external
5658 so that it can be used in other C modules, use the new macro DEFUE.
5659 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5660 (Finit_image_library):
5661 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5662 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5663 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5664 Remove decls, since these functions are now static.
5665 (Funintern, Fget_internal_run_time): New decls, since these functions
5666 were already external.
5668 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5669 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5670 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5671 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5672 * keyboard.c, keymap.c, lread.c:
5673 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5674 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5675 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5676 Mark functions with DEFUE instead of DEFUN,
5677 if they are used in other modules.
5678 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5679 decls for now-static functions.
5680 * buffer.h (Fdelete_overlay): Remove decl.
5681 * callproc.c (Fgetenv_internal): Mark as internal.
5682 * composite.c (Fremove_list_of_text_properties): Remove decl.
5683 (Fcomposition_get_gstring): New forward static decl.
5684 * composite.h (Fcomposite_get_gstring): Remove decl.
5685 * dired.c (Ffile_attributes): New forward static decl.
5686 * doc.c (Fdocumntation_property): New forward static decl.
5687 * eval.c (Ffetch_bytecode): New forward static decl.
5688 (Funintern): Remove extern decl; now in .h file where it belongs.
5689 * fileio.c (Fmake_symbolic_link): New forward static decl.
5690 * image.c (Finit_image_library): New forward static decl.
5691 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5692 * intervals.h (Fprevious_property_change):
5693 (Fremove_list_of_text_properties): Remove decls.
5694 * keyboard.c (Fthis_command_keys): Remove decl.
5695 (Fcommand_execute): New forward static decl.
5696 * keymap.c (Flookup_key): New forward static decl.
5697 (Fcopy_keymap): Now static.
5698 * keymap.h (Flookup_key): Remove decl.
5699 * process.c (Fget_process): New forward static decl.
5700 (Fprocess_datagram_address): Mark as internal.
5701 * syntax.c (Fsyntax_table_p): New forward static decl.
5702 (skip_chars): Remove duplicate decl.
5703 * textprop.c (Fprevious_property_change): New forward static decl.
5704 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5706 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5707 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5709 * editfns.c (Fformat): Remove unreachable code.
5711 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5713 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5716 2011-04-13 Eli Zaretskii <eliz@gnu.org>
5718 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5719 when at ZV. (Bug#8487)
5721 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5723 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5725 * keyboard.c (parse_tool_bar_item): Likewise.
5726 * sound.c (sound_cleanup, alsa_close): Likewise.
5727 * termcap.c (tgetent): Likewise.
5728 * xfns.c (x_default_font_parameter): Likewise.
5729 * xsettings.c (read_and_apply_settings): Likewise.
5731 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5732 (overrun_check_free): Protoize.
5734 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5736 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5737 since callers should never pass a negative size.
5738 Change the signature to match that of plain 'read' and 'write'; see
5739 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5740 * lisp.h: Update prototypes of emacs_write and emacs_read.
5742 2011-04-11 Eli Zaretskii <eliz@gnu.org>
5744 * xdisp.c (redisplay_window): Don't try to determine the character
5745 position of the scroll margin if the window start point w->startp
5746 is outside the buffer's accessible region. (Bug#8468)
5748 2011-04-10 Eli Zaretskii <eliz@gnu.org>
5750 Fix write-region and its subroutines for buffers > 2GB.
5751 * fileio.c (a_write, e_write): Modify declaration of arguments and
5752 local variables to support buffers larger than 2GB.
5753 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5755 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5756 argument, local variables, and return value.
5758 * lisp.h: Update prototypes of emacs_write and emacs_read.
5760 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5762 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
5764 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5766 Fix more problems found by GCC 4.6.0's static checks.
5768 * xdisp.c (vmessage): Use a better test for character truncation.
5770 * charset.c (load_charset_map): <, not <=, for optimization,
5771 and to avoid potential problems with integer overflow.
5772 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
5773 * casetab.c (set_identity, shuffle): Likewise.
5774 * editfns.c (Fformat): Likewise.
5775 * syntax.c (skip_chars): Likewise.
5777 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5778 This also lets GCC 4.6.0 generate slightly better loop code.
5780 * callint.c (Fcall_interactively): <, not <=, for optimization.
5781 (Fcall_interactively): Count the number of arguments produced,
5782 not the number of arguments given. This is simpler and lets GCC
5783 4.6.0 generate slightly better code.
5785 * ftfont.c: Distingish more carefully between FcChar8 and char.
5786 The previous code passed unsigned char * to a functions like
5787 strlen and xstrcasecmp that expect char *, which does not
5788 conform to the C standard.
5789 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5790 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5791 char * when the C standard requires it.
5793 * keyboard.c (read_char): Remove unused var.
5795 * eval.c: Port to Windows vsnprintf (Bug#8435).
5797 (SIZE_MAX): Define if the headers do not.
5798 (verror): Do not give up if vsnprintf returns a negative count.
5799 Instead, grow the buffer. This ports to Windows vsnprintf, which
5800 does not conform to C99. Problem reported by Eli Zaretskii.
5801 Also, simplify the allocation scheme, by avoiding the need for
5802 calling realloc, and removing the ALLOCATED variable.
5804 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5806 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5807 But keep the doprint source code for now, as we might revamp it
5808 and use it again (Bug#8435).
5809 * lisp.h (doprnt): Remove.
5810 * Makefile.in (base_obj): Remove doprnt.o.
5811 * deps.mk (doprnt.o): Remove.
5813 error: Print 32- and 64-bit integers portably (Bug#8435).
5814 Without this change, on typical 64-bit hosts error ("...%d...", N)
5815 was used to print both 32- and 64-bit integers N, which relied on
5817 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5819 * lisp.h (error, verror): Mark as printf-like functions.
5820 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5821 Report overflow in size calculations when allocating printf buffer.
5822 Do not truncate output string at its first null byte.
5823 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5824 Truncate the output at a character boundary, since vsnprintf does not
5826 * charset.c (check_iso_charset_parameter): Convert internal
5827 character to string before calling 'error', since %c now has the
5829 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5830 overflow when computing char to be passed to 'error'. Do not
5831 pass Lisp_Object to 'error'; pass the integer instead.
5832 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5833 formatted with plain %d.
5835 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5837 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5839 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5841 * xterm.c (x_catch_errors): Remove duplicate declaration.
5843 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5845 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5847 2011-04-10 Jim Meyering <meyering@redhat.com>
5849 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5850 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5851 return ssize_t not "int", and use size_t as the buffer length.
5852 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5853 * gnutls.h: Update declarations.
5854 * process.c (read_process_output): Use ssize_t, to match.
5855 (send_process): Likewise.
5857 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5859 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5861 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5863 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5864 Use unsigned char, to match FcChar8 type definition.
5866 * xterm.c (handle_one_xevent):
5867 * xmenu.c (create_and_show_popup_menu):
5868 * xselect.c (x_decline_selection_request)
5869 (x_reply_selection_request): Avoid type-punned deref of X events.
5871 2011-04-09 Eli Zaretskii <eliz@gnu.org>
5873 Fix some uses of `int' instead of EMACS_INT.
5874 * search.c (string_match_1, fast_string_match)
5875 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5876 (scan_buffer, find_next_newline_no_quit)
5877 (find_before_next_newline, search_command, Freplace_match)
5878 (Fmatch_data): Make some `int' variables be EMACS_INT.
5880 * xdisp.c (display_count_lines): 3rd argument and return value now
5881 EMACS_INT. All callers changed.
5882 (pint2hrstr): Last argument is now EMACS_INT.
5884 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5885 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5886 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5887 (decode_coding_utf_16, decode_coding_emacs_mule)
5888 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5889 (decode_coding_ccl, decode_coding_charset)
5890 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5891 (decode_coding_iso_2022, decode_coding_emacs_mule)
5892 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5893 <char_offset, last_offset>: Declare EMACS_INT.
5894 (encode_coding_utf_8, encode_coding_utf_16)
5895 (encode_coding_emacs_mule, encode_invocation_designation)
5896 (encode_designation_at_bol, encode_coding_iso_2022)
5897 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5898 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5900 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5901 (encode_invocation_designation): Last argument P_NCHARS is now
5903 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5904 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5906 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5909 * ccl.c (Fccl_execute_on_string): Declare some variables
5912 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
5914 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5916 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5918 * process.c (Fformat_network_address): Doc fix.
5920 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5922 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5924 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
5926 * keyboard.c (read_char): Call Lisp function help-form-show,
5927 instead of using internal_with_output_to_temp_buffer.
5928 (Qhelp_form_show): New var.
5929 (syms_of_keyboard): Use DEFSYM macro.
5931 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5933 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5935 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
5937 * process.c (Flist_processes): Remove to Lisp.
5938 (list_processes_1): Delete.
5940 2011-04-06 Eli Zaretskii <eliz@gnu.org>
5942 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5944 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5946 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
5948 Fix more problems found by GCC 4.6.0's static checks.
5950 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5952 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5954 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
5956 * xdisp.c (vmessage): Mark as a printf-like function.
5958 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5960 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5962 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5963 printf-like functions.
5964 (tiff_load): Add casts to remove these marks before passing them
5965 to system-supplied API.
5967 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5969 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5970 This avoids several warnings with gcc -Wstrict-overflow.
5971 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5972 directly, rather than having caller test rule sign. This avoids
5973 some unnecessary tests.
5974 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5975 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5976 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
5978 * xfont.c (xfont_text_extents): Remove var that was set but not used.
5979 (xfont_open): Avoid unnecessary tests.
5981 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5983 * composite.h, composite.c (composition_gstring_put_cache):
5984 Use EMACS_INT, not int, for length.
5986 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5987 breaking out part of COMPOSITION_DECODE_RULE.
5988 (COMPOSITION_DECODE_RULE): Use it.
5989 * composite.c (get_composition_id): Remove unused local vars,
5990 by using the new macro.
5992 * textprop.c (set_text_properties_1): Change while to do-while,
5993 since the condition is always true at first.
5995 * intervals.c (graft_intervals_into_buffer): Mark var as used.
5996 (interval_deletion_adjustment): Return unsigned value.
5999 * process.c (list_processes_1, create_pty, read_process_output):
6000 (exec_sentinel): Remove vars that were set but not used.
6001 (create_pty): Remove unnecessary "volatile"s.
6002 (Fnetwork_interface_info): Avoid possibility of int overflow.
6003 (read_process_output): Do adaptive read buffering even if carryover.
6004 (read_process_output): Simplify nbytes computation if buffered.
6006 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6008 * syntax.c (scan_words): Remove var that was set but not used.
6009 (update_syntax_table): Use unsigned instead of int.
6011 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
6012 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
6013 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
6015 * print.c (print_error_message): Avoid int overflow.
6017 * font.c (font_list_entities): Redo for clarity,
6018 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6020 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
6021 (font_score): Avoid potential overflow in diff calculation.
6023 * fns.c (substring_both): Remove var that is set but not used.
6024 (sxhash): Redo loop for clarity and to avoid wraparound warning.
6026 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6028 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6029 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6030 can always succeed if overflow has undefined behavior.
6032 * search.c (boyer_moore, wordify): Remove vars set but not used.
6033 (wordify): Omit three unnecessary tests.
6035 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6036 All callers changed. This avoids the need for an unused var.
6038 * casefiddle.c (casify_region): Remove var that is set but not used.
6040 * dired.c (file_name_completion): Remove var that is set but not used.
6042 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6044 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
6045 (Finsert_file_contents): Remove unnecessary code checking fd.
6047 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6048 Check for integer overflow on size calculations.
6050 * buffer.c (Fprevious_overlay_change): Remove var that is set
6053 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6054 Remove vars that are set but not used.
6055 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6056 (timer_check_2): Mark vars as initialized.
6058 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6060 * image.c (lookup_image): Remove var that is set but not used.
6061 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
6063 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6064 that are set but not used.
6066 * xfns.c (make_invisible_cursor): Don't return garbage
6067 if XCreateBitmapFromData fails (Bug#8410).
6069 * xselect.c (x_get_local_selection, x_handle_property_notify):
6070 Remove vars that are set but not used.
6072 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6073 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
6075 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6076 Remove var that is set but not used.
6077 (scroll_bar_windows_size): Now size_t, not int.
6078 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6081 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6082 (map_tty_color) [!defined MSDOS]: Likewise.
6084 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6086 * coding.c: Remove vars that are set but not used.
6087 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6088 All callers changed.
6089 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6090 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6091 (decode_coding_charset): Remove vars that are set but not used.
6093 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6094 that is set but not used.
6096 * print.c (print_object): Remove var that is set but not used.
6098 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
6099 The gnulib version avoids calling malloc in the usual case,
6100 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6101 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6102 * filelock.c (current_lock_owner): Likewise.
6103 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6104 * sysdep.c: Include allocator.h, careadlinkat.h.
6105 (emacs_no_realloc_allocator): New static constant.
6106 (emacs_readlink): New function.
6107 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6108 ../lib/careadlinkat.h.
6110 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6112 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6113 first non-nil return value).
6115 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6117 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6118 if not defined (Bug#8403).
6120 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6122 * xdisp.c (display_count_lines): Remove parameter `start',
6123 unused since revno:20537 (1998-01-01). All callers changed.
6124 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6125 unused since revno:87605 (2008-05-14). All callers changed.
6126 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6127 unused at least since Kim's GUI unification at revno:50135 (2003-03-16)
6128 and thereabouts. All callers changed.
6129 (get_per_char_metric): Remove parameter `f', unused since
6130 revno:87605 (2008-05-14). All callers changed.
6132 2011-04-02 Jim Meyering <meyering@redhat.com>
6134 do not dereference NULL upon failed strdup
6135 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6136 (ns_get_family): Likewise.
6138 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6140 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6142 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6144 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6147 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6149 Add lexical binding.
6151 * window.c (Ftemp_output_buffer_show): New fun.
6152 (Fsave_window_excursion):
6153 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6155 * lread.c (lisp_file_lexically_bound_p): New function.
6156 (Fload): Bind Qlexical_binding.
6157 (readevalloop): Remove `evalfun' arg.
6158 Bind Qinternal_interpreter_environment.
6159 (Feval_buffer): Bind Qlexical_binding.
6160 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6162 (syms_of_lread): Declare `lexical-binding'.
6164 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6166 * keyboard.c (eval_dyn): New fun.
6167 (menu_item_eval_property): Use it.
6169 * image.c (parse_image_spec): Use Ffunctionp.
6171 * fns.c (concat, mapcar1): Accept byte-code-functions.
6173 * eval.c (Fsetq): Handle lexical vars.
6174 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6175 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6176 (FletX, Flet): Obey lexical binding.
6177 (Fcommandp): Handle closures.
6178 (Feval): New `lexical' arg.
6179 (eval_sub): New function extracted from Feval. Use it almost
6180 everywhere where Feval was used. Look up vars in lexical env.
6182 (Ffunctionp): Move from subr.el.
6183 (Ffuncall): Handle closures.
6184 (apply_lambda): Remove `eval_flags'.
6185 (funcall_lambda): Handle closures and new byte-code-functions.
6186 (Fspecial_variable_p): New function.
6187 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6188 but without exporting it to Lisp.
6190 * doc.c (Fdocumentation, store_function_docstring):
6191 * data.c (Finteractive_form): Handle closures.
6193 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6196 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6198 (exec_byte_code): New function extracted from Fbyte_code to handle new
6199 calling convention for byte-code-functions. Add new byte-codes.
6201 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
6203 * alloc.c (Fmake_symbol): Init new `declared_special' field.
6205 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6207 * xdisp.c (redisplay_internal): Fix prototype.
6209 2011-03-31 Eli Zaretskii <eliz@gnu.org>
6211 * xdisp.c (SCROLL_LIMIT): New macro.
6212 (try_scrolling): Use it when setting scroll_limit.
6213 Limit scrolling to 100 screen lines.
6214 (redisplay_window): Even when falling back on "recentering",
6215 position point in the window according to scroll-conservatively,
6216 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6218 (try_scrolling): When point is above the window, allow searching
6219 as far as scroll_max, or one screenful, to compute vertical
6220 distance from PT to the scroll margin position. This prevents
6221 try_scrolling from unnecessarily failing when
6222 scroll-conservatively is set to a value slightly larger than the
6223 window height. Clean up the case of PT below the margin at bottom
6224 of window: scroll_max can no longer be INT_MAX. When aggressive
6225 scrolling is in use, don't let point enter the opposite scroll
6226 margin as result of the scroll.
6227 (syms_of_xdisp) <scroll-conservatively>: Document the
6228 threshold of 100 lines for never-recentering scrolling.
6230 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6232 * dispextern.h (move_it_by_lines):
6233 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6234 since revno:34925 (2000-12-29). All callers changed.
6235 (message_log_check_duplicate): Remove parameters `prev_bol' and
6236 `this_bol', unused since revno:20537 (1998-01-01). All callers changed.
6237 (redisplay_internal): Remove parameter `preserve_echo_area',
6238 unused since revno:25013 (1999-07-21). All callers changed.
6240 * indent.c (Fvertical_motion):
6241 * window.c (window_scroll_pixel_based, Frecenter):
6242 Don't pass `need_y_p' to `move_it_by_lines'.
6244 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6246 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6247 steal a few bits to be more compact.
6248 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6249 Remove unneeded casts.
6251 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6253 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6255 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6256 binding" message (bug#7967).
6258 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6260 Fix more problems found by GCC 4.6.0's static checks.
6262 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6263 Remove unused local var.
6265 * editfns.c (Fmessage_box): Remove unused local var.
6267 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6268 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6269 Omit unused local vars.
6270 * window.c (shrink_windows): Omit unused local var.
6271 * menu.c (digest_single_submenu): Omit unused local var.
6272 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6273 Omit unused local var.
6275 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6276 Don't assume string length fits in int.
6277 (keyremap_step, read_key_sequence): Use size_t for sizes.
6278 (read_key_sequence): Don't check last_real_key_start redundantly.
6280 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6281 instead of alloca (Bug#8344).
6283 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6284 (Fbacktrace_frame): Don't assume nframes fits in int.
6286 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6288 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6291 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6293 * cm.c (calccost): Turn while-do into do-while, for clarity.
6295 * keyboard.c (syms_of_keyboard): Use the same style as later
6296 in this function when indexing through an array. This also
6297 works around GCC bug 48267.
6299 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6301 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6303 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6304 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6306 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6307 This avoids undefined behavior on integer overflow, and is a bit
6308 more convenient anyway since it is compared to a size_t variable.
6310 Variadic C functions now count arguments with size_t, not int.
6311 This avoids an unnecessary limitation on 64-bit machines, which
6312 caused (substring ...) to crash on large vectors (Bug#8344).
6313 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6314 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
6315 All variadic functions and their callers changed accordingly.
6316 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6317 * data.c (arith_driver, float_arith_driver): Likewise.
6318 * editfns.c (general_insert_function): Likewise.
6319 * eval.c (struct backtrace.nargs, interactive_p)
6320 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6321 (funcall_lambda, mark_backtrace): Likewise.
6322 * fns.c (concat): Likewise.
6323 * frame.c (x_set_frame_parameters): Likewise.
6324 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6325 0 if not found, not -1. All callers changed.
6327 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6328 (stack_copy_size): Now size_t, not int.
6329 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6331 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6333 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6334 unused since revno:43563.1.17 (2002-03-01) and revno:84043 (2008-02-1).
6335 All callers changed.
6337 * lisp.h (multibyte_char_to_unibyte):
6338 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6339 unused since revno:43563.1.16 (2002-03-01) and revno:84043 (2008-02-1).
6340 * character.h (CHAR_TO_BYTE8):
6341 * cmds.c (internal_self_insert):
6342 * editfns.c (general_insert_function):
6343 * keymap.c (push_key_description):
6344 * search.c (Freplace_match):
6345 * xdisp.c (message_dolog, set_message_1): All callers changed.
6347 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6349 * keyboard.c (safe_run_hook_funcall): New function.
6350 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6351 don't set the hook to nil, but remove the offending function instead.
6352 (Qcommand_hook_internal): Remove, unused.
6353 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6354 Vcommand_hook_internal.
6356 * eval.c (enum run_hooks_condition): Remove.
6357 (funcall_nil, funcall_not): New functions.
6358 (run_hook_with_args): Call each function through a `funcall' argument.
6359 Remove `cond' argument, now redundant.
6360 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6361 (Frun_hook_with_args_until_failure): Adjust accordingly.
6362 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6364 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6366 * dispextern.h (string_buffer_position): Remove declaration.
6368 * print.c (strout): Remove parameter `multibyte', unused since
6369 revno:25356 (1999-08-21). All callers changed.
6371 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6372 never used since function introduction in revno:20870 (1998-02-08).
6373 All callers changed.
6375 * w32.c (_wsa_errlist): Use braces for struct initializers.
6377 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6378 never used since function introduction in revno:36704 (2001-03-09).
6379 All callers changed.
6380 (string_buffer_position): Likewise. Also, make static (it's never
6381 used outside xdisp.c).
6382 (cursor_row_p): Remove parameter `w', unused since
6383 revno:32591 (2000-10-17). All callers changed.
6384 (decode_mode_spec): Remove parameter `precision', introduced during
6385 Gerd Moellmann's rewrite at revno:25013 (1999-07-21), but never used.
6386 All callers changed.
6388 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6390 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6392 2011-03-27 Anders Lindgren <andlind@gmail.com>
6394 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6395 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6396 (ns_update_auto_hide_menu_bar): New functions.
6397 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6398 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6399 ns_constrain_all_frames.
6400 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6401 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6403 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6405 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6407 2011-03-27 Glenn Morris <rgm@gnu.org>
6409 * syssignal.h: Replace RETSIGTYPE with void.
6410 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6411 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6412 Replace SIGTYPE with void everywhere.
6413 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6414 * s/template.h (SIGTYPE): Remove commented out definition.
6416 2011-03-26 Eli Zaretskii <eliz@gnu.org>
6418 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6419 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6421 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
6423 * w32.c (read_unc_volume): Use parameter `henum', instead of
6424 global variable `wget_enum_handle'.
6426 * keymap.c (describe_vector): Remove parameters `indices' and
6427 `char_table_depth', unused since revno:43563.1.32 (2002-03-01).
6428 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6430 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6432 * keyboard.c (timer_check): Remove parameter `do_it_now',
6433 unused since revno:14998 (1996-04-12).
6434 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6435 unused since revno:86854 (2008-04-19).
6437 * keyboard.c (read_char):
6438 * w32menu.c (w32_menu_display_help):
6439 * xmenu.c (show_help_event, menu_help_callback):
6440 Adjust calls to `show_help_echo'.
6442 * gtkutil.c (xg_maybe_add_timer):
6443 * keyboard.c (readable_events):
6444 * process.c (wait_reading_process_output):
6445 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6447 * insdel.c (adjust_markers_gap_motion):
6448 Remove; no-op since revno:20569 (1998-01-02).
6449 (gap_left, gap_right): Don't call it.
6451 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
6453 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6454 incurred during fontification.
6456 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6458 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6459 (DEFVAR_PER_BUFFER): Don't pass it.
6461 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6462 (scrolling_window): Don't pass it.
6464 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6466 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6468 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6470 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6471 of variables specific to SELinux and computation of `encoded_absname'.
6473 * image.c (XPutPixel): Remove unused variable `height'.
6475 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6477 * unexw32.c (get_section_info): Remove unused variable `section'.
6479 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6480 (system_process_attributes): Remove unused variable `sess'.
6481 (sys_read): Remove unused variable `err'.
6483 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6484 (w32_wnd_proc): Remove unused variable `isdead'.
6485 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6486 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6487 (x_create_tip_frame): Remove unused variable `tem'.
6489 * w32inevt.c (w32_console_read_socket):
6490 Remove unused variable `no_events'.
6492 * w32term.c (x_draw_composite_glyph_string_foreground):
6493 Remove unused variable `width'.
6495 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
6497 * w32term.c (x_set_glyph_string_clipping):
6498 Don't pass uninitialized region to CombineRgn.
6500 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
6502 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6503 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6504 (Fx_close_connection): Remove unused variable `i'.
6506 * w32font.c (w32font_draw): Return number of glyphs.
6507 (w32font_open_internal): Remove unused variable `i'.
6508 (w32font_driver): Add missing initializer.
6510 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6511 (fill_in_menu): Remove unused variable `items_added'.
6513 * w32term.c (last_mouse_press_frame): Remove static global variable.
6514 (w32_clip_to_row): Remove unused variable `f'.
6515 (x_delete_terminal): Remove unused variable `i'.
6517 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6518 (NOTHING): Remove unused static global variable.
6519 (uniscribe_check_otf): Remove unused variable `table'.
6520 (uniscribe_font_driver): Add missing initializers.
6522 2011-03-23 Julien Danjou <julien@danjou.info>
6524 * term.c (Fsuspend_tty, Fresume_tty):
6525 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6526 * window.c (temp_output_buffer_show):
6527 * insdel.c (signal_before_change):
6528 * frame.c (Fhandle_switch_frame):
6529 * fileio.c (Fdo_auto_save):
6530 * emacs.c (Fkill_emacs):
6531 * editfns.c (save_excursion_restore):
6532 * cmds.c (internal_self_insert):
6533 * callint.c (Fcall_interactively):
6534 * buffer.c (Fkill_all_local_variables):
6535 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6537 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
6538 unconditionnaly since it does the check itself.
6540 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
6542 Fix more problems found by GCC 4.5.2's static checks.
6544 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6545 the first time through the loop, since we know p0 < p1 then.
6546 This also avoids a gcc -Wstrict-overflow warning.
6548 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6549 leading to a memory leak, possible in functions like
6550 load_charset_map_from_file that can allocate an unbounded number
6551 of objects (Bug#8318).
6553 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6554 that could (at least in theory) be that large.
6556 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6557 This is less likely to overflow, and avoids undefined behavior if
6558 overflow does occur. All callers changed. Use strtoul to scan
6559 for the unsigned long integer.
6560 (pint2hrstr): Simplify and tune code slightly.
6561 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
6563 * scroll.c (do_scrolling): Work around GCC bug 48228.
6564 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6566 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6567 This also avoids a warning with gcc -Wstrict-overflow.
6568 (validate_x_resource_name): Simplify count usage.
6569 This also avoids a warning with gcc -Wstrict-overflow.
6571 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6574 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
6576 * process.c (Fmake_network_process): Use socklen_t, not int,
6577 where POSIX says socklen_t is required in portable programs.
6578 This fixes a porting bug on hosts like 64-bit HP-UX, where
6579 socklen_t is wider than int (Bug#8277).
6580 (Fmake_network_process, server_accept_connection):
6581 (wait_reading_process_output, read_process_output):
6584 * process.c: Rename or move locals to avoid shadowing.
6585 (list_processes_1, Fmake_network_process):
6586 (read_process_output_error_handler, exec_sentinel_error_handler):
6587 Rename or move locals.
6588 (Fmake_network_process): Define label "retry_connect" only if needed.
6589 (Fnetwork_interface_info): Fix pointer signedness.
6590 (process_send_signal): Add cast to avoid pointer signedness problem.
6591 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
6592 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
6594 Make tparam.h and terminfo.c consistent.
6595 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6596 Include tparam.h instead, since it declares them.
6597 * cm.h (PC): Remove extern decl; tparam.h now does this.
6598 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6599 * terminfo.c: Include tparam.h, to check interfaces.
6600 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6601 (tparam): Adjust signature to match interface in tparam.h;
6602 this removes some undefined behavior. Check that outstring and len
6603 are zero, which they always are with Emacs.
6604 * tparam.h (PC, BC, UP): New extern decls.
6606 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
6607 (xftfont_open): Rename locals to avoid shadowing.
6609 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
6610 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6611 (OTF_TAG_SYM): Omit macro if not needed.
6612 (ftfont_list): Remove unused local.
6613 (get_adstyle_property, ftfont_pattern_entity):
6614 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6615 Rename locals to avoid shadowing.
6617 * xfont.c (xfont_list_family): Mark var as initialized.
6619 * xml.c (make_dom): Now static.
6621 * composite.c (composition_compute_stop_pos): Rename local to
6623 (composition_reseat_it): Remove unused locals.
6624 (find_automatic_composition, composition_adjust_point): Likewise.
6625 (composition_update_it): Mark var as initialized.
6626 (find_automatic_composition): Mark vars as initialized,
6627 with a FIXME (Bug#8290).
6629 character.h: Rename locals to avoid shadowing.
6630 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6631 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6632 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6633 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6636 * textprop.c (property_change_between_p): Remove; unused.
6638 * intervals.c (interval_start_pos): Now static.
6640 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6642 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6643 Rename locals to avoid shadowing.
6645 * sound.c (wav_play, au_play, Fplay_sound_internal):
6646 Fix pointer signedness.
6647 (alsa_choose_format): Remove unused local var.
6648 (wav_play): Initialize a variable to 0, to prevent undefined
6649 behavior (Bug#8278).
6651 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6653 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6655 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6656 clobbering (Bug#8298).
6657 * sysdep.c (sys_subshell): Likewise.
6658 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
6660 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6661 This should get cleaned up, so that child_setup has the
6662 same signature on all platforms.
6664 * callproc.c (call_process_cleanup): Now static.
6665 (relocate_fd): Rename locals to avoid shadowing.
6667 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
6669 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6670 not to be necessary, and produces flickering.
6672 2011-03-20 Glenn Morris <rgm@gnu.org>
6674 * config.in: Remove file.
6676 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
6678 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6679 are now in src/globals.h.
6680 (syms_of_minibuf): Remove spurious & from previous change.
6682 2011-03-20 Leo <sdl.web@gmail.com>
6684 * minibuf.c (completing-read-function): New variable.
6685 (completing-read-default): Rename from completing-read.
6686 (completing-read): Call completing-read-function.
6688 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6690 * xfaces.c (Fx_load_color_file):
6691 Read color file from absolute filename (bug#8250).
6693 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6695 * makefile.w32-in: Update dependencies.
6697 2011-03-17 Eli Zaretskii <eliz@gnu.org>
6699 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6701 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6703 Fix more problems found by GCC 4.5.2's static checks.
6705 * process.c (make_serial_process_unwind, send_process_trap):
6706 (sigchld_handler): Now static.
6708 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6709 That way, the code declares only the vars that it needs.
6710 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6711 * s/cygwin.h (PTY_ITERATION): Likewise.
6712 * s/darwin.h (PTY_ITERATION): Likewise.
6713 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6715 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6716 * process.c (allocate_pty): Don't declare stb unless it's needed.
6718 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
6719 (CONSTANTLIM): Remove; unused.
6720 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6721 Define only if needed.
6723 * unexelf.c (unexec): Name an expression,
6724 to avoid gcc -Wbad-function-cast warning.
6725 Use a different way to cause a compilation error if anyone uses
6726 n rather than nn, a way that does not involve shadowing.
6727 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
6729 * deps.mk (unexalpha.o): Remove; unused.
6731 New file unexec.h, the (simple) interface for unexec (Bug#8267).
6732 * unexec.h: New file.
6733 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6734 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6736 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6737 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6738 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
6739 Change as necessary to match prototype in unexec.h.
6741 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6743 (back_comment, skip_chars): Mark vars as initialized.
6745 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6746 Rename locals to avoid shadowing.
6748 * lread.c (read1): Rewrite so as not to use empty "else".
6749 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
6751 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6753 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6754 warning when compiling print.c.
6756 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6757 instead of using an uninitialized var.
6758 (font_sort_entities): Mark var as initialized.
6760 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6762 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6763 pointers to constants.
6764 (font_parse_fcname): Remove unused vars.
6765 (font_delete_unmatched): Now static.
6766 (font_get_spec): Remove; unused.
6767 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6768 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6769 Rename or move locals to avoid shadowing.
6771 * fns.c (require_nesting_list, require_unwind): Now static.
6772 (Ffillarray): Rename locals to avoid shadowing.
6774 * floatfns.c (domain_error2): Define only if needed.
6775 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
6777 * alloc.c (mark_backtrace): Move decl from here ...
6778 * lisp.h: ... to here, so that it can be checked.
6780 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
6781 (Fdefvar): Rewrite so as not to use empty "else".
6782 (lisp_indirect_variable): Name an expression,
6783 to avoid gcc -Wbad-function-cast warning.
6784 (Fdefvar): Rename locals to avoid shadowing.
6786 * callint.c (quotify_arg, quotify_args): Now static.
6787 (Fcall_interactively): Rename locals to avoid shadowing.
6788 Use const pointer when appropriate.
6790 * lisp.h (get_system_name, get_operating_system_release):
6791 Move decls here, to check interfaces.
6792 * process.c (get_operating_system_release): Move decl to lisp.h.
6793 * xrdb.c (get_system_name): Likewise.
6794 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6795 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6796 some of which prompt warnings from gcc -Wbad-function-cast.
6797 (Fformat_time_string, Fencode_time, Finsert_char):
6798 (Ftranslate_region_internal, Fformat):
6799 Rename or remove local vars to avoid shadowing.
6800 (Ftranslate_region_internal): Mark var as initialized.
6802 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6805 * lisp.h (eassert): Check that the argument compiles, even if
6806 ENABLE_CHECKING is not defined.
6808 * data.c (Findirect_variable): Name an expression, to avoid
6809 gcc -Wbad-function-cast warning.
6810 (default_value, arithcompare, arith_driver, arith_error): Now static.
6811 (store_symval_forwarding): Rename local to avoid shadowing.
6812 (Fmake_variable_buffer_local, Fmake_local_variable):
6813 Mark variables as initialized.
6814 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
6816 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
6817 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6818 Rename locals to avoid shadowing.
6819 (mark_stack): Move local variables into the #ifdef region where
6821 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6822 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6824 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6825 (GC_STRING_CHARS): Remove; not used.
6826 (Fmemory_limit): Cast sbrk's returned value to char *.
6828 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6829 avoids undefined behavior in theory.
6831 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6833 Use functions, not macros, for up- and down-casing (Bug#8254).
6834 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6835 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6836 to use the following functions instead of these macros.
6837 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6838 EMACS_INT, since callers assume the returned value fits in int.
6839 (upcase1): Likewise, for UPCASE_TABLE.
6840 (uppercasep, lowercasep, upcase): New static inline functions.
6841 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
6842 the race-condition problem in the old DOWNCASE.
6844 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6845 Rename locals to avoid shadowing.
6846 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
6847 (regex_compile, re_search_2, re_match_2_internal):
6848 Remove unused local vars.
6849 (FREE_VAR): Rewrite so as not to use empty "else",
6850 which gcc can warn about.
6851 (regex_compile, re_match_2_internal): Mark locals as initialized.
6852 (RETALLOC_IF): Define only if needed.
6853 (WORDCHAR_P): Likewise. This one is never needed, but is used
6854 only in a comment talking about a compiler bug, so put inside
6855 the #if 0 of that comment.
6856 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6857 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6860 * search.c (boyer_moore): Rename locals to avoid shadowing.
6861 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6862 (PREV_CHAR_BOUNDARY): Likewise.
6864 * search.c (simple_search): Remove unused var.
6866 * dired.c (compile_pattern): Move decl from here ...
6867 * lisp.h: ... to here, so that it can be checked.
6868 (struct re_registers): New forward decl.
6870 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6872 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6874 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6875 Rename locals to avoid shadowing.
6876 (Fvertical_motion): Mark locals as initialized.
6878 * casefiddle.c (casify_object, casify_region): Now static.
6879 (casify_region): Mark local as initialized.
6881 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6883 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6884 New macros, so that the caller can use some names other than
6885 gcpro1, gcpro2, etc.
6886 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6888 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6889 argument, for consistency with GCPRO2_VAR, etc: it is now the
6890 prefix of the variable, not the variable itself. All uses
6892 * dired.c (directory_files_internal, file_name_completion):
6893 Rename locals to avoid shadowing.
6895 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6896 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6897 dired.c's scmp function, had undefined behavior.
6898 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6899 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6900 * buffer.h: ... to here, because these macros use current_buffer,
6901 and the new implementation with inline functions needs to have
6902 current_buffer in scope now, rather than later when the macros
6904 (downcase, upcase1): New static inline functions.
6905 (DOWNCASE, UPCASE1): Reimplement using these functions.
6906 This avoids undefined behavior in expressions like
6907 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6908 from race conditions in accessing the global variables
6909 case_temp1 and case_temp2.
6910 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6911 * lisp.h (case_temp1, case_temp2): Remove their decls.
6912 * character.h (ASCII_CHAR_P): Move from here ...
6913 * lisp.h: ... to here, so that the inline functions mentioned
6916 * dired.c (directory_files_internal_unwind): Now static.
6918 * fileio.c (file_name_as_directory, directory_file_name):
6919 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6921 (file_name_as_directory): Use const pointers when appropriate.
6922 (Fexpand_file_name): Likewise. In particular, newdir might
6923 point at constant storage, so make it a const pointer.
6924 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
6925 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6927 (Fset_file_times, Finsert_file_contents, auto_save_error):
6928 Rename locals to avoid shadowing.
6930 * minibuf.c (choose_minibuf_frame_1): Now static.
6931 (Ftry_completion, Fall_completions): Rename or remove locals
6934 * marker.c (bytepos_to_charpos): Remove; unused.
6936 * lisp.h (verify_bytepos, count_markers): New decls,
6937 so that gcc does not warn that these functions aren't declared.
6939 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6940 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
6941 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
6942 (copy_text): Remove unused local var.
6944 * filelock.c (within_one_second): Now static.
6945 (lock_file_1): Rename local to avoid shadowing.
6947 * buffer.c (fix_overlays_before): Mark locals as initialized.
6948 (fix_start_end_in_overlays): Likewise. This function should be
6949 simplified by using pointers-to-pointers, but that's a different
6951 (switch_to_buffer_1): Now static.
6952 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6953 (report_overlay_modification): Rename locals to avoid shadowing.
6955 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
6956 Fix pointer signedness issue.
6957 (sys_subshell): Mark local as volatile if checking for lint,
6958 to suppress a gcc -Wclobbered warning that does not seem to be right.
6959 (MAXPATHLEN): Define only if needed.
6961 * process.c (serial_open, serial_configure): Move decls from here ...
6962 * systty.h: ... to here, so that they can be checked.
6964 * fns.c (get_random, seed_random): Move extern decls from here ...
6965 * lisp.h: ... to here, so that they can be checked.
6967 * sysdep.c (reset_io): Now static.
6968 (wait_for_termination_signal): Remove; unused.
6970 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6971 (copy_keymap_item, append_key, push_text_char_description):
6973 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
6974 (DENSE_TABLE_SIZE): Remove; unused.
6975 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6976 (describe_map_tree):
6977 Rename locals to avoid shadowing.
6979 * keyboard.c: Declare functions static if they are not used elsewhere.
6980 (echo_char, echo_dash, cmd_error, top_level_2):
6981 (poll_for_input, handle_async_input): Now static.
6982 (read_char, kbd_buffer_get_event, make_lispy_position):
6983 (make_lispy_event, make_lispy_movement, apply_modifiers):
6984 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6985 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6986 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
6987 (read_key_sequence, read_char): Mark locals as initialized.
6988 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
6990 * keyboard.h (make_ctrl_char): New decl.
6991 (mark_kboards): Move decl here ...
6992 * alloc.c (mark_kboards): ... from here.
6994 * lisp.h (force_auto_save_soon): New decl.
6996 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
6997 (DEFINE_DUMMY_FUNCTION): New macro.
6998 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7000 (main): Add casts to avoid warnings
7001 if GCC considers string literals to be constants.
7003 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7005 * dbusbind.c: Pointer signedness fixes.
7006 (xd_signature, xd_append_arg, xd_initialize):
7007 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7008 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7009 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7010 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7012 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7013 if GCC considers string literals to be constants.
7014 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
7016 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7018 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7019 (print_preprocess, print_object): New macro to fix last change.
7021 * print.c (print_preprocess): Don't forget font objects.
7023 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
7025 * emacs.c (USAGE3): Doc fixes.
7027 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7029 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7032 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
7034 * lisp.h (VWindow_system, Qfile_name_history):
7035 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7036 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7037 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7039 * w32select.c: Don't #include "keyboard.h".
7040 (run_protected): Add extern declaration for waiting_for_input.
7042 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7043 * w32console.c (detect_input_pending, read_input_pending)
7044 (encode_terminal_code):
7045 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7046 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7047 (w32_system_caret_y, Qfile_name_history):
7048 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7049 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7050 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7051 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7052 * w32proc.c (Qlocal, report_file_error):
7053 * w32term.c (Vwindow_system, updating_frame):
7054 * w32uniscribe.c (initialized, uniscribe_font_driver):
7055 Remove unneeded extern declarations.
7057 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
7059 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
7061 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
7063 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7064 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7065 These macros can no longer be used for assignment.
7067 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7068 Assign struct members directly, instead of using BUF_BEGV etc.
7069 (record_buffer_markers, fetch_buffer_markers): New functions for
7070 recording and fetching special buffer markers.
7071 (set_buffer_internal_1, set_buffer_temp): Use them.
7073 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7075 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7077 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7078 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7080 * xdisp.c (hscroll_window_tree):
7081 (reconsider_clip_changes): Use PT instead of BUF_PT.
7083 2011-03-13 Eli Zaretskii <eliz@gnu.org>
7085 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7086 $(EMACS_ROOT)/lib/intprops.h.
7088 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7090 Fix more problems found by GCC 4.5.2's static checks.
7092 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7093 to unsigned char * to avoid compiler diagnostic.
7094 (xg_free_frame_widgets): Make it clear that a local variable is
7095 needed only if USE_GTK_TOOLTIP.
7096 (gdk_window_get_screen): Make it clear that this macro is needed
7097 only if USE_GTK_TOOLTIP.
7098 (int_gtk_range_get_value): New function, which avoids a diagnostic
7099 from gcc -Wbad-function-cast.
7100 (xg_set_toolkit_scroll_bar_thumb): Use it.
7101 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7102 diagnostic from gcc -Wbad-function-cast.
7103 (get_utf8_string, xg_get_file_with_chooser):
7104 Rename locals to avoid shadowing.
7105 (create_dialog): Move locals to avoid shadowing.
7107 * xgselect.c (xg_select): Remove unused var.
7109 * image.c (four_corners_best): Mark locals as initialized.
7110 (gif_load): Initialize transparent_p to zero (Bug#8238).
7111 Mark another local as initialized.
7112 (my_png_error, my_error_exit): Mark with NO_RETURN.
7114 * image.c (clear_image_cache): Now static.
7115 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
7116 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
7117 (x_edge_detection): Remove unnecessary cast that
7118 gcc -Wbad-function-cast diagnoses.
7119 (gif_load): Fix pointer signedness.
7120 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7121 (jpeg_load, gif_load): Rename locals to avoid shadowing.
7123 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
7125 Improve quality of tests for time stamp overflow.
7126 For example, without this patch (encode-time 0 0 0 1 1
7127 1152921504606846976) returns the obviously-bogus value (-948597
7128 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7129 reports time overflow. See
7130 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
7131 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7132 * editfns.c: Include limits.h and intprops.h.
7133 (TIME_T_MIN, TIME_T_MAX): New macros.
7134 (time_overflow): Move earlier, to before first use.
7135 (hi_time, lo_time): New functions, for an accurate test for
7137 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7138 (Fget_internal_run_time): Don't assume time_t fits in int.
7139 (make_time): Use list2 instead of Fcons twice.
7140 (Fdecode_time): More accurate test for out-of-range times.
7141 (check_tm_member): New function.
7142 (Fencode_time): Use it, to test for out-of-range times.
7143 (lisp_time_argument): Don't rely on undefined left-shift and
7144 right-shift behavior when checking for time stamp overflow.
7146 * editfns.c (time_overflow): New function, refactoring common code.
7147 (Fformat_time_string, Fdecode_time, Fencode_time):
7148 (Fcurrent_time_string): Use it.
7150 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7151 * dired.c (make_time): Move to ...
7152 * editfns.c (make_time): ... here.
7153 * systime.h: Note the move.
7155 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7157 * fringe.c (update_window_fringes): Remove unused variables.
7159 * unexmacosx.c (copy_data_segment): Also copy __got section.
7162 2011-03-12 Eli Zaretskii <eliz@gnu.org>
7164 * termcap.c [MSDOS]: Include "msdos.h".
7165 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7166 Constify `char *' arguments and their references according to
7167 prototypes in tparam.h.
7169 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
7171 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7172 Adapt all references accordingly.
7174 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7176 2011-03-11 Tom Tromey <tromey@redhat.com>
7178 * buffer.c (syms_of_buffer): Remove obsolete comment.
7180 2011-03-11 Eli Zaretskii <eliz@gnu.org>
7182 * termhooks.h (encode_terminal_code): Declare prototype.
7184 * msdos.c (encode_terminal_code): Don't declare prototype.
7186 * term.c (encode_terminal_code): Now external again, used by
7187 w32console.c and msdos.c.
7189 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7190 Depend on $(SRC)/tparam.h, see revno 103623.
7192 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
7194 Fix some minor problems found by GCC 4.5.2's static checks.
7196 * fringe.c (update_window_fringes): Mark locals as initialized
7198 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
7200 * alloc.c (mark_fringe_data): Move decl from here ...
7201 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7202 to check its interface.
7203 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7205 * fontset.c (free_realized_fontset): Now static.
7206 (Fset_fontset_font): Rename local to avoid shadowing.
7207 (fontset_font): Mark local as initialized.
7208 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
7210 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7212 * xselect.c (x_disown_buffer_selections): Remove; not used.
7213 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
7214 (x_own_selection, Fx_disown_selection_internal): Rename locals
7216 (x_handle_dnd_message): Remove local to avoid shadowing.
7218 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7219 so that the caller can use some name other than gcpro1.
7220 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
7221 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7222 (Fx_backspace_delete_keys_p):
7223 Use them to avoid shadowing, and rename vars to avoid shadowing.
7224 (x_decode_color, x_set_name, x_window): Now static.
7225 (Fx_create_frame): Add braces to silence GCC warning.
7226 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
7227 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7228 Remove unused locals.
7229 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7230 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7231 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7234 * xterm.h (x_mouse_leave): New decl.
7236 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7237 Remove unused functions.
7238 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7239 (x_calc_absolute_position): Now static.
7240 (XTread_socket): Don't define label "out" unless it's used.
7241 Don't declare local "event" unless it's used.
7242 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7243 unless they are used.
7244 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7245 (x_fatal_error_signal): Remove; not used.
7246 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7247 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7248 (x_error_catcher, x_connection_closed, x_error_handler):
7249 (x_error_quitter, xembed_send_message, x_iconify_frame):
7250 (my_log_handler): Rename locals to avoid shadowing.
7251 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7252 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7254 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7255 Rename or move locals to avoid shadowing.
7256 (tty_defined_color, merge_face_heights): Now static.
7257 (free_realized_faces_for_fontset): Remove; not used.
7258 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7259 does not deduce is never used uninitialized.
7260 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7261 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7263 * terminal.c (store_terminal_param): Now static.
7265 * xmenu.c (menu_highlight_callback): Now static.
7266 (set_frame_menubar): Remove unused local.
7267 (xmenu_show): Rename parameter to avoid shadowing.
7268 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7269 since they might point to immutable storage.
7270 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7271 since it's unused otherwise.
7273 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7274 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7275 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7276 avoids a gcc -Wuninitialized diagnostic.
7277 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7278 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7279 does not deduce are never used uninitialized.
7281 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7283 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7284 * window.c (window_loop, size_window):
7285 (run_window_configuration_change_hook, enlarge_window): Likewise.
7287 * window.c (display_buffer): Now static.
7288 (size_window): Mark variables that gcc -Wuninitialized
7289 does not deduce are never used uninitialized.
7290 * window.h (check_all_windows): New decl, to forestall
7291 gcc -Wmissing-prototypes diagnostic.
7292 * dispextern.h (bidi_dump_cached_states): Likewise.
7294 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7296 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
7298 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7299 and to avoid gcc -Wuninitialized warning.
7300 (load_charset_map): Mark variables that gcc -Wuninitialized
7301 does not deduce are never used uninitialized.
7302 (load_charset): Abort instead of using uninitialized var (Bug#8229).
7304 * coding.c (coding_set_source, coding_set_destination):
7305 Use "else { /* comment */ }" rather than "else /* comment */;"
7306 for clarity, and to avoid gcc -Wempty-body warning.
7307 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7308 a block, when the outer 'i' will do.
7309 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7310 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7311 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7312 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7313 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7314 Rename locals to avoid shadowing.
7315 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
7316 * coding.c (emacs_mule_char, encode_invocation_designation):
7317 Now static, since they're not used elsewhere.
7318 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
7319 (decode_coding_object, encode_coding_object, detect_coding_system):
7320 (decode_coding_emacs_mule): Mark variables that gcc
7321 -Wuninitialized does not deduce are never used uninitialized.
7322 (detect_coding_iso_2022): Initialize a local variable that might
7323 be used uninitialized. Leave a FIXME because it's not clear that
7324 this initialization is needed. (Bug#8211)
7325 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7326 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7327 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7328 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7329 Remove unused macros.
7331 * category.c (hash_get_category_set): Remove unused local var.
7332 (copy_category_table): Now static, since it's not used elsewhere.
7333 * character.c (string_count_byte8): Likewise.
7335 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7336 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7338 * chartab.c (copy_sub_char_table): Now static, since it's not used
7340 (sub_char_table_ref_and_range, char_table_ref_and_range):
7341 Rename locals to avoid shadowing.
7342 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
7344 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
7345 (BIDI_BOB): Remove unused macro.
7347 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7348 deduce are never used uninitialized.
7349 * term.c (encode_terminal_code): Likewise.
7351 * term.c (encode_terminal_code): Now static. Remove unused local.
7353 * tparam.h: New file.
7354 * term.c, tparam.h: Include it.
7355 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7356 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7357 Move these decls to tparam.h, and make them agree with what
7358 is actually in tparam.c. The previous trick of using incompatible
7359 decls in different modules does not conform to the C standard.
7360 All callers of tparam changed to use tparam's actual API.
7361 * tparam.c (tparam1, tparam, tgoto):
7362 Use const pointers where appropriate.
7364 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7365 * cm.h (struct cm): Likewise.
7366 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7367 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7368 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7369 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7370 (turn_on_face, init_tty): Likewise.
7371 * termchar.h (struct tty_display_info): Likewise.
7373 * term.c (term_mouse_position): Rename local to avoid shadowing.
7375 * alloc.c (mark_ttys): Move decl from here ...
7376 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7378 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7380 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7382 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
7384 * search.c (compile_pattern_1): Remove argument regp, unused since
7385 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7386 (compile_pattern): Don't pass it.
7388 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7390 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7391 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7393 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7395 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7397 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7398 gdk_window_get_screen, gdk_window_get_geometry,
7399 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7400 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7401 (xg_get_pixbuf_from_pixmap): New function.
7402 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7403 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7404 Call xg_get_pixbuf_from_pixmap instead of
7405 gdk_pixbuf_get_from_drawable.
7406 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7407 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7408 (xg_check_special_colors): Use GtkStyleContext and its functions
7410 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7411 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7412 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
7413 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7414 Call gtk_widget_get_preferred_size.
7415 (xg_frame_resized): gdk_window_get_geometry only takes 5
7417 (xg_win_to_widget, xg_event_is_for_menubar):
7418 Call gdk_x11_window_lookup_for_display.
7419 (xg_set_widget_bg): New function.
7420 (delete_cb): New function.
7421 (xg_create_frame_widgets): Connect delete-event to delete_cb.
7422 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7423 (xg_set_background_color): Call xg_set_widget_bg.
7424 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7425 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7426 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7427 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7429 (update_frame_tool_bar): Call gtk_widget_hide.
7430 (xg_initialize): Use GDK_KEY_g.
7432 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7434 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7436 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7437 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7438 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7440 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
7442 * w32xfns.c (select_palette): Check success of RealizePalette against
7443 GDI_ERROR, not zero.
7445 See ChangeLog.11 for earlier changes.
7451 Copyright (C) 2011 Free Software Foundation, Inc.
7453 This file is part of GNU Emacs.
7455 GNU Emacs is free software: you can redistribute it and/or modify
7456 it under the terms of the GNU General Public License as published by
7457 the Free Software Foundation, either version 3 of the License, or
7458 (at your option) any later version.
7460 GNU Emacs is distributed in the hope that it will be useful,
7461 but WITHOUT ANY WARRANTY; without even the implied warranty of
7462 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7463 GNU General Public License for more details.
7465 You should have received a copy of the GNU General Public License
7466 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.