1 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
3 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
6 2012-05-27 Eli Zaretskii <eliz@gnu.org>
8 * bidi.c (bidi_mirror_char): Fix last change.
10 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
12 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
13 when referring to sectname field in printf format.
15 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
17 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
18 Only r_alloc_inhibit_buffer_relocation needed to be added;
19 the others were already declared.
21 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
22 before checking whether it's out of range. Put the check inside
24 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
26 2012-05-27 Ken Brown <kbrown@cornell.edu>
28 * callproc.c (Fcall_process): Restore a line that was accidentally
29 commented out in the 2011-02-13 change (bug#11547).
31 2012-05-27 Eli Zaretskii <eliz@gnu.org>
33 * lisp.h [REL_ALLOC]: Add prototypes for external functions
36 * buffer.c [REL_ALLOC]: Remove prototypes of
37 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
38 they are now on lisp.h.
40 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
42 * search.c (search_buffer): Use it to inhibit relocation of buffer
43 text while re_search_2 is doing its job, because re_search_2 is
44 passed C pointers to buffer text. (Bug#11519)
46 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
49 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
50 state after an additional call to move_it_in_display_line_to, keep
51 the values of it->max_ascent and it->max_descent found for the
53 (pos_visible_p): Revert the comparison against bottom_y to what it
54 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
57 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
59 Fix coding-related core dumps with gcc -ftrapv.
60 The code was computing A - B, where A and B are pointers, and B is
61 random garbage. This can lead to core dumps on platforms that
62 have special pointer registers, and it also leads to core dumps on
63 x86-64 when compiled with gcc -ftrapv. The fix is to compute
64 A - B only when B is initialized properly.
65 * coding.c (coding_set_source, coding_set_destination): Return void.
66 (coding_change_source, coding_change_destinations): New functions,
67 with the old behaviors of coding_set_source and coding_set_destination.
68 All callers that need an offset changed to use these new functions.
70 2012-05-26 Glenn Morris <rgm@gnu.org>
72 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
74 2012-05-26 Eli Zaretskii <eliz@gnu.org>
76 Extend mouse support on W32 text-mode console.
77 * xdisp.c (draw_row_with_mouse_face): Call
78 tty_draw_row_with_mouse_face for WINDOWSNT as well.
80 * w32console.c: Include window.h.
81 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face): New
83 (initialize_w32_display): Initialize mouse-highlight data.
85 * w32inevt.c: Include termchar.h and window.h.
86 (do_mouse_event): Support mouse-autoselect-window. When the mouse
87 moves, call note_mouse_highlight. If help_echo changed, call
88 gen_help_event to produce help-echo message in the echo area.
89 Call clear_mouse_face if mouse_face_hidden is set in the mouse
92 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
94 * lread.c (read1): Simplify slightly to avoid an overflow warning
95 with GCC 4.7.0 on x86-64.
97 2012-05-26 Eli Zaretskii <eliz@gnu.org>
99 * bidi.c (bidi_mirror_char): Revert last change: an int is
100 definitely wide enough here.
102 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
104 Fix integer width and related bugs (Bug#9874).
105 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
106 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
107 (string_bytes, check_sblock, allocate_string_data):
108 (compact_small_strings, Fmake_bool_vector, make_string)
109 (make_unibyte_string, make_multibyte_string)
110 (make_string_from_bytes, make_specified_string)
111 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
112 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
114 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
115 (allocate_pseudovector):
116 Use int, not EMACS_INT, where int is wide enough.
117 (inhibit_garbage_collection, Fgarbage_collect):
118 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
119 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
120 int might not be wide enough.
121 (bidi_cache_search, bidi_cache_find, bidi_init_it)
122 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
123 (bidi_at_paragraph_end, bidi_find_paragraph_start)
124 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
125 (bidi_level_of_next_char, bidi_move_to_visually_next):
126 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
127 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
128 (Fkill_buffer, Fset_buffer_major_mode)
129 (advance_to_char_boundary, Fbuffer_swap_text)
130 (Fset_buffer_multibyte, overlays_at, overlays_in)
131 (overlay_touches_p, struct sortvec, record_overlay_string)
132 (overlay_strings, recenter_overlay_lists)
133 (adjust_overlays_for_insert, adjust_overlays_for_delete)
134 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
135 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
136 (Foverlay_recenter, last_overlay_modification_hooks_used)
137 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
138 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
139 (validate_region): Omit unnecessary test for b <= e,
140 since that's guaranteed by the previous test.
141 (adjust_overlays_for_delete): Avoid pos + length overflow.
142 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
143 (report_overlay_modification):
144 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
145 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
146 Omit pointer cast, which isn't needed anyway, and doesn't work
147 after the EMACS_INT -> ptrdiff_t change.
148 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
149 * buffer.h: Adjust decls to match defn changes elsewhere.
150 (struct buffer_text, struct buffer):
151 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
152 Use EMACS_INT, not int, where int might not be wide enough.
153 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
154 not int, to avoid needless 32-bit limit on 64-bit hosts.
155 (exec_byte_code): Use tighter memory-full test, one that checks
156 for alloca overflow. Don't compute the address of the object just
157 before an array, as that's not portable. Use EMACS_INT, not
158 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
159 * callint.c (Fcall_interactively):
160 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
161 * callproc.c (call_process_kill, Fcall_process):
162 Don't assume pid_t fits into an Emacs fixnum.
163 (call_process_cleanup, Fcall_process, child_setup):
164 Don't assume pid_t fits into int.
165 (call_process_cleanup, Fcall_process, delete_temp_file)
166 (Fcall_process_region):
167 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
168 (Fcall_process): Simplify handling of volatile integers.
169 Use int, not EMACS_INT, where int will do.
170 * casefiddle.c (casify_object, casify_region, operate_on_word)
171 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
172 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
173 (casify_object): Avoid integer overflow when overallocating buffer.
174 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
175 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
176 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
177 * category.h (CATEGORYP): Don't assume arg is nonnegative.
178 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
179 integers are now checked earlier. All uses replaced with XINT.
181 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
182 For CCL_MapSingle, check that content and value are in int range.
183 (ccl_driver, Fregister_code_conversion_map):
184 Check that Vcode_version_map_vector is a vector.
185 (resolve_symbol_ccl_program): Check that vector header is in range.
186 Always copy the vector, so that we can check its contents reliably
187 now rather than having to recheck each instruction as it's being
188 executed. Check that vector words fit in 'int'.
189 (ccl_get_compiled_code, Fregister_ccl_program)
190 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
191 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
192 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
193 contents are in range.
194 (Fccl_execute_on_string): Check that status is in range.
195 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
196 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
197 Accept and return EMACS_INT, not int, because callers can pass values
199 (c_string_width, strwidth, lisp_string_width, chars_in_text)
200 (multibyte_chars_in_text, parse_str_as_multibyte)
201 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
202 (str_as_unibyte, str_to_unibyte, string_count_byte8)
203 (string_escape_byte8, Fget_byte):
204 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
205 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
206 avoid mishandling large integers.
207 * character.h: Adjust decls to match defn changes elsewhere.
208 * charset.c (load_charset_map_from_file, find_charsets_in_text)
209 (Ffind_charset_region):
210 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
211 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
212 (load_charset_map_from_vector, Fdefine_charset_internal):
213 Don't assume fixnum fits in int.
214 (load_charset_map_from_vector, Fmap_charset_chars):
215 Remove now-unnecessary CHECK_NATNUMs.
216 (Fdefine_charset_internal): Check ranges here, more carefully.
217 Don't rely on undefined behavior with signed left shift overflow.
218 Don't assume unsigned int fits into fixnum, or that fixnum fits
219 into unsigned int. Don't require max_code to be a valid fixnum;
220 that's not true for gb10830 4-byte on a 32-bit host. Allow
221 invalid_code to be a cons, for the same reason. Require code_offset
222 to be a character. Avoid int overflow if max_char is close
224 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
225 this is intended anyway and avoids some undefined behavior.
226 (load_charset_map): Pass unsigned, not int, as 2nd arg of
227 INDEX_TO_CODE_POINT, as that's what it expects.
228 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
229 * charset.h (DECODE_CHAR): Return int, not unsigned;
230 this is what was intended anyway, and it avoids undefined behavior.
231 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
232 integer-overflow issues.
233 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
234 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
235 where the argument is EMACS_INT, and this behavior is not intended.
236 * chartab.c (Fmake_char_table, Fset_char_table_range)
237 (uniprop_get_decoder, uniprop_get_encoder):
238 Don't assume fixnum fits in int.
239 * cmds.c (move_point): New function, that does the gist of
240 Fforward_char and Fbackward_char, but does so while checking
241 for integer overflow more accurately.
242 (Fforward_char, Fbackward_char): Use it.
243 (Fforward_line, Fend_of_line, internal_self_insert)
244 (internal_self_insert):
245 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
246 Fix a FIXME, by checking for integer overflow when calculating
247 target_clm and actual_clm.
248 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
249 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
250 (ASSURE_DESTINATION, coding_alloc_by_realloc)
251 (coding_alloc_by_making_gap, alloc_destination)
252 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
253 (encode_coding_utf_16, detect_coding_emacs_mule)
254 (decode_coding_emacs_mule, encode_coding_emacs_mule)
255 (detect_coding_iso_2022, decode_coding_iso_2022)
256 (encode_invocation_designation, encode_designation_at_bol)
257 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
258 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
259 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
260 (encode_coding_ccl, encode_coding_raw_text)
261 (detect_coding_charset, decode_coding_charset)
262 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
263 (produce_composition, produce_charset, produce_annotation)
264 (decode_coding, handle_composition_annotation)
265 (handle_charset_annotation, consume_chars, decode_coding_gap)
266 (decode_coding_object, encode_coding_object, detect_coding_system)
267 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
268 (code_convert_region, code_convert_string)
269 (Fdefine_coding_system_internal)
270 (coding_set_source, coding_set_destination):
271 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
272 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
273 (Fdefine_coding_system_internal):
274 Don't assume fixnums fit in int.
275 (decode_coding_gap, decode_coding_object, encode_coding_object)
276 (Fread_coding_system, Fdetect_coding_region)
277 (Funencodable_char_position, Fcheck_coding_systems_region)
278 (get_translation, handle_composition_annotation, consume_chars):
279 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
280 (consume_chars): Rewrite to not calculate an address outside buffer.
281 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
282 Don't access memory outside of the args array.
283 (Fdefine_coding_system_internal): Check for charset-id overflow.
284 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
285 result of ENCODE_CHAR.
286 * coding.h: Adjust decls to match defn changes elsewhere.
287 (struct coding_system):
288 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
289 * composite.c (get_composition_id, find_composition)
290 (run_composition_function, update_compositions)
291 (compose_text, composition_gstring_put_cache)
292 (composition_gstring_p, composition_gstring_width)
293 (fill_gstring_header, fill_gstring_body, autocmp_chars)
294 (composition_compute_stop_pos, composition_reseat_it)
295 (composition_update_it, struct position_record)
296 (find_automatic_composition, composition_adjust_point)
297 (Fcomposition_get_gstring, Ffind_composition_internal):
298 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
299 (update_compositions):
300 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
301 * composite.h: Adjust decls to match defn changes elsewhere.
302 (struct composition):
303 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
304 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
305 Do not attempt to compute the address of the object just before a
306 buffer; this is not portable.
308 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
309 (Faset): Use int, not EMACS_INT, where int is wide enough.
310 (Fstring_to_number): Don't assume fixnums fit in int.
311 (Frem): Don't assume arg is nonnegative.
312 * dbusbind.c (xd_append_arg): Check for integers out of range.
313 (Fdbus_call_method): Don't overflow the timeout int.
314 (extract_signed, extract_unsigned): New functions.
315 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
316 (xd_get_connection_references): Return ptrdiff_t, not int.
318 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
320 Use int, not unsigned, where the dbus API uses int.
321 (Fdbus_message_internal): Don't overflow mtype.
322 (syms_of_dbusbind): Allocate right-sized buffer for integers.
323 * dired.c (directory_files_internal, file_name_completion, scmp)
324 (file_name_completion_stat):
325 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
326 (file_name_completion): Don't overflow matchcount.
327 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
328 * dispextern.h: Adjust decls to match defn changes elsewhere.
329 (struct text_pos, struct glyph, struct bidi_saved_info)
330 (struct bidi_string_data, struct bidi_it, struct composition_it)
332 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
333 (struct display_pos, struct composition_it, struct it):
334 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
335 * dispnew.c (increment_matrix_positions)
336 (increment_row_positions, mode_line_string)
337 (marginal_area_string):
338 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
339 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
340 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
341 (duration_to_sec_usec): New function, to check for overflow better.
342 (Fsleep_for, sit_for): Use it.
343 * doc.c (get_doc_string, store_function_docstring):
344 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
345 (get_doc_string, Fsnarf_documentation):
346 Use int, not EMACS_INT, where int is wide enough.
348 Use SAFE_ALLOCA, not alloca.
349 Check for overflow when converting EMACS_INT to off_t.
351 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
352 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
353 Don't assume uid_t fits into fixnum.
354 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
355 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
356 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
357 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
358 (general_insert_function)
359 (Finsert_char, make_buffer_string, make_buffer_string_both)
360 (update_buffer_properties, Fbuffer_substring)
361 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
362 (Fsubst_char_in_region, check_translation)
363 (Ftranslate_region_internal, save_restriction_restore, Fformat)
364 (transpose_markers, Ftranspose_regions):
365 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
366 (clip_to_bounds): Move to lisp.h as an inline function).
367 (Fconstrain_to_field): Don't assume integers are nonnegative.
368 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
369 (Fsubst_char_in_region, Fsave_restriction):
370 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
371 (Femacs_pid): Don't assume pid_t fits into fixnum.
372 (lo_time): Use int, not EMACS_INT, when int suffices.
373 (lisp_time_argument): Check for usec out of range.
374 (Fencode_time): Don't assume fixnum fits in int.
375 (Fuser_login_name, Fuser_full_name): Signal an error
376 if a uid argument is out of range, rather than relying on
378 (Fformat_time_string): Remove now-unnecessary check.
379 lisp_time_argument checks for out-of-range usec now.
380 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
381 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
382 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
383 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
384 (init_cmdargs, Fdump_emacs):
385 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
386 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
387 the bottom (typically) 32 bits of the fixnum.
388 * eval.c (specpdl_size, call_debugger):
389 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
390 (when_entered_debugger, Fbacktrace_debug):
391 Don't assume fixnum can fit in int.
392 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
393 the object just before a buffer; this is not portable.
394 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
395 (grow_specpdl, unbind_to):
396 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
397 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
398 (grow_specpdl): Simplify allocation by using xpalloc.
399 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
400 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
401 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
402 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
403 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
405 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
406 (Fcopy_file, non_regular_nbytes, read_non_regular)
407 (Finsert_file_contents):
408 Use int, not EMACS_INT, where int is wide enough.
409 (READ_BUF_SIZE): Verify that it fits in int.
410 (Finsert_file_contents): Check that counts are in proper range,
411 rather than assuming fixnums fit into ptrdiff_t etc.
412 Don't assume fixnums fit into int.
413 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
414 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
415 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
416 (string_char_to_byte, string_byte_to_char)
417 (string_make_multibyte, string_to_multibyte)
418 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
419 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
420 (substring_both, Fdelete, internal_equal, Ffillarray)
421 (Fclear_string, mapcar1)
422 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
423 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
424 (larger_vector, make_hash_table, maybe_resize_hash_table)
425 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
426 (Fmaphash, secure_hash):
427 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
428 (concat): Check for string index and length overflow.
429 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
431 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
432 (larger_vector): New API (vec, incr_min, size_max) replaces old
433 one (vec, new_size, init). This catches size overflow.
434 INIT was removed because it was always Qnil.
436 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
437 the upper bound on a hash table index size.
438 (make_hash_table, maybe_resize_hash_table): Use it.
439 (secure_hash): Computer start_byte and end_byte only after
440 they're known to be in ptrdiff_t range.
441 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
442 (Ffont_get_glyphs, Ffont_at):
443 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
444 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
445 (Flist_fonts, Fopen_font):
446 Don't assume fixnum can fit in int.
447 (check_gstring): Don't assume index can fit in int.
448 (font_match_p): Check that fixnum is a character, not a nonnegative
449 fixnum, since the later code needs to stuff it into an int.
450 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
451 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
452 conversion overflow issues.
453 (Fopen_font): Check for integer out of range.
454 (Ffont_get_glyphs): Don't assume index can fit in int.
455 * font.h: Adjust decls to match defn changes elsewhere.
456 * fontset.c (reorder_font_vector): Redo score calculation to avoid
458 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
459 printmax_t, where ptrdiff_t is wide enough.
460 (Finternal_char_font):
461 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
462 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
463 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
464 (Fset_frame_position, x_set_frame_parameters)
465 (x_set_line_spacing, x_set_border_width)
466 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
467 Check that fixnums are in proper range for system types.
468 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
469 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
470 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
471 Use SAFE_ALLOCA_LISP, not alloca.
472 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
473 intptr_t is wide enough.
474 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
475 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
476 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
477 Check for fixnum out of range.
478 * ftfont.c (ftfont_list): Don't assume index fits in int.
479 Check that fixnums are in proper range for system types.
480 (ftfont_shape_by_flt):
481 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
482 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
483 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
484 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
485 Check that fixnums are in proper range for system types.
486 * gnutls.h: Adjust decls to match defn changes elsewhere.
487 * gtkutil.c (xg_dialog_run):
488 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
489 (update_frame_tool_bar):
490 Check that fixnums are in proper range for system types.
491 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
492 (lookup_image): Check that fixnums are in range for system types.
493 * indent.c (last_known_column, last_known_column_point):
494 (current_column_bol_cache):
495 (skip_invisible, current_column, check_display_width):
496 (check_display_width, scan_for_column, current_column_1)
497 (Findent_to, Fcurrent_indentation, position_indentation)
498 (indented_beyond_p, Fmove_to_column, compute_motion):
499 (Fcompute_motion, Fvertical_motion):
500 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
501 (last_known_column_modified): Use EMACS_INT, not int.
502 (check_display_width):
504 Check that fixnums and floats are in proper range for system types.
505 (compute_motion): Don't assume index or fixnum fits in int.
506 (compute_motion, Fcompute_motion):
507 Use int, not EMACS_INT, when it is wide enough.
508 (vmotion): Omit local var start_hpos that is always 0; that way
509 we don't need to worry about overflow in expressions involving it.
510 * indent.h: Adjust decls to match defn changes elsewhere.
512 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
513 Use int, not EMACS_INT, where int is wide enough.
514 Remove unused members ovstring_chars_done and tab_offset;
516 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
517 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
518 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
519 (make_gap, copy_text, insert, insert_and_inherit)
520 (insert_before_markers, insert_before_markers_and_inherit)
521 (insert_1, count_combining_before, count_combining_after)
522 (insert_1_both, insert_from_string)
523 (insert_from_string_before_markers, insert_from_string_1)
524 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
525 (adjust_after_replace, adjust_after_insert, replace_range)
526 (replace_range_2, del_range, del_range_1, del_range_byte)
527 (del_range_both, del_range_2, modify_region)
528 (prepare_to_modify_buffer, signal_before_change)
529 (signal_after_change, Fcombine_after_change_execute):
530 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
531 * intervals.c (traverse_intervals, rotate_right, rotate_left)
532 (balance_an_interval, split_interval_right, split_interval_left)
533 (find_interval, next_interval, update_interval)
534 (adjust_intervals_for_insertion, delete_node, delete_interval)
535 (interval_deletion_adjustment, adjust_intervals_for_deletion)
536 (static_offset_intervals, offset_intervals)
537 (merge_interval_right, merge_interval_left, make_new_interval)
538 (graft_intervals_into_buffer, temp_set_point_both)
539 (temp_set_point, set_point, adjust_for_invis_intang)
540 (set_point_both, move_if_not_intangible, get_property_and_range)
541 (get_local_map, copy_intervals, copy_intervals_to_string)
542 (compare_string_intervals, set_intervals_multibyte_1):
543 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
544 * intervals.h: Adjust decls to match defn changes elsewhere.
546 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
547 * keyboard.c (this_command_key_count, this_single_command_key_start)
548 (before_command_key_count, before_command_echo_length, echo_now)
549 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
550 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
551 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
552 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
553 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
554 (last_non_minibuf_size, last_point_position, echo_truncate)
555 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
556 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
557 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
558 (stuff_buffered_input):
559 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
560 (last_auto_save, command_loop_1, read_char):
561 Use EMACS_INT, not int, to avoid integer overflow.
562 (record_char): Avoid overflow in total_keys computation.
563 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
564 * keyboard.h: Adjust decls to match defn changes elsewhere.
565 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
566 (Fkey_description, Fdescribe_vector, Flookup_key):
567 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
568 (click_position): New function, to check that positions are in range.
569 (Fcurrent_active_maps):
571 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
572 (Faccessible_keymaps, Fkey_description):
573 (preferred_sequence_p):
574 Don't assume fixnum can fit into int.
575 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
576 Check for integer overflow in size calculations.
577 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
578 avoid mishandling large integers.
579 * lisp.h: Adjust decls to match defn changes elsewhere.
580 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
581 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
582 (struct Lisp_Marker):
583 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
584 (clip_to_bounds): Now an inline function, moved here from editfns.c.
585 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
586 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
588 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
589 Assume the arg has valid form, since it always does.
590 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
591 unsigned integer system type.
592 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
593 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
594 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
595 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
596 (duration_to_sec_usec): New decl.
597 * lread.c (read_from_string_index, read_from_string_index_byte)
598 (read_from_string_limit, readchar, unreadchar, openp)
599 (read_internal_start, read1, oblookup):
600 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
601 (Fload, readevalloop, Feval_buffer, Feval_region):
602 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
603 (openp): Check for out-of-range argument to 'access'.
604 (read1): Use int, not EMACS_INT, where int is wide enough.
605 Don't assume fixnum fits into int.
606 Fix off-by-one error that can read outside a buffer.
607 (read_filtered_event): Use duration_to_sec_usec
608 to do proper overflow checking on durations.
609 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
611 (Fexecute_kbd_macro):
612 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
613 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
614 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
615 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
616 (set_marker_both, set_marker_restricted_both, marker_position)
617 (marker_byte_position, Fbuffer_has_markers_at):
618 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
619 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
620 * menu.c (ensure_menu_items): Renamed from grow_menu_items.
621 It now merely ensures that the menu is large enough, without
622 necessarily growing it, as this avoids some integer overflow issues.
624 (keymap_panes, parse_single_submenu, Fx_popup_menu):
625 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
626 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
627 Use SAFE_ALLOCA_LISP, not alloca.
628 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
629 to EMACS_INT. Check that fixnums are in proper range for system types.
630 * minibuf.c (minibuf_prompt_width, string_to_object)
631 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
632 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
633 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
634 (get_minibuffer, read_minibuf_unwind):
635 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
636 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
637 this simplifies overflow checking. All callers changed.
638 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
640 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
641 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
642 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
643 Check that fixnums are in proper range for system types.
644 (Fx_create_frame, Fx_show_tip):
645 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
646 * nsfont.m (ns_findfonts, nsfont_list_family):
647 Don't assume fixnum fits in long.
648 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
649 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
650 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
652 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
653 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
654 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
655 (PRINTDECLARE, PRINTPREPARE):
656 (strout, print_string):
657 (print, print_preprocess, print_check_string_charset_prop)
659 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
661 (temp_output_buffer_setup, Fprin1_to_string, print_object):
662 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
663 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
664 (printchar, strout): Use xpalloc to catch size calculation overflow.
665 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
666 (print_error_message): Use SAFE_ALLOCA, not alloca.
667 (print_object): Use int, not EMACS_INT, where int is wide enough.
668 (print_depth, new_backquote_output, print_number_index):
669 Use ptrdiff_t, not int, where int might not be wide enough.
670 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
671 (Fset_process_window_size, Fformat_network_address)
672 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
674 Check that fixnums are in proper range for system types.
675 (Fsignal_process): Simplify by avoiding a goto.
676 Check for process-ids out of pid_t range rather than relying on
678 (process_tick, update_tick): Use EMACS_INT, not int.
679 (Fformat_network_address, read_process_output, send_process)
680 (Fprocess_send_region, status_notify):
681 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
682 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
683 (wait_reading_process_output, read_process_output, exec_sentinel):
684 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
685 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
686 (Faccept_process_output): Use duration_to_sec_usec to do proper
687 overflow checking on durations.
688 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
689 Don't assume pid_t fits in int.
690 * process.h (struct Lisp_Process): Members tick and update_tick
691 are now of type EMACS_INT, not int.
692 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
693 configured --with-wide-int.
694 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
695 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
696 * search.c (looking_at_1, string_match_1):
697 (fast_string_match, fast_c_string_match_ignore_case)
698 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
699 (scan_newline, find_before_next_newline, search_command)
700 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
701 (set_search_regs, wordify):
704 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
705 (string_match_1, search_buffer, set_search_regs):
707 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
708 (wordify): Check for overflow in size calculation.
709 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
710 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
711 Check that fixnums are in proper range for system types.
712 * sound.c (struct sound_device)
713 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
714 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
715 (Fplay_sound_internal):
716 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
717 * syntax.c (struct lisp_parse_state, find_start_modiff)
718 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
719 (Fparse_partial_sexp):
720 Don't assume fixnums can fit in int.
721 (struct lisp_parse_state, find_start_pos, find_start_value)
722 (find_start_value_byte, find_start_begv)
723 (update_syntax_table, char_quoted, dec_bytepos)
724 (find_defun_start, prev_char_comend_first, back_comment):
725 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
726 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
727 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
728 (Finternal_describe_syntax_value): Check that match_lisp is a
729 character, not an integer, since the code stuffs it into int.
730 (scan_words, scan_sexps_forward):
731 Check that fixnums are in proper range for system types.
733 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
734 (scan_sexps_forward):
735 Use CHARACTERP, not INTEGERP, since the value must fit into int.
736 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
737 * syntax.h: Adjust decls to match defn changes elsewhere.
739 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
740 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
741 MOST_POSITIVE_FIXNUM.
742 * sysdep.c (wait_for_termination_1, wait_for_termination)
743 (interruptible_wait_for_termination, mkdir):
744 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
745 (emacs_read, emacs_write):
746 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
747 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
748 and double all fit in int.
749 * term.c (set_tty_color_mode):
750 Check that fixnums are in proper range for system types.
751 * termhooks.h (struct input_event):
752 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
753 * textprop.c (validate_interval_range, interval_of)
754 (Fadd_text_properties, set_text_properties_1)
755 (Fremove_text_properties, Fremove_list_of_text_properties)
756 (Ftext_property_any, Ftext_property_not_all)
757 (copy_text_properties, text_property_list, extend_property_ranges)
758 (verify_interval_modification):
759 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
760 (Fnext_single_char_property_change)
761 (Fprevious_single_char_property_change):
762 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
763 (copy_text_properties):
764 Check for integer overflow in index calculation.
765 * undo.c (last_boundary_position, record_point, record_insert)
766 (record_delete, record_marker_adjustment, record_change)
767 (record_property_change):
768 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
769 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
770 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
771 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
772 (Fx_hide_tip, Fx_file_dialog):
773 * w32menu.c (set_frame_menubar):
774 Use ptrdiff_t, not int, for consistency with rest of code.
775 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
776 (select_window, Fdelete_other_windows_internal)
777 (window_scroll_pixel_based, window_scroll_line_based)
778 (Frecenter, Fset_window_configuration):
779 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
780 (Fset_window_hscroll, run_window_configuration_change_hook)
781 (set_window_buffer, temp_output_buffer_show, scroll_command)
782 (Fscroll_other_window, Frecenter):
783 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
784 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
785 Don't assume fixnum fits in int.
786 (Fset_window_scroll_bars):
787 Check that fixnums are in proper range for system types.
788 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
789 (string_pos, c_string_pos, number_of_chars, init_iterator)
790 (in_ellipses_for_invisible_text_p, init_from_display_pos)
791 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
792 (compute_display_string_end, handle_face_prop)
793 (face_before_or_after_it_pos, handle_invisible_prop)
794 (handle_display_prop, handle_display_spec, handle_single_display_spec)
795 (display_prop_intangible_p, string_buffer_position_lim)
796 (string_buffer_position, handle_composition_prop, load_overlay_strings)
797 (get_overlay_strings_1, get_overlay_strings)
798 (iterate_out_of_display_property, forward_to_next_line_start)
799 (back_to_previous_visible_line_start, reseat, reseat_to_string)
800 (get_next_display_element, set_iterator_to_next)
801 (get_visually_first_element, compute_stop_pos_backwards)
802 (handle_stop_backwards, next_element_from_buffer)
803 (move_it_in_display_line_to, move_it_in_display_line)
804 (move_it_to, move_it_vertically_backward, move_it_by_lines)
805 (add_to_log, message_dolog, message_log_check_duplicate)
806 (message2, message2_nolog, message3, message3_nolog
807 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
808 (current_message_1, truncate_echo_area, truncate_message_1)
809 (set_message, set_message_1, store_mode_line_noprop)
810 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
811 (text_outside_line_unchanged_p, check_point_in_composition)
812 (reconsider_clip_changes)
813 (redisplay_internal, set_cursor_from_row, try_scrolling)
814 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
815 (redisplay_window, find_last_unchanged_at_beg_row)
816 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
817 (trailing_whitespace_p, find_row_edges, display_line)
818 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
819 (display_mode_element, store_mode_line_string)
820 (pint2str, pint2hrstr, decode_mode_spec)
821 (display_count_lines, display_string, draw_glyphs)
822 (x_produce_glyphs, x_insert_glyphs)
823 (rows_from_pos_range, mouse_face_from_buffer_pos)
824 (fast_find_string_pos, mouse_face_from_string_pos)
825 (note_mode_line_or_margin_highlight, note_mouse_highlight):
826 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
827 (safe_call, init_from_display_pos, handle_fontified_prop)
828 (handle_single_display_spec, load_overlay_strings)
829 (with_echo_area_buffer, setup_echo_area_for_printing)
830 (display_echo_area, echo_area_display)
831 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
832 (update_tool_bar, hscroll_window_tree, redisplay_internal)
833 (redisplay_window, dump_glyph_row, display_mode_line)
834 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
835 (handle_display_spec, display_prop_string_p):
836 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
837 (handle_single_display_spec, build_desired_tool_bar_string)
838 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
839 (get_specified_cursor_type):
840 Check that fixnums are in proper range for system types.
841 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
843 Don't assume fixnums fit in int.
844 (compare_overlay_entries):
845 Avoid mishandling comparisons due to subtraction overflow.
846 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
847 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
848 (handle_tool_bar_click):
849 Use int, not unsigned, since we prefer signed and the signedness
851 (get_next_display_element, next_element_from_display_vector):
852 Use int, not EMACS_INT, when int is wide enough.
853 (start_hourglass): Use duration_to_sec_usec to do proper
854 overflow checking on durations.
855 * xfaces.c (Fbitmap_spec_p):
856 Check that fixnums are in proper range for system types.
857 (compare_fonts_by_sort_order):
858 Avoid mishandling comparisons due to subtraction overflow.
859 (Fx_family_fonts, realize_basic_faces):
860 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
862 Don't assume fixnum fits in int.
863 Use SAFE_ALLOCA_LISP, not alloca.
864 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
865 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
866 (face_at_buffer_position, face_for_overlay_string)
867 (face_at_string_position):
868 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
869 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
870 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
872 Check that fixnums are in proper range for system types.
873 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
874 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
875 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
876 (Fx_change_window_property): Don't assume fixnums fit in int.
877 * xfont.c (xfont_chars_supported):
878 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
879 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
880 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
881 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
882 * xml.c (parse_region):
883 * xrdb.c (magic_file_p):
884 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
885 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
886 (x_get_local_selection, x_reply_selection_request)
887 (x_handle_selection_request, wait_for_property_change):
888 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
889 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
890 short is wide enough.
891 (x_send_client_event): Don't assume fixnum fits in int.
892 * xterm.c (x_x_to_emacs_modifiers):
893 Don't assume EMACS_INT overflows nicely into int.
894 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
896 (handle_one_xevent): NATNUMP can eval its arg twice.
897 (x_connection_closed):
898 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
899 * xterm.h: Adjust decls to match defn changes elsewhere.
900 (struct scroll_bar): Use struct vectorlike_header
901 rather than rolling our own approximation.
902 (SCROLL_BAR_VEC_SIZE): Remove; not used.
904 2012-05-25 Glenn Morris <rgm@gnu.org>
906 * lisp.mk (lisp): Update for more files being compiled now.
908 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
910 * lread.c: Remove `read_pure' which makes no difference.
911 (read_pure): Remove var.
912 (unreadpure): Remove function.
913 (readevalloop): Don't call read_list with -1 flag.
914 (read1, read_vector): Don't test read_pure any more.
915 (read_list): Simplify.
917 * fileio.c, character.h: Minor style tweaks.
919 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
921 * window.h (clip_changed): Remove useless declaration.
923 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
925 * makefile.w32-in: Follow-up to revno:108341.
926 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
928 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
931 This directory predates autoconf and is no longer needed nowadays.
932 Move its few remaining bits of functionality to where they're needed.
933 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
934 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
935 * m/template.h: Remove.
936 * Makefile.in (M_FILE): Remove. All uses removed.
937 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
938 * lisp.h (USE_LSB_TAG):
939 * mem-limits.h (EXCEEDS_LISP_PTR):
940 Use VAL_MAX, not VALBITS, in #if.
941 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
942 (EMACS_UINT): Define unconditionally now.
943 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
944 (BITS_PER_EMACS_INT): New constants, replacing
945 what used to be in config.h, but not useful in #if.
946 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
947 define them any more.
948 (VAL_MAX): New macro.
950 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
951 BITS_PER_EMACS_INT, in #if.
952 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
953 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
954 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
955 * s/ms-w32.h (DATA_START):
956 Move here from removed file m/intel386.h.
957 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
958 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
960 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
963 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
964 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
966 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
967 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
968 * textprop.c, tparam.c (NULL): Remove.
969 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
970 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
971 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
972 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
973 * xterm.c (input_signal_count): Assume volatile works.
975 2012-05-21 Ken Brown <kbrown@cornell.edu>
977 * xgselect.c (xg_select): Fix first argument in call to 'select'
980 2012-05-20 Ken Brown <kbrown@cornell.edu>
982 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
983 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
985 2012-05-19 Ken Brown <kbrown@cornell.edu>
987 * xfns.c (x_in_use): Remove `static' qualifier.
988 * xterm.h (x_in_use): Declare.
989 * xgselect.c: Include xterm.h.
990 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
991 and `display_arg' (bug#9754).
993 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
995 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
997 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
998 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1000 2012-05-18 Eli Zaretskii <eliz@gnu.org>
1002 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1004 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1005 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1007 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1008 reference to image_cache->refcount.
1009 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1011 2012-05-17 Juri Linkov <juri@jurta.org>
1013 * search.c (Fword_search_regexp, Fword_search_backward)
1014 (Fword_search_forward, Fword_search_backward_lax)
1015 (Fword_search_forward_lax): Move functions to isearch.el
1016 (bug#10145, bug#11381).
1018 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1020 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1022 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1024 * lread.c (init_obarray): Declare Qt and Qnil as special.
1026 2012-05-14 Glenn Morris <rgm@gnu.org>
1028 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
1029 Put "libexec" before "bin", for the sake of init_callproc_1.
1031 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1033 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1035 * unexaix.c: Port to more-recent AIX compilers.
1036 (report_error, report_error_1, make_hdr, copy_sym)
1037 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1038 Make arguments const char *, not char *, to avoid violations of C
1039 standard and to fix some AIX warnings reported by Gilles Pion.
1041 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1043 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1044 already have overlays loaded.
1045 (handle_single_display_spec): Before returning without displaying
1046 fringe bitmap, synchronize the bidi iterator with the main display
1047 iterator, by calling iterate_out_of_display_property.
1048 (iterate_out_of_display_property): Detect buffer iteration by
1049 testing that it->string is a Lisp string.
1050 (get_next_display_element): When the current object is exhausted,
1051 and there's something on it->stack, call set_iterator_to_next to
1052 proceed with what's on the stack, instead of returning zero.
1053 (set_iterator_to_next): If called at the end of a Lisp string,
1054 proceed to consider_string_end without incrementing string
1055 position. Don't increment display vector index past the end of
1056 the display vector. (Bug#11417)
1057 (pos_visible_p): Don't report a position visible when move_it_to
1058 stopped at the last line of window, which happens to be scanned
1059 backwards by the bidi iteration. (Bug#11464)
1061 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1063 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1064 and right-margin display specs even if the spec is invalid or we
1065 are on a TTY, and thus unable to display on the fringes. That's
1066 because the text with the property will not be displayed anyway,
1067 so we need to signal to the caller that this is a "replacing"
1068 display spec. This fixes display when the spec is invalid or we
1071 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1073 * unexaix.c (make_hdr): Fix typo in prototype.
1074 This bug broke the build on AIX. Problem reported by Gilles Pion.
1076 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
1078 * keyboard.c (kbd_buffer_get_event): Read special events also in
1079 batch mode. (Bug#11415)
1081 2012-05-12 Glenn Morris <rgm@gnu.org>
1083 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1085 2012-05-12 Eli Zaretskii <eliz@gnu.org>
1087 * lisp.mk (lisp): Add newcomment.elc.
1089 2012-05-12 Glenn Morris <rgm@gnu.org>
1091 * Makefile.in (MKDIR_P): New, set by configure.
1092 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1094 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1096 Remove unused function hourglass_started.
1097 * dispextern.h (hourglass_started):
1098 * w32fns.c (hourglass_started):
1099 * xdisp.c (hourglass_started): Remove.
1101 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
1103 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1104 Update dependencies.
1106 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1108 * xgselect.c (xg_select): Put maxfds+1 into a var.
1109 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1111 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1113 2012-05-10 Dave Abrahams <dave@boostpro.com>
1115 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1116 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1118 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
1120 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1121 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1122 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1123 Initialize xd_registered_buses.
1125 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1127 Untag more efficiently if USE_LSB_TAG.
1128 This is based on a proposal by YAMAMOTO Mitsuharu in
1129 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1130 For an admittedly artificial (nth 8000 longlist) benchmark on
1131 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1132 Emacs's overall text size by 1%.
1133 * lisp.h (XUNTAG): New macro.
1134 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1135 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1136 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1137 * eval.c (Fautoload):
1138 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1139 * frame.h (XFRAME): Use XUNTAG.
1141 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1142 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1143 Remove unportable assumptions about print widths of types like
1145 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1146 intptr_t when converting between pointer and integer, to avoid GCC
1147 warnings about wrong width.
1149 2012-05-09 Eli Zaretskii <eliz@gnu.org>
1151 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1152 stack for each reader_thread, instead of defaulting to 8MB
1153 determined by the linker. This avoids failures in creating
1154 subprocesses on Windows 7, see the discussion in this thread:
1155 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1157 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1159 Fix up display of the *Minibuf-0* buffer in the mini window.
1160 * keyboard.c (read_char): Don't clear the echo area if there's no
1162 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
1163 contents of *Minibuf-0*) if there's no message displayed in its stead.
1165 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
1167 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1170 2012-05-06 Chong Yidong <cyd@gnu.org>
1172 * lisp.mk (lisp): Update.
1174 2012-05-05 Jim Meyering <meyering@redhat.com>
1176 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1178 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1180 * data.c (PUT_ERROR): New macro.
1181 (syms_of_data): Use it. Add new error type `user-error'.
1182 * undo.c (user_error): New function.
1183 (Fprimitive_undo): Use it.
1184 * print.c (print_error_message): Adjust print style for `user-error'.
1185 * keyboard.c (user_error): New function.
1186 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1188 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1190 Do not limit current-time-string to years 1000..9999.
1191 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1192 (Fcurrent_time_string): Support any year that is supported by the
1193 underlying localtime representation. Don't use asctime, as it
1194 has undefined behavior for years outside the range -999..9999.
1196 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1198 Fix race conditions involving setenv, gmtime, localtime, asctime.
1199 Without this fix, interrupts could mess up code that uses these
1200 nonreentrant functions, since setting TZ invalidates existing
1201 tm_zone or tzname values, and since most of these functions return
1202 pointers to static storage.
1203 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1204 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1205 Grow the critical sections to include not just invoking
1206 localtime/gmtime, but also accessing these functions' results
1207 including their tm_zone values if any, and any related TZ setting.
1208 (format_time_string): Last arg is now struct tm *, not struct tm **,
1209 so that the struct tm is saved in the critical section.
1210 All callers changed. Simplify allocation of initial buffer, partly
1211 motivated by the fact that memory allocation needs to be outside
1212 the critical section.
1214 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1216 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1217 with RESET_INTERVAL.
1219 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1220 Remove duplicated buffer name initialization.
1222 2012-05-02 Jim Meyering <jim@meyering.net>
1224 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1226 * xfns.c (x_window): Use xstrdup (Bug#11375).
1228 2012-05-02 Eli Zaretskii <eliz@gnu.org>
1230 * xdisp.c (pos_visible_p): If already at a newline from the
1231 display string before the 'while' loop, don't walk back the glyphs
1232 from it3.glyph_row. Solves assertion violation when the display
1233 string begins with a newline (egg.el). (Bug#11367)
1235 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1237 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1240 2012-05-01 Glenn Morris <rgm@gnu.org>
1242 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1243 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1244 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1245 All were removed before 23.1.
1247 * dispnew.c: Remove HAVE_LIBNCURSES test;
1248 it is always true on relevant platforms.
1250 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1251 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1253 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1255 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1257 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1258 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1261 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1263 Do not avoid creating empty evaporating overlays (Bug#9642).
1264 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1265 That is, do not delete an evaporating overlay if it becomes
1266 empty after its bounds are adjusted to fit within its buffer.
1267 This fix caused other problems, and I'm reverting it until we get
1268 to the bottom of them.
1270 2012-04-27 Chong Yidong <cyd@gnu.org>
1272 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1274 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1276 * xdisp.c (pos_visible_p): If the window start position is beyond
1277 ZV, start the display from buffer beginning. Prevents assertion
1278 violation in init_iterator when the minibuffer window is scrolled
1281 * window.c (window_scroll_pixel_based): Likewise.
1283 2012-04-27 Chong Yidong <cyd@gnu.org>
1285 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1287 2012-04-27 Glenn Morris <rgm@gnu.org>
1289 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1290 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1292 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1294 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1295 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
1297 2012-04-26 Eli Zaretskii <eliz@gnu.org>
1299 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1300 display element, check also the underlying string or buffer
1301 character. (Bug#11341)
1303 * w32menu.c: Include w32heap.h.
1304 (add_menu_item): If the call to AppendMenuW (via
1305 unicode_append_menu) fails, disable Unicode menus only if we are
1306 running on Windows 9X/Me.
1308 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1310 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1311 (xgetint): Add missing shift for LSB tags.
1313 2012-04-24 Martin Rudalics <rudalics@gmx.at>
1315 * keyboard.c (read_char): Don't wipe echo area for select window
1316 events: These might get delayed via `mouse-autoselect-window'
1319 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
1321 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1322 manipulation of :loaded-from data.
1324 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
1326 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1327 now a cons (bug#11311).
1329 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1331 Do not create empty overlays with the evaporate property (Bug#9642).
1332 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1333 if it becomes empty after its bounds are adjusted to fit within
1334 its buffer. Without this fix, in a nonempty buffer (let ((o
1335 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1336 yields an empty overlay that has the evaporate property, which is
1337 not supposed to happen.
1339 Fix minor GTK3 problems found by static checking.
1340 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1341 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1342 (struct _EmacsFixedClass, emacs_fixed_get_type):
1343 Move decls here from emacsgtkfixed.h, since they needn't be public.
1344 (emacs_fixed_get_type): Now static.
1345 (emacs_fixed_class_init): Omit unused local.
1346 (emacs_fixed_child_type): Remove; unused.
1347 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1348 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1349 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1350 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1351 (EMACS_FIXED_GET_CLASS): Remove; unused.
1352 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1354 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1355 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1357 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1359 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
1360 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
1361 (__malloc_size_t, __malloc_ptrdiff_t):
1362 Remove. All uses removed, replaced by the definiens if needed,
1363 since we can assume C89 or better now.
1364 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1365 (protect_malloc_state, align, get_contiguous_space)
1366 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1367 (malloc_atfork_handler_child, malloc_enable_thread)
1368 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1369 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1370 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1371 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1372 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1373 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1374 Define using prototypes, not old style.
1375 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1376 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1377 (align): Don't assume that signed integer overflow wraps around.
1378 Omit unused local var.
1379 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1380 (_free_internal_nolock, memalign, mallochook, reallochook):
1381 Omit no-longer-needed casts.
1382 (valloc): Use getpagesize, not __getpagesize.
1383 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1384 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1386 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1388 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
1390 Move functions from C to Lisp. Make non-blocking method calls
1391 the default. Implement further D-Bus standard interfaces.
1393 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1394 (QCdbus_request_name_allow_replacement)
1395 (QCdbus_request_name_replace_existing)
1396 (QCdbus_request_name_do_not_queue)
1397 (QCdbus_request_name_reply_primary_owner)
1398 (QCdbus_request_name_reply_in_queue)
1399 (QCdbus_request_name_reply_exists)
1400 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1401 (QCdbus_registered_serial, QCdbus_registered_method)
1402 (QCdbus_registered_signal): New Lisp objects.
1403 (XD_DEBUG_MESSAGE): Use sizeof.
1404 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1405 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1406 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1407 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1408 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1409 (xd_signature, xd_append_arg): Allow float for integer types.
1410 (xd_get_connection_references): New function.
1411 (xd_get_connection_address): Rename from xd_initialize.
1412 Return cached address.
1413 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1414 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1416 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
1417 Return number of refcounts.
1418 (Fdbus_get_unique_name): Make stronger parameter check.
1419 (Fdbus_message_internal): New defun.
1420 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1421 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1422 (Fdbus_send_signal, Fdbus_register_service)
1423 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1424 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1425 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1426 (Vdbus_compiled_version, Vdbus_runtime_version)
1427 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1428 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1429 (Vdbus_message_type_signal): New defvars.
1430 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1433 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1435 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1436 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1437 Do not assume ptrdiff_t is the same width as 'int'.
1439 * alloc.c: Handle unusual debugging option combinations.
1440 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1441 since the two debugging options are incompatible.
1442 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1444 (mem_init, mem_insert, mem_insert_fixup):
1445 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1446 (NEED_MEM_INSERT): Remove; no longer needed.
1448 2012-04-22 Leo Liu <sdl.web@gmail.com>
1450 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
1452 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1454 * sysdep.c [__FreeBSD__]: Minor cleanups.
1455 (list_system_processes, system_process_attributes) [__FreeBSD__]:
1456 Use Emacs indenting style more consistently. Avoid some casts.
1457 Use 'double' consistently rather than mixing 'float' and 'double'.
1459 2012-04-21 Eduard Wiebe <usenet@pusto.de>
1461 * sysdep.c (list_system_processes, system_process_attributes):
1462 Add implementation for FreeBSD (Bug#5243).
1464 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
1466 * lisp.mk (lisp): Update.
1468 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
1470 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
1471 It is never used otherwise.
1473 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
1475 * print.c (print_preprocess): Only check print_depth if print-circle
1477 (print_object): Check for cycles even when print-circle is nil and
1478 print-gensym is t, but only check print_depth if print-circle is nil.
1480 2012-04-20 Chong Yidong <cyd@gnu.org>
1482 * process.c (wait_reading_process_output): If EIO occurs on a pty,
1483 set the status to "failed" and ensure that sentinel is run.
1485 2012-04-20 Glenn Morris <rgm@gnu.org>
1487 * process.c (Fset_process_inherit_coding_system_flag)
1488 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
1489 (Fmake_network_process, Fmake_serial_process): Doc fix.
1491 2012-04-20 Eli Zaretskii <eliz@gnu.org>
1493 * xdisp.c (string_buffer_position_lim): Limit starting position to
1495 (set_cursor_from_row): If called for a mode-line or header-line
1496 row, return zero immediately.
1497 (try_cursor_movement): If inside continuation line, don't back up
1498 farther than the first row after the header line, if any.
1499 Don't consider the header-line row as "partially visible", even if
1500 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
1502 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1504 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
1507 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
1508 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
1510 configure: new option --enable-gcc-warnings (Bug#11207)
1511 * Makefile.in (C_WARNINGS_SWITCH): Remove.
1512 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
1513 (ALL_CFLAGS): Use new macros rather than old.
1514 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
1515 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
1516 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
1517 -Wunused-result, -Wunused-variable. This should go away once
1518 the Emacs and Gnulib regex code is merged.
1519 (xmalloc, xrealloc): Now static.
1521 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
1523 * dired.c (Fsystem_groups): Remove unused local.
1525 2012-04-17 Glenn Morris <rgm@gnu.org>
1527 * dired.c (Fsystem_users): Doc fix.
1529 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
1531 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
1532 (syms_of_dired): Add them.
1534 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
1536 Fix minor alloc.c problems found by static checking.
1537 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
1538 New extern decls, to avoid calling undeclared functions.
1539 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
1540 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
1541 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
1542 (NEED_MEM_INSERT): New macro.
1543 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
1544 Remove one incorrect comment and fix another.
1546 Fix minor ralloc.c problems found by static checking.
1547 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1548 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
1549 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
1550 (r_alloc_sbrk): Now static.
1552 Improve ralloc.c interface checking.
1553 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1554 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
1555 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
1556 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
1557 [REL_ALLOC]: ... to here, to check interface.
1558 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
1559 Remove decls. This fixes an "It stinks!".
1561 * alloc.c (which_symbols): Fix alignment issue / type clash.
1563 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
1565 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
1566 (struct Lisp_Misc_Any): Likewise.
1567 (struct Lisp_Free): Likewise.
1568 * alloc.c (union aligned_Lisp_Symbol): Define.
1569 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
1570 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
1571 (union aligned_Lisp_Misc): Define.
1572 (MARKER_BLOCK_SIZE, struct marker_block): Use union
1573 aligned_Lisp_Misc instead of union Lisp_Misc.
1574 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
1576 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
1578 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
1579 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
1580 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
1581 * s/netbsd.h, s/sol2-6.h:
1582 Remove definition of GC_MARK_STACK, since the default now works.
1583 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
1584 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
1585 no longer the default.
1586 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
1588 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1590 * lread.c (lisp_file_lexically_bound_p):
1591 Fix hang at ";-*-\n" (bug#11238).
1593 2012-04-14 Eli Zaretskii <eliz@gnu.org>
1595 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
1596 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
1598 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
1600 * nsterm.m (constrainFrameRect): Always constrain when there is only
1601 one screen (Bug#10962).
1603 2012-04-13 Ken Brown <kbrown@cornell.edu>
1605 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
1607 2012-04-13 Reuben Thomas <rrt@sc3d.org>
1609 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
1611 2012-04-11 Daniel Colascione <dancol@dancol.org>
1613 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
1614 against is gone. It's better to use vfork now so that when Cygwin
1615 gains a new, working vfork, we use it automatically (bug#10398).
1617 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1619 * window.c (save_window_save): Obey window-point-insertion-type.
1621 2012-04-11 Glenn Morris <rgm@gnu.org>
1623 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
1625 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1627 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
1629 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
1631 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
1632 (force_quit_count): New var.
1633 (handle_interrupt): Use it.
1635 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
1637 * w32.c (w32_delayed_load): Record the full path of the library
1638 being loaded (bug#10424).
1640 2012-04-09 Glenn Morris <rgm@gnu.org>
1642 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
1643 not just in the obarray, before snarfing them. (Bug#11036)
1645 * Makefile.in ($(leimdir)/leim-list.el):
1646 Pass EMACS rather than BUILT_EMACS.
1648 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
1650 * process.c (make_process):
1651 * process.h: Add integer `gnutls_handshakes_tried' member to
1654 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
1655 Add convenience `GNUTLS_LOG2i' macro.
1657 * gnutls.c (gnutls_log_function2i): Convenience log function.
1658 (emacs_gnutls_read): Use new log functions,
1659 `gnutls_handshakes_tried' process member, and
1660 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
1661 attempts per process (connection).
1663 2012-04-09 Chong Yidong <cyd@gnu.org>
1665 * eval.c (Fuser_variable_p, user_variable_p_eh)
1666 (lisp_indirect_variable): Functions deleted.
1667 (Fdefvar): Caller changed.
1669 * callint.c (Finteractive, Fcall_interactively):
1670 * minibuf.c (Fread_variable): Callers changed.
1672 2012-04-09 Eli Zaretskii <eliz@gnu.org>
1674 * xdisp.c (set_cursor_from_row): If the display string appears in
1675 the buffer at position that is closer to point than the position
1676 after the display string, display the cursor on the first glyph of
1677 the display string. Fixes cursor display when a 'display' text
1678 property immediately follows invisible text. (Bug#11094)
1680 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
1682 composite.c: use 'double' consistently
1683 * composite.c (get_composition_id): Use 'double' consistently
1684 instead of converting 'float' to 'double' and vice versa; this is
1685 easier to understand and avoids a GCC warning.
1687 2012-04-09 Glenn Morris <rgm@gnu.org>
1689 * Makefile.in: Generate leim-list with bootstrap-emacs, in
1690 preparation for dumping it with emacs. (Bug#4789)
1691 (leimdir): New variable.
1692 ($(leimdir)/leim-list.el): New rule.
1693 (emacs$(EXEEXT)): Depend on leim-list.el.
1695 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
1696 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
1697 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
1699 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
1701 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
1704 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
1706 * xml.c (init_libxml2_functions) [WINDOWSNT]:
1707 Remove unused local variable.
1709 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1711 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
1712 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
1713 (mark_memory): Mark Lisp_Objects only if pointers might hide in
1714 objects, as mark_maybe_pointer will catch them otherwise.
1715 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
1716 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
1718 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1720 Fix typo that broke non-Windows builds.
1721 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
1723 2012-04-07 Eli Zaretskii <eliz@gnu.org>
1725 Support building on MS-Windows with libxml2.
1727 * makefile.w32-in (OBJ2): Add xml.$(O).
1728 (GLOBAL_SOURCES): Add xml.c.
1729 ($(BLD)/xml.$(O)): New dependency list.
1731 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
1732 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
1733 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
1734 [!WINDOWSNT]: New macros.
1735 (init_libxml2_functions, libxml2_loaded_p): New functions.
1736 (parse_region): Call fn_xmlCheckVersion instead of using the macro
1737 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
1738 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
1739 Calls xmlCleanupParser only if libxml2 was loaded (or statically
1741 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
1742 Call init_libxml2_functions before calling libxml2 functions.
1743 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
1745 * emacs.c: Don't include libxml/parser.h.
1746 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
1747 xmlCleanupParser directly.
1749 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
1751 2012-04-07 Eli Zaretskii <eliz@gnu.org>
1753 * indent.c (Fvertical_motion): If there is a display string at
1754 point, use it.vpos to compute how many lines to backtrack after
1755 move_it_to point. (Bug#11133)
1757 2012-04-06 Eli Zaretskii <eliz@gnu.org>
1759 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
1760 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
1761 about subtle differences between FETCH_CHAR* and STRING_CHAR*
1762 macros related to unification of CJK characters. For the details,
1763 see the discussion following the message here:
1764 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
1766 2012-04-04 Chong Yidong <cyd@gnu.org>
1768 * keyboard.c (Vdelayed_warnings_list): Doc fix.
1770 2012-04-01 Eli Zaretskii <eliz@gnu.org>
1772 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
1773 instead of alloca. (Bug#11138)
1775 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
1777 * w32menu.c (is_simple_dialog): Properly check lisp types.
1780 2012-03-31 Eli Zaretskii <eliz@gnu.org>
1782 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
1783 position we get to after a call to move_it_to fails the
1784 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
1785 only if we wind up in a string from display property. (Bug#11063)
1787 * window.c (Fdelete_other_windows_internal): Invalidate the row
1788 and column information about mouse highlight, so that redisplay
1789 restores it after reallocating the glyph matrices. (Bug#7464)
1791 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
1792 string comes from a `display' text property, use the buffer
1793 position of that property as if we actually saw that position in
1795 (move_it_by_lines): Remove the assertion that
1796 "it->current_x == 0 && it->hpos == 0" which can be legitimately
1797 violated when there's a before-string at the beginning of a line.
1800 2012-03-30 Eli Zaretskii <eliz@gnu.org>
1802 * xdisp.c (append_space_for_newline): If the default face was
1803 remapped, use the remapped face for the appended newline.
1804 (extend_face_to_end_of_line): Use the remapped default face for
1805 extending the face to the end of the line.
1806 (display_line): Call extend_face_to_end_of_line when the default
1807 face was remapped. (Bug#11068)
1809 2012-03-29 Eli Zaretskii <eliz@gnu.org>
1811 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
1813 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1815 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
1817 2012-03-27 Glenn Morris <rgm@gnu.org>
1819 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
1822 2012-03-26 Kenichi Handa <handa@m17n.org>
1824 * dispextern.h (struct glyph): Fix previous change. Change the
1825 bit length of glyphless.ch to 25 (Bug#11082).
1827 2012-03-26 Chong Yidong <cyd@gnu.org>
1829 * keyboard.c (Vselection_inhibit_update_commands): New variable.
1830 (command_loop_1): Use it; inhibit selection update for
1831 handle-select-window too (Bug#8996).
1833 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
1835 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
1837 2012-03-25 Kenichi Handa <handa@m17n.org>
1839 * dispextern.h (struct glyph): Change the bit length of
1840 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
1842 2012-03-24 Eli Zaretskii <eliz@gnu.org>
1844 * s/ms-w32.h (tzname): Include time.h before redirecting to
1845 _tzname. Fixes the MSVC build. (Bug#9960)
1847 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
1849 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
1852 * xterm.c (XTread_socket): Only modify handling_signal if
1853 !SYNC_INPUT. (Bug#11080)
1855 2012-03-23 Eli Zaretskii <eliz@gnu.org>
1857 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
1858 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
1859 when fetching a multibyte character consumes more bytes than
1860 CHAR_BYTES returns, due to unification of CJK characters in
1861 string_char. (Bug#11073)
1863 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
1865 * process.c (wait_reading_process_output): Handle pty disconnect
1866 by refraining from sending oneself a SIGCHLD (bug#10933).
1868 2012-03-22 Chong Yidong <cyd@gnu.org>
1870 * dispextern.h (struct it): New member string_from_prefix_prop_p.
1872 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
1873 Mark string as coming from a prefix property.
1874 (handle_face_prop): Use default face for prefix strings (Bug#4281).
1875 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
1877 2012-03-21 Chong Yidong <cyd@gnu.org>
1879 * xfaces.c (Vface_remapping_alist): Doc fix.
1881 2012-03-20 Eli Zaretskii <eliz@gnu.org>
1883 * w32proc.c (Fw32_set_console_codepage)
1884 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
1887 2012-03-20 Chong Yidong <cyd@gnu.org>
1889 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
1890 to reflect default non-nil value of redisplay-dont-pause.
1892 2012-03-19 Kenichi Handa <handa@m17n.org>
1894 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
1895 it fit in a valid range (Bug#11003).
1897 2012-03-18 Eli Zaretskii <eliz@gnu.org>
1899 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
1900 that is not from display property, accept the row as a "cursor
1901 row" if one of the string's character has a non-nil `cursor'
1902 property. Fixes cursor positioning when there are newlines in
1903 overlay strings, e.g. in icomplete.el. (Bug#11035)
1905 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
1907 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
1909 2012-03-12 Chong Yidong <cyd@gnu.org>
1911 * eval.c (inhibit_lisp_code): Rename from
1912 inhibit_window_configuration_change_hook; move from window.c.
1914 * xfns.c (unwind_create_frame_1, Fx_create_frame):
1915 * window.c (run_window_configuration_change_hook)
1916 (syms_of_window): Callers changed.
1918 2012-03-11 Chong Yidong <cyd@gnu.org>
1920 * keymap.c (Fkey_description): Doc fix (Bug#9700).
1922 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
1924 2012-03-10 Chong Yidong <cyd@gnu.org>
1926 * frame.c (other_visible_frames): Don't assume the selected frame
1927 is visible (Bug#10955).
1929 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
1931 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
1933 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
1935 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
1936 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
1939 2012-03-03 Glenn Morris <rgm@gnu.org>
1941 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
1943 2012-03-02 Eli Zaretskii <eliz@gnu.org>
1945 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
1946 position past the first glyph_row that ends at ZV. (Bug#10902)
1947 (redisplay_window, next_element_from_string): Fix typos in
1949 (redisplay_window): Pass to move_it_vertically the margin in
1950 pixels, not in screen lines.
1952 2012-03-02 Glenn Morris <rgm@gnu.org>
1954 * buffer.c (buffer-list-update-hook): Doc fix.
1956 2012-02-29 Eli Zaretskii <eliz@gnu.org>
1958 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
1959 push_it before setting up the iterator for the first overlay
1960 string, even if we have an empty string loaded.
1961 (next_overlay_string): If there's an empty string on the iterator
1962 stack, pop the stack. (Bug#10903)
1964 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
1966 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
1967 Suggested by Stefan Monnier in
1968 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
1969 * alloc.c (widen_to_Lisp_Object): New static function.
1970 (mark_memory): Also mark Lisp_Objects by fetching pointer words
1971 and widening them to Lisp_Objects. This would work even if
1972 USE_LSB_TAG is defined and wide integers are used, which might
1973 happen in a future version of Emacs.
1975 2012-02-25 Chong Yidong <cyd@gnu.org>
1977 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
1980 * xselect.c (Fx_selection_exists_p): Doc fix.
1981 (x_clipboard_manager_save_all): Print an informative message
1982 before saving to clipboard manager.
1984 2012-02-24 Chong Yidong <cyd@gnu.org>
1986 * keyboard.c (process_special_events): Handle all X selection
1987 requests in kbd_buffer, not just the next one (Bug#8869).
1989 2012-02-23 Chong Yidong <cyd@gnu.org>
1991 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
1992 call when setting menu-bar-lines and tool-bar-lines parameters.
1993 (unwind_create_frame_1): New helper function.
1995 * window.c (inhibit_window_configuration_change_hook): New var.
1996 (run_window_configuration_change_hook): Obey it.
1997 (syms_of_window): Initialize it.
1999 2012-02-22 Chong Yidong <cyd@gnu.org>
2001 * xterm.c (x_draw_image_relief): Add missing type check for
2002 Vtool_bar_button_margin (Bug#10743).
2004 2012-02-21 Chong Yidong <cyd@gnu.org>
2006 * fileio.c (Vfile_name_handler_alist): Doc fix.
2008 * buffer.c (Fget_file_buffer): Protect against invalid file
2009 handler return value.
2011 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2013 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2014 when computing $valmask.
2016 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2017 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2018 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2019 It's useless in that case, and it can cause problems on hosts
2020 that allocate halves of EMACS_INT values separately.
2021 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2022 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2023 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2024 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2025 it avoids undefined behavior on hosts where shifting right by more
2026 than the word width has undefined behavior.
2028 2012-02-19 Chong Yidong <cyd@gnu.org>
2030 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2031 (Funhandled_file_name_directory, Ffile_name_as_directory)
2032 (Fdirectory_file_name, Fexpand_file_name)
2033 (Fsubstitute_in_file_name): Protect against invalid file handler
2034 return values (Bug#10845).
2036 2012-02-18 Eli Zaretskii <eliz@gnu.org>
2038 * .gdbinit (pitx): Fix incorrect references to fields of the
2041 2012-02-17 Chong Yidong <cyd@gnu.org>
2043 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2045 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2047 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2048 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2050 2012-02-15 Chong Yidong <cyd@gnu.org>
2052 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2053 marked as special. Also, starting docstrings with * is obsolete.
2055 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2057 * gnutls.c (emacs_gnutls_write): Fix last change.
2059 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2061 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2064 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2066 * keymap.c (Fsingle_key_description): Handle char ranges.
2068 2012-02-12 Chong Yidong <cyd@gnu.org>
2070 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2071 as that creates a dangerous corner case.
2073 * window.c (Fdelete_window_internal): Invalidate the mouse
2074 highlight (Bug#9904).
2076 2012-02-12 Glenn Morris <rgm@gnu.org>
2078 * xselect.c (Fx_own_selection_internal)
2079 (Fx_get_selection_internal, Fx_disown_selection_internal)
2080 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2081 * nsselect.m (Fx_own_selection_internal)
2082 (Fx_disown_selection_internal, Fx_selection_exists_p)
2083 (Fx_selection_owner_p, Fx_get_selection_internal):
2084 Sync docs and argument specs with the xselect.c versions.
2086 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2088 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2090 2012-02-11 Eli Zaretskii <eliz@gnu.org>
2092 * w32select.c (Fx_selection_exists_p): Sync doc string and
2093 argument list with xselect.c. (Bug#10783)
2095 * w16select.c (Fx_selection_exists_p): Sync doc string and
2096 argument list with xselect.c. (Bug#10783)
2098 2012-02-10 Glenn Morris <rgm@gnu.org>
2100 * fns.c (Fsecure_hash): Doc fix.
2102 2012-02-09 Kenichi Handa <handa@m17n.org>
2104 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2106 2012-02-07 Chong Yidong <cyd@gnu.org>
2108 * buffer.c (Fbuffer_local_variables)
2109 (buffer_lisp_local_variables): Handle unbound vars correctly;
2110 don't let Qunbound leak into Lisp.
2112 2012-02-07 Glenn Morris <rgm@gnu.org>
2114 * image.c (Fimagemagick_types): Doc fix.
2116 * image.c (imagemagick-render-type): Change it from a lisp object
2117 to an integer. Move the doc here from the lisp manual.
2118 Treat all values not equal to 0 the same.
2120 2012-02-06 Chong Yidong <cyd@gnu.org>
2122 * doc.c (store_function_docstring): Avoid applying docstring of
2123 alias to base function (Bug#2603).
2125 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2127 * .gdbinit (pp1, pv1): Remove redundant defines.
2130 2012-02-04 Chong Yidong <cyd@gnu.org>
2132 * nsterm.m: Declare a global (Bug#10694).
2134 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2136 * w32.c (get_emacs_configuration_options):
2137 Include --enable-checking, if specified, in the return value.
2139 2012-02-04 Martin Rudalics <rudalics@gmx.at>
2141 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2142 after rounding frame sizes. (Bug#9723)
2144 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2146 * keyboard.c (adjust_point_for_property): Don't position point
2147 before BEGV. (Bug#10696)
2149 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2151 Handle overflow when computing char display width (Bug#9496).
2152 * character.c (char_width): Return EMACS_INT, not int.
2153 (char_width, c_string_width): Check for overflow when
2154 computing the width; this is possible now that individual
2155 characters can have unbounded width. Problem introduced
2156 by merge from Emacs 23 on 2012-01-19.
2158 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
2160 * dbusbind.c (Fdbus_register_method): Mention the return value
2161 :ignore in the docstring.
2163 2012-02-02 Glenn Morris <rgm@gnu.org>
2165 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2167 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2168 Unconditionally set to t. (Bug#10673)
2169 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2170 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2171 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2173 2012-02-02 Kenichi Handa <handa@m17n.org>
2175 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2176 0, do not call append_composite_glyph.
2178 2012-02-02 Kenichi Handa <handa@m17n.org>
2180 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2182 (x_produce_glyphs): If the component of a composition is a null
2183 string, set it->pixel_width to 1 to avoid zero-width glyph.
2185 2012-02-01 Eli Zaretskii <eliz@gnu.org>
2187 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2188 first 2 arguments are identical. This makes inserting large
2189 output from a subprocess an order of magnitude faster on
2190 MS-Windows, where all sbrk'ed memory is always contiguous.
2192 2012-01-31 Glenn Morris <rgm@gnu.org>
2194 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2195 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2196 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2198 2012-01-29 Glenn Morris <rgm@gnu.org>
2200 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2202 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2204 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2206 2012-01-28 Chong Yidong <cyd@gnu.org>
2208 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2210 2012-01-26 Chong Yidong <cyd@gnu.org>
2212 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2214 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2215 repeat counts (Bug#10507).
2217 2012-01-26 Glenn Morris <rgm@gnu.org>
2219 * lread.c (syms_of_lread): Doc fix.
2221 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2223 * coding.c (encode_designation_at_bol): Change return value to
2226 2012-01-25 Chong Yidong <cyd@gnu.org>
2228 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2230 2012-01-21 Chong Yidong <cyd@gnu.org>
2232 * floatfns.c (Fcopysign): Make the second argument non-optional,
2233 since nil is not allowed anyway.
2235 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2237 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2238 (send_process): Likewise.
2240 2012-01-19 Martin Rudalics <rudalics@gmx.at>
2242 * window.c (save_window_save, Fcurrent_window_configuration)
2243 (Vwindow_persistent_parameters): Do not use Qstate.
2244 Rewrite doc-strings.
2246 2012-01-19 Kenichi Handa <handa@m17n.org>
2248 * character.c (char_width): New function.
2249 (Fchar_width, c_string_width, lisp_string_width):
2250 Use char_width (Bug#9496).
2252 2012-01-16 Martin Rudalics <rudalics@gmx.at>
2254 * window.c (Vwindow_persistent_parameters): New variable.
2255 (Fset_window_configuration, save_window_save): Handle persistent
2258 2012-01-14 Eli Zaretskii <eliz@gnu.org>
2260 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2261 thrashing the stack of the thread. (Bug#9087)
2263 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2265 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2267 2012-01-11 Eli Zaretskii <eliz@gnu.org>
2269 * xdisp.c (rows_from_pos_range): Handle the case where the
2270 highlight ends on a newline. (Bug#10464)
2271 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2272 he end column for display of highlight that ends on a newline
2275 2012-01-11 Glenn Morris <rgm@gnu.org>
2277 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2278 from load-path also when installation-directory is nil. (Bug#10208)
2280 2012-01-10 Glenn Morris <rgm@gnu.org>
2282 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2284 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2285 Update template values to be closer to their typical values these days.
2287 2012-01-09 Eli Zaretskii <eliz@gnu.org>
2289 * xdisp.c (rows_from_pos_range): Accept additional argument
2290 DISP_STRING, and accept any glyph in a row whose object is that
2291 string as eligible for mouse highlight. Fixes mouse highlight of
2292 display strings from overlays. (Bug#10464)
2294 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
2296 emacs: fix an auto-save permissions race condition (Bug#10400)
2297 * fileio.c (auto_saving_dir_umask): New static var.
2298 (Fmake_directory_internal): Use it.
2299 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2300 creating the directory. The old code temporarily assigns
2301 too-generous permissions to the directory.
2302 (do_auto_save_eh): Clear it.
2303 (Fdo_auto_save): Catch all errors, not just file errors, so
2304 that the var is always cleared.
2306 2012-01-07 Eli Zaretskii <eliz@gnu.org>
2308 * search.c (scan_buffer): Pass character positions to
2309 know_region_cache, not byte positions. (Bug#6540)
2311 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
2313 * w32.c (sys_rename): Report EXDEV when rename of a directory
2314 fails because the target is on another logical disk. (Bug#10284)
2316 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2318 * xterm.c (x_embed_request_focus): New function.
2320 * xterm.h: Add prototype.
2322 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2324 2012-01-05 Glenn Morris <rgm@gnu.org>
2326 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2328 2012-01-01 Eli Zaretskii <eliz@gnu.org>
2330 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2331 Load gnutls_transport_set_lowat only if GnuTLS version is below
2333 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2334 GnuTLS versions below 2.11.1.
2336 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2338 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2339 to the doc string advising against its use for altering the way
2340 windows are scrolled.
2342 2011-12-28 Kenichi Handa <handa@m17n.org>
2344 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2345 coding-system ASCII compatible only when it does not produce BOM
2346 on encoding (Bug#10383).
2348 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2350 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2352 (create_and_show_popup_menu): Always use menu_position_func for
2355 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2357 * callint.c (Fcall_interactively): Don't truncate prompt string.
2359 2011-12-23 Eli Zaretskii <eliz@gnu.org>
2361 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2362 property that ends at ZV, so that the bidi iteration could be
2363 resumed from there (after widening). (Bug#10360)
2365 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2367 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2369 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2371 * nsterm.m (x_free_frame_resources):
2372 Release f->output_data.ns->miniimage.
2373 (ns_index_color): Fix indentation. Do not retain
2374 color_table->colors[i].
2376 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2379 * nsfns.m (x_set_background_color): Assign return value from
2380 ns_index_color to face-background instead of NSColor*.
2381 (ns_implicitly_set_icon_type): Fix indentation.
2382 Change assignment in for loop to comparison.
2384 * emacs.c (ns_pool): New variable.
2385 (main): Assign ns_pool.
2386 (Fkill_emacs): Call ns_release_autorelease_pool.
2388 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2389 autorelease fdesc, release fdAttrs and tdict.
2390 (ns_get_covering_families): Release charset.
2391 (ns_findfonts): Release NSFontDescriptor created with new.
2392 (ns_uni_to_glyphs): Fix indentation.
2393 (setString): Release attrStr before assigning new value.
2395 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2397 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2399 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2400 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2402 2011-12-18 David Reitter <reitter@cmu.edu>
2404 * nsterm.m (ns_term_init): Subscribe for notifications
2405 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2406 to method trackingNotification in EmacsMenu.
2408 * nsmenu.m (trackingMenu): New variable.
2409 (trackingNotification): New method (from Aquamacs).
2410 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
2411 from Aquamacs (Bug#7030).
2413 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2415 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2416 (symbol_to_nsstring): Fix indentation.
2417 (ns_symbol_to_pb): New function.
2418 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2419 (Fns_rotate_cut_buffers_internal): Remove.
2420 (Fns_store_selection_internal): Rename from
2421 Fns_store_cut_buffer_internal.
2422 (ns_get_foreign_selection, Fx_own_selection_internal)
2423 (Fx_disown_selection_internal, Fx_selection_exists_p)
2424 (Fns_get_selection_internal, Fns_store_selection_internal):
2425 Use ns_symbol_to_pb and check if return value is nil.
2426 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2427 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
2428 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2429 renamed to Sns_store_selection_internal.
2430 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2431 and remove this function.
2432 (ns_handle_selection_clear): Remove, never used.
2433 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2436 2011-12-17 Ken Brown <kbrown@cornell.edu>
2438 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2439 GID is unknown (Bug#10257).
2441 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2443 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2444 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2445 which caused a build failure on GNU/Linux IA-64. This problem was
2446 introduced by my 2011-10-07 patch.
2448 2011-12-15 Juri Linkov <juri@jurta.org>
2450 * image.c (imagemagick_error): New function. (Bug#10112)
2451 (imagemagick_load_image): Comment out `MagickSetResolution' call.
2452 Use `imagemagick_error' where ImageMagick functions return
2454 (Fimagemagick_types): Add `Fnreverse' to return the list in the
2457 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2459 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
2460 fill background (Bug#8992).
2462 2011-12-13 Martin Rudalics <rudalics@gmx.at>
2464 * window.c (Vwindow_combination_resize)
2465 (Vwindow_combination_limit): Use t instead of non-nil in
2467 (Vrecenter_redisplay): Add first sentence of doc-string on
2469 (Frecenter): Fix doc-string typo.
2471 2011-12-11 Kenichi Handa <handa@m17n.org>
2473 * coding.c (Funencodable_char_position): Pay attention to the
2474 buffer text relocation (Bug#9389).
2476 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2478 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
2479 gtk_init (Bug#10100).
2481 2011-12-10 Eli Zaretskii <eliz@gnu.org>
2483 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
2484 IT->string is nil. (Bug#10263)
2486 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2488 * nsterm.h (x_free_frame_resources): Declare.
2490 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
2491 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
2493 * nsterm.h (ns_get_defaults_value): Declare.
2495 * nsterm.m (ns_default): Call ns_get_defaults_value.
2497 2011-12-09 Eli Zaretskii <eliz@gnu.org>
2499 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
2502 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2504 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
2505 that where the value of an _OBJC_* symbol points to is in the .bss
2506 section (Bug#10240).
2508 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2510 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2511 after the loop to call ccl_driver at least once (Bug#8619).
2513 2011-12-08 Kenichi Handa <handa@m17n.org>
2515 * ftfont.c (get_adstyle_property): Fix previous change
2518 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
2520 * w32.c (init_environment): If no_site_lisp, remove site-lisp
2521 dirs from the default value of EMACSLOADPATH (bug#10208).
2523 2011-12-07 Glenn Morris <rgm@gnu.org>
2525 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
2526 installation and source directories as well. (Bug#10208)
2528 2011-12-06 Chong Yidong <cyd@gnu.org>
2530 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
2532 2011-12-06 Glenn Morris <rgm@gnu.org>
2534 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
2535 as an error, not just -1. (Bug#10217)
2537 2011-12-05 Chong Yidong <cyd@gnu.org>
2539 * keyboard.c (process_special_events): New function.
2540 (swallow_events, Finput_pending_p): Use it (Bug#10195).
2542 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
2544 * coding.c (encode_designation_at_bol): Don't use uninitialized
2545 local variable (Bug#9318).
2547 2011-12-05 Kenichi Handa <handa@m17n.org>
2549 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
2550 return Qnil (Bug#8046, Bug#10193).
2552 2011-12-05 Kenichi Handa <handa@m17n.org>
2554 * coding.c (encode_designation_at_bol): New args charbuf_end and
2555 dst. Return the number of produced bytes. Callers changed.
2556 (coding_set_source): Return how many bytes coding->source was
2558 (coding_set_destination): Return how many bytes
2559 coding->destination was relocated.
2560 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
2561 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
2563 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2565 * coding.c (CODING_CHAR_CHARSET_P): New macro.
2566 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
2569 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
2571 The following changes are to fix Bug#9318.
2573 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
2574 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
2575 (encode_coding_iso_2022, encode_coding_sjis)
2576 (encode_coding_big5, encode_coding_charset): Use the above macros.
2578 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
2580 * lisp.h (process_quit_flag): Fix external declaration.
2582 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
2584 Don't macro-inline non-performance-critical code.
2585 * eval.c (process_quit_flag): New function.
2586 * lisp.h (QUIT): Use it.
2588 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
2590 * nsfns.m (get_geometry_from_preferences): New function.
2591 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
2593 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
2595 * emacs.c (Qkill_emacs): Define.
2596 (syms_of_emacs): Initialize it.
2597 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
2598 Qquit_flag to `kill-emacs' instead.
2599 (quit_throw_to_read_char): Add parameter `from_signal'.
2600 All callers changed. Call Fkill_emacs if requested and safe.
2601 * lisp.h (QUIT): Call Fkill_emacs if requested.
2603 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
2605 * widget.c (update_wm_hints): Return if wmshell is null.
2606 (widget_update_wm_size_hints): New function.
2608 * widget.h (widget_update_wm_size_hints): Declare.
2610 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
2611 widget_update_wm_size_hints (Bug#10104).
2613 2011-12-03 Eli Zaretskii <eliz@gnu.org>
2615 * xdisp.c (handle_invisible_prop): If the invisible text ends just
2616 before a newline, prepare the bidi iterator for consuming the
2617 newline, and keep the current paragraph direction. (Bug#10183)
2618 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
2620 2011-12-02 Juri Linkov <juri@jurta.org>
2622 * search.c (Fword_search_regexp): New Lisp function created from
2623 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
2624 (Fword_search_backward, Fword_search_forward)
2625 (Fword_search_backward_lax, Fword_search_forward_lax):
2626 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
2627 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
2629 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
2631 * fileio.c (Finsert_file_contents): Move after-change-function call
2632 to before the "handled:" label, since all "goto handled" appear in
2633 cases where the *-change-functions have already been properly called
2636 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
2638 * keyboard.c (interrupt_signal): Don't call kill-emacs when
2639 waiting for input. (Bug#10169)
2641 2011-11-30 Eli Zaretskii <eliz@gnu.org>
2643 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
2644 verifies glyph row's hash code--we have just reallocated the
2645 glyphs, so their contents can be complete garbage. (Bug#10164)
2647 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
2649 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
2651 2011-11-30 Eli Zaretskii <eliz@gnu.org>
2653 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
2654 attributes are tested _before_ calling verify_row_hash, to protect
2655 against GCC re-ordering of the tests. (Bug#10164)
2657 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
2659 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
2661 * xterm.c (handle_one_xevent): Only set async_visible and friends
2662 if net_wm_state_hidden_seen is non-zero (Bug#10002)
2663 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2664 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
2666 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
2668 Remove GCPRO-related macros that exist only to avoid shadowing locals.
2669 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
2670 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
2671 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2672 All uses changed to use GCPRO1 etc.
2673 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
2674 Revert to old implementation (i.e., before 2011-03-11).
2676 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2678 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
2679 of scroll runs so as to avoid assigning disabled bogus rows and
2680 unnecessary graphics copy operations.
2682 2011-11-27 Eli Zaretskii <eliz@gnu.org>
2684 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
2685 (snprintf) [_MSC_VER]: Redirect to _snprintf.
2686 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
2687 (malloc, free, realloc, calloc): Redirect to e_* only when
2690 * lisp.h (GCTYPEBITS): Move before first use.
2691 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
2692 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
2693 this macro definition.
2695 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
2698 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
2700 * gtkutil.c (xg_create_frame_widgets):
2701 Call gtk_window_set_has_resize_grip (FALSE) if that function is
2702 present with Gtk+ 2.0.
2704 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2706 * fileio.c (Finsert_file_contents): Undo previous change; see
2707 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2709 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2711 Rename locals to avoid shadowing.
2712 * fileio.c (Finsert_file_contents):
2713 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
2714 * process.c (wait_reading_process_output):
2715 Rename inner 'proc' to 'p' to avoid shadowing.
2716 Indent for consistency with usual Emacs style.
2718 2011-11-25 Eli Zaretskii <eliz@gnu.org>
2720 * xdisp.c (redisplay_window): If cursor row is not fully visible
2721 after recentering, and scroll-conservatively is set to a large
2722 number, scroll window by a few more lines to make the cursor fully
2723 visible and out of scroll-margin. (Bug#10105)
2724 (start_display): Don't move to the next line if the display should
2725 start at a newline that is part of a display vector or an overlay
2728 2011-11-24 Juri Linkov <juri@jurta.org>
2730 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
2731 after the `MagickPingImage' call. (Bug#10112)
2733 2011-11-23 Chong Yidong <cyd@gnu.org>
2735 * window.c (Fcoordinates_in_window_p): Accept only live windows.
2737 2011-11-23 Martin Rudalics <rudalics@gmx.at>
2739 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
2740 making another buffer current. (Bug#10114)
2742 2011-11-23 Glenn Morris <rgm@gnu.org>
2744 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
2746 2011-11-23 Chong Yidong <cyd@gnu.org>
2748 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
2749 using it (Bug#5984).
2751 2011-11-22 Eli Zaretskii <eliz@gnu.org>
2753 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
2754 and header-lines, as they don't have one computed for them.
2757 * .gdbinit (prow): Make displayed values more self-explaining.
2758 Add row's hash code.
2760 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
2762 * process.c (wait_reading_process_output): Fix asynchrounous
2763 GnuTLS socket handling on some versions of the GnuTLS library.
2764 (wait_reading_process_output): Add comment and URL.
2766 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
2768 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
2770 2011-11-21 Chong Yidong <cyd@gnu.org>
2772 * window.c (Fnext_window, Fprevious_window): Doc fix.
2774 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
2776 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
2778 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
2780 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
2782 2011-11-20 Martin Rudalics <rudalics@gmx.at>
2784 * window.c (Fset_window_combination_limit): Rename argument
2786 (Vwindow_combination_limit): Remove "status" from doc-string.
2788 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
2790 * m/ibms390.h: Remove.
2791 * m/ibms390x.h: Don't include "ibms390.h".
2793 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
2795 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
2796 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
2798 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
2800 * casetab.c (Fset_case_table):
2801 * charset.c (Fcharset_after): Fix typos.
2803 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
2805 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
2806 Otherwise, valgrind does not work on some platforms.
2807 Problem reported by Andreas Schwab in
2808 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
2809 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
2810 is set, removing the need for VIRT_ADDRESS_VARIES.
2811 (PURE_P): Use a more-efficient implementation that needs just one
2812 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
2813 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
2814 to 4 (xorl, subq, cmpq, setbe).
2815 * alloc.c (pure): Always extern now, since that's the
2816 VIRT_ADDR_VARIES behavior.
2817 (PURE_POINTER_P): Use a single comparison, not two, for
2818 consistency with the new puresize.h.
2819 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
2820 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
2821 Remove VIRT_ADDR_VARIES no longer needed.
2823 2011-11-19 Eli Zaretskii <eliz@gnu.org>
2825 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
2826 (erase_phys_cursor, update_window_cursor, show_mouse_face)
2827 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
2828 behave as if the cursor position were at the window margin.
2830 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
2831 and the cursor position is out of bounds, behave as if the cursor
2832 position were at the window margin. (Bug#10075)
2834 2011-11-18 Chong Yidong <cyd@gnu.org>
2836 * window.c (Fwindow_combination_limit): Make first argument
2837 non-optional, since it is meaningless for live windows like the
2840 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
2842 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
2844 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
2846 * intervals.c: Fix grafting over the whole buffer (bug#10071).
2847 (graft_intervals_into_buffer): Simplify.
2849 2011-11-18 Eli Zaretskii <eliz@gnu.org>
2851 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
2852 hash values of the two rows.
2853 (copy_row_except_pointers): Preserve the used[] arrays and the
2854 hash values of the two rows. (Bug#10035)
2855 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
2857 * xdisp.c (row_hash): New function, body extracted from
2858 compute_line_metrics.
2859 (compute_line_metrics): Call row_hash, instead of computing the
2862 * dispnew.c (verify_row_hash): Call row_hash for computing the
2863 hash code of a row, instead of duplicating code from xdisp.c.
2865 * dispextern.h (row_hash): Add prototype.
2867 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
2869 * frame.c (delete_frame): Don't delete the terminal when the last
2870 X frame is closed if emacs is built with GTK toolkit.
2872 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
2874 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
2876 2011-11-17 Martin Rudalics <rudalics@gmx.at>
2878 * window.c (Vwindow_splits): Rename to
2879 Vwindow_combination_resize. Suggested by Juri Linkov.
2880 (Fsplit_window_internal): Use Vwindow_combination_resize instead
2883 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
2885 * nsfns.m (Fns_font_name):
2886 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
2888 2011-11-16 Martin Rudalics <rudalics@gmx.at>
2890 * window.h (window): Rename slot "nest" to "combination_limit".
2891 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
2892 (Fset_window_nest): Rename to Fset_window_combination_limit.
2893 (Vwindow_nest): Rename to Vwindow_combination_limit.
2894 (recombine_windows, make_parent_window, make_window)
2895 (Fsplit_window_internal, saved_window)
2896 (Fset_window_configuration, save_window_save): Rename all
2897 occurrences of window_nest to window_combination_limit.
2899 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
2901 * image.c (imagemagick_load_image): Fix typo.
2903 2011-11-14 Eli Zaretskii <eliz@gnu.org>
2905 * xdisp.c (display_line): Move the call to
2906 highlight_trailing_whitespace before the call to
2907 compute_line_metrics, since the latter needs to see the final
2908 faces of all the glyphs to compute ROW's hash value.
2909 Fixes assertion violations in row_equal_p. (Bug#10035)
2911 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
2913 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
2914 just return (bug#10044).
2916 2011-11-12 Eli Zaretskii <eliz@gnu.org>
2918 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
2919 with user-defined heap size. Bump the default size of the temacs
2920 heap to 27MB, to avoid memory warning when running temacs.
2921 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
2923 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
2924 current_matrix and desired_matrix. (Bug#9990)
2925 (verify_row_hash) [XASSERTS]: New function.
2926 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
2927 that the hash value of glyph rows is correct.
2929 2011-11-12 Martin Rudalics <rudalics@gmx.at>
2931 * window.h (window): Remove splits slot.
2932 * window.c (Fwindow_splits, Fset_window_splits): Remove.
2933 (Fdelete_other_windows_internal, make_parent_window)
2934 (make_window, Fsplit_window_internal, Fdelete_window_internal)
2935 (Fset_window_configuration, save_window_save): Don't deal with
2936 split status of windows.
2937 (saved_window): Remove splits slot.
2938 (Vwindow_splits): Rewrite doc-string.
2940 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
2942 * xfns.c (unwind_create_frame):
2943 * nsfns.m (unwind_create_frame):
2944 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
2945 Vframe_list (Bug#9999).
2947 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
2949 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
2951 2011-11-11 Kenichi Handa <handa@m17n.org>
2953 * callproc.c (Fcall_process): Set the member dst_multibyte of
2956 2011-11-11 Johan Bockgård <bojohan@gnu.org>
2958 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
2959 avoid a crash (bug#9496).
2961 2011-11-09 Chong Yidong <cyd@gnu.org>
2963 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
2964 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
2966 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
2968 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
2970 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
2972 Avoid some portability problems by eschewing 'extern inline' functions.
2973 The trivial performance wins aren't worth the portability hassles; see
2974 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
2976 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
2977 (window_box_width, window_box_left, window_box_left_offset)
2978 (window_box_right, window_box_right_offset): Undo previous change,
2979 by removing the "extern"s.
2980 * intervals.c (adjust_intervals_for_insertion)
2981 (adjust_intervals_for_deletion): Undo previous change,
2982 making these static again.
2983 (offset_intervals, temp_set_point_both, temp_set_point)
2984 (copy_intervals_to_string): No longer inline.
2985 * xdisp.c (window_text_bottom_y, window_box_width)
2986 (window_box_height, window_box_left_offset)
2987 (window_box_right_offset, window_box_left, window_box_right)
2988 (window_box): No longer inline.
2990 2011-11-08 Chong Yidong <cyd@gnu.org>
2992 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
2993 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
2994 Signal an error if not a live window.
2995 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
2996 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
2998 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
3000 * lisp.h (syms_of_abbrev): Remove declaration.
3001 Reported by CHENG Gao <chenggao@royau.me>.
3003 2011-11-07 Eli Zaretskii <eliz@gnu.org>
3005 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3006 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3007 of temacs in GUI mode.
3009 2011-11-07 Martin Rudalics <rudalics@gmx.at>
3011 * window.h: Declare delete_all_child_windows instead of
3012 delete_all_subwindows.
3013 * window.c (Fwindow_nest, Fset_window_nest)
3014 (Fset_window_new_total, Fset_window_new_normal)
3015 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3016 (delete_all_subwindows): Rename to delete_all_child_windows.
3017 (Fdelete_other_windows_internal, Fset_window_configuration):
3018 Call delete_all_child_windows instead of delete_all_subwindows.
3019 * frame.c (delete_frame): Call delete_all_child_windows instead
3020 of delete_all_subwindows.
3022 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3024 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3025 This is also needed for porting to any host where GC_MARK_STACK is
3026 not GC_MAKE_GCPROS_NOOPS.
3027 (which_symbols): Use it.
3029 2011-11-07 Kenichi Handa <handa@m17n.org>
3031 * coding.c (coding_set_destination): Check coding->src_pos only
3032 when coding->src_object is a buffer (bug#9910).
3034 * process.c (send_process): Set the member src_multibyte of coding
3035 to 0 (bug#9911) when sending a unibyte text.
3037 * callproc.c (Fcall_process): Set the member src_multibyte of
3038 process_coding to 0 (bug#9912).
3040 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3042 * xmenu.c (cleanup_widget_value_tree): New function.
3043 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3044 calling free_menubar_widget_value_tree directly (Bug#9830).
3046 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3048 Fix some portability problems with 'inline'.
3049 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3050 (window_box_width, window_box_left, window_box_left_offset)
3051 (window_box_right, window_box_right_offset): Declare extern.
3052 Otherwise, these inline functions do not conform to C99 and
3053 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3054 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3055 * intervals.c (adjust_intervals_for_insertion)
3056 (adjust_intervals_for_deletion): Now extern, because otherwise the
3057 extern inline functions 'offset_intervals' couldn't refer to it.
3058 (static_offset_intervals): Remove.
3059 (offset_intervals): Rewrite using the old contents of
3060 static_offset_intervals. The old version didn't conform to C99
3061 because an extern inline function contained a reference to an
3062 identifier with static linkage.
3064 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3066 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3069 2011-11-06 Eli Zaretskii <eliz@gnu.org>
3071 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3072 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3073 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3074 return Qleft_to_right.
3076 2011-11-06 Chong Yidong <cyd@gnu.org>
3078 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3079 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3080 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3081 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3082 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3083 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3084 (Fwindow_vscroll): Doc fix.
3085 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3086 argument, since it makes no sense to pass a live window and for
3087 consistency with window-child.
3089 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3091 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3094 2011-11-05 Jason Rumney <jasonr@gnu.org>
3096 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3097 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3099 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3100 bitwise arithmetic preventing use of unicode-sip and non-truetype
3103 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3105 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3108 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3109 initialization code to keep similarity to xfns.c after changes
3112 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3114 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3115 (unwind_create_frame): New function (Bug#9943).
3116 (Fx_create_frame): Restructure code to be more similar to the one in
3117 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3118 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3119 Move terminal->reference_count++ just before making the frame official
3122 * nsterm.m (x_free_frame_resources): New function.
3123 (x_destroy_window): Move code to x_free_frame_resources.
3125 * xfns.c (unwind_create_frame): Fix comment.
3126 (Fx_create_frame, x_create_tip_frame):
3127 Move terminal->reference_count++ just before making the frame
3128 official. Move initialization of image_cache_refcount and
3129 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3131 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3133 Support MSVC build with newer versions of Visual Studio.
3134 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3135 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3138 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3139 which are not supported by MSVC.
3140 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3141 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3143 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3145 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3147 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3149 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
3151 Support MSVC build with newer versions of Visual Studio.
3152 * w32.c: Don't include w32api.h for MSVC.
3153 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3155 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3156 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3157 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3158 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3160 (alloca) [_MSC_VER]: Define to _alloca.
3162 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3164 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3166 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3168 * xdisp.c (note_mouse_highlight): If either of
3169 previous/next-single-property-change returns nil, treat that as
3170 the beginning or the end of the buffer. (Bug#9955)
3172 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3174 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
3175 label is not null (Bug#9951).
3176 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3179 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3181 * window.c (Fwindow_body_size): Mention in the doc string that the
3182 return value is in frame's canonical units. (Bug#9949)
3184 2011-11-03 Eli Zaretskii <eliz@gnu.org>
3186 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3188 * w32fns.c (unwind_create_frame): If needed, free the glyph
3189 matrices of the partially constructed frame. (Bug#9943)
3190 * xfns.c (unwind_create_frame): Likewise.
3192 2011-11-01 Eli Zaretskii <eliz@gnu.org>
3194 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3195 Don't stop backward scan on the continuation glyph, even though
3196 its CHARPOS is positive.
3197 (mouse_face_from_buffer_pos, note_mouse_highlight):
3198 Rename cover_string to disp_string.
3200 2011-11-01 Martin Rudalics <rudalics@gmx.at>
3202 * window.c (temp_output_buffer_show): Don't use
3203 Vtemp_buffer_show_specifiers.
3204 (Vtemp_buffer_show_specifiers): Remove unused variable.
3206 2011-10-30 Eli Zaretskii <eliz@gnu.org>
3208 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3209 past the beginning of the current glyph matrix.
3211 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
3213 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3214 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3215 HAVE_GTK3 (Bug#9869).
3217 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3218 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3220 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3222 * xterm.c: Declare x_handle_net_wm_state to return int.
3223 (handle_one_xevent): Check if we are iconified but don't have
3224 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3225 (get_current_wm_state): Return non-zero if not hidden,
3226 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3227 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3228 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3229 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3231 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3233 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3234 so that this new function doesn't get optimized away by a
3235 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3237 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3239 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3241 2011-10-29 Eli Zaretskii <eliz@gnu.org>
3243 Fix the `xbytecode' command.
3244 * .gdbinit (xprintbytestr): New command.
3245 (xwhichsymbols): Rename from `which'; all callers changed.
3246 (xbytecode): Print the byte-code string as well.
3248 2011-10-29 Kim Storm <storm@cua.dk>
3250 * alloc.c (which_symbols): New function.
3252 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3254 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3257 2011-10-29 Glenn Morris <rgm@gnu.org>
3259 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3260 Not clear what it was for, and it causes various bugs. (Bug#9839)
3262 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3264 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3265 possible random value that matches one of those tested as
3266 condition to clear the mouse face.
3268 2011-10-28 Chong Yidong <cyd@gnu.org>
3270 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3272 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3274 * window.c (make_window): Initialize phys_cursor_on_p.
3276 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3278 * lisp.h (struct Lisp_Symbol): Update comments.
3280 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
3282 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3284 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3286 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3287 <oslsachem@gmail.com> for helping to debug this.
3289 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3290 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3291 (g_b_init_get_glyph_outline_w): New static variables.
3292 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3293 (GetGlyphOutlineW_Proc): New typedefs.
3294 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
3295 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3297 (w32font_open_internal, compute_metrics):
3298 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
3299 instead of calling the "wide" APIs directly.
3301 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3303 * w32.h (syms_of_w32font): Add prototype.
3305 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3307 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3308 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3309 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3310 (Fmove_to_window_line): Doc fix.
3312 2011-10-27 Chong Yidong <cyd@gnu.org>
3314 * process.c (make_process): Set gnutls_state to NULL.
3316 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3317 non-NULL, regardless of GNUTLS_INITSTAGE.
3318 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3319 an error. Set process slots as soon as we allocate them.
3321 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3323 2011-10-27 Chong Yidong <cyd@gnu.org>
3325 * gnutls.c (emacs_gnutls_deinit): New function.
3326 Deallocate credentials structures as well as calling gnutls_deinit.
3327 (Fgnutls_deinit, Fgnutls_boot): Use it.
3329 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3330 (deactivate_process): Call emacs_gnutls_deinit.
3332 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3334 * image.c (x_create_x_image_and_pixmap):
3335 * w32.c (sys_rename, w32_delayed_load):
3336 * w32font.c (fill_in_logfont):
3337 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3339 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
3341 * w32fns.c (w32_default_color_map): New function,
3342 extracted from Fw32_default_color_map.
3343 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
3345 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3347 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3349 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3351 * keyboard.c (test_undefined): New function (bug#9751).
3352 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3354 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3356 * sysdep.c (init_sys_modes): Fix the check for the controlling
3357 terminal (Bug#6649).
3359 2011-10-20 Eli Zaretskii <eliz@gnu.org>
3361 * dispextern.h (struct bidi_it): New member next_en_type.
3363 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3364 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3365 current character, check also for next_en_type being WEAK_EN.
3366 (bidi_resolve_weak): Don't enter the expensive loop if the current
3367 position is before next_en_pos. Record the bidi type of the first
3368 non-ET, non-BN character we find, in addition to its position.
3369 (bidi_level_of_next_char): Invalidate next_en_type when
3370 next_en_pos is over-stepped.
3372 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3374 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3375 * editfns.c: Rewrite current-time-zone so that it invokes
3376 the equivalent of (format-time-string "%Z") to get the time zone name.
3377 This fixes a bug when the time zone name contains characters that
3378 need converting from the system time locale to Emacs internal format.
3379 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3380 that patch fixed format-time-string to do the conversion, but
3381 I forgot to fix current-time-zone.
3382 (format_time_string): New function, containing most of
3383 what Fformat_time_string used to contain.
3384 (Fformat_time_string): Rewrite in terms of format_time_string.
3385 This doesn't change this function's behavior.
3386 (current-time-zone): Rewrite to use format_time_string.
3387 This fixes the bug reported by Michael Schierl in
3388 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3389 Jason Rumney's 2007-06-07 change worked around this bug, but
3391 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3393 2011-10-19 Eli Zaretskii <eliz@gnu.org>
3395 * xdisp.c (start_display): If the character at POS is displayed
3396 via a display vector, reset IT->current.dpvec_index to zero.
3397 (try_window_reusing_current_matrix): If a line ends in a display
3398 vector or the next line starts in a display vector, continue
3399 redrawing the window even though the character position of
3400 start_row was reached.
3403 2011-10-18 Chong Yidong <cyd@gnu.org>
3405 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3406 with nobreak-char-display too.
3408 2011-10-18 Eli Zaretskii <eliz@gnu.org>
3410 Fix part 3 of bug#9771.
3411 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3412 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3413 non-neutral characters if the current character is a paragraph
3414 separator (a.k.a. Newline). This avoids running the same
3415 expensive loop twice, once when we consume the preceding newline
3416 and the other time when the line actually needs to be displayed.
3417 Avoid the loop when we see neutrals on the base embedding level
3418 following a character whose directionality is the same as the
3419 paragraph's. This avoids running the expensive loop when a line
3420 ends in a long sequence of neutrals, like control characters.
3421 Add assertion against STRONG_AL type. Slightly rearrange code
3422 that determines the type of a neutral given the first non-neutral
3424 (bidi_level_of_next_char): Set next_en_pos to zero when
3425 invalidating its info.
3427 2011-10-17 Eli Zaretskii <eliz@gnu.org>
3429 * xdisp.c (push_display_prop): Determine whether to record string
3430 or buffer position by IT->string, not by IT->method. Allow
3431 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
3432 (move_it_vertically_backward): Don't look for character position
3433 immediately after the newline when in a continuation line.
3436 2011-10-15 Martin Rudalics <rudalics@gmx.at>
3438 * window.c (coordinates_in_window): Rewrite and delabelize
3439 vertical border check. (Bug#5357) (Bug#9618)
3441 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3443 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3444 errors in XSetWindowBorder (bug#9310).
3446 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3448 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3449 avoid crash when xmalloc overrun checking is enabled.
3451 2011-10-13 Eli Zaretskii <eliz@gnu.org>
3453 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
3454 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
3455 cursor motion with <left> and <right> arrow keys.
3457 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
3458 some callers set that themselves.
3460 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3462 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
3463 display string and the previous row comes from the same string and
3464 is empty. (Bug#9739) (Bug#9738)
3466 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
3468 * doc.c (get_doc_string): Encode file name (bug#9735).
3470 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3472 * bidi.c (bidi_level_of_next_char):
3473 * xdisp.c (get_visually_first_element): Remove old incorrect
3474 comments regarding the Unicode Line Separator character.
3476 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
3478 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
3480 * alloc.c (Fgc_status): Do not access beyond zombies array
3481 boundary if nzombies > MAX_ZOMBIES.
3482 * alloc.c (dump_zombies): Add missing format specifier.
3484 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
3486 * xdisp.c (set_cursor_from_row): Simplify conditionals,
3487 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
3489 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
3490 Some packages use them to denote characters with modifiers.
3492 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
3494 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
3495 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
3496 matching a pp-number. Rename parameter var to var1.
3498 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
3500 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
3502 2011-10-08 Glenn Morris <rgm@gnu.org>
3504 * callint.c (Fcall_interactively): Give a more explicit error for the
3505 'c' case with a non-character input. (Bug#8479)
3507 2011-10-08 Eli Zaretskii <eliz@gnu.org>
3509 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
3511 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
3512 lines that are hscrolled on the left.
3514 * dispnew.c (buffer_posn_from_coords): Account for a possible
3515 presence of header-line. (Bug#4426)
3517 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
3519 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
3520 Don't advertise functionality which we discourage or doesn't work.
3522 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
3524 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
3525 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
3526 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
3527 this makes Emacs dump core during garbage collection on rare
3528 occasions. sizeof is obviously inferior to offsetof here, so
3529 stick with offsetof.
3530 (GC_POINTER_ALIGNMENT): New macro.
3531 (mark_memory): Omit 3rd (offset) arg; caller changed.
3532 Don't assume EMACS_INT alignment is the same as pointer alignment.
3534 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
3536 * keyboard.c (read_key_sequence_remapped): New var.
3537 (read_key_sequence): Compute remapping in the right buffer.
3538 (command_loop_1): Use read_key_sequence's remapping directly.
3540 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
3542 * dired.c (file_name_completion): Don't expand file name.
3543 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
3544 before checking file name handler.
3546 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
3547 they've been requested explicitly (bug#9591).
3549 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
3551 * keymap.c (Fsingle_key_description): Use make_specified_string
3552 instead of build_string to build string from push_key_description.
3555 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3557 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
3558 This fixes a Y2038 bug on 64-bit hosts.
3559 * buffer.c (reset_buffer):
3560 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
3561 (Fclear_buffer_auto_save_failure):
3562 Use 0, not -1, to represent an unset failure time, since time_t
3563 might not be signed.
3565 Remove dependency on glibc malloc internals.
3566 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3567 Move back here from lisp.h, but with their new implementations.
3568 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3569 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
3570 * charset.c (charset_table_init): New static var.
3571 (syms_of_charset): Use it instead of xmalloc. This removes a
3572 dependency on glibc malloc internals. See Eli Zaretskii's comment in
3573 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
3574 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3575 Move back to alloc.c.
3576 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3577 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
3579 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
3581 * nsterm.m (windowDidResize): Call x_set_window_size only when
3582 ns_in_resize is true. Otherwise set pixelwidth/height and
3583 call change_frame_size (Bug#9628).
3585 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3587 Port --enable-checking=all to Fedora 14 x86-64.
3588 * charset.c (syms_of_charset): Also account for glibc malloc's
3589 internal overhead when calculating the initial malloc maximum.
3591 Port --enable-checking=all to Fedora 14 x86.
3592 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3594 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
3595 (overrun_check_realloc, overrun_check_free):
3596 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
3597 That way, xmalloc returns a properly-aligned pointer even if
3598 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
3599 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
3600 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
3601 into account when calculating the initial malloc maximum.
3602 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3603 Move here from alloc.c, so that charset.c can use it too.
3604 Properly align; the old code wasn't right for common 32-bit hosts
3605 when configured with --enable-checking=all.
3606 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3607 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
3609 2011-09-29 Eli Zaretskii <eliz@gnu.org>
3611 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
3614 2011-09-28 Eli Zaretskii <eliz@gnu.org>
3616 * xdisp.c (compute_display_string_end): If there's no display
3617 string at CHARPOS, return -1.
3619 * bidi.c (bidi_fetch_char): When compute_display_string_end
3620 returns a negative value, treat the character as a normal
3621 character not covered by a display string. (Bug#9624)
3623 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
3625 * lread.c (Fread_from_string): Fix typo in docstring.
3627 2011-09-27 Eli Zaretskii <eliz@gnu.org>
3629 * xdisp.c (handle_invisible_prop): If invisible text ends on a
3630 newline, reseat the iterator instead of bidi-iterating there one
3631 character at a time. (Bug#9610)
3632 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
3633 TO_CHARPOS if the bidi iterator is at base embedding level.
3635 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
3637 * lread.c (readevalloop): Use correct code for NBSP.
3638 (read1): Likewise. (Bug#9608)
3640 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
3642 * dbusbind.c (Fdbus_register_signal): When service is not
3643 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
3645 2011-09-25 Glenn Morris <rgm@gnu.org>
3647 * buffer.c (truncate-lines): Doc fix.
3649 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
3651 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
3652 (Fset_window_next_buffers): Doc fix.
3654 2011-09-24 Glenn Morris <rgm@gnu.org>
3656 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
3658 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
3660 Fix minor problems found by static checking.
3661 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
3662 * indent.c (Fvertical_motion): Fix == vs = typo.
3664 2011-09-24 Eli Zaretskii <eliz@gnu.org>
3666 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
3667 Default value is now t. Doc fix.
3669 * indent.c (Fvertical_motion): Compute and apply the overshoot
3670 logic when moving up, not only when moving down. Fix the
3671 confusing name and values of the it_overshoot_expected variable;
3672 logic changes accordingly. (Bug#9254) (Bug#9549)
3674 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
3675 CHARPOS is covered by a display string which includes newlines.
3676 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
3677 is covered by a display string with embedded newlines.
3679 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
3681 * dbusbind.c (Fdbus_register_signal): Add match rule to
3682 Vdbus_registered_objects_table. (Bug#9581)
3683 (Fdbus_register_method, Vdbus_registered_objects_table):
3686 2011-09-24 Jim Meyering <meyering@redhat.com>
3688 do not ignore write error for any output size
3689 The previous change was incomplete.
3690 While it makes emacs --batch detect the vast majority of stdout
3691 write failures, errors were still ignored whenever the output size is
3692 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
3693 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
3694 && echo FAIL: ignored write error
3695 FAIL: ignored write error
3696 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
3697 && echo FAIL: ignored write error
3698 FAIL: ignored write error
3699 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
3701 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
3703 * emacs.c (Fkill_emacs): In noninteractive mode exit
3704 non-successfully if a write error occurred on stdout. (Bug#9574)
3706 2011-09-21 Eli Zaretskii <eliz@gnu.org>
3708 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
3711 * dispextern.h (struct it): Update the comment documenting what
3714 2011-09-20 Eli Zaretskii <eliz@gnu.org>
3716 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
3717 a display string, extend search for cursor position to end of row.
3718 (find_row_edges): If the row ends in a newline from a display
3719 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
3720 Handle the case of a display string with multiple newlines.
3721 (Fcurrent_bidi_paragraph_direction): Fix search for previous
3722 non-empty line. Fixes confusing cursor motion with arrow keys at
3723 the beginning of a line that starts with whitespace.
3725 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3727 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
3730 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
3732 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
3735 2011-09-18 Eli Zaretskii <eliz@gnu.org>
3737 * xdisp.c (display_line): Record maximum and minimum buffer
3738 positions even if no glyphs were produced (e.g., by a zero-width
3739 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
3740 buffer positions that will be removed from the glyph row because
3742 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
3743 column is beyond frame width: don't subtract 1 "pixel" when
3744 computing width of the stretch.
3745 (reseat_at_next_visible_line_start): Undo the change made on
3746 2011-09-17 that saved paragraph information and restored it after
3747 the call to `reseat'. (Bug#9545)
3749 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3751 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
3752 and turn window cursor on if cleared (Bug#9415).
3754 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
3756 * search.c (boyer_moore): Take unibyte characters from pattern
3757 literally. (Bug#9458)
3759 2011-09-18 Eli Zaretskii <eliz@gnu.org>
3761 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
3763 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
3765 Fix minor problem found by static checking.
3766 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
3767 initialized, to pacify gcc -Wuninitialized.
3769 * fileio.c: Report proper errno when syscall falls.
3770 (Finsert_file_contents): Save and restore errno,
3771 so that report_file_error outputs the correct diagnostic.
3772 (Fwrite_region) [CLASH_DETECTION]: Likewise.
3774 2011-09-18 Eli Zaretskii <eliz@gnu.org>
3776 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
3778 2011-09-17 Eli Zaretskii <eliz@gnu.org>
3780 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
3781 2011-08-30 (revision 105619). (Bug#9530)
3783 2011-09-17 Eli Zaretskii <eliz@gnu.org>
3785 * xdisp.c (reseat_at_next_visible_line_start): Keep information
3786 about the current paragraph and restore it after the call to reseat.
3788 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
3789 (bidi_find_paragraph_start): Search back for paragraph beginning
3790 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
3791 (bidi_move_to_visually_next): Only trigger paragraph-related
3792 computations when the last character is a newline or at EOB, not
3793 just any NEUTRAL_B. (Bug#9470)
3795 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
3796 truncated lines if point is covered by a display string. (Bug#9524)
3798 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
3800 * xselect.c: Relax test for outgoing X longs (Bug#9498).
3801 (cons_to_x_long): New function.
3802 (lisp_data_to_selection_data): Use it. Correct the test for
3803 short-versus-long data; it was negated. Break out of vector
3804 loop, for efficiency, when a long datum is discovered.
3806 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
3808 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
3810 2011-09-16 Eli Zaretskii <eliz@gnu.org>
3812 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
3813 GCC PR/17406) by declaring this function with external scope.
3815 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
3817 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
3818 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
3820 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
3822 * editfns.c (Fformat): Correctly handle text properties on "%%".
3824 2011-09-15 Eli Zaretskii <eliz@gnu.org>
3826 * xterm.c (x_draw_composite_glyph_string_foreground):
3827 * w32term.c (x_draw_composite_glyph_string_foreground):
3828 * term.c (encode_terminal_code):
3829 * composite.c (composition_update_it, get_composition_id):
3830 * xdisp.c (get_next_display_element)
3831 (fill_composite_glyph_string): Add comments about special meaning
3832 of TAB characters in a composition.
3834 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
3836 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
3837 This occurs when processing a multibyte format.
3838 Problem reported by Wolfgang Jenker.
3840 2011-09-15 Johan Bockgård <bojohan@gnu.org>
3842 * xdisp.c (try_cursor_movement): Only check for exact match if
3843 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
3845 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
3847 Remove unused external symbols.
3848 * dispextern.h (calc_pixel_width_or_height): Remove decl.
3849 * xdisp.c (calc_pixel_width_or_height): Now static.
3850 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
3851 * indent.c (check_display_width):
3852 * w32term.c: Fix comment to match code.
3853 * xterm.c, xterm.h (x_catching_errors): Remove.
3855 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
3857 * xselect.c: Use signed conversions more consistently (Bug#9498).
3858 (selection_data_to_lisp_data): Assume incoming selection data are
3859 signed integers, not unsigned. This is to be consistent with
3860 outgoing selection data, which was modified to use signed integers
3861 in as part of the fix to Bug#9196 in response to Jan D.'s comment
3862 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
3863 expects long, not unsigned long.
3865 2011-09-14 Eli Zaretskii <eliz@gnu.org>
3867 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
3868 computation of loop end. Reported by Johan Bockgård
3871 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
3873 * frame.c (Fother_visible_frames_p): Function deleted.
3875 2011-09-12 Eli Zaretskii <eliz@gnu.org>
3877 * indent.c (compute_motion): Process display vector front to back
3878 rather than the other way around. (Bug#2496)
3880 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
3882 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
3884 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
3886 * minibuf.c (Fread_from_minibuffer): Doc fix.
3888 2011-09-11 Eli Zaretskii <eliz@gnu.org>
3890 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
3891 2011-08-30 (revision 105619). (Bug#9475)
3893 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3895 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
3896 value for non-existent files.
3898 2011-09-11 Eli Zaretskii <eliz@gnu.org>
3900 * fileio.c (Finsert_file_contents): If the file cannot be opened,
3901 set its "size" to -1. This will set the modtime_size field of
3902 the corresponding buffer to -1, which is what
3903 verify-visited-file-modtime expects for files that do not exist.
3906 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
3908 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
3910 * lisp.h: ... from here. push_key_description is no longer
3911 defined in keyboard.c, so its declaration should not be in
3912 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
3913 logically belongs with push_key_description.
3915 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
3917 * buffer.h: Include <sys/types.h> instead of <time.h>.
3918 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
3919 Problem reported by Herbert J. Skuhra.
3921 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
3923 * xml.c (parse_region): Make the parsing work for
3924 non-comment-starting XML files again (bug#9144).
3926 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
3928 * image.c (gif_load): Fix calculation of bottom and right corner.
3931 2011-09-10 Eli Zaretskii <eliz@gnu.org>
3933 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
3934 redisplay in small windows.
3936 2011-09-09 Eli Zaretskii <eliz@gnu.org>
3938 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
3940 2011-09-08 Martin Rudalics <rudalics@gmx.at>
3942 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
3943 Operate on live windows only.
3945 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
3947 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
3949 2011-09-07 Eli Zaretskii <eliz@gnu.org>
3951 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
3952 only under bidi iteration.
3954 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
3956 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
3958 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
3960 isnan: Fix porting problem to Solaris 10 with bundled gcc.
3961 Without this fix, the command to link temacs failed due to an
3962 undefined symbol __builtin_isnan. This is because
3963 /usr/include/iso/math_c99.h #defines isnan(x) to
3964 __builtin_isnan(x), but the bundled gcc, which identifies itself
3965 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
3967 * floatfns.c (isnan): #undef, and then #define to a clone of
3969 (Fisnan): Always define, since it's always available now.
3970 (syms_of_floatfns): Always define isnan at the Lisp level.
3972 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
3974 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
3976 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
3978 * fileio.c: Fix bugs with large file offsets (Bug#9428).
3979 The previous code assumed that file offsets (off_t values) fit in
3980 EMACS_INT variables, which is not true on typical 32-bit hosts.
3981 The code messed up by falsely reporting buffer overflow in cases
3982 such as (insert-file-contents "big" nil 1 2) into an empty buffer
3983 when "big" contains more than 2**29 bytes, even though this
3984 inserts just one byte and does not overflow the buffer.
3985 (Finsert_file_contents): Store file offsets as off_t
3986 values, not as EMACS_INT values. Check for overflow when
3987 converting between EMACS_INT and off_t. When checking for
3988 buffer overflow or for overlap, take the offsets into account.
3989 Don't use EMACS_INT for small values where int suffices.
3990 When checking for overlap, fix a typo: ZV was used where
3991 ZV_BYTE was intended.
3992 (Fwrite_region): Don't assume off_t fits into 'long'.
3993 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
3995 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
3997 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
3999 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4001 sprintf-related integer and memory overflow issues (Bug#9412).
4003 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
4004 (esprintf, exprintf, evxprintf): New functions.
4005 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
4006 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
4007 (modify_event_symbol): Do not assume that the length of
4008 name_alist_or_stem is safe to alloca and fits in int.
4009 (Fexecute_extended_command): Likewise for function name and binding.
4010 (Frecursion_depth): Wrap around reliably on integer overflow.
4011 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4012 since some callers pass EMACS_INT values.
4013 (Fsingle_key_description): Don't crash if symbol name contains more
4014 than MAX_ALLOCA bytes.
4015 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4016 (get_minibuffer): Arg is now EMACS_INT, not int.
4017 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
4018 (esprintf, exprintf, evxprintf): New decls.
4019 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4021 * dbusbind.c (signature_cat): New function.
4022 (xd_signature, Fdbus_register_signal):
4023 Do not overrun buffer; instead, report string overflow.
4025 * dispnew.c (add_window_display_history): Don't overrun buffer.
4026 Truncate instead; this is OK since it's just a log.
4028 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4029 even if the time zone offset is outlandishly large.
4030 Don't mishandle offset == INT_MIN.
4032 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4033 when creating daemon; the previous buffer-overflow check was incorrect.
4035 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4036 which has the guts of the old verror function.
4038 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4039 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4041 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4042 (font_unparse_xlfd): Don't blindly alloca long strings.
4043 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
4044 fits in int, when using sprintf. Use single snprintf to count
4045 length of string rather than counting it via multiple sprintfs;
4046 that's simpler and more reliable.
4047 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4048 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4049 sprintf, in case result does not fit in int.
4051 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4052 (fontset_from_font): Print it.
4054 * frame.c (tty_frame_count): Now printmax_t, not int.
4055 (make_terminal_frame, set_term_frame_name): Print it.
4056 (x_report_frame_params): In X, window IDs are unsigned long,
4057 not signed long, so print them as unsigned.
4058 (validate_x_resource_name): Check for implausibly long names,
4059 and don't assume name length fits in 'int'.
4060 (x_get_resource_string): Don't blindly alloca invocation name;
4061 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4064 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4065 (xg_check_special_colors, xg_set_geometry):
4066 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4068 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4069 Use esprintf, not sprintf, in case result does not fit in int.
4071 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4072 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4073 it as a large positive number.
4074 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4075 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4077 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4078 in case result does not fit in int.
4080 * print.c (float_to_string): Detect width overflow more reliably.
4081 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4082 buffer overrun. Don't assume list length fits in 'int'. Treat
4083 print length of 0 as 0, not as infinity; to be consistent with other
4084 uses of print length in this function. Don't overflow print length
4085 index. Don't assume hash table size fits in 'long', or that
4086 vectorlike size fits in 'unsigned long'.
4088 * process.c (make_process): Use printmax_t, not int, to format
4089 process-name gensyms.
4091 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4093 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4094 to avoid potential buffer overrun.
4096 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4097 if X resource line is longer than 512 bytes.
4099 * xfns.c (x_window): Make sprintf buffer a bit bigger
4100 to avoid potential buffer overrun.
4102 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4104 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4106 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4108 Integer overflow fixes for scrolling, etc.
4109 Without these, Emacs silently mishandles large integers sometimes.
4110 For example, "C-u 4294967297 M-x recenter" was treated as if
4111 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4113 * xdisp.c (try_window_id): Check Emacs fixnum range before
4114 converting to 'int'.
4116 * window.c (window_scroll_line_based, Frecenter):
4117 Check that an Emacs fixnum is in range before assigning it to 'int'.
4118 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4119 values converted from Emacs fixnums.
4120 (Frecenter): Don't wrap around a line count if it is out of 'int'
4121 range; instead, treat it as an extreme value.
4122 (Fset_window_configuration, compare_window_configurations):
4123 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4125 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4126 that can exceed INT_MAX. Check that EMACS_INT value is in range
4127 before assigning it to the (possibly-narrower) index.
4128 (match_limit): Don't assume that a fixnum can fit in 'int'.
4130 * print.c (print_object): Use ptrdiff_t, not int, for index that can
4133 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
4134 (Fvertical_motion): Don't wrap around LINES values that don't fit
4135 in 'int'. Instead, treat them as extreme values. This is good
4136 enough for windows, which can't have more than INT_MAX lines anyway.
4138 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4140 * Require libxml/parser.h to avoid compilation warning.
4142 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4144 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4145 since this reportedly can destroy thread storage.
4147 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
4149 * syntax.c (find_defun_start): Update all cache variables if
4150 exiting early (Bug#9401).
4152 2011-08-30 Eli Zaretskii <eliz@gnu.org>
4154 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4156 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4157 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4158 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4160 * term.c (tty_append_glyph): New function.
4161 (produce_stretch_glyph): Static function and its prototype deleted.
4163 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4166 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4168 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4169 when checking :margin (Bug#9390).
4170 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
4171 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
4172 so that the name doesn't mislead. All uses changed.
4174 2011-08-28 Johan Bockgård <bojohan@gnu.org>
4176 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4179 2011-08-27 Eli Zaretskii <eliz@gnu.org>
4181 * xdisp.c (move_it_to): Don't bail out early when reaching
4182 position beyond to_charpos, if we are scanning backwards.
4183 (move_it_vertically_backward): When DY == 0, make sure we get to
4184 the first character in the line after the newline.
4186 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4188 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4189 (ccl_driver): Do not generate an out-of-range pointer.
4190 (Fccl_execute_on_string): Remove unnecessary check for
4191 integer overflow, noted by Stefan Monnier in
4192 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4193 Remove a FIXME that didn't need fixing.
4194 Simplify the newly-introduced buffer reallocation code.
4196 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
4198 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4200 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
4202 Integer and memory overflow issues (Bug#9196).
4204 * doc.c (get_doc_string): Rework so that
4205 get_doc_string_buffer_size is the actual buffer size, rather than
4206 being 1 less than the actual buffer size; this makes xpalloc more
4209 * image.c (x_allocate_bitmap_record, cache_image):
4210 * xselect.c (Fx_register_dnd_atom):
4211 Simplify previous changes by using xpalloc.
4213 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4214 since either will do and ptrdiff_t is convenient with xpalloc.
4216 * charset.c (charset_table_size)
4217 (struct charset_sort_data.priority): Now ptrdiff_t.
4218 (charset_compare): Don't overflow if priorities differ greatly.
4219 (Fsort_charsets): Don't assume list length fits in int.
4220 Check for size-calculation overflow when allocating sort data.
4221 (syms_of_charset): Allocate an initial charset table that is
4222 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4224 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4226 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4227 The actual value is always <= INT_MAX, and leaving it unsigned made
4228 overflow checking harder.
4230 * dispextern.h (struct glyph_matrix.rows_allocated)
4231 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4232 with xpalloc. The values are still always <= INT_MAX.
4234 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4236 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4237 (SAFE_NALLOCA): New macro.
4239 * region-cache.c (struct boundary.pos, find_cache_boundary)
4240 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4241 (set_cache_region, invalidate_region_cache)
4242 (revalidate_region_cache, know_region_cache, region_cache_forward)
4243 (region_cache_backward, pp_cache):
4244 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4245 so that ptrdiff_t * can be passed to xpalloc.
4246 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4247 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4248 (pp_cache): Don't assume cache_len fits in int.
4249 * region-cache.h: Adjust extern decls to match.
4251 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4252 EMACS_INT, since either will do, for xpalloc.
4254 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4255 (xnmalloc, xnrealloc, xpalloc): New functions.
4257 * bidi.c (bidi_shelve_header_size): New constant.
4258 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4259 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4261 * bidi.c (bidi_cache_shrink):
4262 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4264 Don't update size of array until after memory allocation succeeds,
4265 because xmalloc/xrealloc may not return.
4266 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4267 now that we have proper integer overflow checking.
4268 (record_overlay_string, overlay_strings): Catch overflows when
4269 calculating size of overlay_str_buf.
4271 * callproc.c (Fcall_process): Check for size overflow when
4272 calculating size of args2.
4273 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4274 Normally we prefer signed values, but sticking with ptrdiff_t would
4275 require adding more-complicated checks.
4277 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4278 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4279 Redo buffer-overflow calculations to avoid integer overflow.
4280 Add a FIXME comment where memory seems to be over-allocated.
4282 * character.c (Fstring): Check for size-calculation overflow.
4284 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4285 unnecessary integer overflow. Check for size overflow.
4286 (encode_coding_object): Don't update size until xmalloc succeeds.
4288 * composite.c (get_composition_id): Check for overflow in glyph
4289 length calculations.
4291 Integer and memory overflow fixes for display code.
4292 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4293 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4294 (scrolling_window): Check for overflow in size calculations.
4295 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4296 Don't assume glyph table len fits in int.
4297 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4298 (row_table_size): Now ptrdiff_t, not int.
4299 (scrolling_window): Avoid overflow in size calculations.
4300 Don't update size until allocation succeeds.
4301 * fns.c (concat): Check for overflow in size calculations.
4302 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4303 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4304 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4306 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4307 (get_doc_string): Check for size calculation overflow.
4308 Don't update size until allocation succeeds.
4309 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4310 EMACS_INT, where ptrdiff_t will do.
4311 (Fsubstitute_command_keys): Check for string overflow.
4313 * editfns.c (set_time_zone_rule): Don't assume environment length
4315 (message_length): Now ptrdiff_t, not int.
4316 (Fmessage_box): Don't update size until allocation succeeds.
4317 Don't assume message length fits in int.
4318 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4320 * emacs.c (main): Do not reallocate argv, since there is a null at
4321 the end that can be overwritten, and this way there's no need to
4322 worry about size-calculation overflow.
4323 (sort_args): Check for size-calculation overflow.
4325 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4327 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4329 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4330 (x_set_scroll_bar_width, x_figure_window_size):
4331 Check for integer overflow.
4332 (x_set_alpha): Do not assume XINT fits in int.
4334 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4335 This is for the members text_lines, text_cols, total_lines, total_cols,
4336 where the system imposes an 'int' limit.
4338 * fringe.c (Fdefine_fringe_bitmap):
4339 Don't update size until alloc works.
4341 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4342 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4344 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4345 Check for size-calculation overflow.
4346 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4347 do, as we prefer signed integers.
4348 (id_to_widget.max_size, id_to_widget.used)
4349 (xg_store_widget_in_map, xg_remove_widget_from_map)
4350 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4351 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4352 Use and return ptrdiff_t, not int.
4353 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4354 * gtkutil.h: Change prototypes to match the above.
4356 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4357 are duplicate now that they've been promoted to lisp.h.
4358 (x_allocate_bitmap_record, x_alloc_image_color)
4359 (make_image_cache, cache_image, xpm_load):
4360 Don't update size until alloc is done.
4361 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4363 Check for size calculation overflow.
4364 (ct_colors_allocated_max): New constant.
4365 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4368 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4369 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4370 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4371 Use ptrdiff_t, not int, to count maps.
4372 (read_char_minibuf_menu_prompt): Check for overflow in size
4373 calculations. Don't update size until allocation succeeds.
4374 Redo calculations to avoid overflow.
4375 * keyboard.h: Change prototypes to match the above.
4377 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4379 (current_minor_maps): Check for size calculation overflow.
4380 * keymap.h: Change prototypes to match the above.
4382 * lread.c (read1, init_obarray): Don't update size until alloc done.
4384 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4385 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4387 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4388 Now ptrdiff_t, not int.
4389 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4390 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4392 * process.c (Fnetwork_interface_list): Check for overflow
4393 in size calculation.
4395 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4397 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4398 overflow. Don't bother calling xmalloc when xrealloc will do.
4400 * search.c (Freplace_match): Check for size calculation overflow.
4401 (Fset_match_data): Don't assume list lengths fit in 'int'.
4403 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4404 for command line length. Do not attempt to address one before the
4405 beginning of an array, as that's not portable.
4407 * term.c (max_frame_lines): Remove; unused.
4408 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4410 (encode_terminal_code, calculate_costs): Check for size
4411 calculation overflow.
4412 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4413 table lengths and related sizes. Don't update size until alloc
4414 done. Redo calculations to avoid overflow.
4415 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4417 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4418 subtracting pointers.
4419 (gobble_line): Check for overflow more carefully. Don't update size
4422 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4423 Don't update size until alloc done.
4424 Redo size calculations to avoid overflow.
4425 Check for size calculation overflow.
4426 (main) [DEBUG]: Fix typo in invoking tparam1.
4428 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4429 Use ptrdiff_t, not int, for sizes.
4430 (store_mode_line_noprop_char): Don't update size until alloc done.
4432 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4433 Use ptrdiff_t, not int, for sizes.
4434 (Finternal_make_lisp_face, cache_face):
4435 Check for size calculation overflow.
4436 (cache_face): Treat size calculation overflows as if they were
4437 memory exhaustion (the usual treatment), rather than aborting.
4439 * xfns.c (x_encode_text, x_set_name_internal)
4440 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4441 sizes, since they can exceed INT_MAX in size. Check for size
4442 calculation overflow.
4444 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4445 (xg_select): Check for size calculation overflow.
4446 Don't update size until alloc done.
4448 * xrdb.c (get_environ_db): Don't assume path length fits in int,
4449 as sprintf is limited to int lengths.
4451 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
4452 (X_LONG_MIN): New macros.
4453 Use them to make the following changes clearer.
4454 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
4455 This change doesn't affect the value now, but it may help remind
4456 future maintainers not to raise the value too much later.
4457 (SELECTION_QUANTUM): Remove, replacing with ...
4458 (selection_quantum): ... new function, which avoids overflow.
4460 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
4461 assumption that selection length fits in 'int'.
4462 (x_reply_selection_request, x_handle_selection_request)
4463 (x_get_window_property, receive_incremental_selection)
4464 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
4465 (lisp_data_to_selection_data, clean_local_selection_data):
4466 Use ptrdiff_t, not int, to record length of selection.
4467 (x_reply_selection_request, x_get_window_property)
4468 (receive_incremental_selection, x_property_data_to_lisp):
4469 Redo calculations to avoid overflow.
4470 (x_reply_selection_request): When sending hint, ceiling it at
4471 X_LONG_MAX rather than relying on wraparound overflow to send
4473 (x_get_window_property, receive_incremental_selection)
4474 (lisp_data_to_selection_data, x_property_data_to_lisp):
4475 Check for size-calculation overflow.
4476 (x_get_window_property, receive_incremental_selection)
4477 (lisp_data_to_selection_data, Fx_register_dnd_atom):
4478 Don't store size until memory allocation succeeds.
4479 (x_get_window_property): Plug memory leak on memory exhaustion.
4480 Don't double-block input; malloc is safe here. Don't assume 2**34
4481 - 4 fits in unsigned long. Add an xassert to check
4482 XGetWindowProperty overflow. Be more careful about overflow
4483 calculations, and distinguish size from memory overflow better.
4484 (receive_incremental_selection): When tracing, don't assume
4485 unsigned int is less than INT_MAX.
4486 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
4487 harmful) conversions of unsigned short to int.
4488 (lisp_data_to_selection_data): Don't assume that integers
4489 in the range -65535 through -1 fit in an X unsigned short.
4490 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
4491 result parameters unless successful. Rely on cons_to_unsigned
4492 to report problems with elements; the old code wasn't right anyway.
4493 (x_check_property_data): Check for int overflow; we cannot use
4494 a wider type due to X limits.
4495 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
4497 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
4499 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
4500 (x_term_init): Check for size calculation overflow.
4501 (x_color_cells): Don't store size until memory allocation succeeds.
4502 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
4503 Don't assume alloca size is less than MAX_ALLOCA.
4504 (x_term_init): Don't assume length fits in int (sprintf is limited
4507 Use ptrdiff_t for composition IDs.
4508 * character.c (lisp_string_width):
4509 * composite.c (composition_table_size, n_compositions)
4510 (get_composition_id, composition_gstring_from_id):
4511 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
4512 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
4513 * window.c (Frecenter):
4514 Use ptrdiff_t, not int, for composition IDs.
4515 * composite.c (get_composition_id): Check for integer overflow.
4516 * composite.h: Adjust prototypes to match the above changes.
4518 Use ptrdiff_t for hash table indexes.
4519 * category.c (hash_get_category_set):
4520 * ccl.c (ccl_driver):
4521 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
4522 * coding.c (coding_system_charset_list, detect_coding_system):
4523 * coding.h (struct coding_system.id):
4524 * composite.c (get_composition_id, gstring_lookup_cache):
4525 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
4526 * image.c (xpm_get_color_table_h):
4527 * lisp.h (hash_lookup, hash_put):
4528 * minibuf.c (Ftest_completion):
4529 Use ptrdiff_t for hash table indexes, not int (which is too
4530 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
4531 32-bit --with-wide-int hosts).
4533 * charset.c (Fdefine_charset_internal): Check for integer overflow.
4534 Add a FIXME comment about memory leaks.
4535 (syms_of_charset): Don't assume xmalloc returns.
4537 Don't assume that stated character widths fit in int.
4538 * character.c (Fchar_width, c_string_width, lisp_string_width):
4539 * character.h (CHAR_WIDTH):
4540 * indent.c (MULTIBYTE_BYTES_WIDTH):
4541 Use sanitize_char_width to avoid undefined and/or bad behavior
4542 with outlandish widths.
4543 * character.h (sanitize_tab_width): Rename from sanitize_width,
4544 now that we have two such functions. All uses changed.
4545 (sanitize_char_width): New inline function.
4547 Don't assume that tab-width fits in int.
4548 * character.h (sanitize_width): New inline function.
4549 (SANE_TAB_WIDTH): New macro.
4550 (ASCII_CHAR_WIDTH): Use it.
4551 * indent.c (sane_tab_width): Remove. All uses replaced by
4552 SANE_TAB_WIDTH (current_buffer).
4553 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
4555 * fileio.c: Integer overflow issues with file modes.
4556 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
4558 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
4559 Remove unreachable code.
4560 (read_hex, load_charset_map_from_file): Check for integer overflow.
4562 * xterm.c: Don't go over XClientMessageEvent limit.
4563 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
4564 (x_send_scroll_bar_event): Likewise. Check that the size does not
4565 exceed limits imposed by XClientMessageEvent, as well as the usual
4566 ptrdiff_t and size_t limits.
4568 * keyboard.c: Overflow, signedness and related fixes.
4569 (make_lispy_movement): Use same integer type in forward decl
4570 that is used in the definition.
4571 (read_key_sequence, keyremap_step):
4572 Change bufsize argument back to int, undoing my 2011-03-30 change.
4573 We prefer signed types, and int is wide enough here.
4574 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
4575 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
4576 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
4577 length, not size_t. Use ptrdiff_t for index, not int.
4578 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
4579 possibility of integer overflow.
4581 Overflow, signedness and related fixes for images.
4583 * dispextern.h (struct it.stack[0].u.image.image_id)
4584 (struct_it.image_id, struct image.id, struct image_cache.size)
4585 (struct image_cache.used, struct image_cache.ref_count):
4586 * gtkutil.c (update_frame_tool_bar):
4587 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
4588 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
4589 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
4590 * nsmenu.m (update_frame_tool_bar):
4591 * xdisp.c (calc_pixel_width_or_height):
4592 * xfns.c (image_cache_refcount):
4593 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
4594 on typical 64-bit hosts.
4596 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4597 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
4598 Omit unnecessary casts to int.
4599 (parse_image_spec): Check that integers fall into 'int' range
4600 when the callers expect that.
4601 (image_ascent): Redo ascent calculation to avoid int overflow.
4602 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
4603 (lookup_image): Remove unnecessary tests.
4604 (xbm_image_p): Locals are now of int, not EMACS_INT,
4605 since parse_image_check makes sure they fit into int.
4606 (png_load, gif_load, svg_load_image):
4607 Prefer int to unsigned where either will do.
4608 (tiff_handler): New function, combining the cores of the
4609 old tiff_error_handler and tiff_warning_handler.
4610 This function is rewritten to use vsnprintf and thereby avoid
4611 stack buffer overflows. It uses only the features of vsnprintf
4612 that are common to both POSIX and native Microsoft.
4613 (tiff_error_handler, tiff_warning_handler): Use it.
4614 (tiff_load, gif_load, imagemagick_load_image):
4615 Don't assume :index value fits in 'int'.
4616 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
4617 (imagemagick_load_image): Check that crop parameters fit into
4618 the integer types that MagickCropImage accepts. Don't assume
4619 Vimagemagick_render_type has a nonnegative value. Don't assume
4620 size_t fits in 'long'.
4621 (gs_load): Use printmax_t to print the widest integers possible.
4622 Check for integer overflow when computing image height and width.
4624 2011-08-26 Eli Zaretskii <eliz@gnu.org>
4626 * xdisp.c (redisplay_window): Don't force window start if point
4627 will be invisible in the resulting window. (Bug#9324)
4629 2011-08-25 Eli Zaretskii <eliz@gnu.org>
4631 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
4632 the display spec is of the form `(space ...)'.
4633 (handle_display_spec): Return the value returned by
4634 handle_single_display_spec, not just 1 or zero.
4635 (handle_single_display_spec): If the display spec is of the form
4636 `(space ...)', and specifies display in the text area, return 2
4638 (try_cursor_movement): Check for the need to scroll more
4639 accurately, and prefer exact match for point under bidi.
4640 Don't advance `row' beyond the last row of the window.
4642 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
4643 into disp_prop; all users changed.
4645 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
4646 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
4647 for the text covered by the display property.
4649 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
4651 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
4652 Change return value to nil.
4653 (Frecord_buffer): Delete unused function.
4655 2011-08-24 Eli Zaretskii <eliz@gnu.org>
4657 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
4658 buffers, return left-to-right.
4659 (set_cursor_from_row): Consider candidate row a win if its glyph
4660 represents a newline and point is on that newline. Fixes cursor
4661 positioning on the newline at EOL of R2L text within L2R
4662 paragraph, and vice versa.
4663 (try_cursor_movement): Check continued rows, in addition to
4664 continuation rows. Fixes unwarranted scroll when point enters a
4665 continued line of R2L text within an L2R paragraph, or vice versa.
4666 (cursor_row_p): Consider the case of point being equal to
4667 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
4668 from the end of a short line to the beginning of a continued line
4669 of R2L text within L2R paragraph.
4670 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
4671 composed characters.
4673 * bidi.c (bidi_check_type): Use xassert.
4674 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
4677 2011-08-23 Eli Zaretskii <eliz@gnu.org>
4679 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
4682 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
4684 * nsfont.m (ns_otf_to_script): Fix typo.
4686 2011-08-22 Kenichi Handa <handa@m17n.org>
4688 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
4689 extra slot even if the purpose is char-code-property-table.
4691 2011-08-23 Eli Zaretskii <eliz@gnu.org>
4693 * xdisp.c (redisplay_window): When computing centering_position,
4694 account for the height of the header line. (Bug#8874)
4696 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
4697 instead of CHAR_TO_BYTE. Fixes a crash when a completion
4698 candidate is selected by the mouse, and that candidate has a
4699 composed character under the mouse.
4701 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
4702 coordinates reported by pos-visible-in-window-p for a composed
4703 character in column zero.
4705 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
4707 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
4709 2011-08-22 Eli Zaretskii <eliz@gnu.org>
4711 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
4712 consider it a hit if to_charpos is anywhere in the range of the
4713 composed buffer positions.
4715 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
4717 * image.c (gif_load): Don't assume that each subimage has the same
4718 dimensions as the base image. Handle disposal method that is
4719 "undefined" by the gif spec (Bug#9335).
4721 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
4723 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
4724 (Fcondition_case): Document `debug' symbol in error handler.
4726 2011-08-19 Eli Zaretskii <eliz@gnu.org>
4728 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
4729 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
4730 from an Org mode buffer to a Speedbar frame.
4732 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
4733 a composition, take its buffer position from IT->cmp_it.charpos.
4734 Fixes cursor positioning at the beginning of a line that begins
4735 with a composed character.
4737 2011-08-18 Eli Zaretskii <eliz@gnu.org>
4739 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
4740 character bidirectional type, use STRONG_L instead. Fixes crashes
4741 in a buffer produced by `describe-categories'.
4743 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
4744 members before the level stack, so they would be saved and
4745 restored when copying iterator state. Fixes incorrect reordering
4746 around TABs covered by display properties.
4748 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
4750 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
4752 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
4754 * eval.c (internal_condition_case, internal_condition_case_1)
4755 (internal_condition_case_2, internal_condition_case_n):
4756 Remove unnecessary aborts (Bug#9081).
4758 2011-08-17 Eli Zaretskii <eliz@gnu.org>
4760 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
4761 has no `load' handler, try opening the file locally. (Bug#9311)
4763 2011-08-16 Ken Brown <kbrown@cornell.edu>
4765 * gmalloc.c: Expand comment.
4767 2011-08-16 Eli Zaretskii <eliz@gnu.org>
4769 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
4770 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
4772 2011-08-16 Ken Brown <kbrown@cornell.edu>
4774 Fix memory allocation problems in Cygwin build (Bug#9273).
4776 * unexcw.c ( __malloc_initialized): Declare external variable.
4777 (fixup_executable): Force the dumped emacs to reinitialize malloc.
4779 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
4781 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
4783 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
4785 [CYGWIN] (special_realloc): New function.
4786 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
4787 requests to realloc storage in the static heap.
4789 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
4791 * bidi.c (bidi_initialize): Remove unused local.
4793 2011-08-15 Eli Zaretskii <eliz@gnu.org>
4796 * biditype.h: Remove file.
4797 * makefile.w32-in ($(BLD)/bidi.$(O)):
4798 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
4800 * dispextern.h: Fix a typo in the comment to bidi_type_t.
4802 * chartab.c: Improve commentary for the uniprop_table API.
4804 * bidi.c (bidi_paragraph_init): Support zero value of
4805 bidi_ignore_explicit_marks_for_paragraph_level.
4806 (bidi_initialize): Use uniprop_table instead of including
4807 biditype.h and bidimirror.h.
4809 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
4810 coordinates of the iterator when restoring from ppos_it.
4813 2011-08-14 Kenichi Handa <handa@m17n.org>
4815 * process.c (create_process): Call setup_process_coding_systems
4816 after the pid of the process is set to -1 (Bug#8162).
4818 2011-08-14 Eli Zaretskii <eliz@gnu.org>
4820 * xdisp.c (move_it_in_display_line_to): Don't invoke
4821 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
4822 ppos_it. Fixes vertical cursor motion when line beginning is
4823 covered by an image. (Bug#9296)
4825 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
4827 * nsterm.h (ns_run_ascript): Declare.
4828 (NSAPP_DATA2_RUNASSCRIPT): Define.
4830 * nsfns.m (as_script, as_result, as_status): New static variables.
4831 (ns_run_ascript): New function.
4832 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
4833 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
4834 the event loop. Get status from as_status (Bug#7276).
4836 * nsterm.m (sendEvent): If event is NSApplicationDefined and
4837 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
4838 the event loop (Bug#7276).
4840 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
4842 * gnutls.c (QCgnutls_bootprop_priority)
4843 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
4844 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
4845 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
4846 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
4847 (QCgnutls_bootprop_verify_hostname_error)
4848 (QCgnutls_bootprop_callbacks_verify): Rename from
4849 Qgnutls_bootprop_..., all uses changed.
4851 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
4854 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
4856 * xfaces.c (Qframe_set_background_mode): Now static.
4857 * dispextern.h (Qframe_set_background_mode): Remove decl.
4859 * process.c (Fnetwork_interface_info): Declare local only if needed.
4861 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
4863 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
4864 (Fnetwork_interface_list): Allocate in increments of bytes instead
4865 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
4866 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
4868 (struct ifflag_def): notrailers is smart on OSX.
4869 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
4870 Get hardware address with getifaddrs if available.
4872 2011-08-12 Eli Zaretskii <eliz@gnu.org>
4874 * xdisp.c (iterate_out_of_display_property): xassert that
4875 IT->position is set to within IT->object's boundaries. Break from
4876 the loop as soon as EOB is reached; avoids infloops in redisplay
4877 when IT->position is set up wrongly due to some bug.
4878 Set IT->current to match the bidi iterator unconditionally.
4879 (push_display_prop): Allow GET_FROM_STRING as IT->method on
4880 entry. Force push_it to save on the stack the current
4881 buffer/string position, to be restored by pop_it. Fix flags in
4882 the iterator structure wrt the object coming from a display
4883 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
4884 properties. (Bug#9284)
4886 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
4888 * fontset.c (fontset_get_font_group): Add proper type checks.
4891 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4893 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
4894 and LC_VERSION_MIN_MACOSX.
4895 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
4896 (dump_it) [LC_FUNCTION_STARTS]: Use it.
4898 2011-08-08 Eli Zaretskii <eliz@gnu.org>
4900 * xdisp.c (forward_to_next_line_start): Allow to use the
4901 no-display-properties-and-no-overlays under bidi display.
4902 Set disp_pos in the bidi iterator to avoid searches for display
4903 properties and overlays.
4905 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
4907 * editfns.c (Fset_time_zone_rule): Document relationship with the
4910 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
4911 the font entity extracted from the cache (Bug#8109).
4913 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
4915 * composite.c (autocmp_chars): Don't reset point. That is done by
4916 restore_point_unwind (Bug#5984).
4918 2011-08-07 Juri Linkov <juri@jurta.org>
4920 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
4921 to show the arg `TIME' instead of `TIMEVAL'.
4923 2011-08-06 Eli Zaretskii <eliz@gnu.org>
4925 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
4926 display property strides EOL and includes a newline, as in
4927 longlines-mode. (Bug#9254)
4928 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
4929 word-wrap under bidirectional display. (Bug#9224)
4931 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
4932 is non-zero, even if the data buffer is NULL. Fixes a crash in
4933 vertical-motion with longlines-mode. (Bug#9254)
4935 2011-08-05 Eli Zaretskii <eliz@gnu.org>
4937 * bidi.c <bidi_cache_total_alloc>: Now static.
4938 (bidi_initialize): Initialize bidi_cache_total_alloc.
4940 * xdisp.c (display_line): Release buffer allocated for shelved bidi
4943 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
4944 amount allocated this far in `bidi_cache_total_alloc'.
4945 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
4946 non-zero, only free the data buffer without restoring the cache
4947 contents. All callers changed.
4949 * dispextern.h (bidi_unshelve_cache): Update prototype.
4951 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
4952 (move_it_in_display_line, move_it_to)
4953 (move_it_vertically_backward, move_it_by_lines): Replace the call
4954 to xfree to an equivalent call to bidi_unshelve_cache.
4955 (move_it_in_display_line_to): Fix logic of returning
4956 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
4958 2011-08-05 Eli Zaretskii <eliz@gnu.org>
4960 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
4961 came from a string character with a `cursor' property. (Bug#9229)
4963 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
4965 * Makefile.in (LIB_PTHREAD): New variable.
4966 (LIBES): Add LIB_PTHREAD (Bug#9216).
4968 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
4969 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
4971 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
4973 * regex.c (re_iswctype): Remove some redundant boolean conversions.
4975 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
4977 * xterm.c (x_find_topmost_parent): New function.
4978 (x_set_frame_alpha): Find topmost parent window with
4979 x_find_topmost_parent and set the property there also (bug#9181).
4980 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
4982 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
4984 * callproc.c (Fcall_process): Avoid vfork clobbering
4985 the local vars buffer, coding_systems, current_dir.
4987 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
4989 * keymap.c (Fmake_composed_keymap): Move to subr.el.
4991 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
4993 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
4994 so that it is not optimized away.
4996 * xdisp.c (compute_display_string_pos): Remove unused local.
4998 2011-08-02 Eli Zaretskii <eliz@gnu.org>
5000 Fix slow cursor motion and scrolling in large buffers with
5001 selective display, like Org Mode buffers. (Bug#9218)
5003 * dispextern.h (struct bidi_it): New member disp_prop_p.
5005 * xdisp.c: Remove one-slot cache of display string positions.
5006 (compute_display_string_pos): Accept an additional argument
5007 DISP_PROP_P; callers changed. Scan at most 5K characters forward
5008 for a display string or property. If found, set DISP_PROP_P
5011 * bidi.c (bidi_fetch_char): Accept an additional argument
5012 DISP_PROP_P, and pass it to compute_display_string_pos.
5013 Only handle text covered by a display string if DISP_PROP_P is returned
5014 non-zero. All callers of bidi_fetch_char changed.
5016 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5018 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5020 2010-12-03 Don March <don@ohspite.net>
5022 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5023 last character M-[char] is translated to ESC [char] (bug#7541).
5025 2011-08-02 Kenichi Handa <handa@m17n.org>
5027 * lisp.h (uniprop_table): Extern it.
5029 * chartab.c (uniprop_table): Make it non-static.
5031 2011-08-01 Eli Zaretskii <eliz@gnu.org>
5033 * xdisp.c (forward_to_next_line_start): Accept additional argument
5034 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5036 (reseat_at_next_visible_line_start): Use the bidi iterator state
5037 returned by forward_to_next_line_start to restore the state of
5038 it->bidi_it after backing up to previous newline. (Bug#9212)
5040 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5042 * regex.c (re_comp): Protoize.
5043 (re_exec): Fix return type.
5044 (regexec): Fix type of `ret'. (Bug#9203)
5046 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5048 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5049 This is needed if max-image-size is a floating-point number.
5051 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5053 * print.c (print_object): Print empty symbol as ##.
5055 * lread.c (read1): Read ## as empty symbol.
5057 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5059 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5060 setting frame foreground color (Bug#9175).
5061 (x_set_background_color): Likewise.
5063 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5064 contents (Bug#9176).
5065 (EmacsTooltip -init): Remove bezels and add shadows to
5068 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5069 or scroll bar (Bug#8470).
5071 * nsfont.m (nsfont_open): Remove assignment to voffset and
5072 unnecessary vars hshink, expand, hd, full_height, min_height.
5073 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5075 * nsterm.h (nsfont_info): Remove voffset field.
5077 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5079 Implement strike-through and overline on NextStep (Bug#8863).
5081 * nsfont.m (nsfont_open): Use underline position provided by font,
5082 instead of hard-coded value of 2.
5083 (nsfont_draw): Call ns_draw_text_decoration instead.
5085 * nsterm.h: Add declaration for ns_draw_text_decoration.
5087 * nsterm.m (ns_draw_text_decoration): New function for drawing
5088 underline, overline, and strike-through.
5089 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5090 ns_draw_text_decoration. Change treatment of cursor drawing to
5091 accommodate underlining, etc.
5093 2011-07-28 Eli Zaretskii <eliz@gnu.org>
5095 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5098 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5100 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5101 Without this fix, if a signal arrives just after memory fills up,
5102 'malloc' might be invoked reentrantly.
5104 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5105 In other words, assume that every image size is allowed, on non-X
5106 hosts. This assumption is probably wrong, but it lets Emacs compile.
5108 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5110 * regex.c (re_iswctype): Convert return values to boolean.
5112 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5114 * xdisp.c (compute_display_string_pos): Don't use cached display
5115 string position if the buffer had its restriction changed.
5118 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5120 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5122 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5124 Integer signedness and overflow and related fixes. (Bug#9079)
5126 * bidi.c: Integer size and overflow fixes.
5127 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5128 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5129 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5130 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5131 (bidi_find_other_level_edge):
5132 Use ptrdiff_t instead of EMACS_INT where either will do.
5133 This works better on 32-bit hosts configured --with-wide-int.
5134 (bidi_cache_ensure_space): Check for size-calculation overflow.
5135 Use % rather than repeated addition, for better worst-case speed.
5136 Don't set bidi_cache_size until after xrealloc returns, because it
5138 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
5139 (bidi_cache_ensure_space): Also check that the bidi cache size
5140 does not exceed that of the largest Lisp string or buffer. See Eli
5141 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
5143 * alloc.c (__malloc_size_t): Remove.
5144 All uses replaced by size_t. See Andreas Schwab's note
5145 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5147 * image.c: Improve checking for integer overflow.
5148 (check_image_size): Assume that f is nonnull, since
5149 it is always nonnull in practice. This is one less thing to
5150 worry about when checking for integer overflow later.
5151 (x_check_image_size): New function, which checks for integer
5152 overflow issues inside X.
5153 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5154 This removes the need for a memory_full check.
5155 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5156 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5157 (xbm_read_bitmap_data): Change locals back to 'int', since
5158 their values must fit in 'int'.
5159 (xpm_load_image, png_load, tiff_load):
5160 Invoke x_create_x_image_and_pixmap earlier,
5161 to avoid much needless work if the image is too large.
5162 (tiff_load): Treat overly large images as if
5163 x_create_x_image_and_pixmap failed, not as malloc failures.
5164 (gs_load): Use x_check_image_size.
5166 * gtkutil.c: Omit integer casts.
5167 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5168 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5170 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5172 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5173 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5174 would wrongly return t on a 64-bit host.
5176 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5177 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5178 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5179 and therefore cause GCC to emit a bogus diagnostic in some cases.
5181 * image.c: Integer signedness and overflow and related fixes.
5182 This is not an exhaustive set of fixes, but it's time to
5183 record what I've got.
5184 (lookup_pixel_color, check_image_size): Remove redundant decls.
5185 (check_image_size): Don't assume that arbitrary EMACS_INT values
5186 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5187 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5188 (tiff_load, imagemagick_load_image):
5189 Check for overflow in size calculations.
5190 (x_create_x_image_and_pixmap): Remove unnecessary test for
5191 xmalloc returning NULL; that can't happen.
5192 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5193 (xpm_color_bucket): Use better integer hashing function.
5194 (xpm_cache_color): Don't possibly over-allocate memory.
5195 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5196 (gif_memory_source):
5197 Use ptrdiff_t, not int or size_t, to record sizes.
5198 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5199 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5200 either works, as we prefer signed integers.
5201 (tiff_read_from_memory, tiff_write_from_memory):
5202 Return tsize_t, not size_t, since that's what the TIFF API wants.
5203 (tiff_read_from_memory): Don't fail simply because the read would
5204 go past EOF; instead, return a short read.
5205 (tiff_load): Omit no-longer-needed casts.
5206 (Fimagemagick_types): Don't assume size fits into 'int'.
5208 Improve hashing quality when configured --with-wide-int.
5209 * fns.c (hash_string): New function, taken from sxhash_string.
5210 Do not discard information about ASCII character case; this
5211 discarding is no longer needed.
5212 (sxhash-string): Use it. Change sig to match it. Caller changed.
5213 * lisp.h: Declare it.
5214 * lread.c (hash_string): Remove, since we now use fns.c's version.
5215 The fns.c version returns a wider integer if --with-wide-int is
5216 specified, so this should help the quality of the hashing a bit.
5218 * emacs.c: Integer overflow minor fix.
5219 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5220 Define only if GNU_LINUX.
5221 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5223 * dispnew.c: Integer signedness and overflow fixes.
5224 Remove unnecessary forward decls, that were a maintenance hassle.
5225 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5227 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5228 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5229 (prepare_desired_row, line_draw_cost):
5230 Use int, not unsigned, where either works.
5231 (save_current_matrix, restore_current_matrix):
5232 Use ptrdiff_t, not size_t, where either works.
5233 (init_display): Check for overflow more accurately, and without
5234 relying on undefined behavior.
5236 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5237 Remove, replacing with the new symbols in lisp.h. All uses changed.
5238 * fileio.c (make_temp_name):
5239 * filelock.c (lock_file_1, lock_file):
5240 * xdisp.c (message_dolog):
5241 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5242 Use pMd etc. instead.
5243 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5244 replacing the pWIDE etc. symbols removed from editfns.c.
5246 * keyboard.h (num_input_events): Now uintmax_t.
5247 This is (very slightly) less likely to mess up due to wraparound.
5250 * buffer.c: Integer signedness fixes.
5251 (alloc_buffer_text, enlarge_buffer_text):
5252 Use ptrdiff_t rather than size_t when either will do, as we prefer
5255 * alloc.c: Integer signedness and overflow fixes.
5256 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5257 (__malloc_size_t): Default to size_t, not to int.
5258 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5259 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5260 Prefer ptrdiff_t to size_t when either would do, as we prefer
5262 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5263 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5264 Now const. Initialize with values that are in range even if char
5266 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5267 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5268 These functions do the right thing with sizes > 2**32.
5269 (check_depth): Now ptrdiff_t, not int.
5270 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5271 Adjust to new way of storing sizes. Check for size overflow bugs
5273 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5274 slightly wrong anyway, as it missed one instance of
5275 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5276 (refill_memory_reserve): Omit needless cast to size_t.
5277 (mark_object_loop_halt): Mark as externally visible.
5279 * xselect.c: Integer signedness and overflow fixes.
5280 (Fx_register_dnd_atom, x_handle_dnd_message):
5281 Use ptrdiff_t, not size_t, since we prefer signed.
5282 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5283 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5284 x_dnd_atoms_size and x_dnd_atoms_length.
5286 * doprnt.c: Prefer signed to unsigned when either works.
5288 * doprnt.c (doprnt):
5290 * xdisp.c (vmessage):
5291 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5292 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5293 prefer signed arithmetic to avoid comparison confusion.
5294 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5295 but is a bit tricky.
5297 Assume freestanding C89 headers, string.h, stdlib.h.
5298 * data.c, doprnt.c, floatfns.c, print.c:
5299 Include float.h unconditionally.
5300 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5301 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5302 * regex.c: Likewise for stddef.h, string.h.
5303 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5304 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5305 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5306 (STDC_HEADERS): Remove obsolete defines.
5307 * sysdep.c: Include limits.h unconditionally.
5309 Assume support for memcmp, memcpy, memmove, memset.
5310 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5311 * regex.c (memcmp, memcpy):
5312 Remove; we assume C89 now.
5314 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5315 (__malloc_safe_bcopy): Remove; no longer needed.
5317 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
5318 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5319 well either way, and we prefer signed to unsigned.
5321 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5323 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5324 closes the connection while we're reading (bug#9182).
5326 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
5328 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5329 are specified (Bug#9168).
5331 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5333 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5334 Found by GCC static checking and --with-wide-int on a 32-bit host.
5336 2011-07-25 Eli Zaretskii <eliz@gnu.org>
5338 * xdisp.c (compute_display_string_pos): Fix logic of caching
5339 previous display string position. Initialize cached_prev_pos to
5340 -1. Fixes slow-down at the beginning of a buffer.
5342 2011-07-24 Eli Zaretskii <eliz@gnu.org>
5344 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5345 for attrs[LFACE_FONTSET_INDEX].
5347 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5349 * xml.c (parse_region): Remove unused local
5350 that was recently introduced.
5352 2011-07-23 Eli Zaretskii <eliz@gnu.org>
5354 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5355 revision 84777 on 2008-02-22.
5357 * xdisp.c (move_it_in_display_line_to): Record the best matching
5358 position for TO_CHARPOS while scanning the line, and restore it on
5359 exit if none of the characters scanned was an exact match.
5360 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
5361 when exact match is impossible due to invisible text, and the
5362 lines are truncated.
5364 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5366 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5369 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5371 Fix a significant slow-down of cursor motion with C-n, C-p,
5372 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5373 auto-repeat under bidi redisplay in fontified buffers.
5374 * xdisp.c (compute_stop_pos_backwards): New function.
5375 (next_element_from_buffer): Call compute_stop_pos_backwards to
5376 find a suitable prev_stop when we find ourselves before
5378 (reseat): Don't look for prev_stop, as that could mean a very long
5380 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5381 <cached_disp_overlay_modiff>: Cache for last found display string
5383 (compute_display_string_pos): Return the cached position if asked
5384 about the same buffer in the same area of character positions, and
5385 the buffer wasn't changed since the time the display string
5386 position was cached.
5388 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5390 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5391 is an integer, which is important for empty lines. (Bug#9149)
5393 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
5395 * frame.c (Fmodify_frame_parameters): In tty case, update the
5396 default face if necessary (Bug#4238).
5398 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
5400 * editfns.c (Fstring_to_char): No need to explain what a character
5401 is in the docstring (Bug#6576).
5403 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5405 * xml.c (parse_region): Make sure we always return a tree.
5407 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5409 * xml.c (parse_region): If a document contains only comments,
5412 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5414 * xml.c (make_dom): Return comments, too.
5416 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5419 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5420 and the surrounding thread.
5421 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5422 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5423 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5425 * s/openbsd.h (BROKEN_SIGIO): Define.
5426 * unexelf.c (unexec) [__OpenBSD__]:
5427 Don't update the .mdebug section of the Alpha COFF symbol table.
5429 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5431 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5434 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5436 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5437 This fixes some race conditions on the permissions of any newly
5440 * alloc.c (valid_pointer_p): Use pipe, not open.
5441 This fixes some permissions issues when debugging.
5443 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5444 If fchown fails to set both uid and gid, try to set just gid,
5445 as that is sometimes allowed. Adjust the file's mode to eliminate
5446 setuid or setgid bits that are inappropriate if fchown fails.
5448 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5450 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
5451 to compare Lisp_Objects.
5452 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
5453 global_gnutls_log_level, don't mistake it for a Lisp_Object.
5454 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
5456 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
5458 * lread.c (read_integer): Unread even EOF character.
5459 (read1): Likewise. Properly record start position of symbol.
5461 * lread.c (read1): Read `#:' as empty uninterned symbol if no
5462 symbol character follows.
5464 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
5466 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
5467 This works around a problem with the previous change to Fcopy_file.
5468 Recent glibc declares fchown with __attribute__((warn_unused_result)),
5469 and without this change, GCC might complain about discarding
5470 fchown's return value.
5472 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
5474 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
5476 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
5478 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
5480 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
5482 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
5483 it's used from the C level.
5485 * process.c: Use the same condition for POLL_FOR_INPUT in both
5486 keyboard.c and process.c (bug#1858).
5488 2011-07-09 Lawrence Mitchell <wence@gmx.li>
5490 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
5491 (Fgnutls_boot): Use it.
5493 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
5495 * doc.c (Fsubstitute_command_keys): Revert last change.
5497 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
5499 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
5500 quotes the next character, and doesn't affect other longer
5501 sequences (bug#8935).
5503 * lread.c (syms_of_lread): Clarify that is isn't only
5504 `eval-buffer' and `eval-defun' that's affected by
5505 `lexical-binding' (bug#8460).
5507 2011-07-15 Eli Zaretskii <eliz@gnu.org>
5509 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
5510 bidi redisplay when a line includes both an image and is truncated.
5512 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
5514 Fix minor problems found by static checking.
5515 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
5516 (elsz): Now a signed constant, not a size_t var. We prefer signed
5517 types to unsigned, to avoid integer comparison confusion. Without
5518 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
5519 "cannot optimize loop, the loop counter may overflow", a symptom
5521 * indent.c (Fvertical_motion): Mark locals as initialized.
5522 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
5524 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5526 * search.c (Fre_search_backward): Mention `case-fold-search' in
5527 all the re_search_* functions (bug#8138).
5529 * keyboard.c (Fopen_dribble_file): Document when the file is
5532 2011-07-14 Eli Zaretskii <eliz@gnu.org>
5534 * bidi.c (bidi_dump_cached_states): Fix format of displaying
5537 Support bidi reordering of display and overlay strings.
5538 * xdisp.c (compute_display_string_pos)
5539 (compute_display_string_end): Accept additional argument STRING.
5540 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
5541 (reseat_to_string): Initialize bidi_it->string.s and
5542 bidi_it->string.schars.
5543 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
5544 NULL (avoids a crash in bidi_paragraph_init).
5545 Initialize itb.string.lstring.
5546 (init_iterator): Call bidi_init_it only of a valid
5547 buffer position was specified. Initialize paragraph_embedding to
5549 (reseat_to_string): Initialize the bidi iterator.
5550 (display_string): If we need to ignore text properties of
5551 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
5552 original value of -1 will not work with bidi.)
5553 (compute_display_string_pos): First arg is now struct
5554 `text_pos *'; all callers changed. Support display properties on
5556 (compute_display_string_end): Support display properties on Lisp
5558 (init_iterator, reseat_1, reseat_to_string): Initialize the
5559 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
5560 when iterating on a string not from display properties).
5561 (compute_display_string_pos, compute_display_string_end):
5562 Fix calculation of the object to scan. Fixes an error when using
5564 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
5565 base_level_stop; instead, set base_level_stop to BEGV.
5566 Fixes crashes in vertical-motion.
5567 (next_element_from_buffer): Improve commentary for when
5568 the iterator is before prev_stop.
5569 (init_iterator): Initialize bidi_p from the default value of
5570 bidi-display-reordering, not from buffer-local value. Use the
5571 buffer-local value only if initializing for buffer iteration.
5572 (handle_invisible_prop): Support invisible properties on strings
5573 that are being bidi-reordered.
5574 (set_iterator_to_next): Support bidi reordering of C strings and
5576 (next_element_from_string): Support bidi reordering of Lisp
5578 (handle_stop_backwards): Support Lisp strings as well.
5579 (display_string): Support display of R2L glyph rows.
5580 Use IT_STRING_CHARPOS when displaying from a Lisp string.
5581 (init_iterator): Don't initialize it->bidi_p for strings
5583 (reseat_to_string): Initialize it->bidi_p for strings here.
5584 (next_element_from_string, next_element_from_c_string)
5585 (next_element_from_buffer): Add xassert's for correspondence
5586 between IT's object being iterated and it->bidi_it.string
5588 (face_before_or_after_it_pos): Support bidi iteration.
5589 (next_element_from_c_string): Handle the case of the first string
5590 character that is not the first one in the visual order.
5591 (get_visually_first_element): New function, refactored from common
5592 parts of next_element_from_buffer, next_element_from_string, and
5593 next_element_from_c_string.
5594 (tool_bar_lines_needed, redisplay_tool_bar)
5595 (display_menu_bar): Force left-to-right direction. Add a FIXME
5596 comment for making that be controlled by a user option.
5597 (push_it, pop_it): Save and restore the state of the
5598 bidi iterator. Save and restore the bidi_p flag.
5599 (pop_it): Iterate out of display property for string iteration as
5601 (iterate_out_of_display_property): Support iteration over strings.
5602 (handle_single_display_spec): Set up it->bidi_it for iteration
5603 over a display string, and call bidi_init_it.
5604 (handle_single_display_spec, next_overlay_string)
5605 (get_overlay_strings_1, push_display_prop): Set up the bidi
5606 iterator for displaying display or overlay strings.
5607 (forward_to_next_line_start): Don't use the shortcut if
5609 (back_to_previous_visible_line_start): If handle_display_prop
5610 pushed the iterator stack, restore the internal state of the bidi
5611 iterator by calling bidi_pop_it same number of times.
5612 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
5613 and we are bidi-iterating, don't decrement the iterator position;
5614 instead, set the first_elt flag in the bidi iterator, to produce
5616 (reseat_1): Remove redundant setting of string_from_display_prop_p.
5617 (push_display_prop): xassert that we are iterating a buffer.
5618 (push_it, pop_it): Save and restore paragraph_embedding member.
5619 (handle_single_display_spec, next_overlay_string)
5620 (get_overlay_strings_1, reseat_1, reseat_to_string)
5621 (push_display_prop): Set up the `unibyte' member of bidi_it.string
5622 correctly. Don't assume unibyte strings are not bidi-reordered.
5623 (compute_display_string_pos)
5624 (compute_display_string_end): Fix handling the case of C string.
5625 (push_it, pop_it): Save and restore from_disp_prop_p.
5626 (handle_single_display_spec, push_display_prop): Set the
5627 from_disp_prop_p flag.
5628 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
5629 (pop_it): Call iterate_out_of_display_property only if we are
5630 popping after iteration over a string that came from a display
5631 property. Fix a typo in popping stretch info. Add an assertion
5632 for verifying that the iterator position is in sync with the bidi
5634 (handle_single_display_spec, get_overlay_strings_1)
5635 (push_display_prop): Fix initialization of paragraph direction for
5636 string when that of the parent object is not yet determined.
5637 (reseat_1): Call bidi_init_it to resync the bidi
5638 iterator with IT's position. (Bug#7616)
5639 (find_row_edges): If ROW->start.pos gives position
5640 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
5641 (handle_stop, back_to_previous_visible_line_start, reseat_1):
5642 Reset the from_disp_prop_p flag.
5643 (SAVE_IT, RESTORE_IT): New macros.
5644 (pos_visible_p, face_before_or_after_it_pos)
5645 (back_to_previous_visible_line_start)
5646 (move_it_in_display_line_to, move_it_in_display_line)
5647 (move_it_to, move_it_vertically_backward, move_it_by_lines)
5648 (try_scrolling, redisplay_window, display_line): Use them when
5649 saving a temporary copy of the iterator and restoring it back.
5650 (back_to_previous_visible_line_start, reseat_1)
5651 (init_iterator): Empty the bidi cache "stack".
5652 (move_it_in_display_line_to): If iterator ended up at
5653 EOL, but we never saw any buffer positions smaller than
5654 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
5655 motion in bidi-reordered lines.
5656 (move_it_in_display_line_to): Record prev_method and prev_pos
5657 immediately before the call to set_iterator_to_next. Fixes cursor
5658 motion in bidi-reordered lines with stretch glyphs and strings
5659 displayed in margins. (Bug#8133) (Bug#8867)
5660 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
5662 (pos_visible_p): Support positions in bidi-reordered lines.
5663 Save and restore bidi cache.
5665 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
5666 (bidi_paragraph_info): Delete unused struct.
5667 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
5668 (bidi_cache_start): New variable.
5669 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
5671 (bidi_cache_fetch_state, bidi_cache_search)
5672 (bidi_cache_find_level_change, bidi_cache_iterator_state)
5673 (bidi_cache_find, bidi_peek_at_next_level)
5674 (bidi_level_of_next_char, bidi_find_other_level_edge)
5675 (bidi_move_to_visually_next): Compare cache index with
5676 bidi_cache_start rather than with zero.
5677 (bidi_fetch_char): Accept new argument STRING; all callers
5678 changed. Support iteration over a string. Support strings with
5679 display properties. Support unibyte strings. Fix the type of
5680 `len' according to what STRING_CHAR_AND_LENGTH expects.
5681 (bidi_paragraph_init, bidi_resolve_explicit_1)
5682 (bidi_resolve_explicit, bidi_resolve_weak)
5683 (bidi_level_of_next_char, bidi_move_to_visually_next):
5684 Support iteration over a string.
5685 (bidi_set_sor_type, bidi_resolve_explicit_1)
5686 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
5687 can now be zero (for strings); special values 0 and -1 were
5688 changed to -1 and -2, respectively.
5689 (bidi_char_at_pos): New function.
5690 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
5691 Call it instead of FETCH_MULTIBYTE_CHAR.
5692 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
5693 initialized to valid values.
5694 (bidi_init_it): Don't initialize charpos and bytepos with invalid
5696 (bidi_level_of_next_char): Allow the sentinel "position" to pass
5697 the test for valid cached positions. Fix the logic for looking up
5698 the sentinel state in the cache. GCPRO the Lisp string we are
5700 (bidi_push_it, bidi_pop_it): New functions.
5701 (bidi_initialize): Initialize the bidi cache start stack pointer.
5702 (bidi_cache_ensure_space): New function, refactored from part of
5703 bidi_cache_iterator_state. Don't assume the required size is just
5704 one BIDI_CACHE_CHUNK away.
5705 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
5706 (bidi_count_bytes, bidi_char_at_pos): New functions.
5707 (bidi_cache_search): Don't assume bidi_cache_last_idx is
5708 always valid if bidi_cache_idx is valid.
5709 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
5710 is valid if it's going to be used.
5711 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
5712 (bidi_cache_fetch_state, bidi_cache_search)
5713 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5714 (bidi_cache_iterator_state, bidi_cache_find)
5715 (bidi_find_other_level_edge, bidi_cache_start_stack):
5716 All variables related to cache indices are now EMACS_INT.
5718 * dispextern.h (struct bidi_string_data): New structure.
5719 (struct bidi_it): New member `string'. Make flag members be 1-bit
5720 fields, and put them last in the struct.
5721 (compute_display_string_pos, compute_display_string_end):
5723 (bidi_push_it, bidi_pop_it): Add prototypes.
5724 (struct iterator_stack_entry): New members bidi_p,
5725 paragraph_embedding, and from_disp_prop_p.
5726 (struct it): Member bidi_p is now a bit field 1 bit wide.
5727 (bidi_shelve_cache, bidi_unshelve_cache):
5730 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
5731 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
5732 and vector-like objects.
5734 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
5735 cache around display iteration.
5737 * window.c (Fwindow_end, window_scroll_pixel_based)
5738 (displayed_window_lines, Frecenter): Save and restore the bidi
5739 cache around display iteration.
5741 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5743 * editfns.c (Fdelete_region): Clarify the use of the named
5744 parameters (bug#6788).
5746 2011-07-14 Martin Rudalics <rudalics@gmx.at>
5748 * indent.c (Fvertical_motion): Set and restore w->pointm when
5749 saving and restoring the window's buffer (Bug#9006).
5751 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
5753 * editfns.c (Fstring_to_char): Clarify just what is returned
5754 (bug#6576). Text by Eli Zaretskii.
5756 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
5758 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
5760 2011-07-13 Eli Zaretskii <eliz@gnu.org>
5762 * buffer.c (mmap_find): Fix a typo.
5764 2011-07-13 Johan Bockgård <bojohan@gnu.org>
5766 Fix execution of x selection hooks.
5767 * xselect.c (Qx_lost_selection_functions)
5768 (Qx_sent_selection_functions): New vars.
5769 (syms_of_xselect): DEFSYM them.
5770 (x_handle_selection_request): Pass Qx_sent_selection_functions
5771 rather than Vx_sent_selection_functions to Frun_hook_with_args.
5772 (x_handle_selection_clear,x_clear_frame_selections):
5773 Pass Qx_lost_selection_functions rather than
5774 Vx_lost_selection_functions to Frun_hook_with_args.
5776 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
5778 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
5779 The old code sometimes used this field without initializing it.
5781 * alloc.c (gc_sweep): Don't read past end of array.
5782 In theory, the old code could also have corrupted Emacs internals,
5783 though it'd be very unlikely.
5785 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
5787 * character.c (Fcharacterp): Don't advertise optional ignored
5788 argument. (Bug#4026)
5790 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
5792 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
5795 * window.c (Fset_window_start): Doc fix (bug#4199).
5796 (Fset_window_hscroll): Ditto.
5798 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
5800 Fix minor new problems caught by GCC 4.6.1.
5801 * term.c (init_tty): Remove unused local.
5802 * xsettings.c (store_monospaced_changed): Define this function only
5803 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
5806 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
5808 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
5810 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5812 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
5813 are the mini-buffer and the echo area (bug#3320).
5815 * term.c (init_tty): Remove support for supdup, c10 and perq
5816 terminals, which are no longer supported (bug#1482).
5818 2011-07-10 Johan Bockgård <bojohan@gnu.org>
5820 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
5822 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
5824 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
5825 for non-popups (Bug#3642).
5827 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
5829 * alloc.c (reset_malloc_hooks): Protoize.
5830 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
5831 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
5832 * cm.c (losecursor): Likewise.
5833 * data.c (fmod): Likewise.
5834 * dispnew.c (swap_glyphs_in_rows): Likewise.
5835 * emacs.c (memory_warning_signal): Likewise.
5836 * floatfns.c (float_error): Likewise.
5837 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
5838 (otf_open, font_otf_capability, generate_otf_features)
5839 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
5841 * image.c (pbm_read_file): Likewise.
5842 * indent.c (string_display_width): Likewise.
5843 * intervals.c (check_for_interval, search_for_interval)
5844 (inc_interval_count, count_intervals, root_interval)
5845 (adjust_intervals_for_insertion, make_new_interval): Likewise.
5846 * lread.c (defalias): Likewise.
5847 * ralloc.c (r_alloc_check): Likewise.
5848 * regex.c (set_image_of_range_1, set_image_of_range)
5849 (regex_grow_registers): Likewise.
5850 * sysdep.c (strerror): Likewise.
5851 * termcap.c (valid_filename_p, tprint, main): Likewise.
5852 * tparam.c (main): Likewise.
5853 * unexhp9k800.c (run_time_remap, save_data_space)
5854 (update_file_ptrs, read_header, write_header, calculate_checksum)
5855 (copy_file, copy_rest, display_header): Likewise.
5856 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
5858 * xdisp.c (check_it): Likewise.
5859 * xfaces.c (register_color, unregister_color, unregister_colors):
5861 * xfns.c (print_fontset_result): Likewise.
5862 * xrdb.c (member, fatal, main): Likewise.
5864 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
5866 Fix minor problems found by static checking (Bug#9031).
5867 * chartab.c (char_table_set_range, map_sub_char_table):
5868 Remove unused locals.
5869 (uniprop_table): Now static.
5870 * composite.c (_work_char): Remove unused static var.
5872 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
5874 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
5876 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
5878 * gtkutil.c (qttip_cb): Remove code without function.
5880 2011-07-09 Eli Zaretskii <eliz@gnu.org>
5882 * w32.c (pthread_sigmask): New stub.
5884 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
5886 Use pthread_sigmask, not sigprocmask (Bug#9010).
5887 sigprocmask is portable only for single-threaded applications, and
5888 Emacs can be multi-threaded when it uses GTK.
5889 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
5891 * callproc.c (Fcall_process):
5892 * process.c (create_process):
5893 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
5894 Use pthread_sigmask, not sigprocmask.
5896 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
5898 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
5899 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
5902 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
5904 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
5905 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
5906 (xg_hide_tooltip): Fix comment.
5908 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
5909 in registerServicesMenuSendTypes.
5910 (validRequestorForSendType): Don't check ns_return_types.
5912 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
5915 2011-07-08 Jason Rumney <jasonr@gnu.org>
5917 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
5918 SH_SHOW for hidden windows (Bug#5482).
5920 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
5921 frame struct members of non-existent frames (Bug#6284).
5923 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
5925 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
5926 variable firstTime not needed on OSX >= 10.6.
5927 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
5928 >= 10.5. Use setKnobProportion, setDoubleValue.
5930 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
5931 (MAC_OS_X_VERSION_10_5): Define if not defined.
5932 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
5933 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
5934 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
5936 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
5937 cString and lossyCString on OSX >= 10.4
5939 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
5940 sizeToFit on OSX >= 10.2.
5942 * nsimage.m (allocInitFromFile): Don't use deprecated method
5943 bestRepresentationForDevice on OSX >= 10.6.
5945 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
5948 * emacs.c: Declare unexec_init_emacs_zone.
5950 * nsgui.h: Fix compiler warning about gnulib redefining verify.
5952 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
5954 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
5955 on svcsMenu (Bug#8842).
5957 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
5959 (Fns_list_services): Just return Qnil on 10.6, code not working there.
5961 * nsterm.m (QUTF8_STRING): Declare.
5962 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
5963 (validRequestorForSendType): Return type is (id).
5964 Change indexOfObjectIdenticalTo to indexOfObject.
5965 Check if we have local selection before returning self (Bug#8842).
5966 (writeSelectionToPasteboard): Put local selection into paste board
5967 if we have a local selection (Bug#8842).
5968 (syms_of_nsterm): DEFSYM QUTF8_STRING.
5970 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
5971 (ns_get_local_selection): Declare.
5973 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
5975 * keymap.c (describe_map_tree): Don't insert a double newline at
5976 the end of the buffer (bug#1169) and return whether we inserted
5979 * callint.c (Fcall_interactively): Change "reading args" to
5980 "providing args" to try to clarify what it does (bug#1010).
5982 2011-07-07 Kenichi Handa <handa@m17n.org>
5984 * composite.c (composition_compute_stop_pos): Ignore a static
5985 composition starting before CHARPOS (Bug#8915).
5987 * xdisp.c (handle_composition_prop): Likewise.
5989 2011-07-07 Eli Zaretskii <eliz@gnu.org>
5991 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
5994 2011-07-07 Kenichi Handa <handa@m17n.org>
5996 * character.h (unicode_category_t): New enum type.
5998 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
5999 (Qchar_code_property_table): New variable.
6000 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6001 (UNIPROP_COMPRESSED_FORM_P): New macros.
6002 (char_table_ascii): Uncompress the compressed values.
6003 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6004 Uncompress the compressed values.
6005 (sub_char_table_ref_and_range): Likewise.
6006 (char_table_ref_and_range): Uncompress the compressed values.
6007 (sub_char_table_set): New arg is_uniprop. Callers changed.
6008 Uncompress the compressed values.
6009 (sub_char_table_set_range): Args changed. Callers changed.
6010 (char_table_set_range): Adjuted for the above change.
6011 (map_sub_char_table): Delete args default_val and parent. Add arg
6012 top. Give decoded values to a Lisp function.
6013 (map_char_table): Adjust for the above change. Give decoded
6014 values to a Lisp function. Gcpro more variables.
6015 (uniprop_table_uncompress)
6016 (uniprop_decode_value_run_length): New functions.
6017 (uniprop_decoder, uniprop_decoder_count): New variables.
6018 (uniprop_get_decoder, uniprop_encode_value_character)
6019 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6021 (uniprop_encoder, uniprop_encoder_count): New variables.
6022 (uniprop_get_encoder, uniprop_table)
6023 (Funicode_property_table_internal, Fget_unicode_property_internal)
6024 (Fput_unicode_property_internal): New functions.
6025 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6026 Sunicode_property_table_internal, Sget_unicode_property_internal,
6027 and Sput_unicode_property_internal. Defvar_lisp
6028 char-code-property-alist.
6030 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
6031 Vunicode_category_table.
6033 * font.c (font_range): Adjust for the change of
6034 Vunicode_category_table.
6036 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6038 * m/iris4d.h: Remove file, move contents ...
6039 * s/irix6-5.h: ... here.
6041 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6043 Remove unportable assumption about struct layout (Bug#8884).
6044 * alloc.c (mark_buffer):
6045 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6046 (clone_per_buffer_values): Don't assume that
6047 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6048 This isn't true in general, and it's particularly not true
6049 if Emacs is configured with --with-wide-int.
6050 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6051 New macros, used in the buffer.c change.
6053 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6055 * xsettings.c: Use both GConf and GSettings if both are available.
6056 (store_config_changed_event): Add comment.
6057 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6058 (store_tool_bar_style_changed): New functions.
6059 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
6060 (struct xsettings): Move font inside HAVE_XFT.
6061 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
6062 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
6063 Move inside HAVE_XFT.
6064 (something_changed_gsettingsCB): Rename from something_changedCB.
6065 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6067 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
6068 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
6069 (something_changed_gconfCB): Rename from something_changedCB.
6070 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6071 (parse_settings): Move check for font inside HAVE_XFT.
6072 (read_settings, apply_xft_settings): Add comment.
6073 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6074 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6075 call store_font_name_changed.
6076 (xft_settings_event): Add comment.
6077 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6078 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6079 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6080 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6081 (xsettings_initialize): Call init_gsettings last.
6082 (xsettings_get_system_font, xsettings_get_system_normal_font):
6085 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6087 Random fixes. E.g., (random) never returned negative values.
6088 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6089 subseconds part to the entropy, as that's a bit more random.
6090 Prefer signed to unsigned, since the signedness doesn't matter and
6091 in general we prefer signed. When given a limit, use a
6092 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6093 latter isn't right if USE_2_TAGS_FOR_INTS.
6094 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6095 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6097 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6099 * textprop.c (text_property_stickiness):
6100 Obey Vtext_property_default_nonsticky.
6101 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6102 * w32fns.c (syms_of_w32fns):
6103 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6105 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6107 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6108 This is more efficient than Ffile_directory_p and avoids a minor race.
6110 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6112 * buffer.c (Foverlay_put): Say what the return value is
6115 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6116 is a directory before asking whether to use the file name
6118 (barf_or_query_if_file_exists): Make the "File is a directory"
6119 error be more correct.
6121 * fns.c (Frequire): Remove the mention of the .gz files, since
6122 that's installation-specific, but keep the mention of
6123 `get-load-suffixes'.
6125 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6127 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6128 Report string overflow if the output is too long.
6130 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
6132 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6133 (syms_of_gnutls): Remove duplicate DEFSYM for
6134 Qgnutls_bootprop_verify_hostname_error, an error for
6135 Qgnutls_bootprop_verify_error (which is no longer used).
6137 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6138 unused since revno:102982 (2011-01-26). All callers changed.
6139 Also (re)move comments that are misplaced or no longer relevant.
6141 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6143 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6145 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
6147 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6148 and background color parameters if they have been changed.
6150 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6152 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6154 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6156 * xsettings.c (SYSTEM_FONT): Define only when used.
6157 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6159 * keymap.c (access_keymap_1): Now static.
6161 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
6163 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6164 leave any prefix arg for the up event (Bug#1586).
6166 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6168 * lread.c (syms_of_lread): Mention single symbols defined by
6169 `defvar' or `defconst' (bug#7154).
6171 * fns.c (Frequire): Mention .el.gz files (bug#7314).
6172 (Frequire): Mention get-load-suffixes.
6174 2011-07-02 Martin Rudalics <rudalics@gmx.at>
6176 * window.h (window): Remove clone_number slot.
6177 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6179 (make_parent_window, make_window, saved_window)
6180 (Fset_window_configuration, save_window_save): Don't deal with
6182 * buffer.c (Qclone_number): Remove declaration.
6183 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6185 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6187 Add multiple inheritance to keymaps.
6188 * keymap.c (Fmake_composed_keymap): New function.
6189 (Fset_keymap_parent): Simplify.
6190 (fix_submap_inheritance): Remove.
6191 (access_keymap_1): New function extracted from access_keymap to handle
6192 embedded parents and handle lists of maps.
6193 (access_keymap): Use it.
6194 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6195 (Fcopy_keymap): Handle embedded parents.
6196 (Fcommand_remapping, define_as_prefix): Simplify.
6197 (Fkey_binding): Simplify.
6198 (syms_of_keymap): Move minibuffer-local-completion-map,
6199 minibuffer-local-filename-completion-map,
6200 minibuffer-local-must-match-map, and
6201 minibuffer-local-filename-must-match-map to Elisp.
6202 (syms_of_keymap): Defsubr make-composed-keymap.
6203 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6204 (parse_menu_item): Trivial simplification.
6206 2011-07-01 Glenn Morris <rgm@gnu.org>
6208 * Makefile.in (SETTINGS_LIBS): Fix typo.
6210 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6212 * coding.c (Fencode_coding_string): Record the last coding system
6213 used, as the function doc string says (bug#8738).
6215 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6217 * xsettings.c (store_monospaced_changed): Take new font as arg and
6218 check for change against current_mono_font.
6219 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6220 (emacs_settings_constructor, emacs_settings_get_property)
6221 (emacs_settings_set_property, emacs_settings_class_init)
6222 (emacs_settings_init, gsettings_obj): Remove.
6223 (something_changedCB): New function for HAVE_GSETTINGS.
6224 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6225 with value as argument.
6226 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6227 g_settings_new (Bug#8967). Do not create gsettings_obj.
6228 Remove calls to g_settings_bind. Connect something_changedCB to
6231 * xgselect.c: Add defined (HAVE_GSETTINGS).
6232 (xgselect_initialize): Ditto.
6234 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6235 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6238 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6240 * eval.c (struct backtrace): Simplify and port the data structure.
6241 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6242 signed bit field, as this assumption is not portable and it makes
6243 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6244 "char debug_on_exit : 1" as this is not portable either; instead,
6245 use the portable "unsigned int debug_on_exit : 1". Remove unused
6246 member evalargs. Remove obsolete comments about cc bombing out.
6248 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6250 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
6251 Let HAVE_GSETTINGS override HAVE_GCONF.
6252 (store_monospaced_changed): New function.
6253 (EMACS_SETTINGS): A new type derived from GObject to handle
6254 GSettings notifications.
6255 (emacs_settings_constructor, emacs_settings_get_property)
6256 (emacs_settings_set_property, emacs_settings_class_init):
6258 (gsettings_client, gsettings_obj): New variables.
6259 (GSETTINGS_SCHEMA): New define.
6260 (something_changedCB): Call store_monospaced_changed.
6261 (init_gsettings): New function.
6262 (xsettings_initialize): Call init_gsettings.
6263 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6266 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
6269 2011-06-29 Martin Rudalics <rudalics@gmx.at>
6271 * window.c (resize_root_window, grow_mini_window)
6272 (shrink_mini_window): Rename Qresize_root_window to
6273 Qwindow_resize_root_window and Qresize_root_window_vertically to
6274 Qwindow_resize_root_window_vertically.
6276 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6278 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6280 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
6282 * makefile.w32-in: Redesign dependencies so they reflect more
6283 clearly which files are directly included by each source file,
6284 and not through other includes.
6286 2011-06-27 Martin Rudalics <rudalics@gmx.at>
6288 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6289 (sort_overlays, overlay_strings): When an overlay's clone number
6290 matches the window's clone number process the overlay even if
6291 the overlay's window property doesn't match the current window.
6293 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6294 (Fwindow_hchild): Rename to Fwindow_left_child.
6295 (Fwindow_next): Rename to Fwindow_next_sibling.
6296 (Fwindow_prev): Rename to Fwindow_prev_sibling.
6297 (resize_window_check): Rename to window_resize_check.
6298 (resize_window_apply): Rename to window_resize_apply.
6299 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6300 (Fdelete_other_windows_internal, resize_frame_windows)
6301 (Fsplit_window_internal, Fdelete_window_internal)
6302 (grow_mini_window, shrink_mini_window)
6303 (Fresize_mini_window_internal): Fix callers accordingly.
6305 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6307 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6308 (emacs_fixed_set_min_size): Remove.
6309 (emacs_fixed_new): Take frame as argument.
6311 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6312 (_EmacsFixedPrivate): Remove minwidth/height.
6313 Add struct frame *f.
6314 (emacs_fixed_init): Initialize priv->f.
6315 (get_parent_class, emacs_fixed_set_min_size): Remove.
6316 (emacs_fixed_new): Set priv->f to argument.
6317 (emacs_fixed_get_preferred_width)
6318 (emacs_fixed_get_preferred_height): Use min_width/height from
6319 frames size_hint to set minimum and natural (Bug#8919).
6320 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6321 and use min_width/height from frames size_hint to set
6322 min_width/height (Bug#8919).
6324 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
6325 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6328 2011-06-26 Eli Zaretskii <eliz@gnu.org>
6330 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6331 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6334 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
6336 * process.c (wait_reading_process_output): Bypass select if
6337 waiting for a cell while ignoring keyboard input, and input is
6338 pending. Suggested by Jan Djärv (Bug#8869).
6340 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6342 Use gnulib's dup2 module instead of rolling our own.
6343 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6345 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6347 * dispnew.c (scrolling_window): Before scrolling, turn off a
6348 mouse-highlight in the window being scrolled.
6350 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
6352 Move DEFSYM to lisp.h and use everywhere.
6354 * character.h (DEFSYM): Move declaration...
6355 * lisp.h (DEFSYM): ...here.
6361 * w32select.c: Don't include character.h.
6363 * alloc.c (syms_of_alloc):
6364 * buffer.c (syms_of_buffer):
6365 * bytecode.c (syms_of_bytecode):
6366 * callint.c (syms_of_callint):
6367 * casefiddle.c (syms_of_casefiddle):
6368 * casetab.c (init_casetab_once):
6369 * category.c (init_category_once, syms_of_category):
6370 * ccl.c (syms_of_ccl):
6371 * cmds.c (syms_of_cmds):
6372 * composite.c (syms_of_composite):
6373 * dbusbind.c (syms_of_dbusbind):
6374 * dired.c (syms_of_dired):
6375 * dispnew.c (syms_of_display):
6376 * doc.c (syms_of_doc):
6377 * editfns.c (syms_of_editfns):
6378 * emacs.c (syms_of_emacs):
6379 * eval.c (syms_of_eval):
6380 * fileio.c (syms_of_fileio):
6381 * fns.c (syms_of_fns):
6382 * frame.c (syms_of_frame):
6383 * fringe.c (syms_of_fringe):
6384 * insdel.c (syms_of_insdel):
6385 * keymap.c (syms_of_keymap):
6386 * lread.c (init_obarray, syms_of_lread):
6387 * macros.c (syms_of_macros):
6388 * msdos.c (syms_of_msdos):
6389 * print.c (syms_of_print):
6390 * process.c (syms_of_process):
6391 * search.c (syms_of_search):
6392 * sound.c (syms_of_sound):
6393 * syntax.c (init_syntax_once, syms_of_syntax):
6394 * terminal.c (syms_of_terminal):
6395 * textprop.c (syms_of_textprop):
6396 * undo.c (syms_of_undo):
6397 * w32.c (globals_of_w32):
6398 * window.c (syms_of_window):
6399 * xdisp.c (syms_of_xdisp):
6400 * xfaces.c (syms_of_xfaces):
6401 * xfns.c (syms_of_xfns):
6402 * xmenu.c (syms_of_xmenu):
6403 * xsettings.c (syms_of_xsettings):
6404 * xterm.c (syms_of_xterm): Use DEFSYM.
6406 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6408 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
6410 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6412 Integer and buffer overflow fixes (Bug#8873).
6414 * print.c (printchar, strout): Check for string overflow.
6415 (PRINTPREPARE, printchar, strout):
6416 Don't set size unless allocation succeeds.
6418 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6419 for sizes. Check for string overflow more accurately.
6420 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6422 * macros.c: Integer and buffer overflow fixes.
6423 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6424 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6425 Use ptrdiff_t, not int, for sizes.
6426 Don't increment bufsize until after realloc succeeds.
6427 Check for size-calculation overflow.
6428 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6430 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6432 * lread.c: Integer overflow fixes.
6433 (read_integer): Radix is now EMACS_INT, not int,
6434 to improve quality of diagnostics for out-of-range radices.
6435 Calculate buffer size correctly for out-of-range radices.
6436 (read1): Check for integer overflow in radices, and in
6437 read-circle numbers.
6438 (read_escape): Avoid int overflow.
6439 (Fload, openp, read_buffer_size, read1)
6440 (substitute_object_recurse, read_vector, read_list, map_obarray):
6441 Use ptrdiff_t, not int, for sizes.
6442 (read1): Use EMACS_INT, not int, for sizes.
6443 Check for size overflow.
6445 * image.c (cache_image): Check for size arithmetic overflow.
6447 * lread.c: Integer overflow issues.
6448 (saved_doc_string_size, saved_doc_string_length)
6449 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6450 Now ptrdiff_t, not int.
6451 (read1): Don't assume doc string length fits in int. Check for
6452 out-of-range doc string lengths.
6453 (read_list): Don't assume file position fits in int.
6454 (read_escape): Check for hex character overflow.
6456 2011-06-22 Leo Liu <sdl.web@gmail.com>
6458 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
6459 Move to minibuffer.el.
6461 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6463 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
6464 The following patches are for when GLYPH_DEBUG && !XASSERT.
6465 * dispextern.h (trace_redisplay_p, dump_glyph_string):
6466 * dispnew.c (flush_stdout):
6467 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
6468 Mark as externally visible.
6469 * dispnew.c (check_window_matrix_pointers): Now static.
6470 * dispnew.c (window_to_frame_vpos):
6471 * xfns.c (unwind_create_frame):
6472 * xterm.c (x_check_font): Remove unused local.
6473 * scroll.c (CHECK_BOUNDS):
6474 * xfaces.c (cache_fache): Rename local to avoid shadowing.
6475 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
6476 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
6477 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
6478 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
6480 (debug_method_add): Use va_list and vsprintf rather than relying
6481 on undefined behavior with wrong number of arguments.
6482 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
6483 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
6484 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
6485 since we're not interested in debugging glyphs with old libraries.
6486 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
6487 GCC 4.6.0's static checking.
6489 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6491 Integer overflow and signedness fixes (Bug#8873).
6492 A few related buffer overrun fixes, too.
6494 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
6496 * dispextern.h (struct face.stipple):
6497 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
6498 (x_bitmap_mask, x_allocate_bitmap_record)
6499 (x_create_bitmap_from_data, x_create_bitmap_from_file)
6500 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
6501 (x_create_bitmap_from_xpm_data):
6502 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
6503 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
6505 * xfaces.c (load_pixmap):
6506 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
6507 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
6508 (.bitmaps_last, struct x_output.icon_bitmap):
6509 Use ptrdiff_t, not int, for bitmap indexes.
6510 (x_allocate_bitmap_record): Check for size overflow.
6511 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
6513 Use ptrdiff_t, not int, for overlay counts.
6514 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
6515 * editfns.c (overlays_around, get_pos_property):
6516 * textprop.c (get_char_property_and_overlay):
6517 * xdisp.c (next_overlay_change, note_mouse_highlight):
6518 * xfaces.c (face_at_buffer_position):
6519 * buffer.c (OVERLAY_COUNT_MAX): New macro.
6520 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
6521 (Fnext_overlay_change, Fprevious_overlay_change)
6522 (mouse_face_overlay_overlaps, Foverlays_in):
6523 Use ptrdiff_t, not int, for sizes.
6524 (overlays_at, overlays_in): Check for size-calculation overflow.
6526 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
6528 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
6529 (x_session_initialize): Do not assume string length fits in int.
6531 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
6532 This is unlikely, but can occur if DPI is outlandish.
6534 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
6535 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
6537 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
6538 * xrdb.c (magic_file_p, search_magic_path):
6539 Omit last arg SUFFIX; it was always 0. All callers changed.
6540 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
6542 * xfont.c (xfont_match): Avoid need for strlen.
6544 * xfns.c: Don't assume strlen fits in int.
6545 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
6547 * xdisp.c (message_log_check_duplicate): Return intmax_t,
6548 not unsigned long, as we prefer signed integers. All callers changed.
6549 Detect integer overflow in repeat count.
6550 (message_dolog): Don't assume print length fits in 39 bytes.
6551 (display_mode_element): Don't assume strlen fits in int.
6553 * termcap.c: Don't assume sizes fit in int and never overflow.
6554 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
6555 (gobble_line): Check for size-calculation overflow.
6557 * minibuf.c (Fread_buffer):
6558 * lread.c (intern, intern_c_string):
6559 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
6560 Don't assume string length fits in int.
6562 * keyboard.c (parse_tool_bar_item):
6563 * gtkutil.c (style_changed_cb): Avoid need for strlen.
6565 * font.c: Don't assume string length fits in int.
6566 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
6567 Use ptrdiff_t, not int.
6568 (font_intern_prop): Don't assume string length fits in int.
6569 Don't assume integer property fits in fixnum.
6570 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
6572 * filelock.c: Fix some buffer overrun and integer overflow issues.
6573 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
6574 Reformulate so as not to need the command string.
6575 Invoke gzip -cd rather than gunzip, as it's more portable.
6576 (lock_info_type, lock_file_1, lock_file):
6577 Don't assume pid_t and time_t fit in unsigned long.
6578 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
6579 (current_lock_owner): Prefer signed type for sizes.
6580 Use memcpy, not strncpy, where memcpy is what is really wanted.
6581 Don't assume (via atoi) that time_t and pid_t fit in int.
6582 Check for time_t and/or pid_t out of range, e.g., via a network share.
6583 Don't alloca where an auto var works fine.
6585 * fileio.c: Fix some integer overflow issues.
6586 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
6587 Don't assume string length fits in int.
6588 (directory_file_name): Don't assume string length fits in long.
6589 (make_temp_name): Don't assume pid fits in int, or that its print
6590 length is less than 20.
6592 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
6594 * coding.c (make_subsidiaries): Don't assume string length fits in int.
6596 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
6598 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
6599 We prefer signed integers, even for size calculations.
6601 * emacs.c: Don't assume string length fits in 'int'.
6602 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
6603 (main): Don't invoke strlen when not needed.
6605 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
6606 (XD_DEBUG_MESSAGE): Don't waste a byte.
6608 * callproc.c (getenv_internal_1, getenv_internal)
6610 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
6612 * lread.c (invalid_syntax): Omit length argument.
6613 All uses changed. This doesn't fix a bug, but it simplifies the
6614 code away from its former Hollerith-constant appearance, and it's
6615 one less 'int' to worry about when looking at integer-overflow issues.
6616 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
6618 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
6619 This didn't break anything, but it didn't help either.
6620 It's confusing to put a bogus integer in a place where the actual
6621 value does not matter.
6622 (LIST_END_P): Remove unused macro and its bogus comment.
6623 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
6625 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
6626 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
6628 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
6629 We prefer signed types, and the value cannot exceed the EMACS_INT
6630 range anyway (because otherwise the length would not be representable).
6631 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
6632 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
6633 This avoids a GCC warning when WIDE_EMACS_INT.
6635 * indent.c (sane_tab_width): New function.
6636 (current_column, scan_for_column, Findent_to, position_indentation)
6637 (compute_motion): Use it. This is just for clarity.
6638 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
6640 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
6642 * lisp.h (lint_assume): New macro.
6643 * composite.c (composition_gstring_put_cache):
6644 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
6646 * editfns.c, insdel.c:
6647 Omit unnecessary forward decls, to simplify future changes.
6649 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
6651 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
6653 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
6654 Use much-faster test for byte-length change.
6655 Don't assume string byte-length fits in 'int'.
6656 Check that character arg fits in 'int'.
6657 (mapcar1): Declare byte as byte, for clarity.
6659 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
6661 * fns.c (concat): Catch string overflow earlier.
6662 Do not rely on integer wraparound.
6664 * dispextern.h (struct it.overlay_strings_charpos)
6665 (struct it.selective): Now EMACS_INT, not int.
6666 * xdisp.c (forward_to_next_line_start)
6667 (back_to_previous_visible_line_start)
6668 (reseat_at_next_visible_line_start, next_element_from_buffer):
6669 Don't arbitrarily truncate the value of 'selective' to int.
6671 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
6673 * composite.c: Don't truncate sizes to 'int'.
6674 (composition_gstring_p, composition_reseat_it)
6675 (composition_adjust_point): Use EMACS_INT, not int.
6676 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
6677 not EMACS_UINT, for indexes.
6679 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
6681 * buffer.c: Include <verify.h>.
6682 (struct sortvec.priority, struct sortstr.priority):
6683 Now EMACS_INT, not int.
6684 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
6685 (struct sortstr.size, record_overlay_string)
6686 (struct sortstrlist.size, struct sortlist.used):
6687 Don't truncate size to int.
6688 (record_overlay_string): Check for size-calculation overflow.
6689 (init_buffer_once): Check at compile-time, not run-time.
6691 2011-06-22 Jim Meyering <meyering@redhat.com>
6693 Don't leak an XBM-image-sized buffer
6694 * image.c (xbm_load): Free the image buffer after using it.
6696 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
6699 * composite.c (find_automatic_composition): Omit needless 'return 0;'
6700 that Sun C diagnosed.
6701 * fns.c (secure_hash): Fix pointer signedness issue.
6702 * intervals.c (static_offset_intervals): New function.
6703 (offset_intervals): Use it.
6705 2011-06-21 Leo Liu <sdl.web@gmail.com>
6708 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
6711 * fns.c (secure_hash): Rename from crypto_hash_function and change
6712 the first arg to accept symbols.
6713 (Fsecure_hash): New primitive.
6714 (syms_of_fns): New symbols.
6716 2011-06-20 Deniz Dogan <deniz@dogan.se>
6718 * process.c (Fset_process_buffer): Clarify return value in
6721 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
6723 * dispnew.c (add_window_display_history): Use BVAR.
6725 * xdisp.c (debug_method_add): Use BVAR.
6726 (check_window_end, dump_glyph_matrix, dump_glyph)
6727 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
6729 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
6732 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
6733 check till after the cache is created in init_frame_faces.
6735 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
6737 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
6739 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
6741 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
6742 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
6743 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
6745 Improve buffer-overflow checking (Bug#8873).
6746 * fileio.c (Finsert_file_contents):
6747 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
6748 Remove the old (too-loose) buffer overflow checks.
6749 They weren't needed, since make_gap checks for buffer overflow.
6750 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
6751 The old code merely checked for Emacs fixnum overflow, and relied
6752 on undefined (wraparound) behavior. The new code avoids undefined
6753 behavior, and also checks for ptrdiff_t and/or size_t overflow.
6755 * editfns.c (Finsert_char): Don't dump core with very negative counts.
6756 Tune. Don't use wider integers than needed. Don't use alloca.
6757 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
6759 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
6761 * insdel.c, lisp.h (buffer_overflow): New function.
6762 (insert_from_buffer_1, replace_range, replace_range_2):
6763 * insdel.c (make_gap_larger):
6764 * editfns.c (Finsert_char):
6765 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
6767 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
6769 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
6771 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
6773 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
6774 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
6776 * fileio.c: Don't assume EMACS_INT fits in off_t.
6777 (emacs_lseek): New static function.
6778 (Finsert_file_contents, Fwrite_region): Use it.
6779 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
6781 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
6783 * fns.c: Don't overflow int when computing a list length.
6784 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
6785 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
6786 truncation on 64-bit hosts. Check for QUIT every
6787 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
6788 faster and is responsive enough.
6789 (Flength): Report an error instead of overflowing an integer.
6790 (Fsafe_length): Return a float if the value is not representable
6791 as a fixnum. This shouldn't happen except in contrived situations.
6792 (Fnthcdr, Fsort): Don't assume list length fits in int.
6793 (Fcopy_sequence): Don't assume vector length fits in int.
6795 * alloc.c: Check that resized vectors' lengths fit in fixnums.
6796 (header_size, word_size): New constants.
6797 (allocate_vectorlike): Don't check size overflow here.
6798 (allocate_vector): Check it here instead, since this is the only
6799 caller of allocate_vectorlike that could cause overflow.
6800 Check that the new vector's length is representable as a fixnum.
6802 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
6803 The previous code was bogus. For example, next_almost_prime (32)
6804 returned 39, which is undesirable as it is a multiple of 3; and
6805 next_almost_prime (24) returned 25, which is a multiple of 5 so
6806 why was the code bothering to check for multiples of 7?
6808 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
6810 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
6812 Variadic C functions now count arguments with ptrdiff_t.
6813 This partly undoes my 2011-03-30 change, which replaced int with size_t.
6814 Back then I didn't know that the Emacs coding style prefers signed int.
6815 Also, in the meantime I found a few more instances where arguments
6816 were being counted with int, which may truncate counts on 64-bit
6817 machines, or EMACS_INT, which may be unnecessarily wide.
6818 * lisp.h (struct Lisp_Subr.function.aMANY)
6819 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
6820 Arg counts are now ptrdiff_t, not size_t.
6821 All variadic functions and their callers changed accordingly.
6822 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
6823 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
6824 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
6825 * callint.c (Fcall_interactively): Check arg count for overflow,
6826 to avoid potential buffer overrun. Use signed char, not 'int',
6827 for 'varies' array, so that we needn't bother to check its size
6828 calculation for overflow.
6829 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
6830 * eval.c (apply_lambda):
6831 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
6832 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
6833 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
6835 * callint.c (Fcall_interactively): Don't use index var as event count.
6837 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
6838 * mem-limits.h (SIZE): Remove; no longer used.
6840 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
6842 Remove unnecessary casts.
6843 * xterm.c (x_term_init):
6844 * xfns.c (x_set_border_pixel):
6845 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
6846 These aren't needed now that we assume ANSI C.
6848 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
6849 It's more likely to cause problems (due to unsigned overflow)
6852 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
6854 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
6856 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
6858 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
6860 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
6862 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
6864 GLYPH_CODE_FACE returns EMACS_INT, not int.
6865 * dispextern.h (merge_faces):
6866 * xfaces.c (merge_faces):
6867 * xdisp.c (get_next_display_element, next_element_from_display_vector):
6868 Don't assume EMACS_INT fits in int.
6870 * character.h (CHAR_VALID_P): Remove unused parameter.
6871 * fontset.c, lisp.h, xdisp.c: All uses changed.
6873 * editfns.c (Ftranslate_region_internal): Omit redundant test.
6875 * fns.c (concat): Minor tuning based on overflow analysis.
6876 This doesn't fix any bugs. Use int to hold character, instead
6877 of constantly refetching from Emacs object. Use XFASTINT, not
6878 XINT, for value known to be a character. Don't bother comparing
6879 a single byte to 0400, as it's always less.
6881 * floatfns.c (Fexpt):
6882 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
6884 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
6887 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
6889 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
6890 Without this fix, on a 64-bit host (aset S 0 4294967386) would
6891 incorrectly succeed when S was a string, because 4294967386 was
6892 truncated before it was used.
6894 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
6895 Otherwise, an out-of-range integer could cause undefined behavior
6898 * composite.c: Use int, not EMACS_INT, for characters.
6899 (fill_gstring_body, composition_compute_stop_pos): Use int, not
6900 EMACS_INT, for values that are known to be in character range.
6901 This doesn't fix any bugs but is the usual style inside Emacs and
6902 may generate better code on 32-bit machines.
6904 Make sure a 64-bit char is never passed to ENCODE_CHAR.
6905 This is for reasons similar to the recent CHAR_STRING fix.
6906 * charset.c (Fencode_char): Check that character arg is actually
6907 a character. Pass an int to ENCODE_CHAR.
6908 * charset.h (ENCODE_CHAR): Verify that the character argument is no
6909 wider than 'int', as a compile-time check to prevent future regressions
6912 * character.c (char_string): Remove unnecessary casts.
6914 Make sure a 64-bit char is never passed to CHAR_STRING.
6915 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
6916 by silently ignoring the top 32 bits, allowing some values
6917 that were far too large to be valid characters.
6918 * character.h: Include <verify.h>.
6919 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
6920 arguments are no wider than unsigned, as a compile-time check
6921 to prevent future regressions in this area.
6923 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
6924 (Fsubst_char_in_region):
6926 * xdisp.c (decode_mode_spec_coding):
6927 Adjust to CHAR_STRING's new requirement.
6928 * editfns.c (Finsert_char, Fsubst_char_in_region):
6929 * fns.c (concat): Check that character args are actually
6930 characters. Without this test, these functions did the wrong
6931 thing with wildly out-of-range values on 64-bit hosts.
6933 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
6934 These casts should not be needed on 32-bit hosts, either.
6935 * keyboard.c (read_char):
6936 * lread.c (Fload): Remove casts to unsigned.
6938 * lisp.h (UNSIGNED_CMP): New macro.
6939 This fixes comparison bugs on 64-bit hosts.
6940 (ASCII_CHAR_P): Use it.
6941 * casefiddle.c (casify_object):
6942 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
6943 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
6944 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
6945 * dispextern.h (FACE_FROM_ID):
6946 * keyboard.c (read_char): Use UNSIGNED_CMP.
6948 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
6949 not to EMACS_INT, to avoid GCC warning.
6951 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
6953 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
6954 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
6955 isn't needed on 32-bit machines.
6957 * buffer.c (Fgenerate_new_buffer_name):
6958 Use EMACS_INT for count, not int.
6959 (advance_to_char_boundary): Return EMACS_INT, not int.
6961 * data.c (Qcompiled_function): Now static.
6963 * window.c (window_body_lines): Now static.
6965 * image.c (gif_load): Rename local to avoid shadowing.
6967 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
6968 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
6969 * alloc.c (make_save_value): Integer argument is now of type
6971 (mark_object): Use ptrdiff_t, not int.
6972 * lisp.h (pD): New macro.
6973 * print.c (print_object): Use it.
6975 * alloc.c: Use EMACS_INT, not int, to count objects.
6976 (total_conses, total_markers, total_symbols, total_vector_size)
6977 (total_free_conses, total_free_markers, total_free_symbols)
6978 (total_free_floats, total_floats, total_free_intervals)
6979 (total_intervals, total_strings, total_free_strings):
6980 Now EMACS_INT, not int. All uses changed.
6981 (Fgarbage_collect): Compute overall total using a double, so that
6982 integer overflow is less likely to be a problem. Check for overflow
6983 when converting back to an integer.
6984 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
6985 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
6986 These were 'int' variables that could overflow on 64-bit hosts;
6987 they were never used, so remove them instead of repairing them.
6988 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6989 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
6990 Previously, this ceilinged at INT_MAX, but that doesn't work on
6992 (allocate_pseudovector): Don't use EMACS_INT when int would do.
6994 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
6995 (allocate_vectorlike): Check for ptrdiff_t overflow.
6996 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
6997 when a (possibly-narrower) signed value would do just as well.
6998 We prefer using signed arithmetic, to avoid comparison confusion.
7000 * alloc.c: Catch some string size overflows that we were missing.
7001 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7002 for convenience in STRING_BYTES_MAX.
7003 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7004 The definition here is exact; the one in lisp.h was approximate.
7005 (allocate_string_data): Check for string overflow. This catches
7006 some instances we weren't catching before. Also, it catches
7007 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7008 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7009 and ptrdiff_t and EMACS_INT are both 64 bits.
7011 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7012 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
7013 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
7015 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7017 * alloc.c (Fmake_string): Check for out-of-range init.
7019 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7021 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7023 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7025 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7026 xg_get_default_scrollbar_width.
7028 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7029 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7030 (style_changed_cb): Call update_theme_scrollbar_width and call
7031 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7032 all frames (Bug#8505).
7033 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7034 Call gtk_window_set_resizable if HAVE_GTK3.
7035 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7036 and height if HAVE_GTK3 (Bug#8505).
7037 (scroll_bar_width_for_theme): New variable.
7038 (update_theme_scrollbar_width): New function.
7039 (xg_get_default_scrollbar_width): Move code to
7040 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7041 (xg_initialize): Call update_theme_scrollbar_width.
7043 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7045 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7047 2011-06-12 Martin Rudalics <rudalics@gmx.at>
7049 * frame.c (make_frame): Call other_buffer_safely instead of
7052 * window.c (temp_output_buffer_show): Call display_buffer with
7053 second argument Vtemp_buffer_show_specifiers and reset latter
7054 immediately after the call.
7055 (Vtemp_buffer_show_specifiers): New variable.
7056 (auto_window_vscroll_p, next_screen_context_lines)
7057 (Vscroll_preserve_screen_position): Remove leading asterisks from
7060 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
7062 Fix minor problems found by GCC 4.6.0 static checking.
7063 * buffer.c (Qclone_number): Remove for now, as it's unused.
7064 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7065 (record_buffer): Remove unused local.
7066 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7067 (set_frame_buffer_list): Remove; unused.
7068 * frame.h (other_visible_frames): Remove decl.
7069 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7070 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7071 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7073 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7074 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7075 Define only if HAVE_GPM.
7076 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7077 (update_hints_inhibit): Remove; never set. All uses removed.
7078 * widgetprv.h (emacsFrameClassRec): Remove decl.
7079 * window.c (delete_deletable_window): Now returns void, since it
7080 wasn't returning anything.
7081 (compare_window_configurations): Remove unused locals.
7082 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7083 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
7084 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7085 the same widths as pointers. This follows up on the 2011-05-06 patch.
7086 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7087 * xterm.h: Likewise.
7088 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7090 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
7092 * makefile.w32-in: Update dependencies.
7093 (LISP_H): Add lib/intprops.h.
7095 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7097 * image.c (gif_load): Add animation frame delay to the metadata.
7098 (syms_of_image): Use DEFSYM. New symbol `delay'.
7100 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7102 * window.c (delete_deletable_window): Re-add.
7103 (Fset_window_configuration): Rewrite to handle dead buffers and
7104 consequently deletable windows.
7105 (window_tree, Fwindow_tree): Remove. Supply functionality in
7107 (compare_window_configurations): Simplify code.
7109 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7111 * image.c (imagemagick_load_image): Fix type mismatch.
7112 (Fimagemagick_types): Likewise.
7114 * window.h (replace_buffer_in_windows): Declare.
7116 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7118 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7119 Qclone_number. Remove external declaration of Qdelete_window.
7120 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7122 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7123 Run Qbuffer_list_update_hook if allowed.
7124 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7125 buffer list implementation.
7126 (other_buffer_safely): New function.
7127 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7128 calls to replace_buffer_in_windows and
7129 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7131 (record_buffer): Inhibit quitting and rewrite using quittable
7132 functions. Run Qbuffer_list_update_hook if allowed.
7133 (Frecord_buffer, Funrecord_buffer): New functions.
7134 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7135 Move switch-to-buffer to window.el.
7136 (bury-buffer): Move to window.el.
7137 (Vbuffer_list_update_hook): New variable.
7139 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7142 * window.h (resize_frame_windows): Move up in code.
7143 (Fwindow_frame): Remove EXFUN.
7144 (replace_buffer_in_all_windows): Remove prototype.
7145 (replace_buffer_in_windows_safely): Add prototype.
7147 * window.c: Declare Qdelete_window static again. Move down
7148 declaration of select_count.
7149 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7150 (Fother_window): Move to window.el.
7151 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7152 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7153 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7155 (replace_buffer_in_windows): Implement by calling
7156 Qreplace_buffer_in_windows.
7157 (replace_buffer_in_all_windows): Remove with some functionality
7158 moved into replace_buffer_in_windows_safely.
7159 (replace_buffer_in_windows_safely): New function.
7160 (select_window_norecord, select_frame_norecord): Move in front
7161 of run_window_configuration_change_hook. Remove now obsolete
7163 (Fset_window_buffer): Rewrite doc-string.
7164 Call Qrecord_window_buffer.
7165 (keys_of_window): Move binding for other-window to window.el.
7167 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7169 * dispextern.h (struct image): Replace data member, whose int_val
7170 and ptr_val fields were not used by anything, with a single
7173 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7174 (gif_clear_image, gif_load, imagemagick_load_image)
7175 (gs_clear_image, gs_load): Callers changed.
7177 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7179 * buffer.h: Include <time.h>, for time_t.
7180 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7182 Fix minor problems found by static checking.
7184 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7186 Make identifiers static if they are not used in other modules.
7187 * data.c (Qcompiled_function, Qframe, Qvector):
7188 * image.c (QimageMagick, Qsvg):
7189 * minibuf.c (Qmetadata):
7190 * window.c (resize_window_check, resize_root_window): Now static.
7191 * window.h (resize_window_check, resize_root_window): Remove decls.
7193 * window.c (window_deletion_count, delete_deletable_window):
7195 (window_body_lines): Now static.
7196 (Fdelete_other_windows_internal): Mark vars as initialized.
7197 Make sure 'resize_failed' is initialized.
7198 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7199 (resize_window_apply): Remove unused local.
7200 * window.h (delete_deletable_window): Remove decl.
7202 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
7203 (imagemagick_load_image): Fix pointer signedness problem by changing
7204 last arg from unsigned char * to char *. All uses changed.
7205 Also, fix a local for similar reasons.
7206 Remove unused locals. Remove locals to avoid shadowing.
7207 (fn_rsvg_handle_free): Remove; unused.
7208 (svg_load, svg_load_image): Fix pointer signedness problem.
7209 (imagemagick_load_image): Don't use garbage pointer image_wand.
7211 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7213 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
7215 * image.c (gif_load): Fix omitted cast error introduced by
7218 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7220 * window.h (resize_proportionally, orig_total_lines)
7221 (orig_top_line): Remove from window structure.
7222 (set_window_height, set_window_width, change_window_heights)
7223 (Fdelete_window): Remove prototypes.
7224 (resize_frame_windows): Remove duplicate declaration.
7226 2011-06-10 Eli Zaretskii <eliz@gnu.org>
7228 * window.h (resize_frame_windows, resize_window_check)
7229 (delete_deletable_window, resize_root_window)
7230 (resize_frame_windows): Declare prototypes.
7232 * window.c (resize_window_apply): Make definition be "static" to
7233 match the prototype.
7235 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7237 * window.c: Remove declarations of Qwindow_size_fixed,
7238 window_min_size_1, window_min_size_2, window_min_size,
7239 size_window, window_fixed_size_p, enlarge_window, delete_window.
7240 Remove static from declaration of Qdelete_window, it's
7241 temporarily needed by Fbury_buffer.
7242 (replace_window): Don't assign orig_top_line and
7244 (Fdelete_window, delete_window): Remove. Window deletion is
7245 handled by window.el.
7246 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7247 Replace Fdelete_window calls with calls to Qdelete_window.
7248 (Fdelete_other_windows): Remove. Deleting other windows is
7249 handled by window.el.
7250 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7251 handled in window.el.
7252 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7253 Window minimum sizes are handled in window.el.
7254 (shrink_windows, size_window, set_window_height)
7255 (set_window_width, change_window_heights, window_height)
7256 (window_width, CURBEG, CURSIZE, enlarge_window)
7257 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7258 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7259 handled in window.el.
7260 (make_dummy_parent): Rename to make_parent_window and give it a
7261 second argument horflag.
7262 (make_window): Don't set resize_proportionally any more.
7263 (Fsplit_window): Remove. Windows are split in window.el.
7264 (save_restore_action, save_restore_orig_size)
7265 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7266 Resize mini windows in window.el.
7267 (grow_mini_window, shrink_mini_window): Implement by calling
7268 Qresize_root_window_vertically, resize_window_check and
7269 resize_window_apply.
7270 (saved_window, Fset_window_configuration, save_window_save):
7271 Do not handle orig_top_line, orig_total_lines, and
7272 resize_proportionally.
7273 (window_min_height, window_min_width): Move to window.el.
7274 (keys_of_window): Move bindings for delete-other-windows,
7275 split-window, delete-window and enlarge-window to window.el.
7277 * buffer.c: Temporarily extern Qdelete_window.
7278 (Fbury_buffer): Temporarily call Qdelete_window instead of
7279 Fdelete_window (Fbury_buffer will move to window.el soon).
7281 * frame.c (set_menu_bar_lines_1): Remove code handling
7282 orig_top_line and orig_total_lines.
7284 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7285 set_window_height but set heights directly.
7286 (change_frame_size_1): Use resize_frame_windows.
7288 * xdisp.c (init_xdisp): Don't use set_window_height but set
7291 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7292 Use resize_frame_windows instead of change_window_heights and run
7293 run_window_configuration_change_hook.
7295 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7296 instead of change_window_heights and run
7297 run_window_configuration_change_hook.
7299 2011-06-09 Martin Rudalics <rudalics@gmx.at>
7301 * window.c (replace_window): Rename second argument REPLACEMENT to
7302 NEW. New third argument SETFLAG. Rewrite.
7303 (delete_window, make_dummy_parent): Call replace_window with
7305 (window_list_1): Move down in code.
7306 (run_window_configuration_change_hook): Move set_buffer part
7307 before select_frame_norecord part in order to unwind correctly.
7308 Rename count1 to count.
7309 (recombine_windows, delete_deletable_window, resize_root_window)
7310 (Fdelete_other_windows_internal)
7311 (Frun_window_configuration_change_hook, make_parent_window)
7312 (resize_window_check, resize_window_apply, Fresize_window_apply)
7313 (resize_frame_windows, Fsplit_window_internal)
7314 (Fdelete_window_internal, Fresize_mini_window_internal):
7316 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7318 2011-06-08 Martin Rudalics <rudalics@gmx.at>
7320 * window.h (window): Add some new members to window structure -
7321 normal_lines, normal_cols, new_total, new_normal, clone_number,
7322 splits, nest, prev_buffers, next_buffers.
7323 (WINDOW_TOTAL_SIZE): Move here from window.c.
7324 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
7326 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7328 (make_dummy_parent): Set new members of windows structure.
7329 (make_window): Move down in code. Handle new members of window
7331 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7332 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7333 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7334 (Fset_window_prev_buffers, Fwindow_next_buffers)
7335 (Fset_window_next_buffers, Fset_window_clone_number):
7337 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7338 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7340 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7341 Argument WINDOW can be now internal window too.
7342 (Fwindow_use_time): Move up in code.
7343 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7345 (Fset_window_configuration, saved_window)
7346 (Fcurrent_window_configuration, save_window_save): Handle new
7347 members of window structure.
7348 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7349 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7350 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7351 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7352 Qget_mru_window, Qresize_root_window,
7353 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7354 Qauto_buffer_name; staticpro them.
7356 2011-06-07 Martin Rudalics <rudalics@gmx.at>
7358 * window.c (Fwindow_total_size, Fwindow_left_column)
7359 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7360 (Fwindow_list_1): New functions.
7361 (window_box_text_cols): Replace with window_body_cols.
7362 (Fwindow_width, Fscroll_left, Fscroll_right):
7363 Use window_body_cols instead of window_box_text_cols.
7364 (delete_window, Fset_window_configuration):
7365 Call delete_all_subwindows with window as argument.
7366 (delete_all_subwindows): Take a window as argument and not a
7368 (window_loop): Remove handling of GET_LRU_WINDOW and
7370 (Fget_lru_window, Fget_largest_window): Move to window.el.
7372 * window.h: Extern window_body_cols instead of
7373 window_box_text_cols. delete_all_subwindows now takes a
7374 Lisp_Object as argument.
7376 * indent.c (compute_motion, Fcompute_motion):
7377 Use window_body_cols instead of window_box_text_cols.
7379 * frame.c (delete_frame): Call delete_all_subwindows with root
7382 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7384 * fns.c (Fputhash): Document return value.
7386 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
7388 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7390 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7392 Cons<->int and similar integer overflow fixes (Bug#8794).
7394 Check for overflow when converting integer to cons and back.
7395 * charset.c (Fdefine_charset_internal, Fdecode_char):
7396 Use cons_to_unsigned to catch overflow.
7397 (Fencode_char): Use INTEGER_TO_CONS.
7398 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7399 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7400 * data.c (long_to_cons, cons_to_long): Remove.
7401 (cons_to_unsigned, cons_to_signed): New functions.
7402 These signal an error for invalid or out-of-range values.
7403 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7404 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7405 * font.c (Ffont_variation_glyphs):
7406 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7407 * lisp.h: Include <intprops.h>.
7408 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7409 (cons_to_signed, cons_to_unsigned): New decls.
7410 (long_to_cons, cons_to_long): Remove decls.
7411 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7412 (Fprimitive_undo): Use CONS_TO_INTEGER.
7413 * xfns.c (Fx_window_property): Likewise.
7414 * xselect.c: Include <limits.h>.
7415 (x_own_selection, selection_data_to_lisp_data):
7416 Use INTEGER_TO_CONS.
7417 (x_handle_selection_request, x_handle_selection_clear)
7418 (x_get_foreign_selection, Fx_disown_selection_internal)
7419 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7420 (lisp_data_to_selection_data): Use cons_to_unsigned.
7421 (x_fill_property_data): Use cons_to_signed.
7422 Report values out of range.
7424 Check for buffer and string overflow more precisely.
7425 * buffer.h (BUF_BYTES_MAX): New macro.
7426 * lisp.h (STRING_BYTES_MAX): New macro.
7427 * alloc.c (Fmake_string):
7428 * character.c (string_escape_byte8):
7429 * coding.c (coding_alloc_by_realloc):
7430 * doprnt.c (doprnt):
7431 * editfns.c (Fformat):
7433 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7434 since they may not be the same number.
7435 * editfns.c (Finsert_char):
7436 * fileio.c (Finsert_file_contents):
7437 Likewise for BUF_BYTES_MAX.
7439 * image.c: Use ptrdiff_t, not int, for sizes.
7440 (slurp_file): Switch from int to ptrdiff_t.
7442 (slurp_file): Check that file size fits in both size_t (for
7443 malloc) and ptrdiff_t (for sanity and safety).
7445 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7446 if b->modtime has its maximal value.
7448 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7450 Don't assume time_t can fit into int.
7451 * buffer.h (struct buffer.modtime): Now time_t, not int.
7452 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
7453 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7455 Minor fixes for signed vs unsigned integers.
7456 * character.h (MAYBE_UNIFY_CHAR):
7457 * charset.c (maybe_unify_char):
7458 * keyboard.c (read_char, reorder_modifiers):
7459 XINT -> XFASTINT, since the integer must be nonnegative.
7460 * ftfont.c (ftfont_spec_pattern):
7461 * keymap.c (access_keymap, silly_event_symbol_error):
7462 XUINT -> XFASTINT, since the integer must be nonnegative.
7463 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
7464 since it makes no difference and we prefer signed.
7465 * keyboard.c (record_char): Use XUINT when all the neighbors do.
7466 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
7469 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
7471 * window.h (Fwindow_frame): Declare.
7473 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7475 * alloc.c: Simplify handling of large-request failures (Bug#8800).
7476 (SPARE_MEMORY): Always define.
7477 (LARGE_REQUEST): Remove.
7478 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
7480 2011-06-06 Martin Rudalics <rudalics@gmx.at>
7482 * lisp.h: Move EXFUNS for Fframe_root_window,
7483 Fframe_first_window and Fset_frame_selected_window to window.h.
7485 * window.h: Move EXFUNS for Fframe_root_window,
7486 Fframe_first_window and Fset_frame_selected_window here from
7489 * frame.c (Fwindow_frame, Fframe_first_window)
7490 (Fframe_root_window, Fframe_selected_window)
7491 (Fset_frame_selected_window): Move to window.c.
7492 (Factive_minibuffer_window): Move to minibuf.c.
7493 (Fother_visible_frames_p): New function.
7495 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
7497 * window.c (decode_window, decode_any_window): Move up in code.
7498 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
7499 (inhibit_frame_unsplittable): Remove unused variable.
7500 (Fwindow_buffer): Move up and rewrite doc-string.
7501 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
7502 (Fwindow_prev): New functions.
7503 (Fwindow_frame): Move here from frame.c. Accept any window as
7505 (Fframe_root_window, Fframe_first_window)
7506 (Fframe_selected_window): Move here from frame.c. Accept frame
7507 or arbitrary window as argument. Update doc-strings.
7508 (Fminibuffer_window): Move up in code.
7509 (Fwindow_minibuffer_p): Move up in code and simplify.
7510 (Fset_frame_selected_window): Move here from frame.c.
7512 (Fselected_window, select_window, Fselect_window): Move up in
7513 code. Minor doc-string fixes.
7515 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7517 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
7518 Do not assume that spare memory exists; that assumption is valid
7519 only if SYSTEM_MALLOC.
7520 (LARGE_REQUEST): New macro, so that the issue of large requests
7521 is separated from the issue of spare memory.
7523 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
7525 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
7528 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
7530 * xfns.c (x_set_scroll_bar_default_width): Move declarations
7533 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
7535 * gtkutil.c (xg_get_default_scrollbar_width): New function.
7537 * gtkutil.h: Declare xg_get_default_scrollbar_width.
7539 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
7540 min width by calling x_set_scroll_bar_default_width (Bug#8505).
7542 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
7544 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
7546 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
7548 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
7549 (x_clipboard_manager_save): Add return value.
7550 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
7552 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
7553 Obey Vx_select_enable_clipboard_manager. Catch errors in
7554 x_clipboard_manager_save (Bug#8779).
7555 (Vx_select_enable_clipboard_manager): New variable.
7556 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
7558 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
7560 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
7562 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7564 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
7565 in the current matrix if keep_current_p is non-zero.
7567 2011-06-04 Eli Zaretskii <eliz@gnu.org>
7569 * bidi.c (bidi_level_of_next_char): Fix last change.
7571 2011-06-03 Eli Zaretskii <eliz@gnu.org>
7573 Support bidi reordering of text covered by display properties.
7575 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
7576 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
7577 (bidi_cache_search, bidi_cache_iterator_state)
7578 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
7579 (bidi_level_of_next_char, bidi_move_to_visually_next):
7580 Support character positions inside a run of characters covered by a
7582 (bidi_paragraph_init, bidi_resolve_explicit_1)
7583 (bidi_level_of_next_char): Call bidi_fetch_char and
7584 bidi_fetch_char_advance instead of FETCH_CHAR and
7586 (bidi_init_it): Initialize new members.
7587 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
7589 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
7590 instead of using explicit *_CHAR codes.
7591 (bidi_resolve_explicit, bidi_resolve_weak):
7592 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
7593 bidirectional text is supported only in multibyte buffers.
7594 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
7595 it to initialize the frame_window_p member of struct bidi_it.
7596 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
7597 (bidi_resolve_explicit, bidi_resolve_weak)
7598 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
7599 bidi_it->nchars is non-positive.
7600 (bidi_level_of_next_char): Don't try to lookup the cache for the
7601 next/previous character if nothing is cached there yet, or if we
7602 were just reseat()'ed to a new position.
7604 * xdisp.c (set_cursor_from_row): Set start and stop points
7605 according to the row's direction when priming the loop that looks
7606 for the glyph on which to display cursor.
7607 (single_display_spec_intangible_p): Function deleted.
7608 (display_prop_intangible_p): Reimplement to call
7609 handle_display_spec instead of single_display_spec_intangible_p.
7610 Accept 3 additional arguments needed by handle_display_spec.
7611 This fixes incorrect cursor motion across display property with complex
7612 values: lists, `(when COND...)' forms, etc.
7613 (single_display_spec_string_p): Support property values that are
7614 lists with the argument STRING its top-level element.
7615 (display_prop_string_p): Fix the condition for processing a
7616 property that is a list to be consistent with handle_display_spec.
7617 (handle_display_spec): New function, refactored from the
7618 last portion of handle_display_prop.
7619 (compute_display_string_pos): Accept additional argument
7620 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
7621 value of a `display' property is a "replacing spec".
7622 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
7623 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
7624 the display property, but just return a value indicating whether
7625 the display property will replace the characters it covers.
7626 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
7627 frame_window_p members of struct bidi_it.
7628 (compute_display_string_pos, compute_display_string_end):
7630 (push_it): Accept second argument POSITION, where pop_it should
7631 jump to continue iteration.
7632 (reseat_1): Initialize bidi_it.disp_pos.
7634 * keyboard.c (adjust_point_for_property): Adjust the call to
7635 display_prop_intangible_p to its new signature.
7637 * dispextern.h (struct bidi_it): New member frame_window_p.
7638 (bidi_init_it): Update prototypes.
7639 (display_prop_intangible_p): Update prototype.
7640 (compute_display_string_pos, compute_display_string_end):
7642 (struct bidi_it): New members nchars and disp_pos. ch_len is now
7645 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
7647 Malloc failure behavior now depends on size of allocation.
7648 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
7649 * lisp.h: Change signatures accordingly.
7650 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
7651 All callers changed. (Bug#8762)
7653 * gnutls.c: Use Emacs's memory allocators.
7654 Without this change, the gnutls library would invoke malloc etc.
7655 directly, which causes problems on non-SYNC_INPUT hosts, and which
7656 runs afoul of improving memory_full behavior. (Bug#8761)
7657 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
7658 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
7659 xfree instead of the default malloc, realloc, free.
7660 (Fgnutls_boot): No need to check for memory allocation failure,
7661 since xmalloc does that for us.
7663 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
7664 * category.c (hash_get_category_set):
7665 * ccl.c (ccl_driver):
7666 * charset.c (Fdefine_charset_internal):
7667 * charset.h (struct charset.hash_index):
7668 * composite.c (get_composition_id, gstring_lookup_cache)
7669 (composition_gstring_put_cache):
7670 * composite.h (struct composition.hash_index):
7671 * dispextern.h (struct image.hash):
7672 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
7673 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
7674 (hashfn_equal, hashfn_user_defined, make_hash_table)
7675 (maybe_resize_hash_table, hash_lookup, hash_put)
7676 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
7677 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
7678 (Fsxhash, Fgethash, Fputhash, Fmaphash):
7679 * image.c (make_image, search_image_cache, lookup_image)
7680 (xpm_put_color_table_h):
7681 * lisp.h (struct Lisp_Hash_Table):
7682 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
7683 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
7684 for hashes and hash indexes, instead of 'unsigned' and 'int'.
7685 * alloc.c (allocate_vectorlike):
7686 Check for overflow in vector size calculations.
7687 * ccl.c (ccl_driver):
7688 Check for overflow when converting EMACS_INT to int.
7689 * fns.c, image.c: Remove unnecessary static decls that would otherwise
7690 need to be updated by these changes.
7691 * fns.c (make_hash_table, maybe_resize_hash_table):
7692 Check for integer overflow with large hash tables.
7693 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
7694 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
7695 (SXHASH_REDUCE): New macro.
7696 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
7697 Use it instead of discarding useful hash info with large hash values.
7698 (sxhash_float): New function.
7699 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
7700 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
7701 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
7702 Rewrite to use FIXNUM_BITS, as this simplifies things.
7703 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
7704 Adjust signatures to match updated version of code.
7705 (consing_since_gc): Now EMACS_INT, since a single hash table can
7706 use more than INT_MAX bytes.
7708 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
7710 Make it possible to build with GCC-4.6+ -O2 -flto.
7712 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
7714 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
7716 * minibuf.c (get_minibuffer, read_minibuf_unwind):
7717 Call minibuffer-inactive-mode.
7719 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
7721 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
7722 Update dependencies.
7724 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7726 * data.c (init_data): Remove code for UTS, this system is not
7729 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7731 Don't force ./temacs to start in terminal mode.
7733 * frame.c (make_initial_frame): Initialize faces in all cases, not
7734 only when CANNOT_DUMP is defined.
7735 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
7737 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7739 * dispnew.c (add_window_display_history): Use const for the string
7740 pointer. Remove declaration, not needed.
7742 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
7744 Use 'inline', not 'INLINE'.
7745 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
7746 * alloc.c, fontset.c (INLINE): Remove.
7747 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
7748 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
7749 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
7750 * gmalloc.c (register_heapinfo): Use inline unconditionally.
7751 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
7753 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7755 Make it possible to run ./temacs.
7757 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
7758 syms_of_callproc does the same thing. Remove test for
7759 "initialized", do it in the caller.
7760 * emacs.c (main): Avoid calling set_initial_environment when dumping.
7762 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
7764 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
7765 (read_minibuf): Use get_minibuffer.
7766 (syms_of_minibuf): Use DEFSYM.
7767 (Qmetadata): New var.
7768 * data.c (Qbuffer): Don't make it static.
7769 (syms_of_data): Use DEFSYM.
7771 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
7773 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
7774 (CCL_CODE_MIN): New macro.
7776 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
7778 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
7780 * eval.c (Qdebug): Now static.
7781 * lisp.h (Qdebug): Remove decl. This reverts a part of the
7782 2011-04-26 change (bzr 104015) that inadvertently undid part of
7783 the 2011-04-14 change (bzr 103913).
7785 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
7787 * image.c: Various fixes to ImageMagick code comments.
7788 (Fimagemagick_types): Doc fix.
7790 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
7792 Minor fixes prompted by GCC 4.6.0 warnings.
7794 * xselect.c (converted_selections, conversion_fail_tag): Now static.
7796 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
7797 (x_clipboard_manager_save_all): Move extern decl to ...
7798 * xterm.h: ... here, so that it can be checked for consistency.
7800 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
7802 * xselect.c (x_clipboard_manager_save_frame)
7803 (x_clipboard_manager_save_all): New functions.
7804 (Fx_clipboard_manager_save): Lisp function deleted.
7806 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
7807 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
7809 * xterm.h: Update prototype.
7811 2011-05-28 William Xu <william.xwl@gmail.com>
7813 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
7816 2011-05-28 Jim Meyering <meyering@redhat.com>
7818 Avoid a sign-extension bug in crypto_hash_function.
7819 * fns.c (to_uchar): Define.
7820 (crypto_hash_function): Use it to convert some newly-signed
7821 variables to unsigned, to avoid sign-extension bugs. For example,
7822 without this change, (md5 "truc") would evaluate to
7823 45723a2aff78ff4fff7fff1114760e62 rather than the expected
7824 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
7825 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
7827 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
7829 Integer overflow fixes.
7831 * dbusbind.c: Serial number integer overflow fixes.
7832 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
7833 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
7834 to hold a serial number that is too large for a fixnum.
7835 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7836 Check for serial numbers out of range. Decode any serial number
7837 that was so large that it became a float. (Bug#8722)
7839 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
7840 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7841 Use XFASTINT rather than XUINT when numbers are nonnegative.
7842 (xd_append_arg, Fdbus_method_return_internal):
7843 (Fdbus_method_error_internal): Likewise. Also, for unsigned
7844 arguments, check that Lisp number is nonnegative, rather than
7845 silently wrapping negative numbers around. (Bug#8722)
7846 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
7849 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
7851 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
7853 ccl: Add integer overflow checks.
7854 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
7855 (IN_INT_RANGE): New macros.
7856 (ccl_driver): Use them to check for integer overflow when
7857 decoding a CCL program. Many of the new checks are whether XINT (x)
7858 fits in int; it doesn't always, on 64-bit hosts. The new version
7859 doesn't catch all possible integer overflows, but it's an
7860 improvement. (Bug#8719)
7862 * alloc.c (make_event_array): Use XINT, not XUINT.
7863 There's no need for unsigned here.
7865 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
7866 This follows up to the 2011-05-06 change that substituted uintptr_t
7867 for EMACS_INT. This case wasn't caught back then.
7869 Rework Fformat to avoid integer overflow issues.
7870 * editfns.c: Include <float.h> unconditionally, as it's everywhere
7871 now (part of C89). Include <verify.h>.
7872 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
7873 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
7874 (Fformat): Avoid the prepass trying to compute sizes; it was only
7875 approximate and thus did not catch overflow reliably. Instead, walk
7876 through the format just once, formatting and computing sizes as we go,
7877 checking for integer overflow at every step, and allocating a larger
7878 buffer as needed. Keep track separately whether the format is
7879 multibyte. Keep only the most-recently calculated precision, rather
7880 than them all. Record whether each argument has been converted to
7881 string. Use EMACS_INT, not int, for byte and char and arg counts.
7882 Support field widths and precisions larger than INT_MAX. Avoid
7883 sprintf's undefined behavior with conversion specifications such as %#d
7884 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
7885 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
7886 formatting out-of-range floating point numbers with int
7889 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
7891 * data.c: Avoid integer truncation in expressions involving floats.
7892 * data.c: Include <intprops.h>.
7893 (arith_driver): When there's an integer overflow in an expression
7894 involving floating point, convert the integers to floating point
7895 so that the resulting value does not suffer from catastrophic
7896 integer truncation. For example, on a 64-bit host (* 4
7897 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
7898 Do not rely on undefined behavior after integer overflow.
7900 merge count_size_as_multibyte, parse_str_to_multibyte
7901 * character.c, character.h (count_size_as_multibyte):
7902 Rename from parse_str_to_multibyte; all uses changed.
7903 Check for integer overflow.
7904 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
7905 since it's now a duplicate of the other. This is more of
7906 a character than a buffer op, so better that it's in character.c.
7907 * fns.c, print.c: Adjust to above changes.
7909 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
7911 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
7913 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
7915 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
7916 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
7917 (x_clipboard_manager_save): Now static.
7918 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
7920 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
7921 (crypto_hash_function): Now static.
7922 Fix pointer signedness problems. Avoid unnecessary initializations.
7924 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
7926 * termhooks.h (Vselection_alist): Make it terminal-local.
7928 * terminal.c (create_terminal): Initialize it.
7930 * xselect.c: Support for clipboard managers.
7931 (Vselection_alist): Move to termhooks.h as terminal-local var.
7932 (LOCAL_SELECTION): New macro.
7933 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
7934 (symbol_to_x_atom): Remove gratuitous arg.
7935 (x_handle_selection_request, lisp_data_to_selection_data)
7936 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
7937 (x_own_selection, x_get_local_selection, x_convert_selection):
7938 New arg, specifying work frame. Use terminal-local Vselection_alist.
7939 (some_frame_on_display): Delete unused function.
7940 (Fx_own_selection_internal, Fx_get_selection_internal)
7941 (Fx_disown_selection_internal, Fx_selection_owner_p)
7942 (Fx_selection_exists_p): New optional frame arg.
7943 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
7944 (x_handle_selection_clear): Don't treat other terminals with the
7945 same keyboard specially. Use the terminal-local Vselection_alist.
7946 (x_clear_frame_selections): Use Frun_hook_with_args.
7948 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
7950 * xterm.h: Add support for those atoms.
7952 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
7954 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
7955 (converted_selections, conversion_fail_tag): New global variables.
7956 (x_selection_request_lisp_error): Free the above.
7957 (x_get_local_selection): Remove unnecessary code.
7958 (x_reply_selection_request): Args changed; handle arbitrary array
7959 of converted selections stored in converted_selections.
7960 Separate the XChangeProperty and SelectionNotify steps.
7961 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
7962 (x_convert_selection): New function.
7963 (x_handle_selection_event): Simplify.
7964 (x_get_foreign_selection): Don't ignore incoming requests while
7965 waiting for an answer; this will fail when we implement
7966 SAVE_TARGETS, and seems unnecessary anyway.
7967 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
7968 (Vx_sent_selection_functions): Doc fix.
7970 2011-05-26 Leo Liu <sdl.web@gmail.com>
7972 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
7974 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7976 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
7978 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
7979 for fringe update if it has periodic bitmap.
7980 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
7981 and fringe_bitmap_periodic_p.
7983 * fringe.c (get_fringe_bitmap_data): New function.
7984 (draw_fringe_bitmap_1, update_window_fringes): Use it.
7985 (update_window_fringes): Record periodicity of fringe bitmap in glyph
7986 row. Mark glyph row for fringe update if periodicity changed.
7988 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
7989 for fringe update unless it has periodic bitmap.
7991 2011-05-25 Kenichi Handa <handa@m17n.org>
7993 * xdisp.c (get_next_display_element): Set correct it->face_id for
7994 a static composition.
7996 2011-05-24 Leo Liu <sdl.web@gmail.com>
7999 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8001 * fns.c (crypto_hash_function, Fsha1): New function.
8002 (Fmd5): Use crypto_hash_function.
8003 (syms_of_fns): Add Ssha1.
8005 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8007 * gnutls.c: Remove unused macros.
8008 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8009 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8010 Remove macros that are defined and never used.
8011 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8013 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8015 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8016 (Fx_get_selection_internal): Minor cleanup.
8017 (Fx_own_selection_internal): Rename arguments for consistency with
8020 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8022 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8024 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8026 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8028 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8030 * dispnew.c (scrolling_window): Don't exclude the case that the
8031 last enabled row in the desired matrix touches the bottom boundary.
8033 2011-05-21 Glenn Morris <rgm@gnu.org>
8035 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
8036 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8037 and add some more files.
8039 2011-05-20 Eli Zaretskii <eliz@gnu.org>
8041 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8042 report_file_error introduced by the change from 2011-05-07.
8044 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8046 * systime.h (Time): Define only if emacs is defined.
8047 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8048 where the include path doesn't have X11/X.h by default. See
8049 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8051 2011-05-20 Kenichi Handa <handa@m17n.org>
8053 * composite.c (find_automatic_composition): Fix previous change.
8055 2011-05-20 Glenn Morris <rgm@gnu.org>
8057 * lisp.mk: New file, split from Makefile.in.
8058 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8059 (shortlisp): Remove.
8060 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8062 2011-05-19 Glenn Morris <rgm@gnu.org>
8064 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8065 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8066 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8067 (lisp): Set the order to that of loadup.el.
8068 (shortlisp): Make it a copy of $lisp.
8069 (SOME_MACHINE_LISP): Remove.
8070 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8071 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8073 2011-05-18 Kenichi Handa <handa@m17n.org>
8075 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8076 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8077 (find_automatic_composition): Mostly rewrite for efficiency.
8079 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
8081 * makefile.w32-in: Update dependencies.
8083 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8085 * menu.c: Include limits.h (fixes the MS-Windows build broken by
8088 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
8090 Fix some integer overflow issues, such as string length overflow.
8092 * insdel.c (count_size_as_multibyte): Check for string overflow.
8094 * character.c (lisp_string_width): Check for string overflow.
8095 Use EMACS_INT, not int, for string indexes and lengths; in
8096 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8097 the resulting string length overflows an EMACS_INT; instead,
8098 report a string overflow if no precision given. When checking for
8099 precision exhaustion, use a check that cannot possibly have
8100 integer overflow. (Bug#8675)
8101 * character.h (lisp_string_width): Adjust to new signature.
8103 * alloc.c (string_overflow): New function.
8104 (Fmake_string): Use it. This doesn't change behavior, but saves
8105 a few bytes and will simplify future changes.
8106 * character.c (string_escape_byte8): Likewise.
8107 * lisp.h (string_overflow): New decl.
8109 Fixups, following up to the user-interface timestamp change.
8110 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8111 for UI timestamps, instead of unsigned long.
8112 * msdos.c (mouse_get_pos): Likewise.
8113 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
8114 * w32gui.h (Time): Define by including "systime.h" rather than by
8115 declaring it ourselves. (Bug#8664)
8117 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8118 * image.c (clear_image_cache): Likewise.
8120 * term.c (term_mouse_position): Don't assume time_t wraparound.
8122 Be more systematic about user-interface timestamps.
8123 Before, the code sometimes used 'Time', sometimes 'unsigned long',
8124 and sometimes 'EMACS_UINT', to represent these timestamps.
8125 This change causes it to use 'Time' uniformly, as that's what X uses.
8126 This makes the code easier to follow, and makes it easier to catch
8127 integer overflow bugs such as Bug#8664.
8128 * frame.c (Fmouse_position, Fmouse_pixel_position):
8129 Use Time, not unsigned long, for user-interface timestamps.
8130 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8131 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8132 * keyboard.h (last_event_timestamp): Likewise.
8133 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8134 * menu.h (xmenu_show): Likewise.
8135 * term.c (term_mouse_position): Likewise.
8136 * termhooks.h (struct input_event.timestamp): Likewise.
8137 (struct terminal.mouse_position_hook): Likewise.
8138 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8139 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8140 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8141 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8143 * menu.h, termhooks.h: Include "systime.h", for Time.
8145 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8146 Don't assume that the difference between two unsigned long values
8147 can fit into an integer. At this point, we know button_down_time
8148 <= event->timestamp, so the difference must be nonnegative, so
8149 there's no need to cast the result if double-click-time is
8150 nonnegative, as it should be; check that it's nonnegative, just in
8151 case. This bug is triggered when events are more than 2**31 ms
8152 apart (about 25 days). (Bug#8664)
8154 * xselect.c (last_event_timestamp): Remove duplicate decl.
8155 (x_own_selection): Remove needless cast to unsigned long.
8157 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8158 that always fit in int. Use a sentinel instead of a counter, to
8159 avoid a temp and to allay GCC's concerns about possible int overflow.
8160 * frame.h (struct frame): Use int for menu_bar_items_used
8161 instead of EMACS_INT, since it always fits in int.
8163 * menu.c (grow_menu_items): Check for int overflow.
8165 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8167 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8168 Before, the code was not consistent. These values cannot exceed
8169 2**31 - 1 so there's no need to make them unsigned.
8170 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8171 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8172 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8174 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8176 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8177 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8178 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8179 presumably because the widths might not match.
8181 * window.c (size_window): Avoid needless test at loop start.
8183 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8185 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8187 2011-05-12 Drew Adams <drew.adams@oracle.com>
8189 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8191 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8193 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8194 `width' to `bar_area_x' and `bar_area_width', respectively.
8195 (x_scroll_run): Take account of fringe background extension.
8197 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8198 Rename local vars `left' and `width' to `bar_area_x' and
8199 `bar_area_width', respectively.
8200 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8201 background extension.
8203 2011-05-10 Jim Meyering <meyering@redhat.com>
8205 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8207 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
8209 * image.c (Finit_image_library): Return t for built-in image types,
8210 like pbm and xbm. (Bug#8640)
8212 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8214 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8216 2011-05-07 Eli Zaretskii <eliz@gnu.org>
8218 * w32console.c (Fset_screen_color): Doc fix.
8219 (Fget_screen_color): New function.
8220 (syms_of_ntterm): Defsubr it.
8222 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8223 unlink the temporary file if Fcall_process didn't create it in the
8225 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8226 child process will be redirected to a file specified with `:file'.
8227 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8228 cue to call_process_cleanup not to close that handle.
8230 2011-05-07 Ben Key <bkey76@gmail.com>
8232 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8233 one of two shell specific rules, either bootstrap-temacs-CMD or
8234 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8235 to the previous implementation of the bootstrap-temacs rule.
8236 The bootstrap-temacs-CMD rule is similar to the previous
8237 implementation of the bootstrap-temacs rule except that it
8238 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8241 These changes, along with some changes to nt/configure.bat,
8242 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8243 earlier fix to add support for --cflags and --ldflags options
8244 that include quotes so that it works whether make uses cmd or
8247 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
8249 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8250 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8252 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8253 a string. Handle both cases.
8254 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8255 (Fdbus_register_method): Use Qinvalid_function.
8257 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8259 * makefile.w32-in: Update dependencies.
8260 (LISP_H): Add inttypes.h and stdin.h.
8261 (PROCESS_H): Add unistd.h.
8263 2011-05-06 Eli Zaretskii <eliz@gnu.org>
8265 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8268 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
8270 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8272 * term.c (vfatal): Remove stray call to va_end.
8273 It's not needed and the C Standard doesn't allow it here anyway.
8275 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8276 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8278 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8281 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8283 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8285 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8287 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8289 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8291 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8292 * charset.c (Fdefine_charset_internal): Don't initialize
8293 charset.code_space[15]. The value was garbage, on hosts with
8294 32-bit int (Bug#8600).
8296 * lread.c (read_integer): Be more consistent with string-to-number.
8297 Use string_to_number to do the actual conversion; this avoids
8298 rounding errors and fixes some other screwups. Without this fix,
8299 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8300 (digit_to_number): Move earlier, for benefit of read_integer.
8301 Return -1 if the digit is out of range for the base, -2 if it is
8302 not a digit in any supported base. (Bug#8602)
8304 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8306 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8307 to match comment at start of function. This also removes a
8308 GCC warning about overflow in a 32+64-bit port.
8310 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8312 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8313 Reported by Stefan Monnier in
8314 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
8315 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8316 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
8318 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8319 (EMACS_UINTPTR): Likewise, with uintptr_t.
8321 * lisp.h: Prefer 64-bit EMACS_INT if available.
8322 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8323 on 32-bit hosts that have 64-bit int, so that they can access
8325 However, temporarily disable this change unless the temporary
8326 symbol WIDE_EMACS_INT is defined.
8328 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8330 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8331 This removes an assumption that EMACS_INT and long are the same
8332 width as pointers. The assumption is true for Emacs porting targets
8333 now, but we want to make other targets possible.
8334 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8335 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8336 In the rest of the code, change types of integers that hold casted
8337 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8338 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8339 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8340 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8341 No need to cast type when ORing.
8342 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8343 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8344 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8345 assume EMACS_INT is the same width as char *.
8346 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8347 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8348 Remove no-longer-needed casts.
8349 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8350 (xg_tool_bar_help_callback, xg_make_tool_item):
8351 Use EMACS_INTPTR to hold an integer
8352 that will be cast to void *; this can avoid a GCC warning
8353 if EMACS_INT is not the same width as void *.
8354 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8355 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8356 (current_message_1, set_message_1):
8357 Use a local to convert to proper width without a cast.
8358 * xmenu.c (dialog_selection_callback): Likewise.
8360 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8361 Also, don't assume VALBITS / RAND_BITS is less than 5,
8362 and don't rely on undefined behavior when shifting a 1 left into
8364 * lisp.h (get_random): Change signature to match.
8366 * lread.c (hash_string): Use size_t, not int, for hash computation.
8367 Normally we prefer signed values; but hashing is special, because
8368 it's better to use unsigned division on hash table sizes so that
8369 the remainder is nonnegative. Also, size_t is the natural width
8370 for hashing into memory. The previous code used 'int', which doesn't
8371 retain enough info to hash well into very large tables.
8372 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8374 * dbusbind.c: Don't possibly lose pointer info when converting.
8375 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8376 Use XPNTR rather than XHASH, so that the high-order bits of
8377 the pointer aren't lost when converting through void *.
8379 * eval.c (Fautoload): Don't double-shift a pointer.
8381 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8383 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8385 * gnutls.c (DEF_GNUTLS_FN):
8386 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8388 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8390 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8393 2011-05-05 Eli Zaretskii <eliz@gnu.org>
8395 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8396 New version that can reserve upto 2GB of heap space.
8398 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
8400 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8402 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8404 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8405 `gnutls_certificate_set_x509_key_file'.
8407 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
8409 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8410 Update dependencies.
8412 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8414 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8415 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8416 Remove unused parameter `fildes'.
8417 * process.c (read_process_output, send_process): Don't pass it.
8419 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8421 Fix previous change: the library cache is defined in w32.c.
8422 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8423 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8425 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8427 Implement dynamic loading of GnuTLS on Windows.
8429 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8430 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8431 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8434 * gnutls.c (Qgnutls_dll): Define.
8435 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8436 (gnutls_*): Declare function pointers.
8437 (init_gnutls_functions): New function to initialize function pointers.
8438 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8439 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8440 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8441 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8442 (emacs_gnutls_write, emacs_gnutls_read)
8443 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8444 (Fgnutls_available_p): New function.
8445 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8446 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8447 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8449 * image.c: Include w32.h.
8450 (Vimage_type_cache): Delete.
8451 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
8452 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
8453 (w32_delayed_load): Move to w32.c.
8455 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
8457 * w32.c (QCloaded_from, Vlibrary_cache): Define.
8458 (w32_delayed_load): Move from image.c. When loading a library, record
8459 its filename in the :loaded-from property of the library id.
8460 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
8461 Initialize and staticpro them.
8462 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
8464 * process.c: Include lisp.h before w32.h, not after.
8465 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
8466 instead of gnutls_record_check_pending.
8468 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
8470 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
8472 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
8473 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
8476 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
8478 * xterm.c (x_set_frame_alpha): Do not set property on anything
8479 else than FRAME_X_OUTER_WINDOW (Bug#8608).
8481 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8483 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
8485 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8487 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
8488 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
8489 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
8490 (gnutls_global_initialized, Qgnutls_bootprop_priority)
8491 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
8492 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
8493 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
8494 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
8495 (Qgnutls_bootprop_callbacks_verify): Make static.
8497 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
8499 * callproc.c: Indentation fixup.
8501 * sysdep.c (wait_for_termination_1): Make static.
8502 (wait_for_termination, interruptible_wait_for_termination):
8503 Move after wait_for_termination_1.
8505 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
8507 * sysdep.c (interruptible_wait_for_termination): New function
8508 which is like wait_for_termination, but allows keyboard
8511 * callproc.c (Fcall_process): Add (:file "file") as an option for
8513 (Fcall_process_region): Ditto.
8515 2011-04-30 Eli Zaretskii <eliz@gnu.org>
8517 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
8518 rather than `XVECTOR (FOO)->size'.
8520 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
8521 inttypes.h, as a gnulib replacement is used if it not available in
8524 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8526 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
8527 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
8528 of MOST_POSITIVE_FIXNUM. (Bug#8528)
8530 * coding.c (coding_alloc_by_realloc): Error out if destination
8531 will grow beyond MOST_POSITIVE_FIXNUM.
8532 (decode_coding_emacs_mule): Abort if there isn't enough place in
8533 charbuf for the composition carryover bytes. Reserve an extra
8534 space for up to 2 characters produced in a loop.
8535 (decode_coding_iso_2022): Abort if there isn't enough place in
8536 charbuf for the composition carryover bytes.
8538 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8540 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
8541 aborting when %lld or %lll format is passed.
8542 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
8543 %llo or %llx format is passed. (Bug#8545)
8545 * window.c (window_scroll_line_based): Use a marker instead of
8546 simple variables to record original value of point. (Bug#7952)
8548 * doprnt.c (doprnt): Fix the case where a multibyte sequence
8549 produced by %s or %c overflows available buffer space. (Bug#8545)
8551 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
8553 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
8554 (SIZE_MAX): Move defn after all includes, as they might #define it.
8556 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8558 * w32.c (init_environment): Warn about defaulting HOME to C:\.
8560 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8562 * keyboard.c (Qdelayed_warnings_hook): Define.
8563 (command_loop_1): Run `delayed-warnings-hook'
8564 if Vdelayed_warnings_list is non-nil.
8565 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
8566 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
8568 2011-04-28 Eli Zaretskii <eliz@gnu.org>
8570 * doprnt.c (doprnt): Don't return value smaller than the buffer
8571 size if the message was truncated. (Bug#8545).
8573 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8575 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
8576 (Fx_window_property): #if-0 the whole functions, not just the bodies.
8578 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8580 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
8582 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
8584 * makefile.w32-in: Update dependencies.
8586 2011-04-27 Eli Zaretskii <eliz@gnu.org>
8588 Improve `doprnt' and its usage. (Bug#8545)
8589 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
8590 `format_end'. Remove support for %l as a conversion specifier.
8591 Don't use xrealloc. Improve diagnostics when the %l size modifier
8592 is used. Update the commentary.
8594 * eval.c (verror): Simplify calculation of size_t.
8596 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
8599 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
8601 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
8604 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8606 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
8607 This makes this file independent of the recent pseudovector change.
8609 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
8611 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
8613 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
8614 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8615 Remove unused local.
8616 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
8618 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
8619 GCC 4.6.0 optimizes based on type-based alias analysis.
8620 For example, if b is of type struct buffer * and v of type struct
8621 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
8622 != &v->size, and therefore "v->size = 1; b->size = 2; return
8623 v->size;" must therefore return 1. This assumption is incorrect
8624 for Emacs, since it type-puns struct Lisp_Vector * with many other
8625 types. To fix this problem, this patch adds a new type struct
8626 vectorlike_header that documents the constraints on layout of vectors
8627 and pseudovectors, and helps optimizing compilers not get fooled
8628 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
8629 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
8630 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
8632 (XSETPVECTYPE): Rewrite in terms of new macro.
8633 (XSETPVECTYPESIZE): New macro, specifying both type and size.
8634 This is a bit clearer, and further avoids the possibility of
8635 undesirable aliasing.
8636 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
8637 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
8638 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
8639 since Lisp_Subr is a special case (no "next" field).
8640 (ASIZE): Now uses header.size rather than size.
8641 All previous uses of XVECTOR (foo)->size replaced to use this macro,
8642 to avoid the hassle of writing XVECTOR (foo)->header.size.
8643 (struct vectorlike_header): New type.
8644 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
8645 object, to help avoid aliasing.
8646 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
8647 (SUBRP): Likewise, since Lisp_Subr is a special case.
8648 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
8649 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
8650 (struct Lisp_Hash_Table): Combine first two members into a single
8651 struct vectorlike_header member. All uses of "size" and "next" members
8652 changed to be "header.size" and "header.next".
8653 * buffer.h (struct buffer): Likewise.
8654 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
8655 * frame.h (struct frame): Likewise.
8656 * process.h (struct Lisp_Process): Likewise.
8657 * termhooks.h (struct terminal): Likewise.
8658 * window.c (struct save_window_data, struct saved_window): Likewise.
8659 * window.h (struct window): Likewise.
8660 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
8661 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
8662 * buffer.c (init_buffer_once): Likewise.
8663 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
8665 * process.c (Fformat_network_address): Use local var for size,
8668 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
8670 Make the Lisp reader and string-to-float more consistent (Bug#8525)
8671 * data.c (atof): Remove decl; no longer used or needed.
8672 (digit_to_number): Move to lread.c.
8673 (Fstring_to_number): Use new string_to_number function, to be
8674 consistent with how the Lisp reader treats infinities and NaNs.
8675 Do not assume that floating-point numbers represent EMACS_INT
8676 without losing information; this is not true on most 64-bit hosts.
8677 Avoid double-rounding errors, by insisting on integers when
8678 parsing non-base-10 numbers, as the documentation specifies.
8679 * lisp.h (string_to_number): New decl, replacing ...
8680 (isfloat_string): Remove.
8681 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
8682 (read1): Do not accept +. and -. as integers; this
8683 appears to have been a coding error. Similarly, do not accept
8684 strings like +-1e0 as floating point numbers. Do not report
8685 overflow for integer overflows unless the base is not 10 which
8686 means we have no simple and reliable way to continue.
8687 Break out the floating-point parsing into a new
8688 function string_to_number, so that Fstring_to_number parses
8689 floating point numbers consistently with the Lisp reader.
8690 (digit_to_number): Move here from data.c. Make it static inline.
8691 (E_CHAR, EXP_INT): Remove, replacing with ...
8692 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
8693 (string_to_number): New function, replacing isfloat_string.
8694 This function checks for valid syntax and produces the resulting
8695 Lisp float number too. Rework it so that string-to-number
8696 no longer mishandles examples like "1.0e+". Use strtoumax,
8697 so that overflow for non-base-10 numbers is reported only when
8698 there's no portable and simple way to convert to floating point.
8700 * textprop.c (set_text_properties_1): Rewrite for clarity,
8701 and to avoid GCC warning about integer overflow.
8703 * intervals.h (struct interval): Use EMACS_INT for members
8704 where EMACS_UINT might cause problems. See
8705 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
8706 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
8707 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
8709 (offset_intervals): Tell GCC not to worry about length overflow
8710 when negating a negative length.
8712 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
8713 (overrun_check_free): Likewise.
8715 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
8716 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
8719 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8720 (gnutls_make_error): Rename local to avoid shadowing.
8721 (gnutls_emacs_global_deinit): ifdef out; not used.
8722 (Fgnutls_boot): Use const for pointer to readonly storage.
8723 Comment out unused local. Fix pointer signedness problems.
8725 * lread.c (openp): Don't stuff size_t into an 'int'.
8726 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
8727 about possible signed overflow.
8729 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8730 (GDK_KEY_g): Don't define if already defined.
8731 (xg_prepare_tooltip): Avoid pointer signedness problem.
8732 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
8734 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
8735 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
8737 * xfns.c (Fx_window_property): Simplify a bit,
8738 to make a bit faster and to avoid GCC 4.6.0 warning.
8739 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
8741 * fns.c (internal_equal): Don't assume size_t fits in int.
8743 * alloc.c (compact_small_strings): Tighten assertion a little.
8745 Replace pEd with more-general pI, and fix some printf arg casts.
8746 * lisp.h (pI): New macro, generalizing old pEd macro to other
8747 conversion specifiers. For example, use "...%"pI"d..." rather
8748 than "...%"pEd"...".
8749 (pEd): Remove. All uses replaced with similar uses of pI.
8750 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
8751 * alloc.c (check_pure_size): Don't overflow by converting size to int.
8752 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
8753 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
8754 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
8755 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
8756 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
8758 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
8759 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
8760 * print.c (safe_debug_print, print_object): Likewise.
8761 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
8763 Use pI instead of if-then-else-abort. Use %p to avoid casts,
8764 avoiding the 0 flag, which is not portable.
8765 * process.c (Fmake_network_process): Use pI to avoid cast.
8766 * region-cache.c (pp_cache): Likewise.
8767 * xdisp.c (decode_mode_spec): Likewise.
8768 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
8769 behavior on 64-bit hosts with printf arg.
8770 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
8771 (x_stop_queuing_selection_requests): Likewise.
8772 (x_get_window_property): Don't truncate byte count to an 'int'
8775 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
8776 here, since it parses constructs like leading '-' and spaces,
8777 which are not wanted; and it overflows with large numbers.
8778 Instead, simply match F[0-9]+, which is what is wanted anyway.
8780 * alloc.c: Remove unportable assumptions about struct layout.
8781 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
8782 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
8783 (allocate_vectorlike, make_pure_vector): Use the new macros,
8784 plus offsetof, to remove unportable assumptions about struct layout.
8785 These assumptions hold on all porting targets that I know of, but
8786 they are not guaranteed, they're easy to remove, and removing them
8787 makes further changes easier.
8789 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
8790 This doesn't fix a bug but makes the code clearer.
8791 (string_overrun_cookie): Now const. Use initializers that
8792 don't formally overflow signed char, to avoid warnings.
8793 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
8794 can cause Emacs to crash when string overrun checking is enabled.
8795 (allocate_buffer): Don't assume sizeof (struct buffer) is a
8796 multiple of sizeof (EMACS_INT); it need not be, if
8797 alignof(EMACS_INT) < sizeof (EMACS_INT).
8798 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
8800 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
8802 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
8804 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
8806 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
8807 supposed to be handshaking. (Bug#8556)
8808 Reported by Paul Eggert <eggert@cs.ucla.edu>.
8810 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
8812 * lisp.h (Qdebug): List symbol.
8813 * eval.c (Qdebug): Restore global linkage.
8814 * keyboard.c (debug-on-event): New variable.
8815 (handle_user_signal): Break into debugger when debug-on-event
8816 matches the current signal symbol.
8818 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
8820 * alloc.c (check_sblock, check_string_bytes)
8821 (check_string_free_list): Convert to standard C.
8823 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
8825 * w32.c (emacs_gnutls_push): Fix typo.
8827 2011-04-25 Eli Zaretskii <eliz@gnu.org>
8829 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
8830 "cast to pointer from integer of different size".
8832 Improve doprnt and its use in verror. (Bug#8545)
8833 * doprnt.c (doprnt): Document the set of format control sequences
8834 supported by the function. Use SAFE_ALLOCA instead of always
8837 * eval.c (verror): Don't limit the buffer size at size_max-1, that
8838 is one byte too soon. Don't use xrealloc; instead xfree and
8841 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
8843 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
8846 * gnutls.c: Renamed global_initialized to
8847 gnutls_global_initialized. Added internals for the
8848 :verify-hostname-error, :verify-error, and :verify-flags
8849 parameters of `gnutls-boot' and documented those parameters in the
8850 docstring. Start callback support.
8851 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
8852 unless a fatal error occurred. Call gnutls_alert_send_appropriate
8853 on error. Return error code.
8854 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
8855 (emacs_gnutls_read): Likewise.
8856 (Fgnutls_boot): Return handshake error code.
8857 (emacs_gnutls_handle_error): New function.
8858 (wsaerror_to_errno): Likewise.
8860 * w32.h (emacs_gnutls_pull): Add prototype.
8861 (emacs_gnutls_push): Likewise.
8863 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
8864 (emacs_gnutls_push): Likewise.
8866 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
8868 * process.c (wait_reading_process_output): Check if GnuTLS
8869 buffered some data internally if no FDs are set for TLS
8872 * makefile.w32-in (OBJ2): Add gnutls.$(O).
8873 (LIBS): Link to USER_LIBS.
8874 ($(BLD)/gnutls.$(0)): New target.
8876 2011-04-24 Eli Zaretskii <eliz@gnu.org>
8878 * xdisp.c (handle_single_display_spec): Rename the
8879 display_replaced_before_p argument into display_replaced_p, to
8880 make it consistent with the commentary. Fix typos in the
8883 * textprop.c (syms_of_textprop): Remove dead code.
8884 (copy_text_properties): Delete obsolete commentary about an
8885 interface that was deleted long ago. Fix typos in the description
8888 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
8889 to changes in oldXMenu/XMenu.h from 2011-04-16.
8890 <menu_help_message, prev_menu_help_message>: Constify.
8891 (IT_menu_make_room): menu->help_text is now `const char **';
8894 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
8895 to changes in oldXMenu/XMenu.h from 2011-04-16.
8896 (struct XMenu): Declare `help_text' `const char **'.
8898 * xfaces.c <Qunspecified>: Make extern again.
8900 * syntax.c: Include sys/types.h before including regex.h, as
8903 * doc.c (get_doc_string): Improve the format passed to `error'.
8905 * doprnt.c (doprnt): Improve commentary.
8907 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
8909 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
8912 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
8913 changes in globals.h immediately force recompilation.
8914 (TAGS): Depend on $(CURDIR)/m/intel386.h and
8915 $(CURDIR)/s/ms-w32.h.
8916 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
8918 * character.c (Fchar_direction): Function deleted.
8919 (syms_of_character): Don't defsubr it.
8920 <char-direction-table>: Deleted.
8922 2011-04-23 Eli Zaretskii <eliz@gnu.org>
8924 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
8925 * doprnt.c: Include limits.h.
8926 (SIZE_MAX): New macro.
8927 (doprnt): Return a size_t value. 2nd arg is now size_t.
8928 Many local variables are now size_t instead of int or unsigned.
8929 Improve overflow protection. Support `l' modifier for integer
8930 conversions. Support %l conversion. Don't assume an EMACS_INT
8931 argument for integer conversions and for %c.
8933 * lisp.h (doprnt): Restore prototype.
8935 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
8938 * Makefile.in (base_obj): Add back doprnt.o.
8940 * deps.mk (doprnt.o): Add back prerequisites.
8941 (callint.o): Depend on character.h.
8943 * eval.c (internal_lisp_condition_case): Include the handler
8944 representation in the error message.
8945 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
8946 when breaking from the loop.
8948 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
8950 * callint.c (Fcall_interactively): When displaying error message
8951 about invalid control letter, pass the character's codepoint, not
8952 a pointer to its multibyte form. Improve display of the character
8953 in octal and display also its hex code.
8955 * character.c (char_string): Use %x to display the (unsigned)
8956 codepoint of an invalid character, to avoid displaying a bogus
8959 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
8960 `error', not SYMBOL_NAME itself.
8962 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
8963 character arguments to `error'.
8965 * charset.c (check_iso_charset_parameter): Fix incorrect argument
8966 to `error' in error message about FINAL_CHAR argument. Make sure
8967 FINAL_CHAR is a character, and use %c when it is passed as
8968 argument to `error'.
8970 2011-04-23 Eli Zaretskii <eliz@gnu.org>
8972 * s/ms-w32.h (localtime): Redirect to sys_localtime.
8974 * w32.c: Include <time.h>.
8975 (sys_localtime): New function.
8977 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
8979 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
8981 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
8983 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
8985 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
8988 2011-04-19 Eli Zaretskii <eliz@gnu.org>
8990 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
8991 gl_state.e_property when gl_state.object is Qt.
8993 * insdel.c (make_gap_larger): Remove limitation of buffer size
8996 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
8998 * xdisp.c (lookup_glyphless_char_display)
8999 (produce_glyphless_glyph): Handle cons cell entry in
9000 glyphless-char-display.
9001 (Vglyphless_char_display): Document it.
9003 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9004 glyphless-char-display.
9006 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
9008 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9010 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9012 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9013 definition for no-X builds.
9015 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
9017 Static checks with GCC 4.6.0 and non-default toolkits.
9019 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9021 * process.c (keyboard_bit_set): Define only if SIGIO.
9022 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9023 (send_process): Repair possible setjmp clobbering.
9025 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9027 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9029 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9031 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9032 Define only if needed.
9034 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9035 by pacifying GCC about it. Maybe it's time to retire it?
9036 * xfaces.c (USG, __TIMEVAL__): Likewise.
9038 * dispextern.h (struct redisplay_interface): Rename param
9040 * termhooks.h (struct terminal): Likewise.
9041 * xterm.c (xembed_send_message): Likewise.
9043 * insdel.c (make_gap_smaller): Define only if
9044 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9046 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9049 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9050 so that we aren't warned about unused symbols.
9052 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9054 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
9056 * xfns.c (x_real_positions): Mark locals as initialized.
9058 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9060 * xterm.c: Fix problems found by static analysis with other toolkits.
9061 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
9062 (x_dispatch_event): Declare static if USE_GTK, and
9063 define if USE_GTK || USE_X_TOOLKIT.
9064 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
9065 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
9066 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9067 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
9069 * xmenu.c (menu_help_callback): Pointer type fixes.
9070 Use const pointers when pointing at readonly data. Avoid pointer
9072 (FALSE): Remove unused macro.
9073 (update_frame_menubar): Remove unused decl.
9075 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9077 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9078 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9079 (single_menu_item): Rename local to avoid shadowing.
9081 * keyboard.c (make_lispy_event): Remove unused local var.
9083 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9084 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9086 * bitmaps: Change bitmaps from unsigned char back to the X11
9087 compatible char. Avoid the old compiler warnings about
9088 out-of-range initializers by using, for example, '\xab' rather
9091 * xgselect.c (xgselect_initialize): Check vs interface
9092 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9094 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9096 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9097 to read-only memory.
9099 * fns.c (vector): Remove; this old hack is no longer needed.
9101 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
9103 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
9105 * xrdb.c (x_load_resources): Omit unused local.
9107 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
9108 (x_window): Rename locals to avoid shadowing.
9109 (USG): Use the kludged USG macro, to pacify gcc.
9111 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
9112 (x_term_init): Remove local to avoid shadowing.
9114 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
9116 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9117 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9119 2011-04-16 Eli Zaretskii <eliz@gnu.org>
9121 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9123 Fix regex.c, syntax.c and friends for buffers > 2GB.
9124 * syntax.h (struct gl_state_s): Declare character position members
9127 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9129 * textprop.c (verify_interval_modification, interval_of):
9130 Declare arguments EMACS_INT.
9132 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9135 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9137 * indent.c (Fvertical_motion): Local variable it_start is now
9140 * regex.c (re_match, re_match_2, re_match_2_internal)
9141 (bcmp_translate, regcomp, regexec, print_double_string)
9142 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9143 (re_compile_pattern, re_exec): Declare arguments and local
9144 variables `size_t' and `ssize_t' and return values `regoff_t', as
9146 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9147 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9148 <compile_stack_type>: `size' and `avail' are now `size_t'.
9150 * regex.h <regoff_t>: Use ssize_t, not int.
9151 (re_search, re_search_2, re_match, re_match_2): Arguments that
9152 specify buffer/string position and length are now ssize_t and
9153 size_t. Return type is regoff_t.
9155 2011-04-16 Ben Key <bkey76@gmail.com>
9157 * nsfont.m: Fixed bugs in ns_get_family and
9158 ns_descriptor_to_entity that were caused by using free to
9159 deallocate memory blocks that were allocated by xmalloc (via
9160 xstrdup). This caused Emacs to crash when compiled with
9161 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9162 --enable-checking=xmallocoverrun). xfree is now used to
9163 deallocate these memory blocks.
9165 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
9167 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9169 emacs_write: Accept and return EMACS_INT for sizes.
9170 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9172 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9173 Accept and return EMACS_INT.
9174 (emacs_gnutls_write): Return the number of bytes written on
9176 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
9177 (emacs_read, emacs_write): Remove check for negative size, as the
9178 Emacs source code has been audited now.
9179 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9180 (emacs_read, emacs_write): Use it.
9181 * process.c (send_process): Adjust to the new signatures of
9182 emacs_write and emacs_gnutls_write. Do not attempt to store
9183 a byte offset into an 'int'; it might overflow.
9184 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
9186 * sound.c: Don't assume sizes fit in 'int'.
9187 (struct sound_device.period_size, alsa_period_size):
9188 Return EMACS_INT, not int.
9189 (struct sound_device.write, vox_write, alsa_write):
9190 Accept EMACS_INT, not int.
9191 (wav_play, au_play): Use EMACS_INT to store sizes and to
9192 record read return values.
9194 2011-04-15 Ben Key <bkey76@gmail.com>
9196 * keyboard.c (Qundefined): Don't declare static since it is used
9198 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9199 static since they are used in nsfont.m.
9201 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9203 * process.c (Qprocessp): Don't declare static.
9204 * lisp.h (Qprocessp): Declare again.
9206 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
9208 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9210 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9212 Improve C-level modularity by making more things 'static'.
9214 Don't publish debugger-only interfaces to other modules.
9215 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9216 (verify_bytepos, count_markers): Move decls to the only modules
9218 * region-cache.h (pp_cache): Likewise.
9219 * window.h (check_all_windows): Likewise.
9220 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9222 * sysdep.c (croak): Now static, if
9223 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9224 * syssignal.h (croak): Declare only if not static.
9226 * alloc.c (refill_memory_reserve): Now static if
9227 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9228 * lisp.h (refill_memory_reserve): Declare only if not static.
9230 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9231 Define only if USE_LUCID.
9233 * xrdb.c (x_customization_string, x_rm_string): Now static.
9235 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9236 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9238 * xdisp.c (draw_row_with_mouse_face): Now static.
9239 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9241 * window.h (check_all_windows): Mark externally visible.
9243 * window.c (window_deletion_count): Now static.
9245 * undo.c: Make symbols static if they're not exported.
9246 (last_undo_buffer, last_boundary_position, pending_boundary):
9249 * textprop.c (interval_insert_behind_hooks): Now static.
9250 (interval_insert_in_front_hooks): Likewise.
9252 * term.c: Make symbols static if they're not exported.
9253 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9254 (max_frame_lines, tty_set_terminal_modes):
9255 (tty_reset_terminal_modes, tty_turn_off_highlight):
9256 (get_tty_terminal): Now static.
9257 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9258 * termhooks.h (term_mouse_moveto): Do not declare if
9260 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9261 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9263 * sysdep.c: Make symbols static if they're not exported.
9264 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9266 (sigprocmask_set, full_mask): Remove; unused.
9267 (wait_debugging): Mark as visible.
9268 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9269 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9271 * syntax.c (syntax_temp): Define only if !__GNUC__.
9273 * sound.c (current_sound_device, current_sound): Now static.
9275 * search.c (searchbufs, searchbuf_head): Now static.
9277 * scroll.c (scroll_cost): Remove; unused.
9278 * dispextern.h (scroll_cost): Remove decl.
9280 * region-cache.h (pp_cache): Mark as externally visible.
9282 * process.c: Make symbols static if they're not exported.
9283 (process_tick, update_tick, create_process, chan_process):
9284 (Vprocess_alist, proc_buffered_char, datagram_access):
9285 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9286 (deactivate_process): Mark defn as static, as well as decl.
9287 * lisp.h (create_process): Remove decl.
9288 * process.h (chan_process, Vprocess_alist): Remove decls.
9290 * print.c: Make symbols static if they're not exported.
9291 (print_depth, new_backquote_output, being_printed, print_buffer):
9292 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9293 (print_interval, print_number_index, initial_stderr_stream):
9295 * lisp.h (Fprinc): Remove decl.
9296 (debug_output_compilation_hack): Mark as externally visible.
9298 * sysdep.c (croak): Move decl from here to syssignal.h.
9299 * syssignal.h (croak): Put it here, so the API can be checked when
9300 'croak' is called from dissociate_if_controlling_tty.
9302 * minibuf.c: Make symbols static if they're not exported.
9303 (minibuf_save_list, choose_minibuf_frame): Now static.
9304 * lisp.h (choose_minibuf_frame): Remove decl.
9306 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9308 * lread.c: Make symbols static if they're not exported.
9309 (read_objects, initial_obarray, oblookup_last_bucket_number):
9311 (make_symbol): Remove; unused.
9312 * lisp.h (initial_obarray, make_symbol): Remove decls.
9314 * keyboard.c: Make symbols static if they're not exported.
9315 (single_kboard, recent_keys_index, total_keys, recent_keys):
9316 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9317 (this_single_command_key_start, echoing, last_auto_save):
9318 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9319 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9320 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9321 (Vlispy_mouse_stem, double_click_count):
9323 (force_auto_save_soon): Define only if SIGDANGER.
9324 (ignore_mouse_drag_p): Now static if
9325 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9326 (print_help): Remove; unused.
9327 (stop_character, last_timer_event): Mark as externally visible.
9328 * keyboard.h (ignore_mouse_drag_p): Declare only if
9329 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9330 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9331 * lisp.h (echoing): Remove decl.
9332 (force_auto_save_soon): Declare only if SIGDANGER.
9333 * xdisp.c (redisplay_window): Simplify code, to make it more
9334 obvious that ignore_mouse_drag_p is not accessed if !defined
9335 USE_GTK && !defined HAVE_NS.
9337 * intervals.c: Make symbols static if they're not exported.
9338 (merge_properties_sticky, merge_interval_right, delete_interval):
9340 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9342 * insdel.c: Make symbols static if they're not exported.
9343 However, leave prepare_to_modify_buffer alone. It's never
9344 called from outside this function, but that appears to be a bug.
9345 (combine_after_change_list, combine_after_change_buffer):
9346 (adjust_after_replace, signal_before_change): Now static.
9347 (adjust_after_replace_noundo): Remove; unused.
9348 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
9349 (signal_before_change): Remove decls.
9351 * indent.c (val_compute_motion, val_vmotion): Now static.
9353 * image.c: Make symbols static if they're not exported.
9354 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9356 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9357 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9359 * fringe.c (standard_bitmaps): Now static.
9360 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9362 * frame.c: Make symbols static if they're not exported.
9363 (x_report_frame_params, make_terminal_frame): Now static.
9364 (get_frame_param): Now static, unless HAVE_NS.
9365 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9366 (x_get_resource_string): Remove; not used.
9367 * frame.h (make_terminal_frame, x_report_frame_params):
9368 (x_get_resource_string); Remove decls.
9369 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9370 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9372 * font.c, fontset.c: Make symbols static if they're not exported.
9373 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9374 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9375 * font.c (font_close_object): Now static.
9376 * font.h (font_close_object): Remove.
9377 * fontset.c (FONTSET_OBJLIST): Remove.
9378 (free_realized_fontset) #if-0 the body, which does nothing.
9379 (face_suitable_for_char_p): #if-0, as it's never called.
9380 * fontset.h (face_suitable_for_char_p): Remove decl.
9381 * xfaces.c (face_at_string_position):
9382 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
9383 since 0 is always ASCII.
9385 * fns.c (weak_hash_tables): Now static.
9387 * fileio.c: Make symbols static if they're not exported.
9388 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9389 (Vwrite_region_annotation_buffers): Now static.
9391 * eval.c: Make symbols static if they're not exported.
9392 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9393 * lisp.h (backtrace_list): Remove decl.
9395 * emacs.c: Make symbols static if they're not exported.
9396 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9397 (fatal_error_code, fatal_error_signal_hook, standard_args):
9399 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9400 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9401 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9402 * lisp.h (fatal_error_signal_hook): Remove decl.
9403 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9405 * editfns.c: Move a (normally-unused) function to its only use.
9406 * editfns.c, lisp.h (get_operating_system_release): Remove.
9407 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9408 worth the hassle of breaking this out.
9410 * xterm.c: Make symbols static if they're not exported.
9411 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9412 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9413 (x_destroy_window, x_delete_display):
9415 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9416 (x_mouse_leave): Remove; unused.
9417 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9418 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9419 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9421 (x_mouse_leave): Declare only if WINDOWSNT.
9422 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9423 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9426 * ftxfont.c: Make symbols static if they're not exported.
9427 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9429 * font.h (ftxfont_driver): Likewise.
9431 * xfns.c: Make symbols static if they're not exported.
9432 (x_last_font_name, x_display_info_for_name):
9433 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9434 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9435 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9436 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9437 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9438 (last_show_tip_args): Now static.
9439 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9440 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9441 (x_screen_planes): Remove; unused.
9442 * dispextern.h (x_screen_planes): Remove decl.
9444 * dispnew.c: Make symbols static if they're not exported.
9445 * dispextern.h (redraw_garbaged_frames, scrolling):
9446 (increment_row_positions): Remove.
9447 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9448 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9450 (redraw_garbaged_frames): Remove; unused.
9452 * xfaces.c: Make symbols static if they're not exported.
9453 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
9455 * xterm.h (defined_color): Remove decls.
9456 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
9457 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
9458 (menu_face_changed_default, defined_color, free_realized_face):
9459 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
9460 (ascii_face_of_lisp_face): Remove; unused.
9462 * xdisp.c: Make symbols static if they're not exported.
9463 * dispextern.h (scratch_glyph_row, window_box_edges):
9464 (glyph_to_pixel_coords, set_cursor_from_row):
9465 (get_next_display_element, set_iterator_to_next):
9466 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
9467 (show_mouse_face): Remove decls
9468 * frame.h (message_buf_print): Likewise.
9469 * lisp.h (pop_message, set_message, check_point_in_composition):
9471 * xterm.h (set_vertical_scroll_bar): Likewise.
9472 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
9473 (message_buf_print, scratch_glyph_row, displayed_buffer):
9474 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
9475 (get_next_display_element, show_mouse_face, window_box_edges):
9476 (frame_to_window_pixel_xy, check_point_in_composition):
9477 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
9478 (glyph_to_pixel_coords): Remove; unused.
9480 * dired.c (file_name_completion): Now static.
9482 * dbusbind.c (xd_in_read_queued_messages): Now static.
9484 * lisp.h (circular_list_error, FOREACH): Remove; unused.
9485 * data.c (circular_list_error): Remove.
9487 * commands.h (last_point_position, last_point_position_buffer):
9488 (last_point_position_window): Remove decls.
9489 * keyboard.c: Make these variables static.
9491 * coding.h (coding, code_convert_region, encode_coding_gap):
9493 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
9494 (iso_code_class, detect_coding, code_convert_region): Now static.
9495 (encode_coding_gap): Remove; unused.
9497 * chartab.c (chartab_chars, chartab_bits): Now static.
9499 * charset.h (charset_iso_8859_1): Remove decl.
9500 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
9503 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
9504 * ccl.c (Vccl_program_table): Now static.
9505 (check_ccl_update): Remove; unused.
9507 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
9508 * category.h: ... from here.
9509 * category.c (check_category_table, set_category_set): Now static.
9511 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
9512 * lisp.h: Remove these decls.
9514 * buffer.c (buffer_count): Remove unused var.
9516 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
9517 so that it's not optimized away.
9518 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
9519 * dispextern.h (bidi_dump_cached_states): Remove, since it's
9520 exported only to the debugger.
9522 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
9523 * atimer.h (run_all_atimers): Remove; not exported.
9525 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
9526 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
9527 was inaccessible from Lisp.
9528 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
9529 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
9531 alloc.c: Import and export fewer symbols, and remove unused items.
9532 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
9534 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
9535 it's not optimized away by whole-program optimization.
9536 (message_enable_multibyte, free_misc): Remove.
9537 (catchlist, handlerlist, mark_backtrace):
9538 Declare only if BYTE_MARK_STACK.
9539 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
9540 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
9541 (message_enable_multibyte): Remove decl.
9542 (free_misc, interval_free_list, float_block, float_block_index):
9543 (n_float_blocks, float_free_list, cons_block, cons_block_index):
9544 (cons_free_list, last_marked_index):
9546 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
9547 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
9548 (mark_backtrace): Define only if BYTE_MARK_STACK.
9549 * xdisp.c (message_enable_multibyte): Now static.
9551 Declare Lisp_Object Q* variables to be 'static' if not exported.
9552 This makes it easier for human readers (and static analyzers)
9553 to see whether these variables are used from other modules.
9554 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
9555 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
9556 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
9557 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
9558 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
9559 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
9560 * xmenu.c, xselect.c:
9561 Declare Q* vars static if they are not used in other modules.
9562 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
9563 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
9564 Remove decls of unexported vars.
9565 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
9567 * lisp.h (DEFINE_FUNC): Make sname 'static'.
9569 Make Emacs functions such as Fatom 'static' by default.
9570 This makes it easier for human readers (and static analyzers)
9571 to see whether these functions can be called from other modules.
9572 DEFUN now defines a static function. To make the function external
9573 so that it can be used in other C modules, use the new macro DEFUE.
9574 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
9575 (Finit_image_library):
9576 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
9577 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
9578 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
9579 Remove decls, since these functions are now static.
9580 (Funintern, Fget_internal_run_time): New decls, since these functions
9581 were already external.
9583 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
9584 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
9585 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
9586 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
9587 * keyboard.c, keymap.c, lread.c:
9588 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
9589 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
9590 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
9591 Mark functions with DEFUE instead of DEFUN,
9592 if they are used in other modules.
9593 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
9594 decls for now-static functions.
9595 * buffer.h (Fdelete_overlay): Remove decl.
9596 * callproc.c (Fgetenv_internal): Mark as internal.
9597 * composite.c (Fremove_list_of_text_properties): Remove decl.
9598 (Fcomposition_get_gstring): New forward static decl.
9599 * composite.h (Fcomposite_get_gstring): Remove decl.
9600 * dired.c (Ffile_attributes): New forward static decl.
9601 * doc.c (Fdocumntation_property): New forward static decl.
9602 * eval.c (Ffetch_bytecode): New forward static decl.
9603 (Funintern): Remove extern decl; now in .h file where it belongs.
9604 * fileio.c (Fmake_symbolic_link): New forward static decl.
9605 * image.c (Finit_image_library): New forward static decl.
9606 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
9607 * intervals.h (Fprevious_property_change):
9608 (Fremove_list_of_text_properties): Remove decls.
9609 * keyboard.c (Fthis_command_keys): Remove decl.
9610 (Fcommand_execute): New forward static decl.
9611 * keymap.c (Flookup_key): New forward static decl.
9612 (Fcopy_keymap): Now static.
9613 * keymap.h (Flookup_key): Remove decl.
9614 * process.c (Fget_process): New forward static decl.
9615 (Fprocess_datagram_address): Mark as internal.
9616 * syntax.c (Fsyntax_table_p): New forward static decl.
9617 (skip_chars): Remove duplicate decl.
9618 * textprop.c (Fprevious_property_change): New forward static decl.
9619 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
9621 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
9622 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
9624 * editfns.c (Fformat): Remove unreachable code.
9626 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
9628 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
9631 2011-04-13 Eli Zaretskii <eliz@gnu.org>
9633 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
9634 when at ZV. (Bug#8487)
9636 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
9638 * charset.c (Fclear_charset_maps): Use xfree instead of free.
9640 * keyboard.c (parse_tool_bar_item): Likewise.
9641 * sound.c (sound_cleanup, alsa_close): Likewise.
9642 * termcap.c (tgetent): Likewise.
9643 * xfns.c (x_default_font_parameter): Likewise.
9644 * xsettings.c (read_and_apply_settings): Likewise.
9646 * alloc.c (overrun_check_malloc, overrun_check_realloc)
9647 (overrun_check_free): Protoize.
9649 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
9651 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
9652 since callers should never pass a negative size.
9653 Change the signature to match that of plain 'read' and 'write'; see
9654 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
9655 * lisp.h: Update prototypes of emacs_write and emacs_read.
9657 2011-04-11 Eli Zaretskii <eliz@gnu.org>
9659 * xdisp.c (redisplay_window): Don't try to determine the character
9660 position of the scroll margin if the window start point w->startp
9661 is outside the buffer's accessible region. (Bug#8468)
9663 2011-04-10 Eli Zaretskii <eliz@gnu.org>
9665 Fix write-region and its subroutines for buffers > 2GB.
9666 * fileio.c (a_write, e_write): Modify declaration of arguments and
9667 local variables to support buffers larger than 2GB.
9668 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
9670 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
9671 argument, local variables, and return value.
9673 * lisp.h: Update prototypes of emacs_write and emacs_read.
9675 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
9677 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
9679 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
9681 Fix more problems found by GCC 4.6.0's static checks.
9683 * xdisp.c (vmessage): Use a better test for character truncation.
9685 * charset.c (load_charset_map): <, not <=, for optimization,
9686 and to avoid potential problems with integer overflow.
9687 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
9688 * casetab.c (set_identity, shuffle): Likewise.
9689 * editfns.c (Fformat): Likewise.
9690 * syntax.c (skip_chars): Likewise.
9692 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
9693 This also lets GCC 4.6.0 generate slightly better loop code.
9695 * callint.c (Fcall_interactively): <, not <=, for optimization.
9696 (Fcall_interactively): Count the number of arguments produced,
9697 not the number of arguments given. This is simpler and lets GCC
9698 4.6.0 generate slightly better code.
9700 * ftfont.c: Distingish more carefully between FcChar8 and char.
9701 The previous code passed unsigned char * to a functions like
9702 strlen and xstrcasecmp that expect char *, which does not
9703 conform to the C standard.
9704 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
9705 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
9706 char * when the C standard requires it.
9708 * keyboard.c (read_char): Remove unused var.
9710 * eval.c: Port to Windows vsnprintf (Bug#8435).
9712 (SIZE_MAX): Define if the headers do not.
9713 (verror): Do not give up if vsnprintf returns a negative count.
9714 Instead, grow the buffer. This ports to Windows vsnprintf, which
9715 does not conform to C99. Problem reported by Eli Zaretskii.
9716 Also, simplify the allocation scheme, by avoiding the need for
9717 calling realloc, and removing the ALLOCATED variable.
9719 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
9721 Remove invocations of doprnt, as Emacs now uses vsnprintf.
9722 But keep the doprint source code for now, as we might revamp it
9723 and use it again (Bug#8435).
9724 * lisp.h (doprnt): Remove.
9725 * Makefile.in (base_obj): Remove doprnt.o.
9726 * deps.mk (doprnt.o): Remove.
9728 error: Print 32- and 64-bit integers portably (Bug#8435).
9729 Without this change, on typical 64-bit hosts error ("...%d...", N)
9730 was used to print both 32- and 64-bit integers N, which relied on
9732 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
9733 * lisp.h (error, verror): Mark as printf-like functions.
9734 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
9735 Report overflow in size calculations when allocating printf buffer.
9736 Do not truncate output string at its first null byte.
9737 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
9738 Truncate the output at a character boundary, since vsnprintf does not
9740 * charset.c (check_iso_charset_parameter): Convert internal
9741 character to string before calling 'error', since %c now has the
9743 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
9744 overflow when computing char to be passed to 'error'. Do not
9745 pass Lisp_Object to 'error'; pass the integer instead.
9746 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
9747 formatted with plain %d.
9749 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
9751 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
9753 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
9755 * xterm.c (x_catch_errors): Remove duplicate declaration.
9757 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
9759 * xdisp.c, lisp.h (message_nolog): Remove; unused.
9761 2011-04-10 Jim Meyering <meyering@redhat.com>
9763 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
9764 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
9765 return ssize_t not "int", and use size_t as the buffer length.
9766 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
9767 * gnutls.h: Update declarations.
9768 * process.c (read_process_output): Use ssize_t, to match.
9769 (send_process): Likewise.
9771 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
9773 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
9775 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
9777 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
9778 Use unsigned char, to match FcChar8 type definition.
9780 * xterm.c (handle_one_xevent):
9781 * xmenu.c (create_and_show_popup_menu):
9782 * xselect.c (x_decline_selection_request)
9783 (x_reply_selection_request): Avoid type-punned deref of X events.
9785 2011-04-09 Eli Zaretskii <eliz@gnu.org>
9787 Fix some uses of `int' instead of EMACS_INT.
9788 * search.c (string_match_1, fast_string_match)
9789 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
9790 (scan_buffer, find_next_newline_no_quit)
9791 (find_before_next_newline, search_command, Freplace_match)
9792 (Fmatch_data): Make some `int' variables be EMACS_INT.
9794 * xdisp.c (display_count_lines): 3rd argument and return value now
9795 EMACS_INT. All callers changed.
9796 (pint2hrstr): Last argument is now EMACS_INT.
9798 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
9799 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
9800 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
9801 (decode_coding_utf_16, decode_coding_emacs_mule)
9802 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
9803 (decode_coding_ccl, decode_coding_charset)
9804 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
9805 (decode_coding_iso_2022, decode_coding_emacs_mule)
9806 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
9807 <char_offset, last_offset>: Declare EMACS_INT.
9808 (encode_coding_utf_8, encode_coding_utf_16)
9809 (encode_coding_emacs_mule, encode_invocation_designation)
9810 (encode_designation_at_bol, encode_coding_iso_2022)
9811 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
9812 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
9814 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
9815 (encode_invocation_designation): Last argument P_NCHARS is now
9817 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
9818 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
9820 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
9823 * ccl.c (Fccl_execute_on_string): Declare some variables
9826 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
9828 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
9830 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
9832 * process.c (Fformat_network_address): Doc fix.
9834 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
9836 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
9838 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
9840 * keyboard.c (read_char): Call Lisp function help-form-show,
9841 instead of using internal_with_output_to_temp_buffer.
9842 (Qhelp_form_show): New var.
9843 (syms_of_keyboard): Use DEFSYM macro.
9845 * print.c (internal_with_output_to_temp_buffer): Function deleted.
9847 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
9849 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
9851 * process.c (Flist_processes): Remove to Lisp.
9852 (list_processes_1): Delete.
9854 2011-04-06 Eli Zaretskii <eliz@gnu.org>
9856 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
9858 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
9860 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
9862 Fix more problems found by GCC 4.6.0's static checks.
9864 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
9866 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
9868 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
9870 * xdisp.c (vmessage): Mark as a printf-like function.
9872 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
9874 * sound.c (sound_warning): Don't crash if arg contains a printf format.
9876 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
9877 printf-like functions.
9878 (tiff_load): Add casts to remove these marks before passing them
9879 to system-supplied API.
9881 * eval.c (Fsignal): Remove excess argument to 'fatal'.
9883 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
9884 This avoids several warnings with gcc -Wstrict-overflow.
9885 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
9886 directly, rather than having caller test rule sign. This avoids
9887 some unnecessary tests.
9888 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
9889 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
9890 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
9892 * xfont.c (xfont_text_extents): Remove var that was set but not used.
9893 (xfont_open): Avoid unnecessary tests.
9895 * composite.c (composition_gstring_put_cache): Use unsigned integer.
9897 * composite.h, composite.c (composition_gstring_put_cache):
9898 Use EMACS_INT, not int, for length.
9900 * composite.h (COMPOSITION_DECODE_REFS): New macro,
9901 breaking out part of COMPOSITION_DECODE_RULE.
9902 (COMPOSITION_DECODE_RULE): Use it.
9903 * composite.c (get_composition_id): Remove unused local vars,
9904 by using the new macro.
9906 * textprop.c (set_text_properties_1): Change while to do-while,
9907 since the condition is always true at first.
9909 * intervals.c (graft_intervals_into_buffer): Mark var as used.
9910 (interval_deletion_adjustment): Return unsigned value.
9913 * process.c (list_processes_1, create_pty, read_process_output):
9914 (exec_sentinel): Remove vars that were set but not used.
9915 (create_pty): Remove unnecessary "volatile"s.
9916 (Fnetwork_interface_info): Avoid possibility of int overflow.
9917 (read_process_output): Do adaptive read buffering even if carryover.
9918 (read_process_output): Simplify nbytes computation if buffered.
9920 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
9922 * syntax.c (scan_words): Remove var that was set but not used.
9923 (update_syntax_table): Use unsigned instead of int.
9925 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
9926 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
9927 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
9929 * print.c (print_error_message): Avoid int overflow.
9931 * font.c (font_list_entities): Redo for clarity,
9932 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
9934 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
9935 (font_score): Avoid potential overflow in diff calculation.
9937 * fns.c (substring_both): Remove var that is set but not used.
9938 (sxhash): Redo loop for clarity and to avoid wraparound warning.
9940 * eval.c (funcall_lambda): Rename local to avoid shadowing.
9942 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
9943 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
9944 can always succeed if overflow has undefined behavior.
9946 * search.c (boyer_moore, wordify): Remove vars set but not used.
9947 (wordify): Omit three unnecessary tests.
9949 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
9950 All callers changed. This avoids the need for an unused var.
9952 * casefiddle.c (casify_region): Remove var that is set but not used.
9954 * dired.c (file_name_completion): Remove var that is set but not used.
9956 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
9958 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
9959 (Finsert_file_contents): Remove unnecessary code checking fd.
9961 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
9962 Check for integer overflow on size calculations.
9964 * buffer.c (Fprevious_overlay_change): Remove var that is set
9967 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
9968 Remove vars that are set but not used.
9969 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
9970 (timer_check_2): Mark vars as initialized.
9972 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
9974 * image.c (lookup_image): Remove var that is set but not used.
9975 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
9977 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
9978 that are set but not used.
9980 * xfns.c (make_invisible_cursor): Don't return garbage
9981 if XCreateBitmapFromData fails (Bug#8410).
9983 * xselect.c (x_get_local_selection, x_handle_property_notify):
9984 Remove vars that are set but not used.
9986 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
9987 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
9989 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
9990 Remove var that is set but not used.
9991 (scroll_bar_windows_size): Now size_t, not int.
9992 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
9995 * xfaces.c (realize_named_face): Remove vars that are set but not used.
9996 (map_tty_color) [!defined MSDOS]: Likewise.
9998 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10000 * coding.c: Remove vars that are set but not used.
10001 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10002 All callers changed.
10003 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10004 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10005 (decode_coding_charset): Remove vars that are set but not used.
10007 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10008 that is set but not used.
10010 * print.c (print_object): Remove var that is set but not used.
10012 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
10013 The gnulib version avoids calling malloc in the usual case,
10014 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10015 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10016 * filelock.c (current_lock_owner): Likewise.
10017 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10018 * sysdep.c: Include allocator.h, careadlinkat.h.
10019 (emacs_no_realloc_allocator): New static constant.
10020 (emacs_readlink): New function.
10021 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10022 ../lib/careadlinkat.h.
10024 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10026 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10027 first non-nil return value).
10029 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10031 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10032 if not defined (Bug#8403).
10034 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10036 * xdisp.c (display_count_lines): Remove parameter `start',
10037 unused since revno:20537 (1998-01-01). All callers changed.
10038 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10039 unused since revno:87605 (2008-05-14). All callers changed.
10040 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10041 unused at least since Kim's GUI unification at revno:50135 (2003-03-16)
10042 and thereabouts. All callers changed.
10043 (get_per_char_metric): Remove parameter `f', unused since
10044 revno:87605 (2008-05-14). All callers changed.
10046 2011-04-02 Jim Meyering <meyering@redhat.com>
10048 do not dereference NULL upon failed strdup
10049 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10050 (ns_get_family): Likewise.
10052 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10054 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10056 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10058 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10061 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10063 Add lexical binding.
10065 * window.c (Ftemp_output_buffer_show): New fun.
10066 (Fsave_window_excursion):
10067 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10069 * lread.c (lisp_file_lexically_bound_p): New function.
10070 (Fload): Bind Qlexical_binding.
10071 (readevalloop): Remove `evalfun' arg.
10072 Bind Qinternal_interpreter_environment.
10073 (Feval_buffer): Bind Qlexical_binding.
10074 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10076 (syms_of_lread): Declare `lexical-binding'.
10078 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10080 * keyboard.c (eval_dyn): New fun.
10081 (menu_item_eval_property): Use it.
10083 * image.c (parse_image_spec): Use Ffunctionp.
10085 * fns.c (concat, mapcar1): Accept byte-code-functions.
10087 * eval.c (Fsetq): Handle lexical vars.
10088 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10089 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10090 (FletX, Flet): Obey lexical binding.
10091 (Fcommandp): Handle closures.
10092 (Feval): New `lexical' arg.
10093 (eval_sub): New function extracted from Feval. Use it almost
10094 everywhere where Feval was used. Look up vars in lexical env.
10096 (Ffunctionp): Move from subr.el.
10097 (Ffuncall): Handle closures.
10098 (apply_lambda): Remove `eval_flags'.
10099 (funcall_lambda): Handle closures and new byte-code-functions.
10100 (Fspecial_variable_p): New function.
10101 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10102 but without exporting it to Lisp.
10104 * doc.c (Fdocumentation, store_function_docstring):
10105 * data.c (Finteractive_form): Handle closures.
10107 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10110 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10112 (exec_byte_code): New function extracted from Fbyte_code to handle new
10113 calling convention for byte-code-functions. Add new byte-codes.
10115 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
10117 * alloc.c (Fmake_symbol): Init new `declared_special' field.
10119 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10121 * xdisp.c (redisplay_internal): Fix prototype.
10123 2011-03-31 Eli Zaretskii <eliz@gnu.org>
10125 * xdisp.c (SCROLL_LIMIT): New macro.
10126 (try_scrolling): Use it when setting scroll_limit.
10127 Limit scrolling to 100 screen lines.
10128 (redisplay_window): Even when falling back on "recentering",
10129 position point in the window according to scroll-conservatively,
10130 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10132 (try_scrolling): When point is above the window, allow searching
10133 as far as scroll_max, or one screenful, to compute vertical
10134 distance from PT to the scroll margin position. This prevents
10135 try_scrolling from unnecessarily failing when
10136 scroll-conservatively is set to a value slightly larger than the
10137 window height. Clean up the case of PT below the margin at bottom
10138 of window: scroll_max can no longer be INT_MAX. When aggressive
10139 scrolling is in use, don't let point enter the opposite scroll
10140 margin as result of the scroll.
10141 (syms_of_xdisp) <scroll-conservatively>: Document the
10142 threshold of 100 lines for never-recentering scrolling.
10144 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10146 * dispextern.h (move_it_by_lines):
10147 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10148 since revno:34925 (2000-12-29). All callers changed.
10149 (message_log_check_duplicate): Remove parameters `prev_bol' and
10150 `this_bol', unused since revno:20537 (1998-01-01). All callers changed.
10151 (redisplay_internal): Remove parameter `preserve_echo_area',
10152 unused since revno:25013 (1999-07-21). All callers changed.
10154 * indent.c (Fvertical_motion):
10155 * window.c (window_scroll_pixel_based, Frecenter):
10156 Don't pass `need_y_p' to `move_it_by_lines'.
10158 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10160 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10161 steal a few bits to be more compact.
10162 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10163 Remove unneeded casts.
10165 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10167 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10169 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10170 binding" message (bug#7967).
10172 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10174 Fix more problems found by GCC 4.6.0's static checks.
10176 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10177 Remove unused local var.
10179 * editfns.c (Fmessage_box): Remove unused local var.
10181 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10182 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10183 Omit unused local vars.
10184 * window.c (shrink_windows): Omit unused local var.
10185 * menu.c (digest_single_submenu): Omit unused local var.
10186 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10187 Omit unused local var.
10189 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10190 Don't assume string length fits in int.
10191 (keyremap_step, read_key_sequence): Use size_t for sizes.
10192 (read_key_sequence): Don't check last_real_key_start redundantly.
10194 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10195 instead of alloca (Bug#8344).
10197 * eval.c (Fbacktrace): Don't assume nargs fits in int.
10198 (Fbacktrace_frame): Don't assume nframes fits in int.
10200 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10202 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10205 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10207 * cm.c (calccost): Turn while-do into do-while, for clarity.
10209 * keyboard.c (syms_of_keyboard): Use the same style as later
10210 in this function when indexing through an array. This also
10211 works around GCC bug 48267.
10213 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10215 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10217 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10218 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10220 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10221 This avoids undefined behavior on integer overflow, and is a bit
10222 more convenient anyway since it is compared to a size_t variable.
10224 Variadic C functions now count arguments with size_t, not int.
10225 This avoids an unnecessary limitation on 64-bit machines, which
10226 caused (substring ...) to crash on large vectors (Bug#8344).
10227 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10228 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
10229 All variadic functions and their callers changed accordingly.
10230 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10231 * data.c (arith_driver, float_arith_driver): Likewise.
10232 * editfns.c (general_insert_function): Likewise.
10233 * eval.c (struct backtrace.nargs, interactive_p)
10234 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10235 (funcall_lambda, mark_backtrace): Likewise.
10236 * fns.c (concat): Likewise.
10237 * frame.c (x_set_frame_parameters): Likewise.
10238 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10239 0 if not found, not -1. All callers changed.
10241 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10242 (stack_copy_size): Now size_t, not int.
10243 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10245 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10247 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10248 unused since revno:43563.1.17 (2002-03-01) and revno:84043 (2008-02-1).
10249 All callers changed.
10251 * lisp.h (multibyte_char_to_unibyte):
10252 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10253 unused since revno:43563.1.16 (2002-03-01) and revno:84043 (2008-02-1).
10254 * character.h (CHAR_TO_BYTE8):
10255 * cmds.c (internal_self_insert):
10256 * editfns.c (general_insert_function):
10257 * keymap.c (push_key_description):
10258 * search.c (Freplace_match):
10259 * xdisp.c (message_dolog, set_message_1): All callers changed.
10261 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10263 * keyboard.c (safe_run_hook_funcall): New function.
10264 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10265 don't set the hook to nil, but remove the offending function instead.
10266 (Qcommand_hook_internal): Remove, unused.
10267 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10268 Vcommand_hook_internal.
10270 * eval.c (enum run_hooks_condition): Remove.
10271 (funcall_nil, funcall_not): New functions.
10272 (run_hook_with_args): Call each function through a `funcall' argument.
10273 Remove `cond' argument, now redundant.
10274 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10275 (Frun_hook_with_args_until_failure): Adjust accordingly.
10276 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10278 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10280 * dispextern.h (string_buffer_position): Remove declaration.
10282 * print.c (strout): Remove parameter `multibyte', unused since
10283 revno:25356 (1999-08-21). All callers changed.
10285 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10286 never used since function introduction in revno:20870 (1998-02-08).
10287 All callers changed.
10289 * w32.c (_wsa_errlist): Use braces for struct initializers.
10291 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10292 never used since function introduction in revno:36704 (2001-03-09).
10293 All callers changed.
10294 (string_buffer_position): Likewise. Also, make static (it's never
10295 used outside xdisp.c).
10296 (cursor_row_p): Remove parameter `w', unused since
10297 revno:32591 (2000-10-17). All callers changed.
10298 (decode_mode_spec): Remove parameter `precision', introduced during
10299 Gerd Moellmann's rewrite at revno:25013 (1999-07-21), but never used.
10300 All callers changed.
10302 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10304 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10306 2011-03-27 Anders Lindgren <andlind@gmail.com>
10308 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10309 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10310 (ns_update_auto_hide_menu_bar): New functions.
10311 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10312 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10313 ns_constrain_all_frames.
10314 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10315 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10317 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10319 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10321 2011-03-27 Glenn Morris <rgm@gnu.org>
10323 * syssignal.h: Replace RETSIGTYPE with void.
10324 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10325 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10326 Replace SIGTYPE with void everywhere.
10327 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10328 * s/template.h (SIGTYPE): Remove commented out definition.
10330 2011-03-26 Eli Zaretskii <eliz@gnu.org>
10332 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10333 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10335 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
10337 * w32.c (read_unc_volume): Use parameter `henum', instead of
10338 global variable `wget_enum_handle'.
10340 * keymap.c (describe_vector): Remove parameters `indices' and
10341 `char_table_depth', unused since revno:43563.1.32 (2002-03-01).
10342 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10344 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10346 * keyboard.c (timer_check): Remove parameter `do_it_now',
10347 unused since revno:14998 (1996-04-12).
10348 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10349 unused since revno:86854 (2008-04-19).
10351 * keyboard.c (read_char):
10352 * w32menu.c (w32_menu_display_help):
10353 * xmenu.c (show_help_event, menu_help_callback):
10354 Adjust calls to `show_help_echo'.
10356 * gtkutil.c (xg_maybe_add_timer):
10357 * keyboard.c (readable_events):
10358 * process.c (wait_reading_process_output):
10359 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10361 * insdel.c (adjust_markers_gap_motion):
10362 Remove; no-op since revno:20569 (1998-01-02).
10363 (gap_left, gap_right): Don't call it.
10365 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
10367 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10368 incurred during fontification.
10370 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10372 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10373 (DEFVAR_PER_BUFFER): Don't pass it.
10375 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10376 (scrolling_window): Don't pass it.
10378 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10380 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10382 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10384 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10385 of variables specific to SELinux and computation of `encoded_absname'.
10387 * image.c (XPutPixel): Remove unused variable `height'.
10389 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10391 * unexw32.c (get_section_info): Remove unused variable `section'.
10393 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10394 (system_process_attributes): Remove unused variable `sess'.
10395 (sys_read): Remove unused variable `err'.
10397 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10398 (w32_wnd_proc): Remove unused variable `isdead'.
10399 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10400 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10401 (x_create_tip_frame): Remove unused variable `tem'.
10403 * w32inevt.c (w32_console_read_socket):
10404 Remove unused variable `no_events'.
10406 * w32term.c (x_draw_composite_glyph_string_foreground):
10407 Remove unused variable `width'.
10409 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
10411 * w32term.c (x_set_glyph_string_clipping):
10412 Don't pass uninitialized region to CombineRgn.
10414 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
10416 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10417 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10418 (Fx_close_connection): Remove unused variable `i'.
10420 * w32font.c (w32font_draw): Return number of glyphs.
10421 (w32font_open_internal): Remove unused variable `i'.
10422 (w32font_driver): Add missing initializer.
10424 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10425 (fill_in_menu): Remove unused variable `items_added'.
10427 * w32term.c (last_mouse_press_frame): Remove static global variable.
10428 (w32_clip_to_row): Remove unused variable `f'.
10429 (x_delete_terminal): Remove unused variable `i'.
10431 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10432 (NOTHING): Remove unused static global variable.
10433 (uniscribe_check_otf): Remove unused variable `table'.
10434 (uniscribe_font_driver): Add missing initializers.
10436 2011-03-23 Julien Danjou <julien@danjou.info>
10438 * term.c (Fsuspend_tty, Fresume_tty):
10439 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10440 * window.c (temp_output_buffer_show):
10441 * insdel.c (signal_before_change):
10442 * frame.c (Fhandle_switch_frame):
10443 * fileio.c (Fdo_auto_save):
10444 * emacs.c (Fkill_emacs):
10445 * editfns.c (save_excursion_restore):
10446 * cmds.c (internal_self_insert):
10447 * callint.c (Fcall_interactively):
10448 * buffer.c (Fkill_all_local_variables):
10449 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10451 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
10452 unconditionally since it does the check itself.
10454 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
10456 Fix more problems found by GCC 4.5.2's static checks.
10458 * coding.c (encode_coding_raw_text): Avoid unnecessary test
10459 the first time through the loop, since we know p0 < p1 then.
10460 This also avoids a gcc -Wstrict-overflow warning.
10462 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
10463 leading to a memory leak, possible in functions like
10464 load_charset_map_from_file that can allocate an unbounded number
10465 of objects (Bug#8318).
10467 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
10468 that could (at least in theory) be that large.
10470 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
10471 This is less likely to overflow, and avoids undefined behavior if
10472 overflow does occur. All callers changed. Use strtoul to scan
10473 for the unsigned long integer.
10474 (pint2hrstr): Simplify and tune code slightly.
10475 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
10477 * scroll.c (do_scrolling): Work around GCC bug 48228.
10478 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
10480 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
10481 This also avoids a warning with gcc -Wstrict-overflow.
10482 (validate_x_resource_name): Simplify count usage.
10483 This also avoids a warning with gcc -Wstrict-overflow.
10485 * fileio.c (Fcopy_file): Report error if fchown or fchmod
10488 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
10490 * process.c (Fmake_network_process): Use socklen_t, not int,
10491 where POSIX says socklen_t is required in portable programs.
10492 This fixes a porting bug on hosts like 64-bit HP-UX, where
10493 socklen_t is wider than int (Bug#8277).
10494 (Fmake_network_process, server_accept_connection):
10495 (wait_reading_process_output, read_process_output):
10498 * process.c: Rename or move locals to avoid shadowing.
10499 (list_processes_1, Fmake_network_process):
10500 (read_process_output_error_handler, exec_sentinel_error_handler):
10501 Rename or move locals.
10502 (Fmake_network_process): Define label "retry_connect" only if needed.
10503 (Fnetwork_interface_info): Fix pointer signedness.
10504 (process_send_signal): Add cast to avoid pointer signedness problem.
10505 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
10506 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
10508 Make tparam.h and terminfo.c consistent.
10509 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
10510 Include tparam.h instead, since it declares them.
10511 * cm.h (PC): Remove extern decl; tparam.h now does this.
10512 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
10513 * terminfo.c: Include tparam.h, to check interfaces.
10514 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
10515 (tparam): Adjust signature to match interface in tparam.h;
10516 this removes some undefined behavior. Check that outstring and len
10517 are zero, which they always are with Emacs.
10518 * tparam.h (PC, BC, UP): New extern decls.
10520 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
10521 (xftfont_open): Rename locals to avoid shadowing.
10523 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
10524 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
10525 (OTF_TAG_SYM): Omit macro if not needed.
10526 (ftfont_list): Remove unused local.
10527 (get_adstyle_property, ftfont_pattern_entity):
10528 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
10529 Rename locals to avoid shadowing.
10531 * xfont.c (xfont_list_family): Mark var as initialized.
10533 * xml.c (make_dom): Now static.
10535 * composite.c (composition_compute_stop_pos): Rename local to
10537 (composition_reseat_it): Remove unused locals.
10538 (find_automatic_composition, composition_adjust_point): Likewise.
10539 (composition_update_it): Mark var as initialized.
10540 (find_automatic_composition): Mark vars as initialized,
10541 with a FIXME (Bug#8290).
10543 character.h: Rename locals to avoid shadowing.
10544 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
10545 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
10546 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
10547 (BUF_DEC_POS): Be more systematic about renaming local temporaries
10548 to avoid shadowing.
10550 * textprop.c (property_change_between_p): Remove; unused.
10552 * intervals.c (interval_start_pos): Now static.
10554 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
10556 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
10557 Rename locals to avoid shadowing.
10559 * sound.c (wav_play, au_play, Fplay_sound_internal):
10560 Fix pointer signedness.
10561 (alsa_choose_format): Remove unused local var.
10562 (wav_play): Initialize a variable to 0, to prevent undefined
10563 behavior (Bug#8278).
10565 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
10567 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
10569 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
10570 clobbering (Bug#8298).
10571 * sysdep.c (sys_subshell): Likewise.
10572 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
10574 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
10575 This should get cleaned up, so that child_setup has the
10576 same signature on all platforms.
10578 * callproc.c (call_process_cleanup): Now static.
10579 (relocate_fd): Rename locals to avoid shadowing.
10581 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
10583 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
10584 not to be necessary, and produces flickering.
10586 2011-03-20 Glenn Morris <rgm@gnu.org>
10588 * config.in: Remove file.
10590 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
10592 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
10593 are now in src/globals.h.
10594 (syms_of_minibuf): Remove spurious & from previous change.
10596 2011-03-20 Leo Liu <sdl.web@gmail.com>
10598 * minibuf.c (completing-read-function): New variable.
10599 (completing-read-default): Rename from completing-read.
10600 (completing-read): Call completing-read-function.
10602 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
10604 * xfaces.c (Fx_load_color_file):
10605 Read color file from absolute filename (bug#8250).
10607 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
10609 * makefile.w32-in: Update dependencies.
10611 2011-03-17 Eli Zaretskii <eliz@gnu.org>
10613 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
10615 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
10617 Fix more problems found by GCC 4.5.2's static checks.
10619 * process.c (make_serial_process_unwind, send_process_trap):
10620 (sigchld_handler): Now static.
10622 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
10623 That way, the code declares only the vars that it needs.
10624 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
10625 * s/cygwin.h (PTY_ITERATION): Likewise.
10626 * s/darwin.h (PTY_ITERATION): Likewise.
10627 * s/gnu-linux.h (PTY_ITERATION): Likewise.
10629 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
10630 * process.c (allocate_pty): Don't declare stb unless it's needed.
10632 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
10633 (CONSTANTLIM): Remove; unused.
10634 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
10635 Define only if needed.
10637 * unexelf.c (unexec): Name an expression,
10638 to avoid gcc -Wbad-function-cast warning.
10639 Use a different way to cause a compilation error if anyone uses
10640 n rather than nn, a way that does not involve shadowing.
10641 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
10643 * deps.mk (unexalpha.o): Remove; unused.
10645 New file unexec.h, the (simple) interface for unexec (Bug#8267).
10646 * unexec.h: New file.
10647 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
10648 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
10649 Depend on unexec.h.
10650 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
10651 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
10652 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
10653 Change as necessary to match prototype in unexec.h.
10655 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
10657 (back_comment, skip_chars): Mark vars as initialized.
10659 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
10660 Rename locals to avoid shadowing.
10662 * lread.c (read1): Rewrite so as not to use empty "else".
10663 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
10665 * print.c (Fredirect_debugging_output): Fix pointer signedess.
10667 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
10668 warning when compiling print.c.
10670 * font.c (font_unparse_fcname): Abort in an "impossible" situation
10671 instead of using an uninitialized var.
10672 (font_sort_entities): Mark var as initialized.
10674 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
10676 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
10677 pointers to constants.
10678 (font_parse_fcname): Remove unused vars.
10679 (font_delete_unmatched): Now static.
10680 (font_get_spec): Remove; unused.
10681 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
10682 (font_update_drivers, Ffont_get_glyphs, font_add_log):
10683 Rename or move locals to avoid shadowing.
10685 * fns.c (require_nesting_list, require_unwind): Now static.
10686 (Ffillarray): Rename locals to avoid shadowing.
10688 * floatfns.c (domain_error2): Define only if needed.
10689 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
10691 * alloc.c (mark_backtrace): Move decl from here ...
10692 * lisp.h: ... to here, so that it can be checked.
10694 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
10695 (Fdefvar): Rewrite so as not to use empty "else".
10696 (lisp_indirect_variable): Name an expression,
10697 to avoid gcc -Wbad-function-cast warning.
10698 (Fdefvar): Rename locals to avoid shadowing.
10700 * callint.c (quotify_arg, quotify_args): Now static.
10701 (Fcall_interactively): Rename locals to avoid shadowing.
10702 Use const pointer when appropriate.
10704 * lisp.h (get_system_name, get_operating_system_release):
10705 Move decls here, to check interfaces.
10706 * process.c (get_operating_system_release): Move decl to lisp.h.
10707 * xrdb.c (get_system_name): Likewise.
10708 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
10709 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
10710 some of which prompt warnings from gcc -Wbad-function-cast.
10711 (Fformat_time_string, Fencode_time, Finsert_char):
10712 (Ftranslate_region_internal, Fformat):
10713 Rename or remove local vars to avoid shadowing.
10714 (Ftranslate_region_internal): Mark var as initialized.
10716 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
10719 * lisp.h (eassert): Check that the argument compiles, even if
10720 ENABLE_CHECKING is not defined.
10722 * data.c (Findirect_variable): Name an expression, to avoid
10723 gcc -Wbad-function-cast warning.
10724 (default_value, arithcompare, arith_driver, arith_error): Now static.
10725 (store_symval_forwarding): Rename local to avoid shadowing.
10726 (Fmake_variable_buffer_local, Fmake_local_variable):
10727 Mark variables as initialized.
10728 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
10730 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
10731 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
10732 Rename locals to avoid shadowing.
10733 (mark_stack): Move local variables into the #ifdef region where
10735 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
10736 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
10738 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
10739 (GC_STRING_CHARS): Remove; not used.
10740 (Fmemory_limit): Cast sbrk's returned value to char *.
10742 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
10743 avoids undefined behavior in theory.
10745 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
10747 Use functions, not macros, for up- and down-casing (Bug#8254).
10748 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
10749 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
10750 to use the following functions instead of these macros.
10751 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
10752 EMACS_INT, since callers assume the returned value fits in int.
10753 (upcase1): Likewise, for UPCASE_TABLE.
10754 (uppercasep, lowercasep, upcase): New static inline functions.
10755 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
10756 the race-condition problem in the old DOWNCASE.
10758 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
10759 Rename locals to avoid shadowing.
10760 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
10761 (regex_compile, re_search_2, re_match_2_internal):
10762 Remove unused local vars.
10763 (FREE_VAR): Rewrite so as not to use empty "else",
10764 which gcc can warn about.
10765 (regex_compile, re_match_2_internal): Mark locals as initialized.
10766 (RETALLOC_IF): Define only if needed.
10767 (WORDCHAR_P): Likewise. This one is never needed, but is used
10768 only in a comment talking about a compiler bug, so put inside
10769 the #if 0 of that comment.
10770 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
10771 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
10774 * search.c (boyer_moore): Rename locals to avoid shadowing.
10775 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
10776 (PREV_CHAR_BOUNDARY): Likewise.
10778 * search.c (simple_search): Remove unused var.
10780 * dired.c (compile_pattern): Move decl from here ...
10781 * lisp.h: ... to here, so that it can be checked.
10782 (struct re_registers): New forward decl.
10784 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
10786 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
10788 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
10789 Rename locals to avoid shadowing.
10790 (Fvertical_motion): Mark locals as initialized.
10792 * casefiddle.c (casify_object, casify_region): Now static.
10793 (casify_region): Mark local as initialized.
10795 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
10797 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
10798 New macros, so that the caller can use some names other than
10799 gcpro1, gcpro2, etc.
10800 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
10802 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
10803 argument, for consistency with GCPRO2_VAR, etc: it is now the
10804 prefix of the variable, not the variable itself. All uses
10806 * dired.c (directory_files_internal, file_name_completion):
10807 Rename locals to avoid shadowing.
10809 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
10810 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
10811 dired.c's scmp function, had undefined behavior.
10812 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
10813 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
10814 * buffer.h: ... to here, because these macros use current_buffer,
10815 and the new implementation with inline functions needs to have
10816 current_buffer in scope now, rather than later when the macros
10818 (downcase, upcase1): New static inline functions.
10819 (DOWNCASE, UPCASE1): Reimplement using these functions.
10820 This avoids undefined behavior in expressions like
10821 DOWNCASE (x) == DOWNCASE (y), which previously suffered
10822 from race conditions in accessing the global variables
10823 case_temp1 and case_temp2.
10824 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
10825 * lisp.h (case_temp1, case_temp2): Remove their decls.
10826 * character.h (ASCII_CHAR_P): Move from here ...
10827 * lisp.h: ... to here, so that the inline functions mentioned
10828 above can use them.
10830 * dired.c (directory_files_internal_unwind): Now static.
10832 * fileio.c (file_name_as_directory, directory_file_name):
10833 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
10835 (file_name_as_directory): Use const pointers when appropriate.
10836 (Fexpand_file_name): Likewise. In particular, newdir might
10837 point at constant storage, so make it a const pointer.
10838 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
10839 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
10841 (Fset_file_times, Finsert_file_contents, auto_save_error):
10842 Rename locals to avoid shadowing.
10844 * minibuf.c (choose_minibuf_frame_1): Now static.
10845 (Ftry_completion, Fall_completions): Rename or remove locals
10846 to avoid shadowing.
10848 * marker.c (bytepos_to_charpos): Remove; unused.
10850 * lisp.h (verify_bytepos, count_markers): New decls,
10851 so that gcc does not warn that these functions aren't declared.
10853 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
10854 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
10855 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
10856 (copy_text): Remove unused local var.
10858 * filelock.c (within_one_second): Now static.
10859 (lock_file_1): Rename local to avoid shadowing.
10861 * buffer.c (fix_overlays_before): Mark locals as initialized.
10862 (fix_start_end_in_overlays): Likewise. This function should be
10863 simplified by using pointers-to-pointers, but that's a different
10865 (switch_to_buffer_1): Now static.
10866 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
10867 (report_overlay_modification): Rename locals to avoid shadowing.
10869 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
10870 Fix pointer signedness issue.
10871 (sys_subshell): Mark local as volatile if checking for lint,
10872 to suppress a gcc -Wclobbered warning that does not seem to be right.
10873 (MAXPATHLEN): Define only if needed.
10875 * process.c (serial_open, serial_configure): Move decls from here ...
10876 * systty.h: ... to here, so that they can be checked.
10878 * fns.c (get_random, seed_random): Move extern decls from here ...
10879 * lisp.h: ... to here, so that they can be checked.
10881 * sysdep.c (reset_io): Now static.
10882 (wait_for_termination_signal): Remove; unused.
10884 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
10885 (copy_keymap_item, append_key, push_text_char_description):
10887 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
10888 (DENSE_TABLE_SIZE): Remove; unused.
10889 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
10890 (describe_map_tree):
10891 Rename locals to avoid shadowing.
10893 * keyboard.c: Declare functions static if they are not used elsewhere.
10894 (echo_char, echo_dash, cmd_error, top_level_2):
10895 (poll_for_input, handle_async_input): Now static.
10896 (read_char, kbd_buffer_get_event, make_lispy_position):
10897 (make_lispy_event, make_lispy_movement, apply_modifiers):
10898 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
10899 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
10900 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
10901 (read_key_sequence, read_char): Mark locals as initialized.
10902 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
10904 * keyboard.h (make_ctrl_char): New decl.
10905 (mark_kboards): Move decl here ...
10906 * alloc.c (mark_kboards): ... from here.
10908 * lisp.h (force_auto_save_soon): New decl.
10910 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
10911 (DEFINE_DUMMY_FUNCTION): New macro.
10912 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
10914 (main): Add casts to avoid warnings
10915 if GCC considers string literals to be constants.
10917 * lisp.h (fatal_error_signal): Add decl, since it's exported.
10919 * dbusbind.c: Pointer signedness fixes.
10920 (xd_signature, xd_append_arg, xd_initialize):
10921 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10922 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10923 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
10924 (Fdbus_register_signal): Use SSDATA when the context wants char *.
10926 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
10927 if GCC considers string literals to be constants.
10928 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
10930 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
10932 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
10933 (print_preprocess, print_object): New macro to fix last change.
10935 * print.c (print_preprocess): Don't forget font objects.
10937 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
10939 * emacs.c (USAGE3): Doc fixes.
10941 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
10943 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
10946 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
10948 * lisp.h (VWindow_system, Qfile_name_history):
10949 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
10950 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
10951 (w32_system_caret_x, w32_system_caret_y): Declare extern.
10953 * w32select.c: Don't #include "keyboard.h".
10954 (run_protected): Add extern declaration for waiting_for_input.
10956 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
10957 * w32console.c (detect_input_pending, read_input_pending)
10958 (encode_terminal_code):
10959 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
10960 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
10961 (w32_system_caret_y, Qfile_name_history):
10962 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
10963 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
10964 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
10965 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
10966 * w32proc.c (Qlocal, report_file_error):
10967 * w32term.c (Vwindow_system, updating_frame):
10968 * w32uniscribe.c (initialized, uniscribe_font_driver):
10969 Remove unneeded extern declarations.
10971 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
10973 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
10975 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
10977 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
10978 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
10979 These macros can no longer be used for assignment.
10981 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
10982 Assign struct members directly, instead of using BUF_BEGV etc.
10983 (record_buffer_markers, fetch_buffer_markers): New functions for
10984 recording and fetching special buffer markers.
10985 (set_buffer_internal_1, set_buffer_temp): Use them.
10987 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
10989 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
10991 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
10992 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
10994 * xdisp.c (hscroll_window_tree):
10995 (reconsider_clip_changes): Use PT instead of BUF_PT.
10997 2011-03-13 Eli Zaretskii <eliz@gnu.org>
10999 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11000 $(EMACS_ROOT)/lib/intprops.h.
11002 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11004 Fix more problems found by GCC 4.5.2's static checks.
11006 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11007 to unsigned char * to avoid compiler diagnostic.
11008 (xg_free_frame_widgets): Make it clear that a local variable is
11009 needed only if USE_GTK_TOOLTIP.
11010 (gdk_window_get_screen): Make it clear that this macro is needed
11011 only if USE_GTK_TOOLTIP.
11012 (int_gtk_range_get_value): New function, which avoids a diagnostic
11013 from gcc -Wbad-function-cast.
11014 (xg_set_toolkit_scroll_bar_thumb): Use it.
11015 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11016 diagnostic from gcc -Wbad-function-cast.
11017 (get_utf8_string, xg_get_file_with_chooser):
11018 Rename locals to avoid shadowing.
11019 (create_dialog): Move locals to avoid shadowing.
11021 * xgselect.c (xg_select): Remove unused var.
11023 * image.c (four_corners_best): Mark locals as initialized.
11024 (gif_load): Initialize transparent_p to zero (Bug#8238).
11025 Mark another local as initialized.
11026 (my_png_error, my_error_exit): Mark with NO_RETURN.
11028 * image.c (clear_image_cache): Now static.
11029 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
11030 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
11031 (x_edge_detection): Remove unnecessary cast that
11032 gcc -Wbad-function-cast diagnoses.
11033 (gif_load): Fix pointer signedness.
11034 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11035 (jpeg_load, gif_load): Rename locals to avoid shadowing.
11037 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
11039 Improve quality of tests for time stamp overflow.
11040 For example, without this patch (encode-time 0 0 0 1 1
11041 1152921504606846976) returns the obviously-bogus value (-948597
11042 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11043 reports time overflow. See
11044 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
11045 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11046 * editfns.c: Include limits.h and intprops.h.
11047 (TIME_T_MIN, TIME_T_MAX): New macros.
11048 (time_overflow): Move earlier, to before first use.
11049 (hi_time, lo_time): New functions, for an accurate test for
11050 out-of-range times.
11051 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11052 (Fget_internal_run_time): Don't assume time_t fits in int.
11053 (make_time): Use list2 instead of Fcons twice.
11054 (Fdecode_time): More accurate test for out-of-range times.
11055 (check_tm_member): New function.
11056 (Fencode_time): Use it, to test for out-of-range times.
11057 (lisp_time_argument): Don't rely on undefined left-shift and
11058 right-shift behavior when checking for time stamp overflow.
11060 * editfns.c (time_overflow): New function, refactoring common code.
11061 (Fformat_time_string, Fdecode_time, Fencode_time):
11062 (Fcurrent_time_string): Use it.
11064 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11065 * dired.c (make_time): Move to ...
11066 * editfns.c (make_time): ... here.
11067 * systime.h: Note the move.
11069 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11071 * fringe.c (update_window_fringes): Remove unused variables.
11073 * unexmacosx.c (copy_data_segment): Also copy __got section.
11076 2011-03-12 Eli Zaretskii <eliz@gnu.org>
11078 * termcap.c [MSDOS]: Include "msdos.h".
11079 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11080 Constify `char *' arguments and their references according to
11081 prototypes in tparam.h.
11083 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
11085 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11086 Adapt all references accordingly.
11088 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11090 2011-03-11 Tom Tromey <tromey@redhat.com>
11092 * buffer.c (syms_of_buffer): Remove obsolete comment.
11094 2011-03-11 Eli Zaretskii <eliz@gnu.org>
11096 * termhooks.h (encode_terminal_code): Declare prototype.
11098 * msdos.c (encode_terminal_code): Don't declare prototype.
11100 * term.c (encode_terminal_code): Now external again, used by
11101 w32console.c and msdos.c.
11103 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11104 Depend on $(SRC)/tparam.h, see revno 103623.
11106 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
11108 Fix some minor problems found by GCC 4.5.2's static checks.
11110 * fringe.c (update_window_fringes): Mark locals as initialized
11112 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
11114 * alloc.c (mark_fringe_data): Move decl from here ...
11115 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11116 to check its interface.
11117 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11119 * fontset.c (free_realized_fontset): Now static.
11120 (Fset_fontset_font): Rename local to avoid shadowing.
11121 (fontset_font): Mark local as initialized.
11122 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
11124 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11126 * xselect.c (x_disown_buffer_selections): Remove; not used.
11127 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
11128 (x_own_selection, Fx_disown_selection_internal): Rename locals
11129 to avoid shadowing.
11130 (x_handle_dnd_message): Remove local to avoid shadowing.
11132 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11133 so that the caller can use some name other than gcpro1.
11134 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
11135 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11136 (Fx_backspace_delete_keys_p):
11137 Use them to avoid shadowing, and rename vars to avoid shadowing.
11138 (x_decode_color, x_set_name, x_window): Now static.
11139 (Fx_create_frame): Add braces to silence GCC warning.
11140 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
11141 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11142 Remove unused locals.
11143 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11144 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11145 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11148 * xterm.h (x_mouse_leave): New decl.
11150 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11151 Remove unused functions.
11152 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11153 (x_calc_absolute_position): Now static.
11154 (XTread_socket): Don't define label "out" unless it's used.
11155 Don't declare local "event" unless it's used.
11156 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11157 unless they are used.
11158 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11159 (x_fatal_error_signal): Remove; not used.
11160 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11161 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11162 (x_error_catcher, x_connection_closed, x_error_handler):
11163 (x_error_quitter, xembed_send_message, x_iconify_frame):
11164 (my_log_handler): Rename locals to avoid shadowing.
11165 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
11166 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
11168 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11169 Rename or move locals to avoid shadowing.
11170 (tty_defined_color, merge_face_heights): Now static.
11171 (free_realized_faces_for_fontset): Remove; not used.
11172 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11173 does not deduce is never used uninitialized.
11174 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11175 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
11177 * terminal.c (store_terminal_param): Now static.
11179 * xmenu.c (menu_highlight_callback): Now static.
11180 (set_frame_menubar): Remove unused local.
11181 (xmenu_show): Rename parameter to avoid shadowing.
11182 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11183 since they might point to immutable storage.
11184 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11185 since it's unused otherwise.
11187 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
11188 Add a FIXME, since the code still doesn't look right. (Bug#8215)
11189 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11190 avoids a gcc -Wuninitialized diagnostic.
11191 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
11192 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11193 does not deduce are never used uninitialized.
11195 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11197 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
11198 * window.c (window_loop, size_window):
11199 (run_window_configuration_change_hook, enlarge_window): Likewise.
11201 * window.c (display_buffer): Now static.
11202 (size_window): Mark variables that gcc -Wuninitialized
11203 does not deduce are never used uninitialized.
11204 * window.h (check_all_windows): New decl, to forestall
11205 gcc -Wmissing-prototypes diagnostic.
11206 * dispextern.h (bidi_dump_cached_states): Likewise.
11208 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11210 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
11211 Include <limits.h>.
11212 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11213 and to avoid gcc -Wuninitialized warning.
11214 (load_charset_map): Mark variables that gcc -Wuninitialized
11215 does not deduce are never used uninitialized.
11216 (load_charset): Abort instead of using uninitialized var (Bug#8229).
11218 * coding.c (coding_set_source, coding_set_destination):
11219 Use "else { /* comment */ }" rather than "else /* comment */;"
11220 for clarity, and to avoid gcc -Wempty-body warning.
11221 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11222 a block, when the outer 'i' will do.
11223 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11224 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11225 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11226 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11227 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11228 Rename locals to avoid shadowing.
11229 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
11230 * coding.c (emacs_mule_char, encode_invocation_designation):
11231 Now static, since they're not used elsewhere.
11232 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
11233 (decode_coding_object, encode_coding_object, detect_coding_system):
11234 (decode_coding_emacs_mule): Mark variables that gcc
11235 -Wuninitialized does not deduce are never used uninitialized.
11236 (detect_coding_iso_2022): Initialize a local variable that might
11237 be used uninitialized. Leave a FIXME because it's not clear that
11238 this initialization is needed. (Bug#8211)
11239 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11240 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11241 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11242 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11243 Remove unused macros.
11245 * category.c (hash_get_category_set): Remove unused local var.
11246 (copy_category_table): Now static, since it's not used elsewhere.
11247 * character.c (string_count_byte8): Likewise.
11249 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11250 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11252 * chartab.c (copy_sub_char_table): Now static, since it's not used
11254 (sub_char_table_ref_and_range, char_table_ref_and_range):
11255 Rename locals to avoid shadowing.
11256 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
11258 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
11259 (BIDI_BOB): Remove unused macro.
11261 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11262 deduce are never used uninitialized.
11263 * term.c (encode_terminal_code): Likewise.
11265 * term.c (encode_terminal_code): Now static. Remove unused local.
11267 * tparam.h: New file.
11268 * term.c, tparam.h: Include it.
11269 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11270 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11271 Move these decls to tparam.h, and make them agree with what
11272 is actually in tparam.c. The previous trick of using incompatible
11273 decls in different modules does not conform to the C standard.
11274 All callers of tparam changed to use tparam's actual API.
11275 * tparam.c (tparam1, tparam, tgoto):
11276 Use const pointers where appropriate.
11278 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11279 * cm.h (struct cm): Likewise.
11280 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11281 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11282 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11283 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11284 (turn_on_face, init_tty): Likewise.
11285 * termchar.h (struct tty_display_info): Likewise.
11287 * term.c (term_mouse_position): Rename local to avoid shadowing.
11289 * alloc.c (mark_ttys): Move decl from here ...
11290 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11292 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11294 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11296 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
11298 * search.c (compile_pattern_1): Remove argument regp, unused since
11299 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11300 (compile_pattern): Don't pass it.
11302 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11304 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11305 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11307 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11309 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11311 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11312 gdk_window_get_screen, gdk_window_get_geometry,
11313 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11314 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11315 (xg_get_pixbuf_from_pixmap): New function.
11316 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11317 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11318 Call xg_get_pixbuf_from_pixmap instead of
11319 gdk_pixbuf_get_from_drawable.
11320 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11321 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11322 (xg_check_special_colors): Use GtkStyleContext and its functions
11324 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11325 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11326 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
11327 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11328 Call gtk_widget_get_preferred_size.
11329 (xg_frame_resized): gdk_window_get_geometry only takes 5
11331 (xg_win_to_widget, xg_event_is_for_menubar):
11332 Call gdk_x11_window_lookup_for_display.
11333 (xg_set_widget_bg): New function.
11334 (delete_cb): New function.
11335 (xg_create_frame_widgets): Connect delete-event to delete_cb.
11336 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
11337 (xg_set_background_color): Call xg_set_widget_bg.
11338 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11339 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11340 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11341 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11343 (update_frame_tool_bar): Call gtk_widget_hide.
11344 (xg_initialize): Use GDK_KEY_g.
11346 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11348 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11350 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11351 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11352 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11354 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
11356 * w32xfns.c (select_palette): Check success of RealizePalette against
11357 GDI_ERROR, not zero.
11359 See ChangeLog.11 for earlier changes.
11361 ;; Local Variables:
11365 Copyright (C) 2011-2012 Free Software Foundation, Inc.
11367 This file is part of GNU Emacs.
11369 GNU Emacs is free software: you can redistribute it and/or modify
11370 it under the terms of the GNU General Public License as published by
11371 the Free Software Foundation, either version 3 of the License, or
11372 (at your option) any later version.
11374 GNU Emacs is distributed in the hope that it will be useful,
11375 but WITHOUT ANY WARRANTY; without even the implied warranty of
11376 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11377 GNU General Public License for more details.
11379 You should have received a copy of the GNU General Public License
11380 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.