From dd723bbd427e7c399de316fe48f1514fa8b0bf29 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Jan=20Dj=C3=A4rv?= Date: Thu, 2 Dec 2010 10:33:57 +0100 Subject: [PATCH] * nsmenu.m (update_frame_tool_bar): Remove NSLog on invalid image. --- src/ChangeLog | 2 ++ src/nsmenu.m | 12 ++++++------ 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/src/ChangeLog b/src/ChangeLog index 83d6d4c6e88..dc6a02d7faf 100644 --- a/src/ChangeLog +++ b/src/ChangeLog @@ -1,5 +1,7 @@ 2010-12-02 Jan Djärv + * nsmenu.m (update_frame_tool_bar): Remove NSLog on invalid image. + * nsterm.m (ns_draw_glyph_string): Switch fore- and background if drawing text under filled box cursor (Bug#7479). diff --git a/src/nsmenu.m b/src/nsmenu.m index b6ee93bdf6b..973f2c15e2f 100644 --- a/src/nsmenu.m +++ b/src/nsmenu.m @@ -1049,10 +1049,15 @@ update_frame_tool_bar (FRAME_PTR f) { idx = -1; } + helpObj = TOOLPROP (TOOL_BAR_ITEM_HELP); + if (NILP (helpObj)) + helpObj = TOOLPROP (TOOL_BAR_ITEM_CAPTION); + helpText = NILP (helpObj) ? "" : (char *)SDATA (helpObj); + /* Ignore invalid image specifications. */ if (!valid_image_p (image)) { - NSLog (@"Invalid image for toolbar item"); + /* Don't log anything, GNUS makes invalid images all the time. */ continue; } @@ -1066,11 +1071,6 @@ update_frame_tool_bar (FRAME_PTR f) continue; } - helpObj = TOOLPROP (TOOL_BAR_ITEM_HELP); - if (NILP (helpObj)) - helpObj = TOOLPROP (TOOL_BAR_ITEM_CAPTION); - helpText = NILP (helpObj) ? "" : (char *)SDATA (helpObj); - [toolbar addDisplayItemWithImage: img->pixmap idx: i helpText: helpText enabled: enabled_p]; #undef TOOLPROP -- 2.11.4.GIT