From bedb08d44f3c32dae97693e3f095f1cfdfc66622 Mon Sep 17 00:00:00 2001 From: Karl Fogel Date: Mon, 3 Dec 2007 21:37:30 +0000 Subject: [PATCH] * emacs-cvs/lisp/saveplace.el (save-place-quiet): Remove, reverting 2007-12-02T19:54:46Z!kfogel@red-bean.com. (save-place-alist-to-file, load-save-place-alist-from-file): Don't print non-error messages at all, there's really no need. Do print if there's a problem, and clarify message in that case. --- lisp/ChangeLog | 7 +++++++ lisp/saveplace.el | 18 +++--------------- 2 files changed, 10 insertions(+), 15 deletions(-) diff --git a/lisp/ChangeLog b/lisp/ChangeLog index 73d10be0259..71e4aa2bc12 100644 --- a/lisp/ChangeLog +++ b/lisp/ChangeLog @@ -1,3 +1,10 @@ +2007-12-03 Karl Fogel + + * saveplace.el (save-place-quiet): Remove, reverting 2007-12-02T19:54:46Z!kfogel@red-bean.com. + (save-place-alist-to-file, load-save-place-alist-from-file): + Don't print non-error messages at all, there's really no need. + Do print if there's a problem, and clarify message in that case. + 2007-12-03 Dan Nicolaescu * ediff-util.el (ediff-setup): diff --git a/lisp/saveplace.el b/lisp/saveplace.el index e846ea844fe..df2deb6c14c 100644 --- a/lisp/saveplace.el +++ b/lisp/saveplace.el @@ -119,10 +119,6 @@ be checked, based on said regexp, and instead saved or forgotten based on this flag." :type 'boolean :group 'save-place) -(defcustom save-place-quiet nil - "If non-nil, suppress messages about loading and saving `save-place-alist'." - :type 'boolean :group 'save-place) - (defcustom save-place-skip-check-regexp ;; thanks to ange-ftp-name-format "\\`/\\(?:cdrom\\|floppy\\|mnt\\|\\(?:[^@/:]*@\\)?[^@/:]*[^@/:.]:\\)" @@ -212,8 +208,6 @@ may have changed\) back to `save-place-alist'." (let ((file (expand-file-name save-place-file)) (coding-system-for-write 'utf-8)) (save-excursion - (unless save-place-quiet - (message "Saving places to %s..." file)) (set-buffer (get-buffer-create " *Saved Places*")) (delete-region (point-min) (point-max)) (when save-place-forget-unreadable-files @@ -233,10 +227,8 @@ may have changed\) back to `save-place-alist'." (condition-case nil ;; Don't use write-file; we don't want this buffer to visit it. (write-region (point-min) (point-max) file) - (file-error (message "Can't write %s" file))) - (kill-buffer (current-buffer)) - (unless save-place-quiet - (message "Saving places to %s...done" file)))))) + (file-error (message "Saving places: can't write %s" file))) + (kill-buffer (current-buffer)))))) (defun load-save-place-alist-from-file () (if (not save-place-loaded) @@ -247,8 +239,6 @@ may have changed\) back to `save-place-alist'." ;; load it if it exists: (if (file-readable-p file) (save-excursion - (unless save-place-quiet - (message "Loading places from %s..." file)) ;; don't want to use find-file because we have been ;; adding hooks to it. (set-buffer (get-buffer-create " *Saved Places*")) @@ -276,9 +266,7 @@ may have changed\) back to `save-place-alist'." (setq count (1+ count))) (setq s (cdr s)))))) - (kill-buffer (current-buffer)) - (unless save-place-quiet - (message "Loading places from %s...done" file)))) + (kill-buffer (current-buffer)))) nil)))) (defun save-places-to-alist () -- 2.11.4.GIT