From 0a893f0cfa166d7f17d982c3f0503dff2be25f62 Mon Sep 17 00:00:00 2001 From: Nicolas Petton Date: Sun, 13 Sep 2015 16:18:24 +0200 Subject: [PATCH] Better docstring and parameter name for seq-find * lisp/emacs-lisp/seq.el (seq-find): Improve the docstring and rename the parameter `sentinel' to `default'. * doc/lispref/sequences.texi (Sequence Functions): Update the documentation for `seq-find' accordingly. --- doc/lispref/sequences.texi | 9 ++++----- lisp/emacs-lisp/seq.el | 12 ++++++------ 2 files changed, 10 insertions(+), 11 deletions(-) diff --git a/doc/lispref/sequences.texi b/doc/lispref/sequences.texi index 6292c02a21d..b85d5d4c1b1 100644 --- a/doc/lispref/sequences.texi +++ b/doc/lispref/sequences.texi @@ -578,15 +578,14 @@ value is the value returned by @var{predicate}. @end example @end defun -@defun seq-find predicate sequence &optional sentinel +@defun seq-find predicate sequence &optional default This function returns the first element for which @var{predicate} returns non-@code{nil} in @var{sequence}. If no element matches -@var{predicate}, @var{sentinel} is returned if non-@code{nil}, -@code{nil} otherwise. +@var{predicate}, @var{default} is returned. Note that this function has an ambiguity if the found element is -@code{nil}, and if no @var{sentinel} is specified, as it cannot be -known if an element was found or not. +identical to @var{default}, as it cannot be known if an element was +found or not. @example @group diff --git a/lisp/emacs-lisp/seq.el b/lisp/emacs-lisp/seq.el index 4b50a0a9b7b..e0f17c0335d 100644 --- a/lisp/emacs-lisp/seq.el +++ b/lisp/emacs-lisp/seq.el @@ -270,18 +270,18 @@ If so, return the non-nil value returned by PRED." (throw 'seq--break result)))) nil)) -(cl-defgeneric seq-find (pred seq &optional sentinel) +(cl-defgeneric seq-find (pred seq &optional default) "Return the first element for which (PRED element) is non-nil in SEQ. -If no element is found, return SENTINEL or nil. +If no element is found, return DEFAULT. -Note that `seq-find' has an ambiguity if the found element is nil -and if no SENTINEL is specified, as it cannot be known if an -element was found or not." +Note that `seq-find' has an ambiguity if the found element is +identical to DEFAULT, as it cannot be known if an element was +found or not." (catch 'seq--break (seq-doseq (elt seq) (when (funcall pred elt) (throw 'seq--break elt))) - sentinel)) + default)) (cl-defgeneric seq-count (pred seq) "Return the number of elements for which (PRED element) is non-nil in SEQ." -- 2.11.4.GIT