Use binary-io module, O_BINARY, and "b" flag.
commitba1ed52f0c2c7fd15fe1feadabfd0af88e19b4c3
authorPaul Eggert <eggert@cs.ucla.edu>
Mon, 14 Jul 2014 19:23:18 +0000 (14 12:23 -0700)
committerPaul Eggert <eggert@cs.ucla.edu>
Mon, 14 Jul 2014 19:23:18 +0000 (14 12:23 -0700)
tree5ef95ac07de2a856369957a7ac047b9f58b78594
parent091adafaac52ff409790728af63cab19bd52fc8f
Use binary-io module, O_BINARY, and "b" flag.

* admin/merge-gnulib (GNULIB_MODULES): Add binary-io.  It was already
present implicitly; this just makes the dependence explicit.
* lib-src/etags.c, lib-src/hexl.c, lib-src/make-docfile.c:
Include binary-io.h instead of fcntl.h and/or io.h.
(main): Use set_binary_mode or SET_BINARY
in place of handcrafted code.
* lib-src/etags.c (main) [DOS_NT]:
* lib-src/movemail.c (main) [WINDOWSNT]:
Don't mess with _fmode.
* lib-src/etags.c (main, process_file_name, analyse_regex):
Use fopen/popen's "b" flag instead.
* lib-src/movemail.c (main, popmail): Use open/lk_open/mkostemp's O_BINARY
instead.
* src/callproc.c (create_temp_file): Use mkostemp's O_BINARY flag.
* src/emacs.c [MSDOS]:
* src/emacs.c (main) [DOS_NT]: Don't mess with _fmode.
(main) [MSDOS]: Use SET_BINARY instead of setmode.
* src/minibuf.c: Include binary-io.h instead of fcntl.h.
(read_minibuf_noninteractive):
Use set_binary_mode instead of handcrafted code.
Don't call emacs_set_tty if emacs_get_tty failed.
* src/sysdep.c, src/systty.h (emacs_get_tty): Return int, not void.
* src/sysdep.c (emacs_open, emacs_pipe): Use O_BINARY.
* src/w32.c (pipe2): Adjust eassert to include O_BINARY.

Fixes: debbugs:18006
14 files changed:
admin/ChangeLog
admin/merge-gnulib
lib-src/ChangeLog
lib-src/etags.c
lib-src/hexl.c
lib-src/make-docfile.c
lib-src/movemail.c
src/ChangeLog
src/callproc.c
src/emacs.c
src/minibuf.c
src/sysdep.c
src/systty.h
src/w32.c